Completed
Pull Request — develop (#91)
by Boy
19:20
created
DependencyInjection/SurfnetStepupGatewaySamlStepupProviderExtension.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -53,6 +53,9 @@  discard block
 block discarded – undo
53 53
         }
54 54
     }
55 55
 
56
+    /**
57
+     * @param string $provider
58
+     */
56 59
     private function loadProviderConfiguration(
57 60
         $provider,
58 61
         array $configuration,
@@ -223,6 +226,9 @@  discard block
 block discarded – undo
223 226
         $container->setDefinition('gssp.provider.' . $provider . '.metadata.factory', $metadataFactory);
224 227
     }
225 228
 
229
+    /**
230
+     * @param string $provider
231
+     */
226 232
     private function createRouteConfig($provider, $routeName)
227 233
     {
228 234
         return [
Please login to merge, or discard this patch.
StepupGateway/U2fVerificationBundle/Repository/RegistrationRepository.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@
 block discarded – undo
26 26
 {
27 27
     /**
28 28
      * @param KeyHandle $keyHandle
29
-     * @return Registration|null
29
+     * @return Registration
30 30
      */
31 31
     public function findByKeyHandle(KeyHandle $keyHandle)
32 32
     {
Please login to merge, or discard this patch.
Surfnet/StepupGateway/U2fVerificationBundle/Service/VerificationService.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -184,7 +184,7 @@
 block discarded – undo
184 184
 
185 185
     /**
186 186
      * @param KeyHandle $keyHandle
187
-     * @return null|Registration
187
+     * @return Registration
188 188
      */
189 189
     public function findRegistrationByKeyHandle(KeyHandle $keyHandle)
190 190
     {
Please login to merge, or discard this patch.
src/Surfnet/StepupGateway/GatewayBundle/Controller/GatewayController.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -213,7 +213,7 @@
 block discarded – undo
213 213
     }
214 214
 
215 215
     /**
216
-     * @param $authnContextClassRef
216
+     * @param string|null $authnContextClassRef
217 217
      * @param LoggerInterface $logger
218 218
      * @return null|Response
219 219
      */
Please login to merge, or discard this patch.
src/Surfnet/StepupGateway/GatewayBundle/Service/ProxyResponseService.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -89,7 +89,6 @@
 block discarded – undo
89 89
     }
90 90
 
91 91
     /**
92
-     * @param SAML2_Assertion $assertion
93 92
      * @param ServiceProvider $targetServiceProvider
94 93
      * @param string|null $authnContextClassRef
95 94
      * @return \SAML2_Response
Please login to merge, or discard this patch.