Issues in UserController.php (master) - Issues in master - OmarElGabry/lumen-api-oauth - Measure and Improve Code Quality continuously with Scrutinizer

Issues (30)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

app/Http/Controllers/UserController.php (6 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php 

namespace App\Http\Controllers;

use App\User;

use Illuminate\Http\Request;
use Illuminate\Support\Facades\Hash;

class UserController extends Controller{

	public function __construct(){

		$this->middleware('oauth', ['except' => ['index', 'show']]);
		$this->middleware('authorize:' . __CLASS__, ['except' => ['index', 'show']]);
	}

	public function index(){

		$users = User::all();
		return $this->success($users, 200);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
	}

	public function store(Request $request){

		$this->validateRequest($request);

		$user = User::create([

					'email' => $request->get('email'),
					'password'=> Hash::make($request->get('password'))
				]);

		return $this->success("The user with with id {$user->id} has been created", 201);
	}

	public function show($id){


		$user = User::find($id);

		if(!$user){
			return $this->error("The user with {$id} doesn't exist", 404);
		}

		return $this->success($user, 200);
	}

	public function update(Request $request, $id){

		$user = User::find($id);

		if(!$user){
			return $this->error("The user with {$id} doesn't exist", 404);
		}

		$this->validateRequest($request);

		$user->email 		= $request->get('email');
		$user->password 	= Hash::make($request->get('password'));

		$user->save();

		return $this->success("The user with with id {$user->id} has been updated", 200);
	}

	public function destroy($id){


		$user = User::find($id);

		if(!$user){
			return $this->error("The user with {$id} doesn't exist", 404);
		}

		$user->delete();

		return $this->success("The user with with id {$id} has been deleted", 200);
	}

	public function validateRequest(Request $request){

		$rules = [
			'email' => 'required|email|unique:users', 
			'password' => 'required|min:6'
		];

		$this->validate($request, $rules);
	}

	public function isAuthorized(Request $request){

		$resource = "users";
		// $user     = User::find($this->getArgs($request)["user_id"]);


		return $this->authorizeUser($request, $resource);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
	}
}

1		<?php
2
3		namespace App\Http\Controllers;
4
5		use App\User;
6
7		use Illuminate\Http\Request;
8		use Illuminate\Support\Facades\Hash;
9
10		class UserController extends Controller{
11
12		public function __construct(){
13
14		$this->middleware('oauth', ['except' => ['index', 'show']]);
15		$this->middleware('authorize:' . __CLASS__, ['except' => ['index', 'show']]);
16		}
17
18		public function index(){
19
20		$users = User::all();
21		return $this->success($users, 200);
		0 ignored issues – show Bug introduced 2016-10-11 19:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$users` defined by `\App\User::all()` on line `20` can also be of type `object<Illuminate\Database\Eloquent\Collection>`; however, `App\Http\Controllers\Controller::success()` does only seem to accept `array`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
22		}
23
24		public function store(Request $request){
25
26		$this->validateRequest($request);
27
28		$user = User::create([
		0 ignored issues – show Bug introduced 2017-03-22 12:49 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `create()` does not exist on `App\User`. Did you maybe mean `created()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
29		'email' => $request->get('email'),
30		'password'=> Hash::make($request->get('password'))
31		]);
32
33		return $this->success("The user with with id {$user->id} has been created", 201);
34		}
35
36	View Code Duplication	public function show($id){
		0 ignored issues – show Duplication introduced 2016-04-07 08:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
37
38		$user = User::find($id);
39
40		if(!$user){
41		return $this->error("The user with {$id} doesn't exist", 404);
42		}
43
44		return $this->success($user, 200);
45		}
46
47		public function update(Request $request, $id){
48
49		$user = User::find($id);
50
51		if(!$user){
52		return $this->error("The user with {$id} doesn't exist", 404);
53		}
54
55		$this->validateRequest($request);
56
57		$user->email = $request->get('email');
58		$user->password = Hash::make($request->get('password'));
59
60		$user->save();
61
62		return $this->success("The user with with id {$user->id} has been updated", 200);
63		}
64
65	View Code Duplication	public function destroy($id){
		0 ignored issues – show Duplication introduced 2016-04-07 08:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
66
67		$user = User::find($id);
68
69		if(!$user){
70		return $this->error("The user with {$id} doesn't exist", 404);
71		}
72
73		$user->delete();
74
75		return $this->success("The user with with id {$id} has been deleted", 200);
76		}
77
78		public function validateRequest(Request $request){
79
80		$rules = [
81		'email' => 'required\|email\|unique:users',
82		'password' => 'required\|min:6'
83		];
84
85		$this->validate($request, $rules);
86		}
87
88		public function isAuthorized(Request $request){
89
90		$resource = "users";
91		// $user = User::find($this->getArgs($request)["user_id"]);
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-04-07 08:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this `65%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
92
93		return $this->authorizeUser($request, $resource);
		0 ignored issues – show Documentation introduced 2016-04-07 08:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$resource` is of type `string`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
94		}
95		}

OmarElGabry / lumen-api-oauth

Issues (30)

Security Analysis no request data

app/Http/Controllers/UserController.php (6 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like