App\Http\Controllers\UserController

Complexity

Total Complexity

11

Size/Duplication

Total Lines	86
Duplicated Lines	25.58 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	index()	0	5	1
A	update()	0	17	2

<?php 

namespace App\Http\Controllers;

use App\User;

use Illuminate\Http\Request;
use Illuminate\Support\Facades\Hash;

class UserController extends Controller{

	public function __construct(){

		$this->middleware('oauth', ['except' => ['index', 'show']]);
		$this->middleware('authorize:' . __CLASS__, ['except' => ['index', 'show']]);
	}

	public function index(){

		$users = User::all();
		return $this->success($users, 200);

It seems like $users defined by \App\User::all() on line 20 can also be of type object<Illuminate\Database\Eloquent\Collection>; however, App\Http\Controllers\Controller::success() does only seem to accept array, maybe add an additional type check?

	}

	public function store(Request $request){

		$this->validateRequest($request);

		$user = User::create([

The method create() does not exist on App\User. Did you maybe mean created()?

					'email' => $request->get('email'),
					'password'=> Hash::make($request->get('password'))
				]);

		return $this->success("The user with with id {$user->id} has been created", 201);
	}

	public function show($id){

This method seems to be duplicated in your project.

		$user = User::find($id);

		if(!$user){
			return $this->error("The user with {$id} doesn't exist", 404);
		}

		return $this->success($user, 200);
	}

	public function update(Request $request, $id){

		$user = User::find($id);

		if(!$user){
			return $this->error("The user with {$id} doesn't exist", 404);
		}

		$this->validateRequest($request);

		$user->email 		= $request->get('email');
		$user->password 	= Hash::make($request->get('password'));

		$user->save();

		return $this->success("The user with with id {$user->id} has been updated", 200);
	}

	public function destroy($id){

This method seems to be duplicated in your project.

		$user = User::find($id);

		if(!$user){
			return $this->error("The user with {$id} doesn't exist", 404);
		}

		$user->delete();

		return $this->success("The user with with id {$id} has been deleted", 200);
	}

	public function validateRequest(Request $request){

		$rules = [
			'email' => 'required|email|unique:users', 
			'password' => 'required|min:6'
		];

		$this->validate($request, $rules);
	}

	public function isAuthorized(Request $request){

		$resource = "users";
		// $user     = User::find($this->getArgs($request)["user_id"]);

65% of this comment could be valid code. Did you maybe forget this after debugging?

		return $this->authorizeUser($request, $resource);

$resource is of type string, but the function expects a array.

	}
}