OmarElGabry / lumen-api-oauth

app/Listeners/ExampleListener.php

Unused Use Statements -2 removed lines

@@ -3,8 +3,6 @@
 namespace App\Listeners;
 
 use App\Events\ExampleEvent;
-use Illuminate\Queue\InteractsWithQueue;
-use Illuminate\Contracts\Queue\ShouldQueue;
 
 class ExampleListener
 {

app/User.php

Unused Use Statements -1 removed lines

@@ -7,7 +7,6 @@
 use Illuminate\Database\Eloquent\Model;
 use Illuminate\Contracts\Auth\Authenticatable as AuthenticatableContract;
 use Illuminate\Contracts\Auth\Access\Authorizable as AuthorizableContract;
-
 use Illuminate\Support\Facades\Hash;
 
 class User extends Model implements AuthenticatableContract, AuthorizableContract{

Spacing +2 added lines, -2 removed lines

@@ -40,11 +40,11 @@
      * @return int|boolean
      * @see    https://github.com/lucadegasperi/oauth2-server-laravel/blob/master/docs/authorization-server/password.md
      */
-    public function verify($email, $password){
+    public function verify($email, $password) {
 
         $user = User::where('email', $email)->first();
 
-        if($user && Hash::check($password, $user->password)){
+        if ($user && Hash::check($password, $user->password)) {
             return $user->id;
         }
 

app/Comment.php

Indentation +5 added lines, -5 removed lines

@@ -9,22 +9,22 @@
      *
      * @var array
      */
-	protected $fillable = ['id', 'post_id', 'user_id', 'content'];
+    protected $fillable = ['id', 'post_id', 'user_id', 'content'];
 
     /**
      * The attributes excluded from the model's JSON form.
      *
      * @var array
      */
-	protected $hidden   = ['created_at', 'updated_at'];
+    protected $hidden   = ['created_at', 'updated_at'];
 
     /**
      * Define an inverse one-to-many relationship with App\Post.
      *
      * @return \Illuminate\Database\Eloquent\Relations\BelongsTo
      */
-	public function post(){
-		return $this->belongsTo('App\Post');
-	}
+    public function post(){
+        return $this->belongsTo('App\Post');
+    }
 
 }
\ No newline at end of file

Spacing +3 added lines, -3 removed lines

@@ -2,7 +2,7 @@ 
 
 use Illuminate\Database\Eloquent\Model;
 
-class Comment extends Model{
+class Comment extends Model {
 
     /**
      * The attributes that are mass assignable.
@@ -16,14 +16,14 @@ 
      *
      * @var array
      */
-	protected $hidden   = ['created_at', 'updated_at'];
+	protected $hidden = ['created_at', 'updated_at'];
 
     /**
      * Define an inverse one-to-many relationship with App\Post.
      *
      * @return \Illuminate\Database\Eloquent\Relations\BelongsTo
      */
-	public function post(){
+	public function post() {
 		return $this->belongsTo('App\Post');
 	}
 

app/Exceptions/Handler.php

Spacing +3 added lines, -3 removed lines

@@ -48,15 +48,15 @@
      */
     public function render($request, Exception $e)
     {
-        if(env('APP_DEBUG')){
+        if (env('APP_DEBUG')) {
             return parent::render($request, $e);
         }
 
-        if($e instanceof NotFoundHttpException){
+        if ($e instanceof NotFoundHttpException) {
             return response()->json(['message' => 'Bad Request', 'code' => 400], 400);
         }
 
-        if($e instanceof MethodNotAllowedHttpException){
+        if ($e instanceof MethodNotAllowedHttpException) {
             return response()->json(['message' => 'Not Found', 'code' => 404], 404);
         }
 

Unused Use Statements -1 removed lines

@@ -7,7 +7,6 @@
 use Illuminate\Database\Eloquent\Model;
 use Illuminate\Contracts\Auth\Authenticatable as AuthenticatableContract;
 use Illuminate\Contracts\Auth\Access\Authorizable as AuthorizableContract;
-
 use Illuminate\Support\Facades\Hash;
 
 class User extends Model implements AuthenticatableContract, AuthorizableContract{

app/Post.php

Indentation +5 added lines, -5 removed lines

@@ -9,22 +9,22 @@
      *
      * @var array
      */
-	protected $fillable = ['id', 'user_id', 'title', 'content'];
+    protected $fillable = ['id', 'user_id', 'title', 'content'];
 
     /**
      * The attributes excluded from the model's JSON form.
      *
      * @var array
      */
-	protected $hidden   = ['created_at', 'updated_at'];
+    protected $hidden   = ['created_at', 'updated_at'];
 
     /**
      * Define a one-to-many relationship with App\Comment
      *
      * @return \Illuminate\Database\Eloquent\Relations\HasMany
      */
-	public function comments(){
-		return $this->hasMany('App\Comment');
-	}
+    public function comments(){
+        return $this->hasMany('App\Comment');
+    }
 
 }
\ No newline at end of file

Spacing +3 added lines, -3 removed lines

@@ -2,7 +2,7 @@ 
 
 use Illuminate\Database\Eloquent\Model;
 
-class Post extends Model{
+class Post extends Model {
 
     /**
      * The attributes that are mass assignable.
@@ -16,14 +16,14 @@ 
      *
      * @var array
      */
-	protected $hidden   = ['created_at', 'updated_at'];
+	protected $hidden = ['created_at', 'updated_at'];
 
     /**
      * Define a one-to-many relationship with App\Comment
      *
      * @return \Illuminate\Database\Eloquent\Relations\HasMany
      */
-	public function comments(){
+	public function comments() {
 		return $this->hasMany('App\Comment');
 	}
 

app/Providers/AuthServiceProvider.php

Spacing +6 added lines, -6 removed lines

@@ -56,7 +56,7 @@ 
      * @param  array  $arguments
      * @return boolean
      */
-    private function isOwner($arguments = []){
+    private function isOwner($arguments = []) {
 
         foreach ($arguments as $resource => $actions) {
             foreach ($actions as $action) {
@@ -67,9 +67,9 @@ 
                 //     }
                 // });
 
-                Gate::define($this->ability($action, $resource), function ($user, $arg) {
+                Gate::define($this->ability($action, $resource), function($user, $arg) {
                    
-                    if(is_null($arg))  { return false; }
+                    if (is_null($arg)) { return false; }
 
                     return $arg->user_id === $user->id || $user->is_admin;
                 });            
@@ -83,11 +83,11 @@ 
      * @param  array  $arguments
      * @return boolean
      */
-    private function isAdmin($arguments){
+    private function isAdmin($arguments) {
 
         foreach ($arguments as $resource => $actions) {
             foreach ($actions as $action) {
-                Gate::define($this->ability($action, $resource), function ($user) {
+                Gate::define($this->ability($action, $resource), function($user) {
                     return $user->is_admin;
                 });
             }
@@ -101,7 +101,7 @@ 
      * @param  string  $resource
      * @return string
      */
-    private function ability($action, $resource){
+    private function ability($action, $resource) {
         return "{$action}-{$resource}";
     }
     

app/Http/Middleware/Authorize.php

Spacing +2 added lines, -2 removed lines

@@ -11,11 +11,11 @@
      * @param  \Closure  $next
      * @return mixed
      */
-    public function handle($request, Closure $next, $controller){
+    public function handle($request, Closure $next, $controller) {
 
         $controller = new $controller();
 
-        if(!$controller->isAuthorized($request)){
+        if (!$controller->isAuthorized($request)) {
             return $controller->error("You aren't allowed to perform the requested action", 403);
         }
 

app/Http/Controllers/CommentController.php

Indentation +11 added lines, -11 removed lines

@@ -4,20 +4,20 @@
 
 class CommentController extends Controller{
 
-	public function index(){
+    public function index(){
 		
-		$comments = Comment::all();
-		return $this->success($comments, 200);
-	}
+        $comments = Comment::all();
+        return $this->success($comments, 200);
+    }
 
-	public function show($id){
+    public function show($id){
 
-		$comment = Comment::find($id);
+        $comment = Comment::find($id);
 
-		if(!$comment){
-			return $this->error("The comment with {$id} doesn't exist", 404);
-		}
+        if(!$comment){
+            return $this->error("The comment with {$id} doesn't exist", 404);
+        }
 
-		return $this->success($comment, 200);
-	}
+        return $this->success($comment, 200);
+    }
 }
\ No newline at end of file

Spacing +4 added lines, -4 removed lines

@@ -2,19 +2,19 @@
 
 use App\Comment;
 
-class CommentController extends Controller{
+class CommentController extends Controller {
 
-	public function index(){
+	public function index() {
 		
 		$comments = Comment::all();
 		return $this->success($comments, 200);
 	}
 
-	public function show($id){
+	public function show($id) {
 
 		$comment = Comment::find($id);
 
-		if(!$comment){
+		if (!$comment) {
 			return $this->error("The comment with {$id} doesn't exist", 404);
 		}
 

app/Http/Controllers/PostController.php

Indentation +59 added lines, -59 removed lines

@@ -6,92 +6,92 @@
 
 class PostController extends Controller{
 
-	public function __construct(){
+    public function __construct(){
 
-		$this->middleware('oauth', ['except' => ['index', 'show']]);
-		$this->middleware('authorize:' . __CLASS__, ['except' => ['index', 'show', 'store']]);
-	}
+        $this->middleware('oauth', ['except' => ['index', 'show']]);
+        $this->middleware('authorize:' . __CLASS__, ['except' => ['index', 'show', 'store']]);
+    }
 
-	public function index(){
+    public function index(){
 
-		$posts = Post::all();
-		return $this->success($posts, 200);
-	}
+        $posts = Post::all();
+        return $this->success($posts, 200);
+    }
 
-	public function store(Request $request){
+    public function store(Request $request){
 
-		$this->validateRequest($request);
+        $this->validateRequest($request);
 
-		$post = Post::create([
-					'title' => $request->get('title'),
-					'content'=> $request->get('content'),
-					'user_id' => $this->getUserId()
-				]);
+        $post = Post::create([
+                    'title' => $request->get('title'),
+                    'content'=> $request->get('content'),
+                    'user_id' => $this->getUserId()
+                ]);
 
-		return $this->success("The post with with id {$post->id} has been created", 201);
-	}
+        return $this->success("The post with with id {$post->id} has been created", 201);
+    }
 
-	public function show($id){
+    public function show($id){
 
-		$post = Post::find($id);
+        $post = Post::find($id);
 
-		if(!$post){
-			return $this->error("The post with {$id} doesn't exist", 404);
-		}
+        if(!$post){
+            return $this->error("The post with {$id} doesn't exist", 404);
+        }
 
-		return $this->success($post, 200);
-	}
+        return $this->success($post, 200);
+    }
 
-	public function update(Request $request, $id){
+    public function update(Request $request, $id){
 
-		$post = Post::find($id);
+        $post = Post::find($id);
 
-		if(!$post){
-			return $this->error("The post with {$id} doesn't exist", 404);
-		}
+        if(!$post){
+            return $this->error("The post with {$id} doesn't exist", 404);
+        }
 
-		$this->validateRequest($request);
+        $this->validateRequest($request);
 
-		$post->title 		= $request->get('title');
-		$post->content 		= $request->get('content');
-		$post->user_id 		= $this->getUserId();
+        $post->title 		= $request->get('title');
+        $post->content 		= $request->get('content');
+        $post->user_id 		= $this->getUserId();
 
-		$post->save();
+        $post->save();
 
-		return $this->success("The post with with id {$post->id} has been updated", 200);
-	}
+        return $this->success("The post with with id {$post->id} has been updated", 200);
+    }
 
-	public function destroy($id){
+    public function destroy($id){
 
-		$post = Post::find($id);
+        $post = Post::find($id);
 
-		if(!$post){
-			return $this->error("The post with {$id} doesn't exist", 404);
-		}
+        if(!$post){
+            return $this->error("The post with {$id} doesn't exist", 404);
+        }
 
-		// no need to delete the comments for the current post,
-		// since we used on delete cascase on update cascase.
-		// $post->comments()->delete();
-		$post->delete();
+        // no need to delete the comments for the current post,
+        // since we used on delete cascase on update cascase.
+        // $post->comments()->delete();
+        $post->delete();
 
-		return $this->success("The post with with id {$id} has been deleted along with it's comments", 200);
-	}
+        return $this->success("The post with with id {$id} has been deleted along with it's comments", 200);
+    }
 
-	public function validateRequest(Request $request){
+    public function validateRequest(Request $request){
 
-		$rules = [
-			'title' => 'required', 
-			'content' => 'required'
-		];
+        $rules = [
+            'title' => 'required', 
+            'content' => 'required'
+        ];
 
-		$this->validate($request, $rules);
-	}
+        $this->validate($request, $rules);
+    }
 
-	public function isAuthorized(Request $request){
+    public function isAuthorized(Request $request){
 
-		$resource = "posts";
-		$post     = Post::find($this->getArgs($request)["post_id"]);
+        $resource = "posts";
+        $post     = Post::find($this->getArgs($request)["post_id"]);
 
-		return $this->authorizeUser($request, $resource, $post);
-	}
+        return $this->authorizeUser($request, $resource, $post);
+    }
 }
\ No newline at end of file

Unused Use Statements -1 removed lines

@@ -7,7 +7,6 @@
 use Illuminate\Database\Eloquent\Model;
 use Illuminate\Contracts\Auth\Authenticatable as AuthenticatableContract;
 use Illuminate\Contracts\Auth\Access\Authorizable as AuthorizableContract;
-
 use Illuminate\Support\Facades\Hash;
 
 class User extends Model implements AuthenticatableContract, AuthorizableContract{

Spacing +14 added lines, -14 removed lines

@@ -6,21 +6,21 @@ 
 
 use Illuminate\Http\Request;
 
-class PostController extends Controller{
+class PostController extends Controller {
 
-	public function __construct(){
+	public function __construct() {
 
 		$this->middleware('oauth', ['except' => ['index', 'show']]);
-		$this->middleware('authorize:' . __CLASS__, ['except' => ['index', 'show', 'store']]);
+		$this->middleware('authorize:'.__CLASS__, ['except' => ['index', 'show', 'store']]);
 	}
 
-	public function index(){
+	public function index() {
 
 		$posts = Post::all();
 		return $this->success($posts, 200);
 	}
 
-	public function store(Request $request){
+	public function store(Request $request) {
 
 		$this->validateRequest($request);
 
@@ -33,28 +33,28 @@ 
 		return $this->success("The post with with id {$post->id} has been created", 201);
 	}
 
-	public function show($id){
+	public function show($id) {
 
 		$post = Post::find($id);
 
-		if(!$post){
+		if (!$post) {
 			return $this->error("The post with {$id} doesn't exist", 404);
 		}
 
 		return $this->success($post, 200);
 	}
 
-	public function update(Request $request, $id){
+	public function update(Request $request, $id) {
 
 		$post = Post::find($id);
 
-		if(!$post){
+		if (!$post) {
 			return $this->error("The post with {$id} doesn't exist", 404);
 		}
 
 		$this->validateRequest($request);
 
-		$post->title 		= $request->get('title');
+		$post->title = $request->get('title');
 		$post->content 		= $request->get('content');
 		$post->user_id 		= $this->getUserId();
 
@@ -63,11 +63,11 @@ 
 		return $this->success("The post with with id {$post->id} has been updated", 200);
 	}
 
-	public function destroy($id){
+	public function destroy($id) {
 
 		$post = Post::find($id);
 
-		if(!$post){
+		if (!$post) {
 			return $this->error("The post with {$id} doesn't exist", 404);
 		}
 
@@ -79,7 +79,7 @@ 
 		return $this->success("The post with with id {$id} has been deleted along with it's comments", 200);
 	}
 
-	public function validateRequest(Request $request){
+	public function validateRequest(Request $request) {
 
 		$rules = [
 			'title' => 'required', 
@@ -89,7 +89,7 @@ 
 		$this->validate($request, $rules);
 	}
 
-	public function isAuthorized(Request $request){
+	public function isAuthorized(Request $request) {
 
 		$resource = "posts";
 		$post     = Post::find($this->getArgs($request)["post_id"]);