DisplayParameterChecker::process() - Code Metrics - Inspection of "Bugs fixed and tests added" - OAuth2-Framework/oauth2-framework - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — ng ( ede6c5...efffe8 )

by Florent

created 2018-01-23 13:35 UTC

DisplayParameterChecker::process() A

↳ Parent: DisplayParameterChecker

Complexity

Conditions	4
Paths	4

Size

Total Lines	12
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	12
rs	9.2
c	0
b	0
f	0
cc	4
eloc	7
nc	4
nop	2

<?php

declare(strict_types=1);

/*
 * The MIT License (MIT)
 *
 * Copyright (c) 2014-2018 Spomky-Labs
 *
 * This software may be modified and distributed under the terms
 * of the MIT license.  See the LICENSE file for details.
 */

namespace OAuth2Framework\Component\Server\AuthorizationEndpoint\ParameterChecker;

use OAuth2Framework\Component\Server\AuthorizationEndpoint\Authorization;
use OAuth2Framework\Component\Server\AuthorizationEndpoint\Exception\OAuth2AuthorizationException;
use OAuth2Framework\Component\Server\Core\Exception\OAuth2Exception;

final class DisplayParameterChecker implements ParameterChecker
{
    public const DISPLAY_PAGE = 'page';

    public const DISPLAY_POPUP = 'popup';

    public const DISPLAY_TOUCH = 'touch';

    public const DISPLAY_WAP = 'wap';

    /**
     * {@inheritdoc}
     */
    public function check(Authorization $authorization): Authorization
    {
        try {
            if ($authorization->hasQueryParam('display') && !in_array($authorization->getQueryParam('display'), $this->getAllowedDisplayValues())) {
                throw new OAuth2AuthorizationException(400, OAuth2Exception::ERROR_INVALID_REQUEST, sprintf('Invalid parameter "display". Allowed values are %s', implode(', ', $this->getAllowedDisplayValues())), $authorization);
            }

            return $authorization;
        } catch (\InvalidArgumentException $e) {
            throw new OAuth2AuthorizationException(400, OAuth2Exception::ERROR_INVALID_REQUEST, $e->getMessage(), $authorization, $e);
        }
    }

    /**
     * @return string[]
     */
    private function getAllowedDisplayValues(): array
    {
        return [
            self::DISPLAY_PAGE,
            self::DISPLAY_POPUP,
            self::DISPLAY_TOUCH,
            self::DISPLAY_WAP,
        ];
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/*
6			* The MIT License (MIT)
7			*
8			* Copyright (c) 2014-2018 Spomky-Labs
9			*
10			* This software may be modified and distributed under the terms
11			* of the MIT license. See the LICENSE file for details.
12			*/
13
14			namespace OAuth2Framework\Component\Server\AuthorizationEndpoint\ParameterChecker;
15
16			use OAuth2Framework\Component\Server\AuthorizationEndpoint\Authorization;
17			use OAuth2Framework\Component\Server\AuthorizationEndpoint\Exception\OAuth2AuthorizationException;
18			use OAuth2Framework\Component\Server\Core\Exception\OAuth2Exception;
19
20			final class DisplayParameterChecker implements ParameterChecker
21			{
22			public const DISPLAY_PAGE = 'page';
23
24			public const DISPLAY_POPUP = 'popup';
25
26			public const DISPLAY_TOUCH = 'touch';
27
28			public const DISPLAY_WAP = 'wap';
29
30			/**
31			* {@inheritdoc}
32			*/
33			public function check(Authorization $authorization): Authorization
34			{
35			try {
36			if ($authorization->hasQueryParam('display') && !in_array($authorization->getQueryParam('display'), $this->getAllowedDisplayValues())) {
37			throw new OAuth2AuthorizationException(400, OAuth2Exception::ERROR_INVALID_REQUEST, sprintf('Invalid parameter "display". Allowed values are %s', implode(', ', $this->getAllowedDisplayValues())), $authorization);
38			}
39
40			return $authorization;
41			} catch (\InvalidArgumentException $e) {
42			throw new OAuth2AuthorizationException(400, OAuth2Exception::ERROR_INVALID_REQUEST, $e->getMessage(), $authorization, $e);
43			}
44			}
45
46			/**
47			* @return string[]
48			*/
49			private function getAllowedDisplayValues(): array
50			{
51			return [
52			self::DISPLAY_PAGE,
53			self::DISPLAY_POPUP,
54			self::DISPLAY_TOUCH,
55			self::DISPLAY_WAP,
56			];
57			}
58			}
59

OAuth2-Framework / oauth2-framework

Push — ng ( ede6c5...efffe8 )

DisplayParameterChecker::process() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like