Summary - Inspection of "Bugs fixed and tests added" - OAuth2-Framework/oauth2-framework - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — ng ( ede6c5...efffe8 )

by Florent

created 2018-01-23 13:35 UTC

Changes

3 failure conditions met `issues.severity(>= MAJOR).new.exists` File Path Number of issues AuthorizationEndpoint/AuthorizationEndpoint.php 1 AuthorizationRequestLoader.php 2 Server/OpenIdConnect/NonceParameterChecker.php 1 `elements.rating(<= C).exists` Name AnnotationDriver::onKernelController() Firewall\OAuth2Listener::handle() JwtBearerGrantType::checkJWTSignature() IdTokenResponseType::populateWithIdToken() TokenIntrospectionEndpoint::process() AuthenticationMethodManager::findClientIdAndCredentials() OAuth2FrameworkServerExtension OAuth2FrameworkServerBundle ClientAssertionJwt::findClientIdAndCredentials() ClientAssertionJwt::checkClientConfiguration() more ... `elements.rating(<= C).new.exists` Name AuthorizationRequestLoader ResponseTypeAndResponseModeParameterChecker::check()
	14 issues (4 major, 10 minor) were introduced. 16 issues were fixed.
	18 new patches (Unused Use Statements, Doc Comments) are available.
	64 added classes/operations
		B	ParameterCheckerManagerTest added
		C	ResponseTypeAndResponseModeParameterChecker::check() added
		B	PromptParameterChecker::check() added
		B	ConsentScreenExtensionManagerTest::getExtensionManager() added
		B	ParameterCheckerManagerTest::anAuthorizationRequestIsReceivedButTheRes... added
		B	ParameterCheckerManagerTest::anAuthorizationRequestIsReceivedAndIsVali... added
		B	ScopeParameterChecker::check() added
		A	ExtensionManager added
		A	OAuth2AuthorizationException added
		A	ConsentScreenExtensionManagerTest added
B	↗	A	ResponseTypeManager::all() improved
B	↘	C	AuthorizationRequestLoader got worse
B	↗	A	AuthorizationCodeResponseTypeTest::theRequestHaveMissingParameters() improved
A	↘	B	AuthorizationRequestLoader::tryToLoadEncryptedRequest() got worse
B	↗	A	ResponseTypesRule::checkGrantTypes() improved
view all

9.57

▼ -0.02

Head	Spomky 2018-01-23 14:31 GMT+0100 Bugs fixed and tests added
⋮	1 more commit
Base	Spomky 2018-01-21 20:43 UTC Response Mode tests

OAuth2-Framework / oauth2-framework

Push — ng ( ede6c5...efffe8 )

Changes

3 failure conditions met