Failed Conditions
Pull Request — master (#19)
by Florent
04:48
created
src/Bundle/Server/DependencyInjection/OAuth2FrameworkServerExtension.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
82 82
 
83 83
     /**
84 84
      * @param string           $path
85
-     * @param array            $sources
85
+     * @param SourceInterface[]            $sources
86 86
      * @param array            $mergedConfig
87 87
      * @param ContainerBuilder $container
88 88
      */
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
     /**
101 101
      * @param array            $bundleConfig
102 102
      * @param string           $path
103
-     * @param array            $sources
103
+     * @param SourceInterface[]            $sources
104 104
      * @param ContainerBuilder $container
105 105
      */
106 106
     private function prependSources(array $bundleConfig, string $path, array $sources, ContainerBuilder $container)
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types=1);
3
+declare(strict_types = 1);
4 4
 
5 5
 /*
6 6
  * The MIT License (MIT)
Please login to merge, or discard this patch.
src/Bundle/Server/Form/FormFactory.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -59,7 +59,7 @@
 block discarded – undo
59 59
 
60 60
     /**
61 61
      * @param array      $options
62
-     * @param mixed|null $data
62
+     * @param Model\AuthorizationModel $data
63 63
      *
64 64
      * @return FormInterface
65 65
      */
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types=1);
3
+declare(strict_types = 1);
4 4
 
5 5
 /*
6 6
  * The MIT License (MIT)
Please login to merge, or discard this patch.
src/Component/Server/Tests/Application/Application.php 2 patches
Unused Use Statements   -5 removed lines patch added patch discarded remove patch
@@ -22,10 +22,6 @@  discard block
 block discarded – undo
22 22
 use Interop\Http\Factory\ServerRequestFactoryInterface;
23 23
 use Interop\Http\Factory\UriFactoryInterface;
24 24
 use Jose\Checker\CheckerManager;
25
-use Jose\Checker\CriticalHeaderChecker;
26
-use Jose\Checker\ExpirationTimeChecker;
27
-use Jose\Checker\IssuedAtChecker;
28
-use Jose\Checker\NotBeforeChecker;
29 25
 use Jose\Decrypter;
30 26
 use Jose\Encrypter;
31 27
 use Jose\Factory\JWKFactory;
@@ -216,7 +212,6 @@  discard block
 block discarded – undo
216 212
 use OAuth2Framework\Component\Server\Tests\Stub\SecurityLayer;
217 213
 use OAuth2Framework\Component\Server\Tests\Stub\ServiceLocator;
218 214
 use OAuth2Framework\Component\Server\Tests\Stub\SessionStateParameterExtension;
219
-use OAuth2Framework\Component\Server\Tests\Stub\SubjectChecker;
220 215
 use OAuth2Framework\Component\Server\Tests\Stub\TrustedIssuer;
221 216
 use OAuth2Framework\Component\Server\Tests\Stub\UriExtension;
222 217
 use OAuth2Framework\Component\Server\Tests\Stub\UserAccountManager;
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types=1);
3
+declare(strict_types = 1);
4 4
 
5 5
 /*
6 6
  * The MIT License (MIT)
Please login to merge, or discard this patch.
src/Component/Server/Tests/Stub/AuthCodeRepository.php 2 patches
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -202,7 +202,7 @@  discard block
 block discarded – undo
202 202
      * @param string                  $redirectUri
203 203
      * @param DataBag                 $parameters
204 204
      * @param DataBag                 $metadatas
205
-     * @param array                   $scopes
205
+     * @param string[]                   $scopes
206 206
      * @param \DateTimeImmutable|null $expiresAt
207 207
      * @param bool                    $withRefreshToken
208 208
      * @param ResourceServerId|null   $resourceServerId
@@ -239,7 +239,7 @@  discard block
 block discarded – undo
239 239
      * @param string                  $redirectUri
240 240
      * @param DataBag                 $parameters
241 241
      * @param DataBag                 $metadatas
242
-     * @param array                   $scopes
242
+     * @param string[]                   $scopes
243 243
      * @param \DateTimeImmutable|null $expiresAt
244 244
      * @param bool                    $withRefreshToken
245 245
      * @param ResourceServerId|null   $resourceServerId
@@ -277,7 +277,7 @@  discard block
 block discarded – undo
277 277
      * @param string                  $redirectUri
278 278
      * @param DataBag                 $parameters
279 279
      * @param DataBag                 $metadatas
280
-     * @param array                   $scopes
280
+     * @param string[]                   $scopes
281 281
      * @param \DateTimeImmutable|null $expiresAt
282 282
      * @param bool                    $withRefreshToken
283 283
      * @param ResourceServerId|null   $resourceServerId
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types=1);
3
+declare(strict_types = 1);
4 4
 
5 5
 /*
6 6
  * The MIT License (MIT)
@@ -140,7 +140,7 @@  discard block
 block discarded – undo
140 140
     /**
141 141
      * {@inheritdoc}
142 142
      */
143
-    public function create(ClientId $clientId, UserAccountId $userAccountId, array $queryParameters, string $redirectUri, DataBag $parameters, DataBag $metadatas, array $scopes, bool $withRefreshToken, ?ResourceServerId $resourceServerId, ?\DateTimeImmutable $expiresAt): AuthCode
143
+    public function create(ClientId $clientId, UserAccountId $userAccountId, array $queryParameters, string $redirectUri, DataBag $parameters, DataBag $metadatas, array $scopes, bool $withRefreshToken, ? ResourceServerId $resourceServerId, ? \DateTimeImmutable $expiresAt) : AuthCode
144 144
     {
145 145
         if (null === $expiresAt) {
146 146
             $expiresAt = new \DateTimeImmutable($this->lifetime);
@@ -180,7 +180,7 @@  discard block
 block discarded – undo
180 180
     /**
181 181
      * {@inheritdoc}
182 182
      */
183
-    public function find(AuthCodeId $authCodeId): ?AuthCode
183
+    public function find(AuthCodeId $authCodeId): ? AuthCode
184 184
     {
185 185
         $authCode = null;
186 186
         $events = $this->eventStore->getEvents($authCodeId);
Please login to merge, or discard this patch.
src/Component/Server/Tests/Stub/PreConfiguredAuthorizationRepository.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -122,7 +122,7 @@
 block discarded – undo
122 122
      * @param PreConfiguredAuthorizationId $preConfiguredAuthorizationId
123 123
      * @param UserAccountId                $userAccountId
124 124
      * @param ClientId                     $clientId
125
-     * @param array                        $scopes
125
+     * @param string[]                        $scopes
126 126
      */
127 127
     private function createAndSavePreConfiguredAuthorization(PreConfiguredAuthorizationId $preConfiguredAuthorizationId, UserAccountId $userAccountId, ClientId $clientId, array $scopes)
128 128
     {
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types=1);
3
+declare(strict_types = 1);
4 4
 
5 5
 /*
6 6
  * The MIT License (MIT)
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
     /**
57 57
      * {@inheritdoc}
58 58
      */
59
-    public function create(UserAccountId $userAccountId, ClientId $clientId, array $scopes, ?ResourceServerId $resourceServerId): PreConfiguredAuthorization
59
+    public function create(UserAccountId $userAccountId, ClientId $clientId, array $scopes, ? ResourceServerId $resourceServerId) : PreConfiguredAuthorization
60 60
     {
61 61
         $hash = $this->calculateHash($userAccountId, $clientId, $scopes, $resourceServerId);
62 62
         $preConfiguredAuthorization = PreConfiguredAuthorization::createEmpty();
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
     /**
82 82
      * {@inheritdoc}
83 83
      */
84
-    public function find(UserAccountId $userAccountId, ClientId $clientId, array $scopes, ?ResourceServerId $resourceServerId): ?PreConfiguredAuthorization
84
+    public function find(UserAccountId $userAccountId, ClientId $clientId, array $scopes, ? ResourceServerId $resourceServerId) : ? PreConfiguredAuthorization
85 85
     {
86 86
         $hash = $this->calculateHash($userAccountId, $clientId, $scopes, $resourceServerId);
87 87
         $preConfiguredAuthorization = null;
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
104 104
      *
105 105
      * @return PreConfiguredAuthorizationId
106 106
      */
107
-    private function calculateHash(ResourceOwnerId $resourceOwnerId, ClientId $clientId, array $scope, ?ResourceServerId $resourceServerId): PreConfiguredAuthorizationId
107
+    private function calculateHash(ResourceOwnerId $resourceOwnerId, ClientId $clientId, array $scope, ? ResourceServerId $resourceServerId) : PreConfiguredAuthorizationId
108 108
     {
109 109
         return PreConfiguredAuthorizationId::create(hash(
110 110
             'sha512',
Please login to merge, or discard this patch.
src/Component/Server/Tests/Stub/ScopeRepository.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@
 block discarded – undo
41 41
     /**
42 42
      * ScopeManager constructor.
43 43
      *
44
-     * @param array $availableScopes
44
+     * @param string[] $availableScopes
45 45
      */
46 46
     public function __construct(array $availableScopes = [])
47 47
     {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types=1);
3
+declare(strict_types = 1);
4 4
 
5 5
 /*
6 6
  * The MIT License (MIT)
Please login to merge, or discard this patch.
AuthenticationMethod/PrivateKeyJwtTokenEndpointAuthenticationMethod.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -19,7 +19,7 @@
 block discarded – undo
19 19
     /**
20 20
      * {@inheritdoc}
21 21
      */
22
-    public function prepareRequest(ServerMetadata $server_metadata, OAuth2ClientInterface $client, RequestInterface &$request, array &$post_request)
22
+    public function prepareRequest(ServerMetadata $server_metadata, OAuth2ClientInterface $client, RequestInterface & $request, array &$post_request)
23 23
     {
24 24
     }
25 25
 }
Please login to merge, or discard this patch.
Client/AuthenticationMethod/TokenEndpointAuthenticationMethodInterface.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -21,5 +21,5 @@
 block discarded – undo
21 21
      *
22 22
      * @return mixed
23 23
      */
24
-    public function prepareRequest(ServerMetadata $server_metadata, OAuth2ClientInterface $client, RequestInterface &$request, array &$post_request);
24
+    public function prepareRequest(ServerMetadata $server_metadata, OAuth2ClientInterface $client, RequestInterface & $request, array &$post_request);
25 25
 }
Please login to merge, or discard this patch.
AuthenticationMethod/ClientSecretBasicTokenEndpointAuthenticationMethod.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@
 block discarded – undo
20 20
     /**
21 21
      * {@inheritdoc}
22 22
      */
23
-    public function prepareRequest(ServerMetadata $server_metadata, OAuth2ClientInterface $client, RequestInterface &$request, array &$post_request)
23
+    public function prepareRequest(ServerMetadata $server_metadata, OAuth2ClientInterface $client, RequestInterface & $request, array &$post_request)
24 24
     {
25 25
         Assertion::keyExists($client->getConfiguration(), 'client_secret');
26 26
         $this->checkClientTokenEndpointAuthenticationMethod($client);
Please login to merge, or discard this patch.