Summary - Inspection of "ClientAssertionJwt Tests added and bugs fixed" - OAuth2-Framework/oauth2-framework - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — ng ( 8b0de7...c3dfca )

by Florent

created 2018-03-22 12:50 UTC

Changes

3 failure conditions met `issues.severity(>= MAJOR).new.exists` File Path Number of issues AuthorizationRequestLoader.php 1 Tests/ClientConfigurationEndpointTest.php 1 ClientRegistrationEndpoint/Rule/SoftwareRule.php 1 Tests/ClientRegistrationEndpointTest.php 1 MetadataEndpoint/Tests/MetadataEndpointTest.php 1 src/Component/OpenIdConnect/IdTokenLoader.php 1 Tests/TokenRevocationEndpointTest.php 1 Tests/TokenRevocationGetEndpointTest.php 1 Tests/TokenRevocationPostEndpointTest.php 1 Form/Handler/AuthorizationFormHandler.php 1 ServerBundle/Security/Firewall/OAuth2Listener.php 1 ClientAuthentication/ClientAssertionJwt.php 2 more... `elements.rating(<= C).exists` Name AuthorizationEndpoint\Authorization AuthorizationEndpoint::process() ResponseTypeAndResponseModeParameterChecker::check() IdTokenHintDiscovery::check() UserAccountDiscoveryManager::find() IdTokenResponseType::populateWithIdToken() TokenIntrospectionEndpoint::process() AuthorizationCodeResponseType::process() AuthenticationMethodManager::findClientIdAndCredentials() ClientRule\SoftwareRule::handle() more ... `elements.rating(<= C).new.exists` Name ClientAssertionJwt::processPrivateKeyJwtConfiguration()
	20 issues (13 major, 5 minor, 2 informational) were introduced. 38 issues were fixed.
	26 added classes/operations
		C	ClientAssertionJwt::processPrivateKeyJwtConfiguration() added
		A	ClientAssertionJwtAuthenticationMethodTest added
		A	ClientAssertionJwt::processClientSecretJwtConfiguration() added
		A	ClientAssertionJwtAuthenticationMethodTest::genericCalls() added
		A	ClientAssertionJwtAuthenticationMethodTest::theClientIdCannotBeFoundIn... added
		A	ClientAssertionJwtAuthenticationMethodTest::theClientAssertionTypeIsNo... added
		A	ClientAssertionJwtAuthenticationMethodTest::theClientAssertionIsMissin... added
		A	ClientAssertionJwtAuthenticationMethodTest::theClientAssertionIsInvali... added
		A	ClientAssertionJwtAuthenticationMethodTest::theClientAssertionSignedBy... added
		A	ClientAssertionJwtAuthenticationMethodTest::theClientAssertionIsValidA... added
C	↗	A	ClientAssertionJwt::checkClientConfiguration() improved
D	↗	B	JwtBearerGrantType improved
D	↗	A	JwtBearerGrantTypeTest improved
F	↗	B	ClientAssertionJwt improved
B	↗	A	TokenEndpoint improved
B	↗	A	AuthorizationCodeGrantTypeTest improved
C	↗	B	ClientAssertionJwt::findClientIdAndCredentials() improved
B	↗	A	ParameterCheckerManagerTest improved
B	↗	A	AuthorizationEndpointSource improved
C	↗	B	IdTokenBuilder improved
view all

9.63

▲ + 0.17

Head	Spomky 2018-03-22 13:50 GMT+0100 ClientAssertionJwt Tests added and bugs fixed
Base	Spomky 2018-03-21 12:26 UTC Use of the last v1.1@beta JWT framework components

OAuth2-Framework / oauth2-framework

Push — ng ( 8b0de7...c3dfca )

Changes

3 failure conditions met