OAuth2Framework\Component\ClientRule\JwksRule::handle()

Complexity

Conditions	10
Paths	13

Size

Total Lines	34
Code Lines	21

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function handle(ClientId $clientId, DataBag $commandParameters, DataBag $validatedParameters, RuleHandler $next): DataBag
    {
        if ($commandParameters->has('jwks') && $commandParameters->has('jwks_uri')) {
            throw new \InvalidArgumentException('The parameters "jwks" and "jwks_uri" cannot be set together.');
        }

        if ($commandParameters->has('jwks')) {
            try {
                $keyset = JWKSet::createFromKeyData($commandParameters->get('jwks'));

It seems like $commandParameters->get('jwks') can also be of type null; however, parameter $data of Jose\Component\Core\JWKSet::createFromKeyData() does only seem to accept array, maybe add an additional type check?

            } catch (\Throwable $e) {
                throw new \InvalidArgumentException('The parameter "jwks" must be a valid JWKSet object.', 0, $e);
            }
            if (0 === \count($keyset)) {
                throw new \InvalidArgumentException('The parameter "jwks" must not be empty.');
            }
            $validatedParameters->set('jwks', $commandParameters->get('jwks'));
        }
        if ($commandParameters->has('jwks_uri')) {
            if (null === $this->jkuFactory) {
                throw new \InvalidArgumentException('Distant key sets cannot be used. Please use "jwks" instead of "jwks_uri".');
            }

            try {
                $jwks = $this->jkuFactory->loadFromUrl($commandParameters->get('jwks_uri'));

It seems like $commandParameters->get('jwks_uri') can also be of type null; however, parameter $url of Jose\Component\KeyManagement\JKUFactory::loadFromUrl() does only seem to accept string, maybe add an additional type check?

            } catch (\Throwable $e) {
                throw new \InvalidArgumentException('The parameter "jwks_uri" must be a valid uri to a JWKSet.', 0, $e);
            }
            if (0 === $jwks->count()) {
                throw new \InvalidArgumentException('The distant key set is empty.');
            }
            $validatedParameters->set('jwks_uri', $commandParameters->get('jwks_uri'));
        }

        return $next->handle($clientId, $commandParameters, $validatedParameters);
    }