OAuth2Framework\Component\ClientRule\JwksRule

Complexity

Total Complexity

11

Size/Duplication

Total Lines	46
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
B	handle()	0	34	10

<?php

declare(strict_types=1);

/*
 * The MIT License (MIT)
 *
 * Copyright (c) 2014-2019 Spomky-Labs
 *
 * This software may be modified and distributed under the terms
 * of the MIT license.  See the LICENSE file for details.
 */

namespace OAuth2Framework\Component\ClientRule;

use Jose\Component\Core\JWKSet;
use Jose\Component\KeyManagement\JKUFactory;
use OAuth2Framework\Component\Core\Client\ClientId;
use OAuth2Framework\Component\Core\DataBag\DataBag;

class JwksRule implements Rule
{
    /**
     * @var null|JKUFactory
     */
    private $jkuFactory;

    public function __construct(?JKUFactory $jkuFactory)
    {
        $this->jkuFactory = $jkuFactory;
    }

    public function handle(ClientId $clientId, DataBag $commandParameters, DataBag $validatedParameters, RuleHandler $next): DataBag
    {
        if ($commandParameters->has('jwks') && $commandParameters->has('jwks_uri')) {
            throw new \InvalidArgumentException('The parameters "jwks" and "jwks_uri" cannot be set together.');
        }

        if ($commandParameters->has('jwks')) {
            try {
                $keyset = JWKSet::createFromKeyData($commandParameters->get('jwks'));

It seems like $commandParameters->get('jwks') can also be of type null; however, parameter $data of Jose\Component\Core\JWKSet::createFromKeyData() does only seem to accept array, maybe add an additional type check?

            } catch (\Throwable $e) {
                throw new \InvalidArgumentException('The parameter "jwks" must be a valid JWKSet object.', 0, $e);
            }
            if (0 === \count($keyset)) {
                throw new \InvalidArgumentException('The parameter "jwks" must not be empty.');
            }
            $validatedParameters->set('jwks', $commandParameters->get('jwks'));
        }
        if ($commandParameters->has('jwks_uri')) {
            if (null === $this->jkuFactory) {
                throw new \InvalidArgumentException('Distant key sets cannot be used. Please use "jwks" instead of "jwks_uri".');
            }

            try {
                $jwks = $this->jkuFactory->loadFromUrl($commandParameters->get('jwks_uri'));

It seems like $commandParameters->get('jwks_uri') can also be of type null; however, parameter $url of Jose\Component\KeyManagement\JKUFactory::loadFromUrl() does only seem to accept string, maybe add an additional type check?

            } catch (\Throwable $e) {
                throw new \InvalidArgumentException('The parameter "jwks_uri" must be a valid uri to a JWKSet.', 0, $e);
            }
            if (0 === $jwks->count()) {
                throw new \InvalidArgumentException('The distant key set is empty.');
            }
            $validatedParameters->set('jwks_uri', $commandParameters->get('jwks_uri'));
        }

        return $next->handle($clientId, $commandParameters, $validatedParameters);
    }
}