SFTP::connectWithKey() - Code Metrics - Inspection of "Allow SSH agent connection" - NovikovViktor/SFTPBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — develop (#1)

unknown

created 2017-01-02 10:00 UTC

SFTP::connectWithKey() A

↳ Parent: SFTP

Complexity

Conditions	1
Paths	1

Size

Total Lines	10
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	10
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	6
nc	1
nop	5

<?php

namespace SF2Helpers\SFTPBundle\SFTP;

class SFTP implements ConnectionInterface, ResourceTransferInterface
{
    private $connection; // connection instance

    private $sftp; // established sftp


    public function __construct()
    {
    }

    public function connect($host, $username, $password=NULL, string $pubkeyfile=NULL, string $privkeyfile=NULL)
    {
        $connection = ssh2_connect($host);

        if ($password.is_null()) {
            ssh2_auth_agent($connection, $username);
        } else {
            ssh2_auth_password($connection, $username, $password);
        }

        $sftp = ssh2_sftp($connection);
        $this->connection = $connection;
        $this->sftp = $sftp;
    }

    public function connectWithKey($host, $username, string $pubkeyfile, string $privkeyfile, string $passphrase=NULL)

    {
        $connection = ssh2_connect($host);

        ssh2_auth_pubkey_file($connection, $username, $pubkeyfile, $privkeyfile, $password);


        $sftp = ssh2_sftp($connection);
        $this->connection = $connection;
        $this->sftp = $sftp;
    }

    public function copy($remoteFile, $localFile)

    {
        $sftp = "ssh2.sftp://$this->sftp";
        $data = file_get_contents($sftp . $remoteFile);
        if (!$data) {
            throw new \Exception('File can`t be loaded from server');
        }
        file_put_contents($localFile, $data);
    }

    public function send($localFile, $remoteFile)

    {
        $sftp = "ssh2.sftp://$this->sftp";
        $data = file_get_contents($localFile);
        if (!file_put_contents($sftp . $remoteFile, $data)) {
            throw new \Exception('File could not be uploaded to server');
        }
    }

    public function getFilesList($dir) {
        $handle = opendir("ssh2.sftp://$this->sftp" . $dir);
        $files = array();

        while (false != ($entry = readdir($handle))){

            $files[] = $entry;
        }

        return $files;
    }

    public function disconnect()
    {
        ssh2_exec($this->connection, 'exit');
        unset($this->connection);
    }
}


1		<?php
2
3		namespace SF2Helpers\SFTPBundle\SFTP;
4
5		class SFTP implements ConnectionInterface, ResourceTransferInterface
6		{
7		private $connection; // connection instance
8
9		private $sftp; // established sftp
10
11
12		public function __construct()
13		{
14		}
15
16		public function connect($host, $username, $password=NULL, string $pubkeyfile=NULL, string $privkeyfile=NULL)
17		{
18		$connection = ssh2_connect($host);
19
20		if ($password.is_null()) {
21		ssh2_auth_agent($connection, $username);
22		} else {
23		ssh2_auth_password($connection, $username, $password);
24		}
25
26		$sftp = ssh2_sftp($connection);
27		$this->connection = $connection;
28		$this->sftp = $sftp;
29		}
30
31		public function connectWithKey($host, $username, string $pubkeyfile, string $privkeyfile, string $passphrase=NULL)
		0 ignored issues – show Unused Code introduced 2017-01-02 10:02 UTC by Report Bug Copy Issue Report The parameter `$passphrase` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
32		{
33		$connection = ssh2_connect($host);
34
35		ssh2_auth_pubkey_file($connection, $username, $pubkeyfile, $privkeyfile, $password);
		0 ignored issues – show Bug introduced 2017-01-02 10:02 UTC by Report Bug Copy Issue Report The variable `$password` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history...
36
37		$sftp = ssh2_sftp($connection);
38		$this->connection = $connection;
39		$this->sftp = $sftp;
40		}
41
42	View Code Duplication	public function copy($remoteFile, $localFile)
		0 ignored issues – show Duplication introduced 2015-12-29 14:53 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
43		{
44		$sftp = "ssh2.sftp://$this->sftp";
45		$data = file_get_contents($sftp . $remoteFile);
46		if (!$data) {
47		throw new \Exception('File can`t be loaded from server');
48		}
49		file_put_contents($localFile, $data);
50		}
51
52	View Code Duplication	public function send($localFile, $remoteFile)
		0 ignored issues – show Duplication introduced 2015-12-29 14:53 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
53		{
54		$sftp = "ssh2.sftp://$this->sftp";
55		$data = file_get_contents($localFile);
56		if (!file_put_contents($sftp . $remoteFile, $data)) {
57		throw new \Exception('File could not be uploaded to server');
58		}
59		}
60
61		public function getFilesList($dir) {
62		$handle = opendir("ssh2.sftp://$this->sftp" . $dir);
63		$files = array();
64
65		while (false != ($entry = readdir($handle))){
		0 ignored issues – show Bug Best Practice introduced 2015-12-29 14:53 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing `$entry = readdir($handle)` of type `string` to the boolean `false`. If you are specifically checking for a non-empty string, consider using the more explicit `!== ''` instead. Loading history...
66		$files[] = $entry;
67		}
68
69		return $files;
70		}
71
72		public function disconnect()
73		{
74		ssh2_exec($this->connection, 'exit');
75		unset($this->connection);
76		}
77		}
78

NovikovViktor / SFTPBundle

Pull Request — develop (#1)

SFTP::connectWithKey() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like