SF2Helpers\SFTPBundle\SFTP\SFTP

Complexity

Total Complexity

11

Size/Duplication

Total Lines	73
Duplicated Lines	23.29 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	connect()	0	14	2
A	connectWithKey()	0	10	1
A	copy()	9	9	2
A	send()	8	8	2
A	getFilesList()	0	10	2
A	disconnect()	0	5	1

<?php

namespace SF2Helpers\SFTPBundle\SFTP;

class SFTP implements ConnectionInterface, ResourceTransferInterface
{
    private $connection; // connection instance

    private $sftp; // established sftp


    public function __construct()
    {
    }

    public function connect($host, $username, $password=NULL, string $pubkeyfile=NULL, string $privkeyfile=NULL)
    {
        $connection = ssh2_connect($host);

        if ($password.is_null()) {
            ssh2_auth_agent($connection, $username);
        } else {
            ssh2_auth_password($connection, $username, $password);
        }

        $sftp = ssh2_sftp($connection);
        $this->connection = $connection;
        $this->sftp = $sftp;
    }

    public function connectWithKey($host, $username, string $pubkeyfile, string $privkeyfile, string $passphrase=NULL)

The parameter $passphrase is not used and could be removed.

    {
        $connection = ssh2_connect($host);

        ssh2_auth_pubkey_file($connection, $username, $pubkeyfile, $privkeyfile, $password);

The variable $password does not exist. Did you forget to declare it?

        $sftp = ssh2_sftp($connection);
        $this->connection = $connection;
        $this->sftp = $sftp;
    }

    public function copy($remoteFile, $localFile)

This method seems to be duplicated in your project.

    {
        $sftp = "ssh2.sftp://$this->sftp";
        $data = file_get_contents($sftp . $remoteFile);
        if (!$data) {
            throw new \Exception('File can`t be loaded from server');
        }
        file_put_contents($localFile, $data);
    }

    public function send($localFile, $remoteFile)

This method seems to be duplicated in your project.

    {
        $sftp = "ssh2.sftp://$this->sftp";
        $data = file_get_contents($localFile);
        if (!file_put_contents($sftp . $remoteFile, $data)) {
            throw new \Exception('File could not be uploaded to server');
        }
    }

    public function getFilesList($dir) {
        $handle = opendir("ssh2.sftp://$this->sftp" . $dir);
        $files = array();

        while (false != ($entry = readdir($handle))){

It seems like you are loosely comparing $entry = readdir($handle) of type string to the boolean false. If you are specifically checking for a non-empty string, consider using the more explicit !== '' instead.

            $files[] = $entry;
        }

        return $files;
    }

    public function disconnect()
    {
        ssh2_exec($this->connection, 'exit');
        unset($this->connection);
    }
}