Nickbur / Sunrise-CMS

administration/controller/tool/updater.php

<?php

/* 	Divine CMS - Open source CMS for widespread use.
    Copyright (c) 2019 Mykola Burakov (burakov.work@gmail.com)

    See SOURCE.txt for other and additional information.

    This file is part of Divine CMS.

    This program is free software: you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
    the Free Software Foundation, either version 3 of the License, or
    (at your option) any later version.

    This program is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
    GNU General Public License for more details.

    You should have received a copy of the GNU General Public License
    along with this program. If not, see <http://www.gnu.org/licenses/>. */

use SebastianBergmann\Diff\Differ;
use SebastianBergmann\Diff\Output\StrictUnifiedDiffOutputBuilder;
use DiffMatchPatch\DiffMatchPatch;

The type DiffMatchPatch\DiffMatchPatch was not found. Maybe you did not declare it correctly or list all dependencies?

class ControllerToolUpdater extends \Divine\Engine\Core\Controller

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    public function index()

Expected 2 blank lines before function; 0 found

    {

Expected 0 blank lines after opening function brace; 1 found

        // scripts & styles
        // $this->document->addStyle('https://cdnjs.cloudflare.com/ajax/libs/diff2html/2.9.0/diff2html.min.css');
        // $this->document->addScript('https://cdnjs.cloudflare.com/ajax/libs/diff2html/2.9.0/diff2html.min.js');
        // $this->document->addScript('https://cdnjs.cloudflare.com/ajax/libs/diff2html/2.9.0/diff2html-ui.min.js');

        // language
        // load lang file
        $this->load->language('tool/updater');
        // set standart defines
        $this->document->setTitle($this->language->get('heading_title'));
        $data['heading_title'] = $this->language->get('heading_title');

$data was never initialized. Although not strictly required by PHP, it is generally a good practice to add $data = array(); before regardless.

        // set user defines
        $data['updater_update_text'] = $this->language->get('updater_update_text');

        // alert warning
        if (isset($this->error['warning'])) {
            $data['error_warning'] = $this->error['warning'];
        } else {
            $data['error_warning'] = '';
        }

        // alert success
        if (isset($this->session->data['success'])) {
            $data['success'] = $this->language->get('text_success');

            unset($this->session->data['success']);
        } else {
            $data['success'] = '';
        }

        // breadcrumbs
        $data['breadcrumbs'] = array();

        $data['breadcrumbs'][] = array(
            'text' => $this->language->get('text_home'),
            'href' => $this->url->link('common/dashboard', 'token=' . $this->session->data['token'], true)
        );

        $data['breadcrumbs'][] = array(
            'text' => $this->language->get('heading_title'),
            'href' => $this->url->link('tool/updater', 'token=' . $this->session->data['token'], true)
        );





        // links
        $data['updater_update_link'] = $this->url->link('tool/updater/update', 'token=' . $this->session->data['token'], true);













        // page components
        $data['header'] = $this->load->controller('common/header');
        $data['column'] = $this->load->controller('common/column_left');
        $data['footer'] = $this->load->controller('common/footer');

        // render
        $this->response->setOutput($this->load->view('tool/updater', $data));
    }

    // custom function
    public function update()
    {
        // if ($this->validateUpdate()) {

        // function body
        // creating working directory
        if (!file_exists($_SERVER['DOCUMENT_ROOT'] . '/storage/update/test')) {
            mkdir($_SERVER['DOCUMENT_ROOT'] . '/storage/update/test');
        }

        // set full file path
        $file_core_old = ($_SERVER['DOCUMENT_ROOT'] . '/file_core_old.txt');
        $file_core_new = ($_SERVER['DOCUMENT_ROOT'] . '/storage/update/test/file_core_new.txt');
        $file_result_diff = ($_SERVER['DOCUMENT_ROOT'] . '/file_result_diff.diff');
        $file_result_diff_content = file_get_contents(($_SERVER['DOCUMENT_ROOT'] . '/file_result_diff.diff'));

The assignment to $file_result_diff_content is dead and can be removed.

        $file_core_new_test = ($_SERVER['DOCUMENT_ROOT'] . '/storage/update/test/file_core_new_test.txt');

        // v1. generate diff with SebastianBergmann\Diff\Differ
        $cl_differ = new \Differ();

The type Differ was not found. Maybe you did not declare it correctly or list all dependencies?

        $file_result_diff_to_file = $cl_differ->diff(file_get_contents($file_core_old), file_get_contents($file_core_new));

        // write generated result to the target file
        // file_put_contents($file_result_diff, $file_result_diff_to_file);
        // or
        $fd = fopen($file_result_diff, 'w+');
        fwrite($fd, $file_result_diff_to_file);

It seems like $fd can also be of type false; however, parameter $handle of fwrite() does only seem to accept resource, maybe add an additional type check?

        fclose($fd);

It seems like $fd can also be of type false; however, parameter $handle of fclose() does only seem to accept resource, maybe add an additional type check?

        // https://github.com/yetanotherape/diff-match-patch
        $dmp = new \DiffMatchPatch();

The type DiffMatchPatch was not found. Maybe you did not declare it correctly or list all dependencies?

        $patches = $dmp->patch_make(
            file_get_contents($file_core_old),
            file_get_contents($file_core_new)
        );
        $result = $dmp->patch_apply($patches, '1');
        $result = $result[0];

        // write patched result to the target file
        $fd = fopen($file_core_new_test, 'w+');
        fwrite($fd, $result);
        fclose($fd);

        // \Tracy\Debugger::barDump($patches);
        // \Tracy\Debugger::barDump($result);

        // \Tracy\Debugger::barDump();

        // alert success after function exec
        $this->session->data['success'] = $this->language->get('text_success');

        // redirect to main module page after function exec
        $this->response->redirect($this->url->link('tool/updater', 'token=' . $this->session->data['token'], true));
        // }
    }

    public function validateUpdate()
    {
        // check permissions first
        if (!$this->user->hasPermission('modify', 'tool/updater')) {
            $this->error['warning'] = $this->language->get('error_permission');

The property error does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        }

        return !$this->error;
    }
}