ControllerToolUpdater::update()

Complexity

Conditions	2
Paths	2

Size

Total Lines	52
Code Lines	23

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function update()
    {
        // if ($this->validateUpdate()) {

        // function body
        // creating working directory
        if (!file_exists($_SERVER['DOCUMENT_ROOT'] . '/storage/update/test')) {
            mkdir($_SERVER['DOCUMENT_ROOT'] . '/storage/update/test');
        }

        // set full file path
        $file_core_old = ($_SERVER['DOCUMENT_ROOT'] . '/file_core_old.txt');
        $file_core_new = ($_SERVER['DOCUMENT_ROOT'] . '/storage/update/test/file_core_new.txt');
        $file_result_diff = ($_SERVER['DOCUMENT_ROOT'] . '/file_result_diff.diff');
        $file_result_diff_content = file_get_contents(($_SERVER['DOCUMENT_ROOT'] . '/file_result_diff.diff'));

The assignment to $file_result_diff_content is dead and can be removed.

        $file_core_new_test = ($_SERVER['DOCUMENT_ROOT'] . '/storage/update/test/file_core_new_test.txt');

        // v1. generate diff with SebastianBergmann\Diff\Differ
        $cl_differ = new \Differ();

The type Differ was not found. Maybe you did not declare it correctly or list all dependencies?

        $file_result_diff_to_file = $cl_differ->diff(file_get_contents($file_core_old), file_get_contents($file_core_new));

        // write generated result to the target file
        // file_put_contents($file_result_diff, $file_result_diff_to_file);
        // or
        $fd = fopen($file_result_diff, 'w+');
        fwrite($fd, $file_result_diff_to_file);

It seems like $fd can also be of type false; however, parameter $handle of fwrite() does only seem to accept resource, maybe add an additional type check?

        fclose($fd);

It seems like $fd can also be of type false; however, parameter $handle of fclose() does only seem to accept resource, maybe add an additional type check?

        // https://github.com/yetanotherape/diff-match-patch
        $dmp = new \DiffMatchPatch();

The type DiffMatchPatch was not found. Maybe you did not declare it correctly or list all dependencies?

        $patches = $dmp->patch_make(
            file_get_contents($file_core_old),
            file_get_contents($file_core_new)
        );
        $result = $dmp->patch_apply($patches, '1');
        $result = $result[0];

        // write patched result to the target file
        $fd = fopen($file_core_new_test, 'w+');
        fwrite($fd, $result);
        fclose($fd);

        // \Tracy\Debugger::barDump($patches);
        // \Tracy\Debugger::barDump($result);

        // \Tracy\Debugger::barDump();

        // alert success after function exec
        $this->session->data['success'] = $this->language->get('text_success');

        // redirect to main module page after function exec
        $this->response->redirect($this->url->link('tool/updater', 'token=' . $this->session->data['token'], true));
        // }