NeoBlack / T3Bot

Classes/Commands/AbstractCommand.php

Spacing +6 added lines, -6 removed lines

@@ -88,7 +88,7 @@ 
 
         $command = !empty($params[0]) ? $params[0] : 'help';
         $this->params = $params;
-        $method = 'process' . ucfirst(strtolower($command));
+        $method = 'process'.ucfirst(strtolower($command));
         if (method_exists($this, $method)) {
             return $this->{$method}();
         }
@@ -105,7 +105,7 @@ 
     {
         if ($user !== null) {
             $this->client->apiCall('im.open', ['user' => $user])
-                ->then(function (Payload $response) use ($messageToSent) {
+                ->then(function(Payload $response) use ($messageToSent) {
                     $channel = $response->getData()['channel']['id'];
                     if ($messageToSent instanceof Message) {
                         $data = $this->getBaseDataArray($messageToSent->getText(), $channel);
@@ -198,11 +198,11 @@ 
                 break;
         }
         $attachment->setTitle($item->subject);
-        $attachment->setTitleLink('https://review.typo3.org/' . $item->_number);
+        $attachment->setTitleLink('https://review.typo3.org/'.$item->_number);
 
-        $text .= 'Branch: ' . $this->bold($branch) . ' | :calendar: ' . $this->bold($created)
-            . ' | ID: ' . $this->bold($item->_number) . "\n";
-        $text .= '<https://review.typo3.org/' . $item->_number . '|:arrow_right: Goto Review>';
+        $text .= 'Branch: '.$this->bold($branch).' | :calendar: '.$this->bold($created)
+            . ' | ID: '.$this->bold($item->_number)."\n";
+        $text .= '<https://review.typo3.org/'.$item->_number.'|:arrow_right: Goto Review>';
 
         $attachment->setText($text);
         $attachment->setFallback($text);

Classes/Commands/ReviewCommand.php

Spacing +16 added lines, -16 removed lines

@@ -58,15 +58,15 @@ 
         $countMinus2 = count($result);
 
         $returnString = '';
-        $returnString .= 'There are currently ' . $this->bold($count) . ' open reviews for project '
-            . $this->italic($project) . ' and branch master on <https://review.typo3.org/#/q/project:' . $project
-            . '+status:open+branch:master|https://review.typo3.org>' . chr(10);
-        $returnString .= $this->bold($countMinus1) . ' of ' . $this->bold($count) . ' open reviews voted with '
-            . $this->bold('-1') . ' <https://review.typo3.org/#/q/label:Code-Review%253D-1+is:open+branch:'
-            . 'master+project:' . $project . '|Check now> ' . chr(10);
-        $returnString .= $this->bold($countMinus2) . ' of ' . $this->bold($count) . ' open reviews voted with '
-            . $this->bold('-2') . ' <https://review.typo3.org/#/q/label:Code-Review%253D-2+is:open+branch:'
-            . 'master+project:' . $project . '|Check now>';
+        $returnString .= 'There are currently '.$this->bold($count).' open reviews for project '
+            . $this->italic($project).' and branch master on <https://review.typo3.org/#/q/project:'.$project
+            . '+status:open+branch:master|https://review.typo3.org>'.chr(10);
+        $returnString .= $this->bold($countMinus1).' of '.$this->bold($count).' open reviews voted with '
+            . $this->bold('-1').' <https://review.typo3.org/#/q/label:Code-Review%253D-1+is:open+branch:'
+            . 'master+project:'.$project.'|Check now> '.chr(10);
+        $returnString .= $this->bold($countMinus2).' of '.$this->bold($count).' open reviews voted with '
+            . $this->bold('-2').' <https://review.typo3.org/#/q/label:Code-Review%253D-2+is:open+branch:'
+            . 'master+project:'.$project.'|Check now>';
 
         return $returnString;
     }
@@ -97,9 +97,9 @@ 
         if ($username === null) {
             return 'hey, I need a username!';
         }
-        $results = $this->queryGerrit('is:open owner:"' . $username . '" project:' . $project);
+        $results = $this->queryGerrit('is:open owner:"'.$username.'" project:'.$project);
         if (count($results) > 0) {
-            $listOfItems = ['*Here are the results for ' . $username . '*:'];
+            $listOfItems = ['*Here are the results for '.$username.'*:'];
             if (is_array($results)) {
                 foreach ($results as $item) {
                     $listOfItems[] = $this->buildReviewLine($item);
@@ -108,7 +108,7 @@ 
 
             return implode(chr(10), $listOfItems);
         }
-        return $username . ' has no open reviews or username is unknown';
+        return $username.' has no open reviews or username is unknown';
     }
 
     /**
@@ -146,7 +146,7 @@ 
         $paramsCount = count($this->params);
         $changeIds = [];
         for ($i = 1; $i < $paramsCount; ++$i) {
-            $changeIds[] = 'change:' . $this->params[$i];
+            $changeIds[] = 'change:'.$this->params[$i];
         }
         $result = $this->queryGerrit(implode(' OR ', $changeIds));
         $listOfItems = [];
@@ -165,7 +165,7 @@ 
      */
     protected function buildReviewMessageOutput(int $refId)
     {
-        $result = $this->queryGerrit('change:' . $refId);
+        $result = $this->queryGerrit('change:'.$refId);
         if (!$result) {
             return "{$refId} not found, sorry!";
         }
@@ -193,7 +193,7 @@ 
             return 'hey, I need a query!';
         }
 
-        $results = $this->queryGerrit('limit:50 ' . $query);
+        $results = $this->queryGerrit('limit:50 '.$query);
         if (count($results) > 0) {
             $listOfItems = ["*Here are the results for {$query}*:"];
             if (is_array($results)) {
@@ -223,7 +223,7 @@ 
 
         $cnt = count($result);
 
-        return 'Good job folks, since ' . $date . ' you merged *' . $cnt . '* patches into master';
+        return 'Good job folks, since '.$date.' you merged *'.$cnt.'* patches into master';
     }
 
     /**

Classes/Commands/TellCommand.php

Spacing +8 added lines, -8 removed lines

@@ -81,9 +81,9 @@ 
                 } elseif (strpos($notification['message'], 'forge:') === 0) {
                     $this->processForgeMessage($notification, $user);
                 } else {
-                    $msg = '*Hi <@' . $user . '>, here is a message from <@' . $notification['from_user'] . '>'
+                    $msg = '*Hi <@'.$user.'>, here is a message from <@'.$notification['from_user'].'>'
                         . ' for you:*';
-                    $this->sendResponse($msg . "\n" . $notification['message'], $user);
+                    $this->sendResponse($msg."\n".$notification['message'], $user);
                 }
                 $now = new \DateTime();
                 $now->setTimestamp(time());
@@ -105,8 +105,8 @@ 
     {
         $parts = explode(':', $notification['message']);
         $refId = (int) trim($parts[1]);
-        $result = $this->queryGerrit('change:' . $refId);
-        $msg = '*Hi <@' . $user . '>, <@' . $notification['from_user'] . '>'
+        $result = $this->queryGerrit('change:'.$refId);
+        $msg = '*Hi <@'.$user.'>, <@'.$notification['from_user'].'>'
             . ' ask you to look at this patch:*';
 
         if (is_array($result)) {
@@ -128,11 +128,11 @@ 
     {
         $parts = explode(':', $notification['message']);
         $issueNumber = (int) trim($parts[1]);
-        $result = $this->queryForge('issues/' . $issueNumber);
+        $result = $this->queryForge('issues/'.$issueNumber);
         if ($result) {
-            $msg = '*Hi <@' . $user . '>, <@' . $notification['from_user'] . '>'
+            $msg = '*Hi <@'.$user.'>, <@'.$notification['from_user'].'>'
                 . ' ask you to look at this issue:*';
-            $this->sendResponse($msg . "\n" . $this->buildIssueMessage($result->issue), $user);
+            $this->sendResponse($msg."\n".$this->buildIssueMessage($result->issue), $user);
         }
     }
 
@@ -159,6 +159,6 @@ 
             'message' => $message,
         ]);
 
-        return 'OK, I will tell <@' . $toUser . '> about your message';
+        return 'OK, I will tell <@'.$toUser.'> about your message';
     }
 }