NeoBlack / T3Bot

Tests/Unit/Commands/BottyCommandTest.php

Spacing +17 added lines, -17 removed lines

@@ -30,25 +30,25 @@ 
 
         return [
             'daddy' => ['daddy', 'My daddy is Frank Nägler aka <@neoblack>'],
-            'n8' => ['n8', 'Good night ' . $username . '! :sleeping:'],
-            'nacht' => ['nacht', 'Good night ' . $username . '! :sleeping:'],
-            'night' => ['night', 'Good night ' . $username . '! :sleeping:'],
-            'hello' => ['hello', 'Hello ' . $username . ', nice to see you!'],
-            'hallo' => ['hallo', 'Hello ' . $username . ', nice to see you!'],
-            'ciao' => ['ciao', 'Bye, bye ' . $username . ', cu later alligator! :wave:'],
-            'cu' => ['cu', 'Bye, bye ' . $username . ', cu later alligator! :wave:'],
-            'thx' => ['thx', 'You are welcome ' . $username . '!'],
-            'thank' => ['thank', 'You are welcome ' . $username . '!'],
-            'drink' => ['drink', 'Coffee or beer ' . $username . '?'],
-            'coffee' => ['coffee', 'Here is a :coffee: for you ' . $username . '!'],
-            'beer' => ['beer', 'Here is a :t3beer: for you ' . $username . '!'],
-            'coke' => ['coke', 'Coke is unhealthy ' . $username . '!'],
-            'cola' => ['cola', 'Coke is unhealthy ' . $username . '!'],
-            'cookie' => ['cookie', 'Here is a :cookie: for you ' . $username . '!'],
+            'n8' => ['n8', 'Good night '.$username.'! :sleeping:'],
+            'nacht' => ['nacht', 'Good night '.$username.'! :sleeping:'],
+            'night' => ['night', 'Good night '.$username.'! :sleeping:'],
+            'hello' => ['hello', 'Hello '.$username.', nice to see you!'],
+            'hallo' => ['hallo', 'Hello '.$username.', nice to see you!'],
+            'ciao' => ['ciao', 'Bye, bye '.$username.', cu later alligator! :wave:'],
+            'cu' => ['cu', 'Bye, bye '.$username.', cu later alligator! :wave:'],
+            'thx' => ['thx', 'You are welcome '.$username.'!'],
+            'thank' => ['thank', 'You are welcome '.$username.'!'],
+            'drink' => ['drink', 'Coffee or beer '.$username.'?'],
+            'coffee' => ['coffee', 'Here is a :coffee: for you '.$username.'!'],
+            'beer' => ['beer', 'Here is a :t3beer: for you '.$username.'!'],
+            'coke' => ['coke', 'Coke is unhealthy '.$username.'!'],
+            'cola' => ['cola', 'Coke is unhealthy '.$username.'!'],
+            'cookie' => ['cookie', 'Here is a :cookie: for you '.$username.'!'],
             'typo3' => ['typo3', ':typo3: TYPO3 CMS is the best open source CMS of the world!'],
             'dark' => ['dark', 'sure, we have cookies :cookie:'],
             //'cat' => ['cat', 'ok, here is some cat content '.$cats[array_rand($cats)]],
-            'love' => ['love', 'I love you too, ' . $username . ':kiss:'],
+            'love' => ['love', 'I love you too, '.$username.':kiss:'],
             'no-matching' => ['foobar', null],
         ];
     }
@@ -64,7 +64,7 @@ 
     {
         $this->initCommandWithPayload(BottyCommand::class, [
             'user' => 'U54321',
-            'text' => 'botty ' . $keyword,
+            'text' => 'botty '.$keyword,
         ]);
         $result = $this->command->process();
         if ($response === null) {

Tests/Unit/Commands/ForgeCommandTest.php

Spacing +1 added lines, -1 removed lines

@@ -82,7 +82,7 @@
     {
         $this->initCommandWithPayload(ForgeCommand::class, [
             'user' => 'U54321',
-            'text' => 'forge:show ' . $issueNumber,
+            'text' => 'forge:show '.$issueNumber,
         ]);
         $result = $this->command->process();
 

Tests/Unit/Commands/ReviewCommandTest.php

Spacing +2 added lines, -2 removed lines

@@ -151,7 +151,7 @@ 
     {
         $this->initCommandWithPayload(ReviewCommand::class, [
             'user' => 'U54321',
-            'text' => 'review:show ' . $refId,
+            'text' => 'review:show '.$refId,
         ]);
         /** @var Message $result */
         $result = $this->command->process();
@@ -175,7 +175,7 @@ 
         /** @var Message $result */
         $result = $this->command->process();
         $expectedString = '*[BUGFIX] Prevent fatal error when uploading file with invalid filename* '
-            . '<https://review.typo3.org/47640|Review #47640 now>' . chr(10);
+            . '<https://review.typo3.org/47640|Review #47640 now>'.chr(10);
         $expectedString .= '*[BUGFIX] Cast autoload and classAliasMap to Array* '
             . '<https://review.typo3.org/23456|Review #23456 now>';
         static::assertEquals($expectedString, $result);

Tests/Unit/Controller/GerritHookControllerTest.php

Spacing +11 added lines, -11 removed lines

@@ -36,7 +36,7 @@ 
         $controller
             ->expects(static::once())
             ->method('postToSlack');
-        $controller->process('change-merged', __DIR__ . '/../Fixtures/Valid/change-merged.json');
+        $controller->process('change-merged', __DIR__.'/../Fixtures/Valid/change-merged.json');
     }
 
     /**
@@ -54,7 +54,7 @@ 
                 static::isInstanceOf(Message::class),
                 static::equalTo('#rst-channel')
             );
-        $controller->process('change-merged', __DIR__ . '/../Fixtures/Valid/change-merged-with-added-rst.json');
+        $controller->process('change-merged', __DIR__.'/../Fixtures/Valid/change-merged-with-added-rst.json');
         $GLOBALS['config']['gerrit']['change-merged']['channels'] = $mergeChannel;
     }
 
@@ -73,7 +73,7 @@ 
                 static::isInstanceOf(Message::class),
                 static::equalTo('#rst-channel')
             );
-        $controller->process('change-merged', __DIR__ . '/../Fixtures/Valid/change-merged-with-deleted-rst.json');
+        $controller->process('change-merged', __DIR__.'/../Fixtures/Valid/change-merged-with-deleted-rst.json');
         $GLOBALS['config']['gerrit']['change-merged']['channels'] = $mergeChannel;
     }
 
@@ -92,7 +92,7 @@ 
                 static::isInstanceOf(Message::class),
                 static::equalTo('#rst-channel')
             );
-        $controller->process('change-merged', __DIR__ . '/../Fixtures/Valid/change-merged-with-changed-rst.json');
+        $controller->process('change-merged', __DIR__.'/../Fixtures/Valid/change-merged-with-changed-rst.json');
         $GLOBALS['config']['gerrit']['change-merged']['channels'] = $mergeChannel;
     }
 
@@ -105,7 +105,7 @@ 
         $controller
             ->expects(static::once())
             ->method('postToSlack');
-        $controller->process('patchset-created', __DIR__ . '/../Fixtures/Valid/patchset-created.json');
+        $controller->process('patchset-created', __DIR__.'/../Fixtures/Valid/patchset-created.json');
     }
 
     /**
@@ -117,7 +117,7 @@ 
         $controller
             ->expects(static::never())
             ->method('postToSlack');
-        $controller->process('change-merged', __DIR__ . '/../Fixtures/Invalid/change-merged.json');
+        $controller->process('change-merged', __DIR__.'/../Fixtures/Invalid/change-merged.json');
     }
 
     /**
@@ -129,7 +129,7 @@ 
         $controller
             ->expects(static::never())
             ->method('postToSlack');
-        $controller->process('patchset-created', __DIR__ . '/../Fixtures/Invalid/patchset-created.json');
+        $controller->process('patchset-created', __DIR__.'/../Fixtures/Invalid/patchset-created.json');
     }
 
     /**
@@ -141,7 +141,7 @@ 
         $controller
             ->expects(static::never())
             ->method('postToSlack');
-        $controller->process('change-merged', __DIR__ . '/../Fixtures/Invalid/change-merged-invalid-token.json');
+        $controller->process('change-merged', __DIR__.'/../Fixtures/Invalid/change-merged-invalid-token.json');
     }
 
     /**
@@ -153,7 +153,7 @@ 
         $controller
             ->expects(static::never())
             ->method('postToSlack');
-        $controller->process('patchset-created', __DIR__ . '/../Fixtures/Invalid/patchset-created-invalid-token.json');
+        $controller->process('patchset-created', __DIR__.'/../Fixtures/Invalid/patchset-created-invalid-token.json');
     }
 
     /**
@@ -165,7 +165,7 @@ 
         $controller
             ->expects(static::once())
             ->method('addMessageToQueue');
-        $controller->process('change-merged', __DIR__ . '/../Fixtures/Valid/change-merged.json');
+        $controller->process('change-merged', __DIR__.'/../Fixtures/Valid/change-merged.json');
     }
 
     /**
@@ -177,7 +177,7 @@ 
         $controller
             ->expects(static::once())
             ->method('addMessageToQueue');
-        $controller->process('patchset-created', __DIR__ . '/../Fixtures/Valid/patchset-created.json');
+        $controller->process('patchset-created', __DIR__.'/../Fixtures/Valid/patchset-created.json');
     }
 
     /**

Tests/Unit/Controller/WebHookControllerTest.php

Spacing +9 added lines, -9 removed lines

@@ -36,12 +36,12 @@ 
     public function validWebhookDataProvider()
     {
         return [
-            'webhook' => [__DIR__ . '/../Fixtures/Valid/webhook.json'],
-            'webhook_danger' => [__DIR__ . '/../Fixtures/Valid/webhook_danger.json'],
-            'webhook_info' => [__DIR__ . '/../Fixtures/Valid/webhook_info.json'],
-            'webhook_notice' => [__DIR__ . '/../Fixtures/Valid/webhook_notice.json'],
-            'webhook_ok' => [__DIR__ . '/../Fixtures/Valid/webhook_ok.json'],
-            'webhook_warning' => [__DIR__ . '/../Fixtures/Valid/webhook_warning.json'],
+            'webhook' => [__DIR__.'/../Fixtures/Valid/webhook.json'],
+            'webhook_danger' => [__DIR__.'/../Fixtures/Valid/webhook_danger.json'],
+            'webhook_info' => [__DIR__.'/../Fixtures/Valid/webhook_info.json'],
+            'webhook_notice' => [__DIR__.'/../Fixtures/Valid/webhook_notice.json'],
+            'webhook_ok' => [__DIR__.'/../Fixtures/Valid/webhook_ok.json'],
+            'webhook_warning' => [__DIR__.'/../Fixtures/Valid/webhook_warning.json'],
         ];
     }
 
@@ -54,7 +54,7 @@ 
         $controller
             ->expects(static::never())
             ->method('postToSlack');
-        $controller->process('unknow', __DIR__ . '/../Fixtures/Valid/webhook.json');
+        $controller->process('unknow', __DIR__.'/../Fixtures/Valid/webhook.json');
     }
 
     /**
@@ -79,7 +79,7 @@ 
         $controller
             ->expects(static::never())
             ->method('postToSlack');
-        $controller->process('t3o-registrations', __DIR__ . '/../Fixtures/Invalid/webhook.json');
+        $controller->process('t3o-registrations', __DIR__.'/../Fixtures/Invalid/webhook.json');
     }
 
     /**
@@ -91,7 +91,7 @@ 
         $controller
             ->expects(static::once())
             ->method('addMessageToQueue');
-        $controller->process('t3o-registrations', __DIR__ . '/../Fixtures/Valid/webhook.json');
+        $controller->process('t3o-registrations', __DIR__.'/../Fixtures/Valid/webhook.json');
     }
 
     /**

public/whip/index.php

Spacing +1 added lines, -1 removed lines

@@ -75,7 +75,7 @@
                     <div class="result" style="text-align: left;">
 <pre><?php foreach ($result as $row) {
         ?>
-<?= $row . "\n" ?>
+<?= $row."\n" ?>
 <?php 
     } ?></pre>
                     </div>

Classes/Commands/AbstractCommand.php

Spacing +6 added lines, -6 removed lines

@@ -87,7 +87,7 @@ 
 
         $command = !empty($params[0]) ? $params[0] : 'help';
         $this->params = $params;
-        $method = 'process' . ucfirst(strtolower($command));
+        $method = 'process'.ucfirst(strtolower($command));
         if (method_exists($this, $method)) {
             return $this->{$method}();
         }
@@ -105,7 +105,7 @@ 
         $data = [];
         if ($user !== null) {
             $this->client->apiCall('im.open', ['user' => $user])
-                ->then(function (Payload $response) use ($messageToSent) {
+                ->then(function(Payload $response) use ($messageToSent) {
                     $channel = $response->getData()['channel']['id'];
                     if ($messageToSent instanceof Message) {
                         $data = [];
@@ -242,11 +242,11 @@ 
                 break;
         }
         $attachment->setTitle($item->subject);
-        $attachment->setTitleLink('https://review.typo3.org/' . $item->_number);
+        $attachment->setTitleLink('https://review.typo3.org/'.$item->_number);
 
-        $text .= 'Branch: ' . $this->bold($branch) . ' | :calendar: ' . $this->bold($created)
-            . ' | ID: ' . $this->bold($item->_number) . "\n";
-        $text .= '<https://review.typo3.org/' . $item->_number . '|:arrow_right: Goto Review>';
+        $text .= 'Branch: '.$this->bold($branch).' | :calendar: '.$this->bold($created)
+            . ' | ID: '.$this->bold($item->_number)."\n";
+        $text .= '<https://review.typo3.org/'.$item->_number.'|:arrow_right: Goto Review>';
 
         $attachment->setText($text);
         $attachment->setFallback($text);

Classes/Commands/BottyCommand.php

Spacing +19 added lines, -19 removed lines

@@ -28,7 +28,7 @@ 
     public function processMessage() : string
     {
         $message = strtolower($this->payload->getData()['text']);
-        $username = '<@' . $this->payload->getData()['user'] . '>';
+        $username = '<@'.$this->payload->getData()['user'].'>';
 
         if (strpos($message, 'help') !== false) {
             $links = [
@@ -46,29 +46,29 @@ 
         }
 
         $cats = [':smiley_cat:', ':smile_cat:', ':heart_eyes_cat:', ':kissing_cat:', ':smirk_cat:', ':scream_cat:',
-            ':crying_cat_face:', ':joy_cat:' , ':pouting_cat:', ];
+            ':crying_cat_face:', ':joy_cat:', ':pouting_cat:', ];
 
         $responses = [
             'daddy' => 'My daddy is Frank Nägler aka <@neoblack>',
-            'n8' => 'Good night ' . $username . '! :sleeping:',
-            'nacht' => 'Good night ' . $username . '! :sleeping:',
-            'night' => 'Good night ' . $username . '! :sleeping:',
-            'hello' => 'Hello ' . $username . ', nice to see you!',
-            'hallo' => 'Hello ' . $username . ', nice to see you!',
-            'ciao' => 'Bye, bye ' . $username . ', cu later alligator! :wave:',
-            'cu' => 'Bye, bye ' . $username . ', cu later alligator! :wave:',
-            'thx' => 'You are welcome ' . $username . '!',
-            'thank' => 'You are welcome ' . $username . '!',
-            'drink' => 'Coffee or beer ' . $username . '?',
-            'coffee' => 'Here is a :coffee: for you ' . $username . '!',
-            'beer' => 'Here is a :t3beer: for you ' . $username . '!',
-            'coke' => 'Coke is unhealthy ' . $username . '!',
-            'cola' => 'Coke is unhealthy ' . $username . '!',
-            'cookie' => 'Here is a :cookie: for you ' . $username . '!',
+            'n8' => 'Good night '.$username.'! :sleeping:',
+            'nacht' => 'Good night '.$username.'! :sleeping:',
+            'night' => 'Good night '.$username.'! :sleeping:',
+            'hello' => 'Hello '.$username.', nice to see you!',
+            'hallo' => 'Hello '.$username.', nice to see you!',
+            'ciao' => 'Bye, bye '.$username.', cu later alligator! :wave:',
+            'cu' => 'Bye, bye '.$username.', cu later alligator! :wave:',
+            'thx' => 'You are welcome '.$username.'!',
+            'thank' => 'You are welcome '.$username.'!',
+            'drink' => 'Coffee or beer '.$username.'?',
+            'coffee' => 'Here is a :coffee: for you '.$username.'!',
+            'beer' => 'Here is a :t3beer: for you '.$username.'!',
+            'coke' => 'Coke is unhealthy '.$username.'!',
+            'cola' => 'Coke is unhealthy '.$username.'!',
+            'cookie' => 'Here is a :cookie: for you '.$username.'!',
             'typo3' => ':typo3: TYPO3 CMS is the best open source CMS of the world!',
             'dark' => 'sure, we have cookies :cookie:',
-            'cat' => 'ok, here is some cat content ' . $cats[array_rand($cats)],
-            'love' => 'I love you too, ' . $username . ':kiss:',
+            'cat' => 'ok, here is some cat content '.$cats[array_rand($cats)],
+            'love' => 'I love you too, '.$username.':kiss:',
         ];
         $messageToSend = '';
         foreach ($responses as $keyword => $response) {

Classes/Commands/BeerCommand.php

Spacing +6 added lines, -6 removed lines

@@ -48,7 +48,7 @@ 
      */
     protected function processAll() : string
     {
-        return 'Yeah, ' . $this->getBeerCountAll() . ' :t3beer: spend to all people';
+        return 'Yeah, '.$this->getBeerCountAll().' :t3beer: spend to all people';
     }
 
     /**
@@ -63,7 +63,7 @@ 
         $rows = $this->getBeerTop10();
         $text = ['*Yeah, here are the TOP 10*'];
         foreach ($rows as $row) {
-            $text[] = '<@' . $row['username'] . '> has received ' . $row['cnt'] . ' :t3beer:';
+            $text[] = '<@'.$row['username'].'> has received '.$row['cnt'].' :t3beer:';
         }
 
         return implode(chr(10), $text);
@@ -84,7 +84,7 @@ 
         if (strpos($username, '<') === 0 && $username[1] === '@') {
             $username = str_replace(['<', '>', '@'], '', $username);
 
-            return '<@' . $username . '> has received ' . $this->getBeerCountByUsername($username) . ' :t3beer: so far';
+            return '<@'.$username.'> has received '.$this->getBeerCountByUsername($username).' :t3beer: so far';
         }
         return '*Sorry, a username must start with a @-sign:*';
     }
@@ -128,10 +128,10 @@ 
                     'tstamp' => time()
                 ];
                 $this->getDatabaseConnection()->insert('beers', $data);
-                return 'Yeah, one more :t3beer: for <@' . $username . '>' . chr(10) . '<@' . $username . '> has received '
-                    . $this->getBeerCountByUsername($username) . ' :t3beer: so far';
+                return 'Yeah, one more :t3beer: for <@'.$username.'>'.chr(10).'<@'.$username.'> has received '
+                    . $this->getBeerCountByUsername($username).' :t3beer: so far';
             }
-            return 'You spend one :t3beer: to <@' . $username . '> within in last 24 hours. Too much beer is unhealthy ;)';
+            return 'You spend one :t3beer: to <@'.$username.'> within in last 24 hours. Too much beer is unhealthy ;)';
         }
         return '*Sorry, a username must start with a @-sign:*';
     }