NeoBlack / T3Bot

Classes/Commands/ReviewCommand.php

Spacing +16 added lines, -16 removed lines

@@ -58,15 +58,15 @@ 
         $countMinus2 = count($result);
 
         $returnString = '';
-        $returnString .= 'There are currently ' . $this->bold($count) . ' open reviews for project '
-            . $this->italic($project) . ' and branch master on <https://review.typo3.org/#/q/project:' . $project
-            . '+status:open+branch:master|https://review.typo3.org>' . "\n";
-        $returnString .= $this->bold($countMinus1) . ' of ' . $this->bold($count) . ' open reviews voted with '
-            . $this->bold('-1') . ' <https://review.typo3.org/#/q/label:Code-Review%253D-1+is:open+branch:'
-            . 'master+project:' . $project . '|Check now> ' . "\n";
-        $returnString .= $this->bold($countMinus2) . ' of ' . $this->bold($count) . ' open reviews voted with '
-            . $this->bold('-2') . ' <https://review.typo3.org/#/q/label:Code-Review%253D-2+is:open+branch:'
-            . 'master+project:' . $project . '|Check now>';
+        $returnString .= 'There are currently '.$this->bold($count).' open reviews for project '
+            . $this->italic($project).' and branch master on <https://review.typo3.org/#/q/project:'.$project
+            . '+status:open+branch:master|https://review.typo3.org>'."\n";
+        $returnString .= $this->bold($countMinus1).' of '.$this->bold($count).' open reviews voted with '
+            . $this->bold('-1').' <https://review.typo3.org/#/q/label:Code-Review%253D-1+is:open+branch:'
+            . 'master+project:'.$project.'|Check now> '."\n";
+        $returnString .= $this->bold($countMinus2).' of '.$this->bold($count).' open reviews voted with '
+            . $this->bold('-2').' <https://review.typo3.org/#/q/label:Code-Review%253D-2+is:open+branch:'
+            . 'master+project:'.$project.'|Check now>';
 
         return $returnString;
     }
@@ -97,9 +97,9 @@ 
         if ($username === null) {
             return 'hey, I need a username!';
         }
-        $results = $this->queryGerrit('is:open owner:"' . $username . '" project:' . $project);
+        $results = $this->queryGerrit('is:open owner:"'.$username.'" project:'.$project);
         if (count($results) > 0) {
-            $listOfItems = ['*Here are the results for ' . $username . '*:'];
+            $listOfItems = ['*Here are the results for '.$username.'*:'];
             if (is_array($results)) {
                 foreach ($results as $item) {
                     $listOfItems[] = $this->buildReviewLine($item);
@@ -108,7 +108,7 @@ 
 
             return implode("\n", $listOfItems);
         }
-        return $username . ' has no open reviews or username is unknown';
+        return $username.' has no open reviews or username is unknown';
     }
 
     /**
@@ -133,7 +133,7 @@ 
         if ($paramsCount > 2) {
             $changeIds = [];
             for ($i = 1; $i < $paramsCount; ++$i) {
-                $changeIds[] = 'change:' . $this->params[$i];
+                $changeIds[] = 'change:'.$this->params[$i];
             }
             $result = $this->queryGerrit(implode(' OR ', $changeIds));
             $listOfItems = [];
@@ -144,7 +144,7 @@ 
             }
             $returnMessage = implode(chr(10), $listOfItems);
         } else {
-            $result = $this->queryGerrit('change:' . $refId);
+            $result = $this->queryGerrit('change:'.$refId);
             if (!$result) {
                 return "{$refId} not found, sorry!";
             }
@@ -174,7 +174,7 @@ 
             return 'hey, I need a query!';
         }
 
-        $results = $this->queryGerrit('limit:50 ' . $query);
+        $results = $this->queryGerrit('limit:50 '.$query);
         if (count($results) > 0) {
             $listOfItems = ["*Here are the results for {$query}*:"];
             if (is_array($results)) {
@@ -204,7 +204,7 @@ 
 
         $cnt = count($result);
 
-        return 'Good job folks, since ' . $date . ' you merged *' . $cnt . '* patches into master';
+        return 'Good job folks, since '.$date.' you merged *'.$cnt.'* patches into master';
     }
 
     /**

Classes/Commands/TellCommand.php

Spacing +8 added lines, -8 removed lines

@@ -79,8 +79,8 @@ 
                 if (strpos($notification['message'], 'review:') === 0) {
                     $parts = explode(':', $notification['message']);
                     $refId = (int) trim($parts[1]);
-                    $result = $this->queryGerrit('change:' . $refId);
-                    $msg = '*Hi <@' . $user . '>, <@' . $notification['from_user'] . '>'
+                    $result = $this->queryGerrit('change:'.$refId);
+                    $msg = '*Hi <@'.$user.'>, <@'.$notification['from_user'].'>'
                         . ' ask you to look at this patch:*';
 
                     if (is_array($result)) {
@@ -95,16 +95,16 @@ 
                 } elseif (strpos($notification['message'], 'forge:') === 0) {
                     $parts = explode(':', $notification['message']);
                     $issueNumber = (int) trim($parts[1]);
-                    $result = $this->queryForge('issues/' . $issueNumber);
+                    $result = $this->queryForge('issues/'.$issueNumber);
                     if ($result) {
-                        $msg = '*Hi <@' . $user . '>, <@' . $notification['from_user'] . '>'
+                        $msg = '*Hi <@'.$user.'>, <@'.$notification['from_user'].'>'
                             . ' ask you to look at this issue:*';
-                        $this->sendResponse($msg . "\n" . $this->buildIssueMessage($result->issue), $user);
+                        $this->sendResponse($msg."\n".$this->buildIssueMessage($result->issue), $user);
                     }
                 } else {
-                    $msg = '*Hi <@' . $user . '>, here is a message from <@' . $notification['from_user'] . '>'
+                    $msg = '*Hi <@'.$user.'>, here is a message from <@'.$notification['from_user'].'>'
                         . ' for you:*';
-                    $this->sendResponse($msg . "\n" . $notification['message'], $user);
+                    $this->sendResponse($msg."\n".$notification['message'], $user);
                 }
                 $now = new \DateTime();
                 $now->setTimestamp(time());
@@ -141,6 +141,6 @@ 
             'message' => $message,
         ]);
 
-        return 'OK, I will tell <@' . $toUser . '> about your message';
+        return 'OK, I will tell <@'.$toUser.'> about your message';
     }
 }

Classes/Slack/CommandResolver.php

Spacing +2 added lines, -2 removed lines

@@ -43,14 +43,14 @@
         $message = $this->payload->getData()['text'];
         $parts = explode(':', $message);
         $command = ucfirst(strtolower($parts[0]));
-        $commandClass = '\\T3Bot\\Commands\\' . $command . 'Command';
+        $commandClass = '\\T3Bot\\Commands\\'.$command.'Command';
         if (class_exists($commandClass)) {
             return new $commandClass($this->payload, $this->client);
         }
 
         $parts = explode(' ', $message);
         $command = ucfirst(strtolower($parts[0]));
-        $commandClass = '\\T3Bot\\Commands\\' . $command . 'Command';
+        $commandClass = '\\T3Bot\\Commands\\'.$command.'Command';
         if (class_exists($commandClass)) {
             return new $commandClass($this->payload, $this->client);
         }

Classes/Traits/GerritTrait.php

Spacing +2 added lines, -2 removed lines

@@ -18,7 +18,7 @@ 
      */
     protected function queryGerrit($query)
     {
-        return $this->remoteCall('https://review.typo3.org/changes/?q=' . urlencode($query));
+        return $this->remoteCall('https://review.typo3.org/changes/?q='.urlencode($query));
     }
 
     /**
@@ -30,7 +30,7 @@ 
     protected function getFilesForPatch($changeId, $revision)
     {
         return $this->remoteCall(
-            'https://review.typo3.org/changes/' . $changeId . '/revisions/' . $revision . '/files'
+            'https://review.typo3.org/changes/'.$changeId.'/revisions/'.$revision.'/files'
         );
     }
 

Classes/Traits/SlackTrait.php

Spacing +11 added lines, -11 removed lines

@@ -23,7 +23,7 @@ 
      */
     protected function bold($string) : string
     {
-        return '*' . $string . '*';
+        return '*'.$string.'*';
     }
 
     /**
@@ -35,7 +35,7 @@ 
      */
     protected function italic($string) : string
     {
-        return '_' . $string . '_';
+        return '_'.$string.'_';
     }
 
     /**
@@ -47,8 +47,8 @@ 
      */
     protected function buildReviewLine($item) : string
     {
-        return $this->bold($item->subject) . ' <https://review.typo3.org/' . $item->_number
-        . '|Review #' . $item->_number . ' now>';
+        return $this->bold($item->subject).' <https://review.typo3.org/'.$item->_number
+        . '|Review #'.$item->_number.' now>';
     }
 
     /**
@@ -60,15 +60,15 @@ 
     {
         $created = substr($item->created_on, 0, 19);
         $updated = substr($item->updated_on, 0, 19);
-        $text = $this->bold('[' . $item->tracker->name . '] ' . $item->subject)
-            . ' by ' . $this->italic($item->author->name) . "\n";
-        $text .= 'Project: ' . $this->bold($item->project->name);
+        $text = $this->bold('['.$item->tracker->name.'] '.$item->subject)
+            . ' by '.$this->italic($item->author->name)."\n";
+        $text .= 'Project: '.$this->bold($item->project->name);
         if (!empty($item->category->name)) {
-            $text .= ' | Category: ' . $this->bold($item->category->name);
+            $text .= ' | Category: '.$this->bold($item->category->name);
         }
-        $text .= ' | Status: ' . $this->bold($item->status->name) . "\n";
-        $text .= ':calendar: Created: ' . $this->bold($created) . ' | Last update: ' . $this->bold($updated) . "\n";
-        $text .= '<https://forge.typo3.org/issues/' . $item->id . '|:arrow_right: View on Forge>';
+        $text .= ' | Status: '.$this->bold($item->status->name)."\n";
+        $text .= ':calendar: Created: '.$this->bold($created).' | Last update: '.$this->bold($updated)."\n";
+        $text .= '<https://forge.typo3.org/issues/'.$item->id.'|:arrow_right: View on Forge>';
 
         return $text;
     }

Classes/Controller/GerritHookController.php

Spacing +6 added lines, -6 removed lines

@@ -47,7 +47,7 @@ 
         switch ($hook) {
             case 'patchset-created':
                 if ($patchSet === 1 && $branch === 'master') {
-                    $item = $this->queryGerrit('change:' . $patchId);
+                    $item = $this->queryGerrit('change:'.$patchId);
                     $item = $item[0];
                     $created = substr($item->created, 0, 19);
 
@@ -56,7 +56,7 @@ 
                     $attachment = new Message\Attachment();
 
                     $attachment->setColor(Message\Attachment::COLOR_NOTICE);
-                    $attachment->setTitle('[NEW] ' . $item->subject);
+                    $attachment->setTitle('[NEW] '.$item->subject);
 
                     $text = "Branch: *{$branch}* | :calendar: _{$created}_ | ID: {$item->_number}\n";
                     $text .= ":link: <https://review.typo3.org/{$item->_number}|Review now>";
@@ -73,7 +73,7 @@ 
                 break;
             case 'change-merged':
                 /** @var array $item */
-                $item = $this->queryGerrit('change:' . $patchId);
+                $item = $this->queryGerrit('change:'.$patchId);
                 $item = $item[0];
                 /* @var \stdClass $item */
                 $created = substr($item->created, 0, 19);
@@ -83,7 +83,7 @@ 
                 $attachment = new Message\Attachment();
 
                 $attachment->setColor(Message\Attachment::COLOR_GOOD);
-                $attachment->setTitle(':white_check_mark: [MERGED] ' . $item->subject);
+                $attachment->setTitle(':white_check_mark: [MERGED] '.$item->subject);
 
                 $text = "Branch: {$branch} | :calendar: {$created} | ID: {$item->_number}\n";
                 $text .= ":link: <https://review.typo3.org/{$item->_number}|Goto Review>";
@@ -126,8 +126,8 @@ 
                                 $attachment->setTitle('A documentation file has been updated');
                                 break;
                         }
-                        $text = ':link: <https://git.typo3.org/Packages/TYPO3.CMS.git/blob/HEAD:/' . $fileName
-                            . '|' . $fileName . '>';
+                        $text = ':link: <https://git.typo3.org/Packages/TYPO3.CMS.git/blob/HEAD:/'.$fileName
+                            . '|'.$fileName.'>';
                         $attachment->setText($text);
                         $attachment->setFallback($text);
                         $message->addAttachment($attachment);

migrations-db.php

Spacing +1 added lines, -1 removed lines

@@ -1,5 +1,5 @@
 <?php
 
-require_once __DIR__ . '/config/config.php';
+require_once __DIR__.'/config/config.php';
 
 return $GLOBALS['config']['db'];

botty.php

Spacing +6 added lines, -6 removed lines

@@ -16,12 +16,12 @@ 
 $client = new Slack\RealTimeClient($loop);
 $client->setToken($GLOBALS['config']['slack']['botAuthToken']);
 
-$client->on('message', function (Slack\Payload $payload) use ($client) {
+$client->on('message', function(Slack\Payload $payload) use ($client) {
     $user = $payload->getData()['user'];
     $blackList = array_map('trim', explode(',', $GLOBALS['config']['slack']['userBlacklist']));
     if (in_array($user, $blackList, true)) {
         $client->apiCall('im.open', ['user' => $user])
-            ->then(function (Slack\Payload $response) use ($client) {
+            ->then(function(Slack\Payload $response) use ($client) {
                 $channel = $response->getData()['channel']['id'];
                 $data = [];
                 $data['unfurl_links'] = false;
@@ -48,28 +48,28 @@ 
     }
 });
 
-$client->on('channel_created', function (Slack\Payload $payload) use ($client) {
+$client->on('channel_created', function(Slack\Payload $payload) use ($client) {
     if ($payload->getData()['user'] !== $GLOBALS['config']['slack']['botId']) {
         $command = new \T3Bot\Commands\ChannelCommand($payload, $client);
         $command->processChannelCreated($payload->getData());
     }
 });
 
-$client->on('presence_change', function (Slack\Payload $payload) use ($client) {
+$client->on('presence_change', function(Slack\Payload $payload) use ($client) {
     if ($payload->getData()['user'] !== $GLOBALS['config']['slack']['botId']) {
         $command = new \T3Bot\Commands\TellCommand($payload, $client);
         $command->processPresenceChange($payload->getData()['user'], $payload->getData()['presence']);
     }
 });
 
-$client->connect()->then(function () use ($client) {
+$client->connect()->then(function() use ($client) {
     echo "Connected!\n";
 });
 
 /* @noinspection PhpInternalEntityUsedInspection */
 $db = \Doctrine\DBAL\DriverManager::getConnection($GLOBALS['config']['db'], new \Doctrine\DBAL\Configuration());
 
-$loop->addPeriodicTimer(5, function () use ($client, $db) {
+$loop->addPeriodicTimer(5, function() use ($client, $db) {
     $messages = $db->fetchAll('SELECT * FROM messages ORDER BY id ASC');
     foreach ($messages as $message) {
         $data = json_decode($message['message'], true);

config/config.php

Spacing +1 added lines, -1 removed lines

@@ -1,6 +1,6 @@
 <?php
 
-(new Dotenv\Dotenv(__DIR__ . '/../'))->load();
+(new Dotenv\Dotenv(__DIR__.'/../'))->load();
 
 $GLOBALS['config'] = [
     // project phase