NeoBlack / T3Bot

Classes/Traits/SlackTrait.php

Spacing +11 added lines, -11 removed lines

@@ -26,7 +26,7 @@ 
      */
     protected function bold($string) : string
     {
-        return '*' . $string . '*';
+        return '*'.$string.'*';
     }
 
     /**
@@ -38,7 +38,7 @@ 
      */
     protected function italic($string) : string
     {
-        return '_' . $string . '_';
+        return '_'.$string.'_';
     }
 
     /**
@@ -50,8 +50,8 @@ 
      */
     protected function buildReviewLine($item) : string
     {
-        return $this->bold($item->subject) . ' <https://review.typo3.org/' . $item->_number
-        . '|Review #' . $item->_number . ' now>';
+        return $this->bold($item->subject).' <https://review.typo3.org/'.$item->_number
+        . '|Review #'.$item->_number.' now>';
     }
 
     /**
@@ -63,15 +63,15 @@ 
     {
         $created = substr($item->created_on, 0, 19);
         $updated = substr($item->updated_on, 0, 19);
-        $text = $this->bold('[' . $item->tracker->name . '] ' . $item->subject)
-            . ' by ' . $this->italic($item->author->name) . chr(10);
-        $text .= 'Project: ' . $this->bold($item->project->name);
+        $text = $this->bold('['.$item->tracker->name.'] '.$item->subject)
+            . ' by '.$this->italic($item->author->name).chr(10);
+        $text .= 'Project: '.$this->bold($item->project->name);
         if (!empty($item->category->name)) {
-            $text .= ' | Category: ' . $this->bold($item->category->name);
+            $text .= ' | Category: '.$this->bold($item->category->name);
         }
-        $text .= ' | Status: ' . $this->bold($item->status->name) . chr(10);
-        $text .= ':calendar: Created: ' . $this->bold($created) . ' | Last update: ' . $this->bold($updated) . chr(10);
-        $text .= '<https://forge.typo3.org/issues/' . $item->id . '|:arrow_right: View on Forge>';
+        $text .= ' | Status: '.$this->bold($item->status->name).chr(10);
+        $text .= ':calendar: Created: '.$this->bold($created).' | Last update: '.$this->bold($updated).chr(10);
+        $text .= '<https://forge.typo3.org/issues/'.$item->id.'|:arrow_right: View on Forge>';
 
         return $text;
     }

Classes/Traits/GerritTrait.php

Spacing +3 added lines, -3 removed lines

@@ -18,7 +18,7 @@ 
      */
     protected function queryGerrit($query)
     {
-        return $this->remoteCall('https://review.typo3.org/changes/?q=' . urlencode($query));
+        return $this->remoteCall('https://review.typo3.org/changes/?q='.urlencode($query));
     }
 
     /**
@@ -30,7 +30,7 @@ 
     protected function getFilesForPatch($changeId, $revision)
     {
         return $this->remoteCall(
-            'https://review.typo3.org/changes/' . $changeId . '/revisions/' . $revision . '/files'
+            'https://review.typo3.org/changes/'.$changeId.'/revisions/'.$revision.'/files'
         );
     }
 
@@ -51,7 +51,7 @@ 
         $result = false;
         if (!curl_errno($ch)) {
             curl_close($ch);
-            $result = json_decode(str_replace(")]}'" . chr(10), '', $data));
+            $result = json_decode(str_replace(")]}'".chr(10), '', $data));
         }
 
         return $result;

Classes/Controller/GerritHookController.php

Spacing +5 added lines, -5 removed lines

@@ -40,16 +40,16 @@ 
         $patchId = (int) str_replace('https://review.typo3.org/', '', $json->{'change-url'});
         $patchSet = property_exists($json, 'patchset') ? (int) $json->patchset : 0;
 
-        $item = $this->queryGerrit('change:' . $patchId);
+        $item = $this->queryGerrit('change:'.$patchId);
         $item = $item[0];
         $created = substr($item->created, 0, 19);
-        $text = "Branch: {$json->branch} | :calendar: {$created} | ID: {$item->_number}" . chr(10);
+        $text = "Branch: {$json->branch} | :calendar: {$created} | ID: {$item->_number}".chr(10);
         $text .= ":link: <https://review.typo3.org/{$item->_number}|Goto Review>";
         if ($hook === 'patchset-created' && $patchSet === 1 && $json->branch === 'master') {
-            $message = $this->buildMessage('[NEW] ' . $item->subject, $text);
+            $message = $this->buildMessage('[NEW] '.$item->subject, $text);
             $this->sendMessageToChannel($hook, $message);
         } elseif ($hook === 'change-merged') {
-            $message = $this->buildMessage(':white_check_mark: [MERGED] ' . $item->subject, $text, Message\Attachment::COLOR_GOOD);
+            $message = $this->buildMessage(':white_check_mark: [MERGED] '.$item->subject, $text, Message\Attachment::COLOR_GOOD);
             $this->sendMessageToChannel($hook, $message);
             $this->checkFiles($patchId, $json->commit);
         }
@@ -128,7 +128,7 @@ 
         $attachment->setColor($color[$status]);
         $attachment->setTitle($text[$status]);
 
-        $text = ':link: <https://git.typo3.org/Packages/TYPO3.CMS.git/blob/HEAD:/' . $fileName . '|' . $fileName . '>';
+        $text = ':link: <https://git.typo3.org/Packages/TYPO3.CMS.git/blob/HEAD:/'.$fileName.'|'.$fileName.'>';
         $attachment->setText($text);
         $attachment->setFallback($text);
         return $attachment;

Classes/Slack/CommandResolver.php

Spacing +1 added lines, -1 removed lines

@@ -64,6 +64,6 @@
     {
         $delimiter = strpos($message, ':') !== false ? ':' : ' ';
         $parts = explode($delimiter, $message);
-        return '\\T3Bot\\Commands\\' . ucfirst(strtolower($parts[0])) . 'Command';
+        return '\\T3Bot\\Commands\\'.ucfirst(strtolower($parts[0])).'Command';
     }
 }

Classes/Commands/ReviewCommand.php

Spacing +16 added lines, -16 removed lines

@@ -59,15 +59,15 @@ 
         $countMinus2 = count($result);
 
         $returnString = '';
-        $returnString .= 'There are currently ' . $this->bold($count) . ' open reviews for project '
-            . $this->italic($project) . ' and branch master on <https://review.typo3.org/#/q/project:' . $project
-            . '+status:open+branch:master|https://review.typo3.org>' . chr(10);
-        $returnString .= $this->bold($countMinus1) . ' of ' . $this->bold($count) . ' open reviews voted with '
-            . $this->bold('-1') . ' <https://review.typo3.org/#/q/label:Code-Review%253D-1+is:open+branch:'
-            . 'master+project:' . $project . '|Check now> ' . chr(10);
-        $returnString .= $this->bold($countMinus2) . ' of ' . $this->bold($count) . ' open reviews voted with '
-            . $this->bold('-2') . ' <https://review.typo3.org/#/q/label:Code-Review%253D-2+is:open+branch:'
-            . 'master+project:' . $project . '|Check now>';
+        $returnString .= 'There are currently '.$this->bold($count).' open reviews for project '
+            . $this->italic($project).' and branch master on <https://review.typo3.org/#/q/project:'.$project
+            . '+status:open+branch:master|https://review.typo3.org>'.chr(10);
+        $returnString .= $this->bold($countMinus1).' of '.$this->bold($count).' open reviews voted with '
+            . $this->bold('-1').' <https://review.typo3.org/#/q/label:Code-Review%253D-1+is:open+branch:'
+            . 'master+project:'.$project.'|Check now> '.chr(10);
+        $returnString .= $this->bold($countMinus2).' of '.$this->bold($count).' open reviews voted with '
+            . $this->bold('-2').' <https://review.typo3.org/#/q/label:Code-Review%253D-2+is:open+branch:'
+            . 'master+project:'.$project.'|Check now>';
 
         return $returnString;
     }
@@ -98,9 +98,9 @@ 
         if ($username === null) {
             return 'hey, I need a username!';
         }
-        $results = $this->queryGerrit('is:open owner:"' . $username . '" project:' . $project);
+        $results = $this->queryGerrit('is:open owner:"'.$username.'" project:'.$project);
         if (count($results) > 0) {
-            $listOfItems = ['*Here are the results for ' . $username . '*:'];
+            $listOfItems = ['*Here are the results for '.$username.'*:'];
             if (is_array($results)) {
                 foreach ($results as $item) {
                     $listOfItems[] = $this->buildReviewLine($item);
@@ -109,7 +109,7 @@ 
 
             return implode(chr(10), $listOfItems);
         }
-        return $username . ' has no open reviews or username is unknown';
+        return $username.' has no open reviews or username is unknown';
     }
 
     /**
@@ -147,7 +147,7 @@ 
         $paramsCount = count($this->params);
         $changeIds = [];
         for ($i = 1; $i < $paramsCount; ++$i) {
-            $changeIds[] = 'change:' . $this->params[$i];
+            $changeIds[] = 'change:'.$this->params[$i];
         }
         $result = $this->queryGerrit(implode(' OR ', $changeIds));
         $listOfItems = [];
@@ -166,7 +166,7 @@ 
      */
     protected function buildReviewMessageOutput(int $refId)
     {
-        $result = $this->queryGerrit('change:' . $refId);
+        $result = $this->queryGerrit('change:'.$refId);
         if (!empty($result)) {
             foreach ($result as $item) {
                 if ($item->_number === $refId) {
@@ -190,7 +190,7 @@ 
             return 'hey, I need a query!';
         }
 
-        $results = $this->queryGerrit('limit:50 ' . $query);
+        $results = $this->queryGerrit('limit:50 '.$query);
         if (!empty($results)) {
             $listOfItems = ["*Here are the results for {$query}*:"];
             foreach ($results as $item) {
@@ -218,7 +218,7 @@ 
 
         $cnt = count($result);
 
-        return 'Good job folks, since ' . $date . ' you merged *' . $cnt . '* patches into master';
+        return 'Good job folks, since '.$date.' you merged *'.$cnt.'* patches into master';
     }
 
     /**

Classes/Commands/BeerCommand.php

Spacing +6 added lines, -6 removed lines

@@ -49,7 +49,7 @@ 
      */
     protected function processAll() : string
     {
-        return 'Yeah, ' . $this->getBeerCountAll() . ' :t3beer: spend to all people';
+        return 'Yeah, '.$this->getBeerCountAll().' :t3beer: spend to all people';
     }
 
     /**
@@ -64,7 +64,7 @@ 
         $rows = $this->getBeerTop10();
         $text = ['*Yeah, here are the TOP 10*'];
         foreach ($rows as $row) {
-            $text[] = '<@' . $row['username'] . '> has received ' . $row['cnt'] . ' :t3beer:';
+            $text[] = '<@'.$row['username'].'> has received '.$row['cnt'].' :t3beer:';
         }
 
         return implode(chr(10), $text);
@@ -85,7 +85,7 @@ 
         if (strpos($username, '<') === 0 && $username[1] === '@') {
             $username = str_replace(['<', '>', '@'], '', $username);
 
-            return '<@' . $username . '> has received ' . $this->getBeerCountByUsername($username) . ' :t3beer: so far';
+            return '<@'.$username.'> has received '.$this->getBeerCountByUsername($username).' :t3beer: so far';
         }
         return '*Sorry, a username must start with a @-sign:*';
     }
@@ -109,10 +109,10 @@ 
                     'from_user' => $from_user,
                     'tstamp' => time()
                 ]);
-                return 'Yeah, one more :t3beer: for <@' . $username . '>' . chr(10) . '<@' . $username . '> has received '
-                    . $this->getBeerCountByUsername($username) . ' :t3beer: so far';
+                return 'Yeah, one more :t3beer: for <@'.$username.'>'.chr(10).'<@'.$username.'> has received '
+                    . $this->getBeerCountByUsername($username).' :t3beer: so far';
             }
-            return 'You spend one :t3beer: to <@' . $username . '> within in last 24 hours. Too much beer is unhealthy ;)';
+            return 'You spend one :t3beer: to <@'.$username.'> within in last 24 hours. Too much beer is unhealthy ;)';
         }
         return '*Sorry, a username must start with a @-sign:*';
     }

Classes/Commands/BottyCommand.php

Spacing +2 added lines, -2 removed lines

@@ -18,7 +18,7 @@ 
      * @var array
      */
     protected $cats = [':smiley_cat:', ':smile_cat:', ':heart_eyes_cat:', ':kissing_cat:',
-        ':smirk_cat:', ':scream_cat:', ':crying_cat_face:', ':joy_cat:' , ':pouting_cat:', ];
+        ':smirk_cat:', ':scream_cat:', ':crying_cat_face:', ':joy_cat:', ':pouting_cat:', ];
 
     /**
      * @var array
@@ -69,7 +69,7 @@ 
     public function processMessage() : string
     {
         $message = strtolower($this->payload->getData()['text']);
-        $username = '<@' . $this->payload->getData()['user'] . '>';
+        $username = '<@'.$this->payload->getData()['user'].'>';
 
         if (strpos($message, 'help') !== false) {
             $result = [];

Classes/Commands/TellCommand.php

Spacing +8 added lines, -8 removed lines

@@ -104,8 +104,8 @@ 
     {
         $parts = explode(':', $notification['message']);
         $refId = (int) trim($parts[1]);
-        $result = $this->queryGerrit('change:' . $refId);
-        $msg = '*Hi <@' . $user . '>, <@' . $notification['from_user'] . '>'
+        $result = $this->queryGerrit('change:'.$refId);
+        $msg = '*Hi <@'.$user.'>, <@'.$notification['from_user'].'>'
             . ' ask you to look at this patch:*';
 
         if (is_array($result)) {
@@ -127,11 +127,11 @@ 
     {
         $parts = explode(':', $notification['message']);
         $issueNumber = (int) trim($parts[1]);
-        $result = $this->queryForge('issues/' . $issueNumber);
+        $result = $this->queryForge('issues/'.$issueNumber);
         if ($result) {
-            $msg = '*Hi <@' . $user . '>, <@' . $notification['from_user'] . '>'
+            $msg = '*Hi <@'.$user.'>, <@'.$notification['from_user'].'>'
                 . ' ask you to look at this issue:*';
-            $this->sendResponse($msg . chr(10) . $this->buildIssueMessage($result->issue), $user);
+            $this->sendResponse($msg.chr(10).$this->buildIssueMessage($result->issue), $user);
         }
     }
 
@@ -141,8 +141,8 @@ 
      */
     protected function processTextMessage(array $notification, string $user)
     {
-        $msg = '*Hi <@' . $user . '>, here is a message from <@' . $notification['from_user'] . '>' . ' for you:*';
-        $this->sendResponse($msg . chr(10) . $notification['message'], $user);
+        $msg = '*Hi <@'.$user.'>, here is a message from <@'.$notification['from_user'].'>'.' for you:*';
+        $this->sendResponse($msg.chr(10).$notification['message'], $user);
     }
 
     /**
@@ -168,6 +168,6 @@ 
             'message' => $message,
         ]);
 
-        return 'OK, I will tell <@' . $toUser . '> about your message';
+        return 'OK, I will tell <@'.$toUser.'> about your message';
     }
 }

Classes/Commands/AbstractCommand.php

Spacing +8 added lines, -8 removed lines

@@ -98,7 +98,7 @@ 
 
         $command = !empty($params[0]) ? $params[0] : 'help';
         $this->params = $params;
-        $method = 'process' . ucfirst(strtolower($command));
+        $method = 'process'.ucfirst(strtolower($command));
         if (method_exists($this, $method)) {
             return $this->{$method}();
         }
@@ -115,7 +115,7 @@ 
     {
         if ($user !== null) {
             $this->client->apiCall('im.open', ['user' => $user])
-                ->then(function (Payload $response) use ($messageToSent) {
+                ->then(function(Payload $response) use ($messageToSent) {
                     $channel = $response->getData()['channel']['id'];
                     $this->postMessage($messageToSent, $channel);
                 });
@@ -132,9 +132,9 @@ 
      */
     public function getHelp() : string
     {
-        $result = '*HELP*' . chr(10);
+        $result = '*HELP*'.chr(10);
         foreach ($this->helpCommands as $command => $helpText) {
-            $result .= "*{$this->commandName}:{$command}*: {$helpText}" . chr(10);
+            $result .= "*{$this->commandName}:{$command}*: {$helpText}".chr(10);
         }
 
         return $result;
@@ -178,11 +178,11 @@ 
                 break;
         }
         $attachment->setTitle($item->subject);
-        $attachment->setTitleLink('https://review.typo3.org/' . $item->_number);
+        $attachment->setTitleLink('https://review.typo3.org/'.$item->_number);
 
-        $text .= 'Branch: ' . $this->bold($branch) . ' | :calendar: ' . $this->bold($created)
-            . ' | ID: ' . $this->bold($item->_number) . chr(10);
-        $text .= '<https://review.typo3.org/' . $item->_number . '|:arrow_right: Goto Review>';
+        $text .= 'Branch: '.$this->bold($branch).' | :calendar: '.$this->bold($created)
+            . ' | ID: '.$this->bold($item->_number).chr(10);
+        $text .= '<https://review.typo3.org/'.$item->_number.'|:arrow_right: Goto Review>';
 
         $attachment->setText($text);
         $attachment->setFallback($text);