NeoBlack / T3Bot

Classes/Commands/ReviewCommand.php

Spacing +16 added lines, -16 removed lines

@@ -59,15 +59,15 @@ 
         $countMinus2 = count($result);
 
         $returnString = '';
-        $returnString .= 'There are currently ' . $this->bold($count) . ' open reviews for project '
-            . $this->italic($project) . ' and branch master on <https://review.typo3.org/#/q/project:' . $project
-            . '+status:open+branch:master|https://review.typo3.org>' . chr(10);
-        $returnString .= $this->bold($countMinus1) . ' of ' . $this->bold($count) . ' open reviews voted with '
-            . $this->bold('-1') . ' <https://review.typo3.org/#/q/label:Code-Review%253D-1+is:open+branch:'
-            . 'master+project:' . $project . '|Check now> ' . chr(10);
-        $returnString .= $this->bold($countMinus2) . ' of ' . $this->bold($count) . ' open reviews voted with '
-            . $this->bold('-2') . ' <https://review.typo3.org/#/q/label:Code-Review%253D-2+is:open+branch:'
-            . 'master+project:' . $project . '|Check now>';
+        $returnString .= 'There are currently '.$this->bold($count).' open reviews for project '
+            . $this->italic($project).' and branch master on <https://review.typo3.org/#/q/project:'.$project
+            . '+status:open+branch:master|https://review.typo3.org>'.chr(10);
+        $returnString .= $this->bold($countMinus1).' of '.$this->bold($count).' open reviews voted with '
+            . $this->bold('-1').' <https://review.typo3.org/#/q/label:Code-Review%253D-1+is:open+branch:'
+            . 'master+project:'.$project.'|Check now> '.chr(10);
+        $returnString .= $this->bold($countMinus2).' of '.$this->bold($count).' open reviews voted with '
+            . $this->bold('-2').' <https://review.typo3.org/#/q/label:Code-Review%253D-2+is:open+branch:'
+            . 'master+project:'.$project.'|Check now>';
 
         return $returnString;
     }
@@ -98,15 +98,15 @@ 
         if ($username === null) {
             return 'hey, I need a username!';
         }
-        $results = $this->queryGerrit('is:open owner:"' . $username . '" project:' . $project);
+        $results = $this->queryGerrit('is:open owner:"'.$username.'" project:'.$project);
         if (!empty($results)) {
-            $listOfItems = ['*Here are the results for ' . $username . '*:'];
+            $listOfItems = ['*Here are the results for '.$username.'*:'];
             foreach ($results as $item) {
                 $listOfItems[] = $this->buildReviewLine($item);
             }
             return implode(chr(10), $listOfItems);
         }
-        return $username . ' has no open reviews or username is unknown';
+        return $username.' has no open reviews or username is unknown';
     }
 
     /**
@@ -144,7 +144,7 @@ 
         $paramsCount = count($this->params);
         $changeIds = [];
         for ($i = 1; $i < $paramsCount; ++$i) {
-            $changeIds[] = 'change:' . $this->params[$i];
+            $changeIds[] = 'change:'.$this->params[$i];
         }
         $result = $this->queryGerrit(implode(' OR ', $changeIds));
         $listOfItems = [];
@@ -163,7 +163,7 @@ 
      */
     protected function buildReviewMessageOutput(int $refId)
     {
-        $result = $this->queryGerrit('change:' . $refId);
+        $result = $this->queryGerrit('change:'.$refId);
         if (!empty($result)) {
             foreach ($result as $item) {
                 if ($item->_number === $refId) {
@@ -187,7 +187,7 @@ 
             return 'hey, I need a query!';
         }
 
-        $results = $this->queryGerrit('limit:50 ' . $query);
+        $results = $this->queryGerrit('limit:50 '.$query);
         if (!empty($results)) {
             $listOfItems = ["*Here are the results for {$query}*:"];
             foreach ($results as $item) {
@@ -215,7 +215,7 @@ 
 
         $cnt = count($result);
 
-        return 'Good job folks, since ' . $date . ' you merged *' . $cnt . '* patches into master';
+        return 'Good job folks, since '.$date.' you merged *'.$cnt.'* patches into master';
     }
 
     /**

Classes/Commands/BottyCommand.php

Spacing +2 added lines, -2 removed lines

@@ -18,7 +18,7 @@ 
      * @var array
      */
     protected $cats = [':smiley_cat:', ':smile_cat:', ':heart_eyes_cat:', ':kissing_cat:',
-        ':smirk_cat:', ':scream_cat:', ':crying_cat_face:', ':joy_cat:' , ':pouting_cat:', ];
+        ':smirk_cat:', ':scream_cat:', ':crying_cat_face:', ':joy_cat:', ':pouting_cat:', ];
 
     /**
      * @var array
@@ -61,7 +61,7 @@ 
     public function process() : string
     {
         $message = strtolower($this->payload->getData()['text']);
-        $username = '<@' . $this->payload->getData()['user'] . '>';
+        $username = '<@'.$this->payload->getData()['user'].'>';
 
         if (strpos($message, 'help') !== false) {
             $result = [];

Classes/Commands/AbstractCommand.php

Spacing +8 added lines, -8 removed lines

@@ -118,7 +118,7 @@ 
 
         $command = !empty($params[0]) ? $params[0] : 'help';
         $this->params = $params;
-        $method = 'process' . ucfirst(strtolower($command));
+        $method = 'process'.ucfirst(strtolower($command));
         if (method_exists($this, $method)) {
             return $this->{$method}();
         }
@@ -135,7 +135,7 @@ 
     {
         if ($user !== null) {
             $this->client->apiCall('im.open', ['user' => $user])
-                ->then(function (Payload $response) use ($messageToSent) {
+                ->then(function(Payload $response) use ($messageToSent) {
                     $channel = $response->getData()['channel']['id'];
                     $this->postMessage($messageToSent, $channel);
                 });
@@ -152,9 +152,9 @@ 
      */
     public function getHelp() : string
     {
-        $result = '*HELP*' . chr(10);
+        $result = '*HELP*'.chr(10);
         foreach ($this->helpCommands as $command => $helpText) {
-            $result .= "*{$this->commandName}:{$command}*: {$helpText}" . chr(10);
+            $result .= "*{$this->commandName}:{$command}*: {$helpText}".chr(10);
         }
 
         return $result;
@@ -180,11 +180,11 @@ 
         $attachment->setColor($color);
         $attachment->setPretext($preText);
         $attachment->setTitle($item->subject);
-        $attachment->setTitleLink('https://review.typo3.org/' . $item->_number);
+        $attachment->setTitleLink('https://review.typo3.org/'.$item->_number);
 
-        $text = 'Branch: ' . $this->bold($branch) . ' | :calendar: ' . $this->bold($created)
-            . ' | ID: ' . $this->bold($item->_number) . chr(10);
-        $text .= '<https://review.typo3.org/' . $item->_number . '|:arrow_right: Goto Review>';
+        $text = 'Branch: '.$this->bold($branch).' | :calendar: '.$this->bold($created)
+            . ' | ID: '.$this->bold($item->_number).chr(10);
+        $text .= '<https://review.typo3.org/'.$item->_number.'|:arrow_right: Goto Review>';
 
         $attachment->setText($text);
         $attachment->setFallback($text);