Completed
Pull Request — master (#100)
by Maxime
02:29
created
src/Client/Connection.php 3 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@
 block discarded – undo
47 47
     }
48 48
 
49 49
     /**
50
-     * @param \Exception|string $error
50
+     * @param \Exception $error
51 51
      */
52 52
     private function onError($error)
53 53
     {
Please login to merge, or discard this patch.
Unused Use Statements   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -12,10 +12,10 @@
 block discarded – undo
12 12
 namespace Nekland\Woketo\Client;
13 13
 
14 14
 
15
-use Nekland\Woketo\Core\AbstractConnection;
16
-use Nekland\Woketo\Rfc6455\Handshake\ClientHandShake;
17
-use Nekland\Woketo\Rfc6455\MessageProcessor;
18
-use React\Promise\PromiseInterface;
15
+use Nekland\Woketo\Core\AbstractConnection;
16
+use Nekland\Woketo\Rfc6455\Handshake\ClientHandShake;
17
+use Nekland\Woketo\Rfc6455\MessageProcessor;
18
+use React\Promise\PromiseInterface;
19 19
 use React\Stream\Stream;
20 20
 
21 21
 class Connection extends AbstractConnection
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -28,17 +28,17 @@
 block discarded – undo
28 28
     public function __construct(PromiseInterface $clientPromise, MessageProcessor $messageProcessor)
29 29
     {
30 30
         parent::__construct($messageProcessor, new ClientHandShake());
31
-        $clientPromise->then(function (Stream $stream) {
31
+        $clientPromise->then(function(Stream $stream) {
32 32
             $this->stream = $stream;
33 33
             $this->onConnection($stream);
34
-        }, function (\Exception $error){
34
+        }, function(\Exception $error) {
35 35
             $this->onError($error);
36 36
         });
37 37
     }
38 38
 
39 39
     private function onConnection(Stream $stream)
40 40
     {
41
-        $stream->on('message', function (string $data) {
41
+        $stream->on('message', function(string $data) {
42 42
             $this->onMessage($data);
43 43
         });
44 44
     }
Please login to merge, or discard this patch.
src/Core/AbstractConnection.php 1 patch
Unused Use Statements   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -11,11 +11,11 @@
 block discarded – undo
11 11
 
12 12
 namespace Nekland\Woketo\Core;
13 13
 
14
-use Nekland\Woketo\Exception\WebsocketException;
15
-use Nekland\Woketo\Message\MessageHandlerInterface;
16
-use Nekland\Woketo\Rfc6455\Handshake\HandshakeInterface;
17
-use Nekland\Woketo\Rfc6455\MessageProcessor;
18
-use Psr\Log\LoggerAwareTrait;
14
+use Nekland\Woketo\Exception\WebsocketException;
15
+use Nekland\Woketo\Message\MessageHandlerInterface;
16
+use Nekland\Woketo\Rfc6455\Handshake\HandshakeInterface;
17
+use Nekland\Woketo\Rfc6455\MessageProcessor;
18
+use Psr\Log\LoggerAwareTrait;
19 19
 use React\Socket\Connection;
20 20
 
21 21
 abstract class AbstractConnection
Please login to merge, or discard this patch.
src/Server/Connection.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -69,10 +69,10 @@  discard block
 block discarded – undo
69 69
 
70 70
     private function initListeners()
71 71
     {
72
-        $this->stream->on('data', function ($data) {
72
+        $this->stream->on('data', function($data) {
73 73
             $this->processData($data);
74 74
         });
75
-        $this->stream->on('error', function ($data) {
75
+        $this->stream->on('error', function($data) {
76 76
             $this->error($data);
77 77
         });
78 78
     }
@@ -114,7 +114,7 @@  discard block
 block discarded – undo
114 114
             $this->currentMessage = $message;
115 115
             if ($this->currentMessage->isComplete()) {
116 116
                 // Sending the message through the woketo API.
117
-                switch($this->currentMessage->getOpcode()) {
117
+                switch ($this->currentMessage->getOpcode()) {
118 118
                     case Frame::OP_TEXT:
119 119
                         $this->getHandler()->onMessage($this->currentMessage->getContent(), $this);
120 120
                         break;
@@ -126,7 +126,7 @@  discard block
 block discarded – undo
126 126
 
127 127
             } else {
128 128
                 // We wait for more data so we start a timeout.
129
-                $this->timeout = $this->loop->addTimer(Connection::DEFAULT_TIMEOUT, function () {
129
+                $this->timeout = $this->loop->addTimer(Connection::DEFAULT_TIMEOUT, function() {
130 130
                     $this->logger->notice('Connection to ' . $this->getIp() . ' timed out.');
131 131
                     $this->messageProcessor->timeout($this->stream);
132 132
                 });
Please login to merge, or discard this patch.
src/Rfc6455/Handshake/ClientHandshake.php 2 patches
Unused Use Statements   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -11,8 +11,8 @@
 block discarded – undo
11 11
 
12 12
 namespace Nekland\Woketo\Rfc6455\Handshake;
13 13
 
14
-use Nekland\Woketo\Exception\RuntimeException;
15
-use Nekland\Woketo\Http\Request;
14
+use Nekland\Woketo\Exception\RuntimeException;
15
+use Nekland\Woketo\Http\Request;
16 16
 use Nekland\Woketo\Http\Response;
17 17
 
18 18
 class ClientHandshake implements HandshakeInterface
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@
 block discarded – undo
29 29
 
30 30
         $key = '';
31 31
         for ($i = 0; $i < 16; $i++) {
32
-            $key .= chr(mt_rand(0,255));
32
+            $key .= chr(mt_rand(0, 255));
33 33
         }
34 34
 
35 35
         $key = base64_encode($key);
Please login to merge, or discard this patch.
src/Http/Response.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -98,7 +98,7 @@  discard block
 block discarded – undo
98 98
         $stringResponse = $this->getHttpVersion() . ' ' . $this->httpResponse . "\r\n";
99 99
 
100 100
         foreach ($this->getHeaders() as $name => $content) {
101
-            $stringResponse .= $name . ': '. $content . "\r\n";
101
+            $stringResponse .= $name . ': ' . $content . "\r\n";
102 102
         }
103 103
 
104 104
         // No content to concatenate
@@ -152,7 +152,7 @@  discard block
 block discarded – undo
152 152
     {
153 153
         $httpElements = \explode(' ', $firstLine);
154 154
 
155
-        if (!\preg_match('/HTTP\/[1-2\.]+/',$httpElements[0])) {
155
+        if (!\preg_match('/HTTP\/[1-2\.]+/', $httpElements[0])) {
156 156
             throw Response::createNotHttpException($firstLine);
157 157
         }
158 158
         $response->setHttpVersion($httpElements[0]);
Please login to merge, or discard this patch.