Nelexa\RequestDtoBundle\ArgumentResolver\RequestBodyObjectValueResolver

Complexity

Total Complexity

3

Size/Duplication

Total Lines	22
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	1

2 Methods

Rating	Name	Duplication	Size	Complexity
A	supports()	0	3	1
A	serialize()	0	15	2

<?php

declare(strict_types=1);

namespace Nelexa\RequestDtoBundle\ArgumentResolver;

use Nelexa\RequestDtoBundle\Dto\RequestBodyObjectInterface;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpKernel\ControllerMetadata\ArgumentMetadata;
use Symfony\Component\HttpKernel\Exception\HttpException;
use Symfony\Component\Serializer\Exception\NotEncodableValueException;

final class RequestBodyObjectValueResolver extends AbstractObjectValueResolver
{
    public function supports(Request $request, ArgumentMetadata $argument): bool
    {
        return is_a($argument->getType(), RequestBodyObjectInterface::class, true);
    }

    protected function serialize(Request $request, ArgumentMetadata $argument): object
    {
        try {
            return $this->serializer->deserialize(

The expression return $this->serializer->deserialize($request->getContent(), $argument->getType(), $this->getSerializeFormat($request)) could return the type array which is incompatible with the type-hinted return object. Consider adding an additional type-check to rule them out.

                $request->getContent(),
                $argument->getType(),

It seems like $argument->getType() can also be of type null; however, parameter $type of Symfony\Component\Serializer\SerializerInterface::deserialize() does only seem to accept string, maybe add an additional type check?

                $this->getSerializeFormat($request)
            );
        } catch (NotEncodableValueException $e) {
            throw new HttpException(
                400,
                'Bad Request',
                $e,
                [
                    'Content-Type' => 'application/problem+json',
                ]
            );
        }
    }
}