Nelexa\RequestDtoBundle\ArgumentResolver\RequestBodyObjectValueResolver::serialize()

Complexity

Conditions	2
Paths	2

Size

Total Lines	15
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	1

<?php
    protected function serialize(Request $request, ArgumentMetadata $argument): object
    {
        try {
            return $this->serializer->deserialize(

The expression return $this->serializer->deserialize($request->getContent(), $argument->getType(), $this->getSerializeFormat($request)) could return the type array which is incompatible with the type-hinted return object. Consider adding an additional type-check to rule them out.

                $request->getContent(),
                $argument->getType(),

It seems like $argument->getType() can also be of type null; however, parameter $type of Symfony\Component\Serializer\SerializerInterface::deserialize() does only seem to accept string, maybe add an additional type check?

                $this->getSerializeFormat($request)
            );
        } catch (NotEncodableValueException $e) {
            throw new HttpException(
                400,
                'Bad Request',
                $e,
                [
                    'Content-Type' => 'application/problem+json',
                ]