View GitHub Repository transmit

Schedule Inspection
Subscribe
Completed
Pull Request — master (#5)
by Zach
01:57
created
Status
Category
Toggle Patches
src/Controller.php 2 patches
Unused Use Statements   +2 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -2,13 +2,12 @@
 
 block discarded – undo
2 2
3 3 
 namespace NavJobs\Transmit;
4 4
5 
-use Illuminate\Database\Eloquent\Builder;
5 
+use Illuminate\Routing\Controller as BaseController;
6 6 
 use Illuminate\Support\Facades\App;
7 7 
 use Illuminate\Support\Facades\Input;
8 
+use League\Fractal\Pagination\IlluminatePaginatorAdapter;
8 9 
 use NavJobs\Transmit\Traits\ErrorResponsesTrait;
9 10 
 use NavJobs\Transmit\Traits\QueryHelperTrait;
10 
-use Illuminate\Routing\Controller as BaseController;
11 
-use League\Fractal\Pagination\IlluminatePaginatorAdapter;
12 11
13 12 
 abstract class Controller extends BaseController
14 13 
 {
Please login to merge, or discard this patch.
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch 
@@ -55,7 +55,7 @@  discard block
 
 block discarded – undo
55 55 
     /**
56 56 
      * Sets the current status code.
57 57 
      *
58 
-     * @param $statusCode
58 
+     * @param integer $statusCode
59 59 
      * @return $this
60 60 
      */
61 61 
     protected function setStatusCode($statusCode)
 
@@ -79,8 +79,8 @@  discard block
 
 block discarded – undo
79 79 
      * passed through fractal and optionally a transformer.
80 80 
      *
81 81 
      * @param $item
82 
-     * @param null $callback
83 
-     * @param null $resourceKey
82 
+     * @param \Closure $callback
83 
+     * @param false|null $resourceKey
84 84 
      * @return \Illuminate\Http\JsonResponse
85 85 
      */
86 86 
     protected function respondWithItem($item, $callback = null, $resourceKey = false)
 
@@ -101,7 +101,7 @@  discard block
 
 block discarded – undo
101 101 
      *
102 102 
      * @param $item
103 103 
      * @param null $callback
104 
-     * @param null $resourceKey
104 
+     * @param false|null $resourceKey
105 105 
      * @return \Illuminate\Http\JsonResponse
106 106 
      */
107 107 
     protected function respondWithItemCreated($item, $callback = null, $resourceKey = false)
 
@@ -118,7 +118,7 @@  discard block
 
 block discarded – undo
118 118 
      *
119 119 
      * @param $collection
120 120 
      * @param $callback
121 
-     * @param null $resourceKey
121 
+     * @param false|null $resourceKey
122 122 
      * @return \Illuminate\Http\JsonResponse
123 123 
      */
124 124 
     protected function respondWithCollection($collection, $callback, $resourceKey = false)
Please login to merge, or discard this patch.
src/Templates/ResourceController.php 1 patch
Doc Comments   +4 added lines, -5 removed lines patch added patch discarded remove patch 
@@ -9,7 +9,7 @@  discard block
 
 block discarded – undo
9 9 
     /**
10 10 
      * Display a listing of the resource.
11 11 
      *
12 
-     * @return \Illuminate\Http\Response
12 
+     * @return \Illuminate\Http\JsonResponse
13 13 
      */
14 14 
     public function index()
15 15 
     {
 
@@ -18,8 +18,7 @@  discard block
 
 block discarded – undo
18 18 
     /**
19 19 
      * Store a newly created resource in storage.
20 20 
      *
21 
-     * @param  \Illuminate\Http\Request  $request
22 
-     * @return \Illuminate\Http\Response
21 
+     * @return \Illuminate\Http\JsonResponse
23 22 
      */
24 23 
     public function store()
25 24 
     {
 
@@ -30,7 +29,7 @@  discard block
 
 block discarded – undo
30 29 
      * Display the specified resource.
31 30 
      *
32 31 
      * @param  int  $id
33 
-     * @return \Illuminate\Http\Response
32 
+     * @return \Illuminate\Http\JsonResponse
34 33 
      */
35 34 
     public function show($id)
36 35 
     {
 
@@ -43,7 +42,7 @@  discard block
 
 block discarded – undo
43 42 
      *
44 43 
      * @param  \Illuminate\Http\Request  $request
45 44 
      * @param  int  $id
46 
-     * @return \Illuminate\Http\Response
45 
+     * @return \Illuminate\Http\JsonResponse
47 46 
      */
48 47 
     public function update($id, Request $request)
49 48 
     {
Please login to merge, or discard this patch.