| @@ -76,10 +76,12 @@ | ||
| 76 | 76 | */ | 
| 77 | 77 | public function getUriSpace() | 
| 78 | 78 |      { | 
| 79 | - if ($this->urispace === null) // initialize cache | |
| 79 | +        if ($this->urispace === null) { | |
| 80 | + // initialize cache | |
| 80 | 81 |          { | 
| 81 | 82 |              $this->urispace = $this->resource->getLiteral('void:uriSpace')->getValue(); | 
| 82 | 83 | } | 
| 84 | + } | |
| 83 | 85 | |
| 84 | 86 | return $this->urispace; | 
| 85 | 87 | } | 
| @@ -92,7 +92,7 @@ discard block | ||
| 92 | 92 | return $lname; | 
| 93 | 93 | } | 
| 94 | 94 | // already a full URI | 
| 95 | - return $this->getUriSpace() . $lname; | |
| 95 | + return $this->getUriSpace().$lname; | |
| 96 | 96 | } | 
| 97 | 97 | |
| 98 | 98 | /** | 
| @@ -153,7 +153,7 @@ discard block | ||
| 153 | 153 |                  foreach ($conceptscheme->allLiterals($prop, null) as $val) { | 
| 154 | 154 |                      $prop = (substr($prop, 0, 5) == 'dc11:') ? str_replace('dc11:', 'dc:', $prop) : $prop; | 
| 155 | 155 |                      if ($val->getValue() instanceof DateTime) { | 
| 156 | - $val = Punic\Calendar::formatDate($val->getValue(), 'full', $lang) . ' ' . Punic\Calendar::format($val->getValue(), 'HH:mm:ss', $lang); | |
| 156 | + $val = Punic\Calendar::formatDate($val->getValue(), 'full', $lang).' '.Punic\Calendar::format($val->getValue(), 'HH:mm:ss', $lang); | |
| 157 | 157 | } | 
| 158 | 158 | $ret[$prop][] = $val; | 
| 159 | 159 | } | 
| @@ -264,7 +264,7 @@ discard block | ||
| 264 | 264 | } | 
| 265 | 265 | // don't know how to parse | 
| 266 | 266 | $rev = $parts[2]; | 
| 267 | - $datestr = $parts[3] . ' ' . $parts[4]; | |
| 267 | + $datestr = $parts[3].' '.$parts[4]; | |
| 268 | 268 | |
| 269 | 269 | return "$datestr (r$rev)"; | 
| 270 | 270 | } | 
| @@ -273,7 +273,7 @@ discard block | ||
| 273 | 273 | * Counts the statistics of the vocabulary. | 
| 274 | 274 | * @return array of the concept/group counts | 
| 275 | 275 | */ | 
| 276 | - public function getStatistics($lang = '', $array=null, $group=null) | |
| 276 | + public function getStatistics($lang = '', $array = null, $group = null) | |
| 277 | 277 |      { | 
| 278 | 278 | $sparql = $this->getSparql(); | 
| 279 | 279 | // find the number of concepts | 
| @@ -482,7 +482,7 @@ discard block | ||
| 482 | 482 | */ | 
| 483 | 483 | public function searchConceptsAlphabetical($letter, $limit = null, $offset = null, $clang = null) | 
| 484 | 484 |      { | 
| 485 | - return $this->getSparql()->queryConceptsAlphabetical($letter, $clang, $limit, $offset, $this->config->getIndexClasses(),$this->config->getShowDeprecated()); | |
| 485 | + return $this->getSparql()->queryConceptsAlphabetical($letter, $clang, $limit, $offset, $this->config->getIndexClasses(), $this->config->getShowDeprecated()); | |
| 486 | 486 | } | 
| 487 | 487 | |
| 488 | 488 | /** | 
| @@ -591,14 +591,14 @@ discard block | ||
| 591 | 591 |      { | 
| 592 | 592 | $changelist = $this->getSparql()->queryChangeList($clang, $offset, $prop); | 
| 593 | 593 | $bydate = array(); | 
| 594 | -      foreach($changelist as $concept) { | |
| 594 | +      foreach ($changelist as $concept) { | |
| 595 | 595 | $concept['datestring'] = Punic\Calendar::formatDate($concept['date'], 'medium', $lang); | 
| 596 | - $bydate[Punic\Calendar::getMonthName($concept['date'], 'wide', $lang, true) . Punic\Calendar::format($concept['date'], ' y', $lang) ][strtolower($concept['prefLabel'])] = $concept; | |
| 596 | + $bydate[Punic\Calendar::getMonthName($concept['date'], 'wide', $lang, true).Punic\Calendar::format($concept['date'], ' y', $lang)][strtolower($concept['prefLabel'])] = $concept; | |
| 597 | 597 | } | 
| 598 | 598 | return $bydate; | 
| 599 | 599 | } | 
| 600 | 600 | |
| 601 | -    public function getTitle($lang=null) { | |
| 601 | +    public function getTitle($lang = null) { | |
| 602 | 602 | return $this->config->getTitle($lang); | 
| 603 | 603 | } | 
| 604 | 604 | |
| @@ -109,7 +109,7 @@ discard block | ||
| 109 | 109 | * Get the localname of a concept in the vocabulary. If the URI is not | 
| 110 | 110 | * in the URI space of this vocabulary, return the full URI. | 
| 111 | 111 | * | 
| 112 | - * @param $uri string full URI of concept | |
| 112 | + * @param string $uri string full URI of concept | |
| 113 | 113 | * @return string local name of concept, or original full URI if the local name cannot be determined | 
| 114 | 114 | */ | 
| 115 | 115 | public function getLocalName($uri) | 
| @@ -281,6 +281,8 @@ discard block | ||
| 281 | 281 | |
| 282 | 282 | /** | 
| 283 | 283 | * Counts the statistics of the vocabulary. | 
| 284 | + * @param string $array | |
| 285 | + * @param string $group | |
| 284 | 286 | * @return array of the concept/group counts | 
| 285 | 287 | */ | 
| 286 | 288 | public function getStatistics($lang = '', $array=null, $group=null) | 
| @@ -320,6 +322,7 @@ discard block | ||
| 320 | 322 | /** | 
| 321 | 323 | * Gets the child relations of a concept and whether these children have more children. | 
| 322 | 324 | * @param string $uri | 
| 325 | + * @param string $lang | |
| 323 | 326 | */ | 
| 324 | 327 | public function getConceptChildren($uri, $lang) | 
| 325 | 328 |      { | 
| @@ -428,6 +431,8 @@ discard block | ||
| 428 | 431 | /** | 
| 429 | 432 | * Lists the concepts available in the concept group. | 
| 430 | 433 | * @param $clname | 
| 434 | + * @param string $glname | |
| 435 | + * @param string $clang | |
| 431 | 436 | * @return array | 
| 432 | 437 | */ | 
| 433 | 438 | public function listConceptGroupContents($glname, $clang) | 
| @@ -595,6 +600,7 @@ discard block | ||
| 595 | 600 | * Returns a list of recently changed or entirely new concepts. | 
| 596 | 601 | * @param string $clang content language for the labels | 
| 597 | 602 | * @param string $lang UI language for the dates | 
| 603 | + * @param string $prop | |
| 598 | 604 | * @return Array | 
| 599 | 605 | */ | 
| 600 | 606 | public function getChangeList($prop, $clang, $lang, $offset) | 
| @@ -608,6 +614,9 @@ discard block | ||
| 608 | 614 | return $bydate; | 
| 609 | 615 | } | 
| 610 | 616 | |
| 617 | + /** | |
| 618 | + * @param string $lang | |
| 619 | + */ | |
| 611 | 620 |      public function getTitle($lang=null) { | 
| 612 | 621 | return $this->config->getTitle($lang); | 
| 613 | 622 | } | 
| @@ -10,6 +10,9 @@ | ||
| 10 | 10 | */ | 
| 11 | 11 | class VocabularyCategory extends DataObject | 
| 12 | 12 |  { | 
| 13 | + /** | |
| 14 | + * @param Model $model | |
| 15 | + */ | |
| 13 | 16 | public function __construct($model, $resource) | 
| 14 | 17 |      { | 
| 15 | 18 |          if (!($model instanceof Model)) { | 
| @@ -37,7 +37,7 @@ discard block | ||
| 37 | 37 |      } elseif ($parts[1] == 'data') { | 
| 38 | 38 | $controller->data($request); | 
| 39 | 39 |      } elseif (sizeof($parts) == 2) { | 
| 40 | -        header("Location: " . $parts[1] . "/"); | |
| 40 | +        header("Location: ".$parts[1]."/"); | |
| 41 | 41 |      } else { | 
| 42 | 42 | $vocab = $parts[1]; | 
| 43 | 43 |          try { | 
| @@ -93,5 +93,5 @@ discard block | ||
| 93 | 93 | } | 
| 94 | 94 |  } catch (Exception $e) { | 
| 95 | 95 |      header("HTTP/1.0 500 Internal Server Error"); | 
| 96 | -    echo('ERROR: ' . $e->getMessage()); | |
| 96 | +    echo('ERROR: '.$e->getMessage()); | |
| 97 | 97 | } | 
| @@ -106,7 +106,7 @@ | ||
| 106 | 106 | |
| 107 | 107 | public function getRequestUri() | 
| 108 | 108 |      { | 
| 109 | -        return $this->getServerConstant('HTTP_HOST') . $this->getServerConstant('REQUEST_URI'); | |
| 109 | +        return $this->getServerConstant('HTTP_HOST').$this->getServerConstant('REQUEST_URI'); | |
| 110 | 110 | } | 
| 111 | 111 | |
| 112 | 112 | /** | 
| @@ -74,7 +74,9 @@ discard block | ||
| 74 | 74 | */ | 
| 75 | 75 | public function getQueryParam($paramName) | 
| 76 | 76 |      { | 
| 77 | - if (!isset($this->queryParams[$paramName])) return null; | |
| 77 | +        if (!isset($this->queryParams[$paramName])) { | |
| 78 | + return null; | |
| 79 | + } | |
| 78 | 80 | $val = filter_var($this->queryParams[$paramName], FILTER_SANITIZE_STRING); | 
| 79 | 81 |          return ($val !== null ? str_replace('\\', '', $val) : null); | 
| 80 | 82 | } | 
| @@ -91,7 +93,9 @@ discard block | ||
| 91 | 93 | |
| 92 | 94 | public function getQueryParamPOST($paramName) | 
| 93 | 95 |      { | 
| 94 | - if (!isset($this->queryParamsPOST[$paramName])) return null; | |
| 96 | +        if (!isset($this->queryParamsPOST[$paramName])) { | |
| 97 | + return null; | |
| 98 | + } | |
| 95 | 99 | return filter_var($this->queryParamsPOST[$paramName], FILTER_SANITIZE_STRING); | 
| 96 | 100 | } | 
| 97 | 101 | |
| @@ -106,7 +110,9 @@ discard block | ||
| 106 | 110 | |
| 107 | 111 | public function getServerConstant($paramName) | 
| 108 | 112 |      { | 
| 109 | - if (!isset($this->serverConstants[$paramName])) return null; | |
| 113 | +        if (!isset($this->serverConstants[$paramName])) { | |
| 114 | + return null; | |
| 115 | + } | |
| 110 | 116 | return filter_var($this->serverConstants[$paramName], FILTER_SANITIZE_STRING); | 
| 111 | 117 | } | 
| 112 | 118 | |
| @@ -239,9 +245,11 @@ discard block | ||
| 239 | 245 | */ | 
| 240 | 246 | public function setVocab($vocabid) | 
| 241 | 247 |      { | 
| 242 | - if (strpos($vocabid, ' ') !== false) // if there are multiple vocabularies just storing the string | |
| 248 | +        if (strpos($vocabid, ' ') !== false) { | |
| 249 | + // if there are multiple vocabularies just storing the string | |
| 243 | 250 |          { | 
| 244 | 251 | $this->setVocabids($vocabid); | 
| 252 | + } | |
| 245 | 253 |          } else { | 
| 246 | 254 | $this->vocab = $this->model->getVocabulary($vocabid); | 
| 247 | 255 | } | 
| @@ -23,5 +23,5 @@ | ||
| 23 | 23 | |
| 24 | 24 |  } catch (Exception $e) { | 
| 25 | 25 |      header("HTTP/1.0 500 Internal Server Error"); | 
| 26 | -    echo('ERROR: ' . $e->getMessage()); | |
| 26 | +    echo('ERROR: '.$e->getMessage()); | |
| 27 | 27 | } | 
| @@ -14,7 +14,7 @@ discard block | ||
| 14 | 14 | } | 
| 15 | 15 | require_once 'vendor/autoload.php'; | 
| 16 | 16 |  } catch (Exception $e) { | 
| 17 | - echo "Error: " . $e->getMessage(); | |
| 17 | + echo "Error: ".$e->getMessage(); | |
| 18 | 18 | return; | 
| 19 | 19 | } | 
| 20 | 20 | |
| @@ -32,7 +32,7 @@ discard block | ||
| 32 | 32 | // if language code missing, redirect to guessed language | 
| 33 | 33 | // in any case, redirect to <lang>/ | 
| 34 | 34 | $lang = sizeof($parts) == 2 && $parts[1] !== '' ? $parts[1] : $controller->guessLanguage(); | 
| 35 | -    header("Location: " . $lang . "/"); | |
| 35 | +    header("Location: ".$lang."/"); | |
| 36 | 36 |  } else { | 
| 37 | 37 |    if (array_key_exists($parts[1], $config->getLanguages())) { // global pages | 
| 38 | 38 | $request->setLang($parts[1]); | 
| @@ -61,8 +61,8 @@ discard block | ||
| 61 | 61 | } | 
| 62 | 62 |          if (sizeof($parts) == 3) { // language code missing | 
| 63 | 63 | $lang = $controller->guessLanguage(); | 
| 64 | - $newurl = $controller->getBaseHref() . $vocab . "/" . $lang . "/"; | |
| 65 | -            header("Location: " . $newurl); | |
| 64 | + $newurl = $controller->getBaseHref().$vocab."/".$lang."/"; | |
| 65 | +            header("Location: ".$newurl); | |
| 66 | 66 |          } else { | 
| 67 | 67 |              if (array_key_exists($parts[2], $config->getLanguages())) { | 
| 68 | 68 | $lang = $parts[2]; | 
| @@ -103,10 +103,10 @@ discard block | ||
| 103 | 103 | } | 
| 104 | 104 |              } else { // language code missing, redirect to some language version | 
| 105 | 105 | $lang = $controller->guessLanguage($vocab); | 
| 106 | -                $newurl = $controller->getBaseHref() . $vocab . "/" . $lang . "/" . implode('/', array_slice($parts, 2)); | |
| 106 | +                $newurl = $controller->getBaseHref().$vocab."/".$lang."/".implode('/', array_slice($parts, 2)); | |
| 107 | 107 |                  $qs = $request->getServerConstant('QUERY_STRING'); | 
| 108 | 108 |                  if ($qs) { | 
| 109 | - $newurl .= "?" . $qs; | |
| 109 | + $newurl .= "?".$qs; | |
| 110 | 110 | } | 
| 111 | 111 |                  header("Location: $newurl"); | 
| 112 | 112 | } | 
| @@ -39,11 +39,11 @@ | ||
| 39 | 39 | return $html; | 
| 40 | 40 | } | 
| 41 | 41 | /** | 
| 42 | - * Validate honeypot is empty | |
| 43 | - * | |
| 44 | - * @param mixed $value | |
| 45 | - * @return boolean | |
| 46 | - */ | |
| 42 | + * Validate honeypot is empty | |
| 43 | + * | |
| 44 | + * @param mixed $value | |
| 45 | + * @return boolean | |
| 46 | + */ | |
| 47 | 47 | public function validateHoneypot($value) | 
| 48 | 48 |      { | 
| 49 | 49 |          if ($this->disabled) { | 
| @@ -32,9 +32,9 @@ discard block | ||
| 32 | 32 |      { | 
| 33 | 33 | // Encrypt the current time | 
| 34 | 34 | $honey_time_encrypted = $this->getEncryptedTime(); | 
| 35 | - $html = '<div id="' . $honey_name . '_wrap" style="display:none;">' . "\r\n" . | |
| 36 | - '<input name="' . $honey_name . '" type="text" value="" id="' . $honey_name . '"/>' . "\r\n" . | |
| 37 | - '<input name="' . $honey_time . '" type="text" value="' . $honey_time_encrypted . '"/>' . "\r\n" . | |
| 35 | + $html = '<div id="'.$honey_name.'_wrap" style="display:none;">'."\r\n". | |
| 36 | + '<input name="'.$honey_name.'" type="text" value="" id="'.$honey_name.'"/>'."\r\n". | |
| 37 | + '<input name="'.$honey_time.'" type="text" value="'.$honey_time_encrypted.'"/>'."\r\n". | |
| 38 | 38 | '</div>'; | 
| 39 | 39 | return $html; | 
| 40 | 40 | } | 
| @@ -67,7 +67,7 @@ discard block | ||
| 67 | 67 | // Get the decrypted time | 
| 68 | 68 | $value = $this->decryptTime($value); | 
| 69 | 69 | // The current time should be greater than the time the form was built + the speed option | 
| 70 | - return ( is_numeric($value) && time() > ($value + $parameters[0]) ); | |
| 70 | + return (is_numeric($value) && time() > ($value + $parameters[0])); | |
| 71 | 71 | } | 
| 72 | 72 | /** | 
| 73 | 73 | * Get encrypted time | 
| @@ -55,6 +55,7 @@ | ||
| 55 | 55 | |
| 56 | 56 | /** | 
| 57 | 57 | * Steps back, restoring the previous character or statement read() to the input buffer. | 
| 58 | + * @param string $chars | |
| 58 | 59 | */ | 
| 59 | 60 | protected function unread($chars) | 
| 60 | 61 |      { | 
| @@ -21,7 +21,7 @@ discard block | ||
| 21 | 21 | */ | 
| 22 | 22 | protected function peek() | 
| 23 | 23 |      { | 
| 24 | -        if(!$this->dataLength) { $this->dataLength = strlen($this->data); } | |
| 24 | +        if (!$this->dataLength) { $this->dataLength = strlen($this->data); } | |
| 25 | 25 |          if ($this->dataLength > $this->bytePos) { | 
| 26 | 26 | $slice = substr($this->data, $this->bytePos, 4); | 
| 27 | 27 | return mb_substr($slice, 0, 1, "UTF-8"); | 
| @@ -78,7 +78,7 @@ discard block | ||
| 78 | 78 |      { | 
| 79 | 79 |          if ($this->bytePos - 4 > 0) { | 
| 80 | 80 | $slice = substr($this->data, $this->bytePos - 4, 4); | 
| 81 | -            while($slice != '') { | |
| 81 | +            while ($slice != '') { | |
| 82 | 82 |                  if (!self::isWhitespace(mb_substr($slice, -1, 1, "UTF-8"))) { | 
| 83 | 83 | return; | 
| 84 | 84 | } | 
| @@ -79,10 +79,12 @@ | ||
| 79 | 79 |          if ($sortable !== null) { | 
| 80 | 80 | uksort($sortable, array($this, 'mycompare')); | 
| 81 | 81 |              foreach ($sortable as $prop => $vals) { | 
| 82 | - if (is_array($prop)) // the ConceptProperty objects have their own sorting methods | |
| 82 | +                if (is_array($prop)) { | |
| 83 | + // the ConceptProperty objects have their own sorting methods | |
| 83 | 84 |                  { | 
| 84 | 85 | ksort($sortable[$prop]); | 
| 85 | 86 | } | 
| 87 | + } | |
| 86 | 88 | } | 
| 87 | 89 | } | 
| 88 | 90 | return $sortable; | 
| @@ -124,8 +124,8 @@ | ||
| 124 | 124 | */ | 
| 125 | 125 | public function getEnvLang() | 
| 126 | 126 |      { | 
| 127 | - // get language from locale, same as used by gettext, set by Controller | |
| 128 | -       return substr(getenv("LC_ALL"), 0, 2); // @codeCoverageIgnore | |
| 127 | + // get language from locale, same as used by gettext, set by Controller | |
| 128 | +        return substr(getenv("LC_ALL"), 0, 2); // @codeCoverageIgnore | |
| 129 | 129 | } | 
| 130 | 130 | |
| 131 | 131 | /** |