Passed
Pull Request — master (#1197)
by Osma
03:50
created
model/DataObject.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -50,9 +50,9 @@  discard block
 block discarded – undo
50 50
                 $exsparql = $exvoc->getSparql();
51 51
                 $results = $exsparql->queryLabel($exuri, $lang);
52 52
                 return isset($results[$lang]) ? $results[$lang] : null;
53
-            } catch (EasyRdf\Http\Exception | EasyRdf\Exception | Throwable $e) {
53
+            } catch (EasyRdf\Http\Exception |  EasyRdf\Exception | Throwable $e) {
54 54
                 if ($this->model->getConfig()->getLogCaughtExceptions()) {
55
-                    error_log('Caught exception: ' . $e->getMessage());
55
+                    error_log('Caught exception: '.$e->getMessage());
56 56
                 }
57 57
             }
58 58
         }
@@ -72,9 +72,9 @@  discard block
 block discarded – undo
72 72
                 $exsparql = $exvoc->getSparql();
73 73
                 $results = $exsparql->queryNotation($exuri);
74 74
                 return isset($results) ? $results : null;
75
-            } catch (EasyRdf\Http\Exception | EasyRdf\Exception | Throwable $e) {
75
+            } catch (EasyRdf\Http\Exception |  EasyRdf\Exception | Throwable $e) {
76 76
                 if ($this->model->getConfig()->getLogCaughtExceptions()) {
77
-                    error_log('Caught exception: ' . $e->getMessage());
77
+                    error_log('Caught exception: '.$e->getMessage());
78 78
                 }
79 79
             }
80 80
         }
Please login to merge, or discard this patch.
model/Model.php 2 patches
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -220,18 +220,18 @@  discard block
 block discarded – undo
220 220
         }
221 221
 
222 222
         $vocabs = $params->getVocabs();
223
-        $showDeprecated=false;
223
+        $showDeprecated = false;
224 224
         if (sizeof($vocabs) === 1) { // search within vocabulary
225 225
             $voc = $vocabs[0];
226 226
             $sparql = $voc->getSparql();
227
-            $showDeprecated=$voc->getConfig()->getShowDeprecated();
227
+            $showDeprecated = $voc->getConfig()->getShowDeprecated();
228 228
         } else { // multi-vocabulary or global search
229 229
             $voc = null;
230 230
             $sparql = $this->getDefaultSparql();
231 231
             // @TODO : in a global search showDeprecated will always be false and cannot be set globally
232 232
         }
233 233
 
234
-        $results = $sparql->queryConcepts($vocabs, $params->getAdditionalFields(), $params->getUnique(), $params,$showDeprecated);
234
+        $results = $sparql->queryConcepts($vocabs, $params->getAdditionalFields(), $params->getUnique(), $params, $showDeprecated);
235 235
         if ($params->getRest() && $results && $params->getSearchLimit() !== 0) {
236 236
           $results = array_slice($results, $params->getOffset(), $params->getSearchLimit());
237 237
         }
@@ -386,7 +386,7 @@  discard block
 block discarded – undo
386 386
     public function getVocabularyCategories()
387 387
     {
388 388
         $cats = $this->globalConfig->getGraph()->allOfType('skos:Concept');
389
-        if(empty($cats)) {
389
+        if (empty($cats)) {
390 390
             return array(new VocabularyCategory($this, null));
391 391
         }
392 392
 
@@ -467,9 +467,9 @@  discard block
 block discarded – undo
467 467
         }
468 468
 
469 469
         // if there are multiple vocabularies and one is the preferred vocabulary, return it
470
-        if($preferredVocabId != null) {
470
+        if ($preferredVocabId != null) {
471 471
             foreach ($vocabs as $vocab) {
472
-                if($vocab->getId() == $preferredVocabId) {
472
+                if ($vocab->getId() == $preferredVocabId) {
473 473
                     try {
474 474
                         // double check that a label exists in the preferred vocabulary
475 475
                         if ($vocab->getConceptLabel($uri, null) !== null) {
@@ -478,9 +478,9 @@  discard block
 block discarded – undo
478 478
                             // not found in preferred vocabulary, fall back to next method
479 479
                             break;
480 480
                         }
481
-                    } catch (EasyRdf\Http\Exception | EasyRdf\Exception | Throwable $e) {
481
+                    } catch (EasyRdf\Http\Exception |  EasyRdf\Exception | Throwable $e) {
482 482
                         if ($this->getConfig()->getLogCaughtExceptions()) {
483
-                            error_log('Caught exception: ' . $e->getMessage());
483
+                            error_log('Caught exception: '.$e->getMessage());
484 484
                         }
485 485
                         break;
486 486
                     }
@@ -494,9 +494,9 @@  discard block
 block discarded – undo
494 494
                 if ($vocab->getConceptLabel($uri, null) !== null) {
495 495
                     return $vocab;
496 496
                 }
497
-            } catch (EasyRdf\Http\Exception | EasyRdf\Exception | Throwable $e) {
497
+            } catch (EasyRdf\Http\Exception |  EasyRdf\Exception | Throwable $e) {
498 498
                 if ($this->getConfig()->getLogCaughtExceptions()) {
499
-                    error_log('Caught exception: ' . $e->getMessage());
499
+                    error_log('Caught exception: '.$e->getMessage());
500 500
                 }
501 501
                 break;
502 502
             }
@@ -566,7 +566,7 @@  discard block
 block discarded – undo
566 566
         // using apc cache for the resource if available
567 567
         if ($this->globalConfig->getCache()->isAvailable()) {
568 568
             // @codeCoverageIgnoreStart
569
-            $key = 'fetch: ' . $uri;
569
+            $key = 'fetch: '.$uri;
570 570
             $resource = $this->globalConfig->getCache()->fetch($key);
571 571
             if ($resource === null || $resource === false) { // was not found in cache, or previous request failed
572 572
                 $resource = $this->resolver->resolve($uri, $this->getConfig()->getHttpTimeout());
@@ -587,7 +587,7 @@  discard block
 block discarded – undo
587 587
      */
588 588
     public function getSparqlImplementation($dialect, $endpoint, $graph)
589 589
     {
590
-        $classname = $dialect . "Sparql";
590
+        $classname = $dialect."Sparql";
591 591
 
592 592
         return new $classname($endpoint, $graph, $this);
593 593
     }
Please login to merge, or discard this patch.
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -354,10 +354,12 @@
 block discarded – undo
354 354
                 // register vocabulary ids as RDF namespace prefixes
355 355
                 $prefix = preg_replace('/\W+/', '', $voc->getId()); // strip non-word characters
356 356
                 try {
357
-                    if ($prefix != '' && EasyRdf\RdfNamespace::get($prefix) === null) // if not already defined
357
+                    if ($prefix != '' && EasyRdf\RdfNamespace::get($prefix) === null) {
358
+                      // if not already defined
358 359
                     {
359 360
                         EasyRdf\RdfNamespace::set($prefix, $voc->getUriSpace());
360 361
                     }
362
+                    }
361 363
 
362 364
                 } catch (Exception $e) {
363 365
                     // not valid as namespace identifier, ignore
Please login to merge, or discard this patch.
controller/WebController.php 1 patch
Spacing   +24 added lines, -24 removed lines patch added patch discarded remove patch
@@ -37,7 +37,7 @@  discard block
 block discarded – undo
37 37
         // specify where to look for templates and cache
38 38
         $loader = new Twig_Loader_Filesystem('view');
39 39
         // initialize Twig environment
40
-        $this->twig = new Twig_Environment($loader, array('cache' => $tmpDir,'auto_reload' => true));
40
+        $this->twig = new Twig_Environment($loader, array('cache' => $tmpDir, 'auto_reload' => true));
41 41
         $this->twig->addExtension(new Twig_Extensions_Extension_I18n());
42 42
         // used for setting the base href for the relative urls
43 43
         $this->twig->addGlobal("BaseHref", $this->getBaseHref());
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
60 60
         $this->twig->addFilter(new Twig_SimpleFilter('link_url', array($this, 'linkUrlFilter')));
61 61
 
62 62
         // register a Twig filter for generating strings from language codes with CLDR
63
-        $langFilter = new Twig_SimpleFilter('lang_name', function ($langcode, $lang) {
63
+        $langFilter = new Twig_SimpleFilter('lang_name', function($langcode, $lang) {
64 64
             return Language::getName($langcode, $lang);
65 65
         });
66 66
         $this->twig->addFilter($langFilter);
@@ -234,16 +234,16 @@  discard block
 block discarded – undo
234 234
 
235 235
     private function createFeedbackHeaders($fromName, $fromEmail, $toMail, $sender)
236 236
     {
237
-        $headers = "MIME-Version: 1.0" . "\r\n";
238
-        $headers .= "Content-type: text/html; charset=UTF-8" . "\r\n";
237
+        $headers = "MIME-Version: 1.0"."\r\n";
238
+        $headers .= "Content-type: text/html; charset=UTF-8"."\r\n";
239 239
         if (!empty($toMail)) {
240
-            $headers .= "Cc: " . $this->model->getConfig()->getFeedbackAddress() . "\r\n";
240
+            $headers .= "Cc: ".$this->model->getConfig()->getFeedbackAddress()."\r\n";
241 241
         }
242 242
         if (!empty($fromEmail)) {
243 243
             $headers .= "Reply-To: $fromName <$fromEmail>\r\n";
244 244
         }
245 245
         $service = $this->model->getConfig()->getServiceName();
246
-        return $headers . "From: $fromName via $service <$sender>";
246
+        return $headers."From: $fromName via $service <$sender>";
247 247
     }
248 248
 
249 249
     /**
@@ -257,9 +257,9 @@  discard block
 block discarded – undo
257 257
     public function sendFeedback($request, $message, $messageSubject, $fromName = null, $fromEmail = null, $fromVocab = null, $toMail = null)
258 258
     {
259 259
         $toAddress = ($toMail) ? $toMail : $this->model->getConfig()->getFeedbackAddress();
260
-        $messageSubject = "[" . $this->model->getConfig()->getServiceName() . "] " . $messageSubject;
260
+        $messageSubject = "[".$this->model->getConfig()->getServiceName()."] ".$messageSubject;
261 261
         if ($fromVocab !== null && $fromVocab !== '') {
262
-            $message = 'Feedback from vocab: ' . strtoupper($fromVocab) . "<br />" . $message;
262
+            $message = 'Feedback from vocab: '.strtoupper($fromVocab)."<br />".$message;
263 263
         }
264 264
         $envelopeSender = $this->model->getConfig()->getFeedbackEnvelopeSender();
265 265
         // determine the sender address of the message
@@ -272,10 +272,10 @@  discard block
 block discarded – undo
272 272
         $headers = $this->createFeedbackHeaders($fromName, $fromEmail, $toMail, $sender);
273 273
         $params = empty($envelopeSender) ? '' : "-f $envelopeSender";
274 274
         // adding some information about the user for debugging purposes.
275
-        $message = $message . "<br /><br /> Debugging information:"
276
-            . "<br />Timestamp: " . date(DATE_RFC2822)
277
-            . "<br />User agent: " . $request->getServerConstant('HTTP_USER_AGENT')
278
-            . "<br />Referer: " . $request->getServerConstant('HTTP_REFERER');
275
+        $message = $message."<br /><br /> Debugging information:"
276
+            . "<br />Timestamp: ".date(DATE_RFC2822)
277
+            . "<br />User agent: ".$request->getServerConstant('HTTP_USER_AGENT')
278
+            . "<br />Referer: ".$request->getServerConstant('HTTP_REFERER');
279 279
 
280 280
         try {
281 281
             mail($toAddress, $messageSubject, $message, $headers, $params);
@@ -283,7 +283,7 @@  discard block
 block discarded – undo
283 283
             header("HTTP/1.0 404 Not Found");
284 284
             $template = $this->twig->loadTemplate('error-page.twig');
285 285
             if ($this->model->getConfig()->getLogCaughtExceptions()) {
286
-                error_log('Caught exception: ' . $e->getMessage());
286
+                error_log('Caught exception: '.$e->getMessage());
287 287
             }
288 288
 
289 289
             echo $template->render(
@@ -328,7 +328,7 @@  discard block
 block discarded – undo
328 328
         $vocids = ($vocabs !== null && $vocabs !== '') ? explode(' ', $vocabs) : null;
329 329
         $vocabObjects = array();
330 330
         if ($vocids) {
331
-            foreach($vocids as $vocid) {
331
+            foreach ($vocids as $vocid) {
332 332
                 try {
333 333
                     $vocabObjects[] = $this->model->getVocabulary($vocid);
334 334
                 } catch (ValueError $e) {
@@ -348,7 +348,7 @@  discard block
 block discarded – undo
348 348
                 $vocabObjects = $this->model->getVocabularies();
349 349
             }
350 350
             $defaultEndpoint = $this->model->getConfig()->getDefaultEndpoint();
351
-            foreach($vocabObjects as $voc) {
351
+            foreach ($vocabObjects as $voc) {
352 352
                 if ($voc->getEndpoint() !== $defaultEndpoint) {
353 353
                     $nondefaultEndpointVocs[] = $voc;
354 354
                 }
@@ -367,7 +367,7 @@  discard block
 block discarded – undo
367 367
             $errored = true;
368 368
             header("HTTP/1.0 500 Internal Server Error");
369 369
             if ($this->model->getConfig()->getLogCaughtExceptions()) {
370
-                error_log('Caught exception: ' . $e->getMessage());
370
+                error_log('Caught exception: '.$e->getMessage());
371 371
             }
372 372
         }
373 373
         $vocabList = $this->model->getVocabularyList();
@@ -379,7 +379,7 @@  discard block
 block discarded – undo
379 379
                 'search_count' => $counts,
380 380
                 'languages' => $this->languages,
381 381
                 'search_results' => $searchResults,
382
-                'rest' => $parameters->getOffset()>0,
382
+                'rest' => $parameters->getOffset() > 0,
383 383
                 'global_search' => true,
384 384
                 'search_failed' => $errored,
385 385
                 'skipped_vocabs' => $nondefaultEndpointVocs,
@@ -407,7 +407,7 @@  discard block
 block discarded – undo
407 407
         } catch (Exception $e) {
408 408
             header("HTTP/1.0 500 Internal Server Error");
409 409
             if ($this->model->getConfig()->getLogCaughtExceptions()) {
410
-                error_log('Caught exception: ' . $e->getMessage());
410
+                error_log('Caught exception: '.$e->getMessage());
411 411
             }
412 412
 
413 413
             echo $template->render(
@@ -431,7 +431,7 @@  discard block
 block discarded – undo
431 431
         } catch (Exception $e) {
432 432
             header("HTTP/1.0 404 Not Found");
433 433
             if ($this->model->getConfig()->getLogCaughtExceptions()) {
434
-                error_log('Caught exception: ' . $e->getMessage());
434
+                error_log('Caught exception: '.$e->getMessage());
435 435
             }
436 436
 
437 437
             echo $template->render(
@@ -449,7 +449,7 @@  discard block
 block discarded – undo
449 449
                 'vocab' => $vocab,
450 450
                 'search_results' => $searchResults,
451 451
                 'search_count' => $counts,
452
-                'rest' => $parameters->getOffset()>0,
452
+                'rest' => $parameters->getOffset() > 0,
453 453
                 'limit_parent' => $parameters->getParentLimit(),
454 454
                 'limit_type' =>  $request->getQueryParam('type') ? explode('+', $request->getQueryParam('type')) : null,
455 455
                 'limit_group' => $parameters->getGroupLimit(),
@@ -581,7 +581,7 @@  discard block
 block discarded – undo
581 581
      * Loads and renders the view containing a list of recent changes in the vocabulary.
582 582
      * @param Request $request
583 583
      */
584
-    public function invokeChangeList($request, $prop='dc:created')
584
+    public function invokeChangeList($request, $prop = 'dc:created')
585 585
     {
586 586
         $offset = ($request->getQueryParam('offset') && is_numeric($request->getQueryParam('offset')) && $request->getQueryParam('offset') >= 0) ? $request->getQueryParam('offset') : 0;
587 587
         $limit = ($request->getQueryParam('limit') && is_numeric($request->getQueryParam('limit')) && $request->getQueryParam('limit') >= 0) ? $request->getQueryParam('limit') : 200;
@@ -609,7 +609,7 @@  discard block
 block discarded – undo
609 609
      * @param int $limit maximum number of concepts to return
610 610
      * @return Array list of concepts
611 611
      */
612
-    public function getChangeList($request, $prop, $offset=0, $limit=200)
612
+    public function getChangeList($request, $prop, $offset = 0, $limit = 200)
613 613
     {
614 614
         // set language parameters for gettext
615 615
         $this->setLanguageProperties($request->getLang());
@@ -626,9 +626,9 @@  discard block
 block discarded – undo
626 626
     public function formatChangeList($changeList, $lang)
627 627
     {
628 628
         $formatByDate = array();
629
-        foreach($changeList as $concept) {
629
+        foreach ($changeList as $concept) {
630 630
             $concept['datestring'] = Punic\Calendar::formatDate($concept['date'], 'medium', $lang);
631
-            $formatByDate[Punic\Calendar::getMonthName($concept['date'], 'wide', $lang, true) . Punic\Calendar::format($concept['date'], ' y', $lang) ][strtolower($concept['prefLabel'])] = $concept;
631
+            $formatByDate[Punic\Calendar::getMonthName($concept['date'], 'wide', $lang, true).Punic\Calendar::format($concept['date'], ' y', $lang)][strtolower($concept['prefLabel'])] = $concept;
632 632
         }
633 633
         return $formatByDate;
634 634
     }
Please login to merge, or discard this patch.