Passed
Pull Request — master (#1266)
by Osma
04:30 queued 01:09
created
model/sparql/GenericSparql.php 1 patch
Spacing   +52 added lines, -52 removed lines patch added patch discarded remove patch
@@ -88,11 +88,11 @@  discard block
 block discarded – undo
88 88
     protected function query($query) {
89 89
         $queryId = sprintf("%05d", rand(0, 99999));
90 90
         $logger = $this->model->getLogger();
91
-        $logger->info("[qid $queryId] SPARQL query:\n" . $this->generateQueryPrefixes($query) . "\n$query\n");
91
+        $logger->info("[qid $queryId] SPARQL query:\n".$this->generateQueryPrefixes($query)."\n$query\n");
92 92
         $starttime = microtime(true);
93 93
         $result = $this->client->query($query);
94 94
         $elapsed = intval(round((microtime(true) - $starttime) * 1000));
95
-        if(method_exists($result, 'numRows')) {
95
+        if (method_exists($result, 'numRows')) {
96 96
             $numRows = $result->numRows();
97 97
             $logger->info("[qid $queryId] result: $numRows rows returned in $elapsed ms");
98 98
         } else { // graph result
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
108 108
      * @param Vocabulary[]|null $vocabs
109 109
      * @return string
110 110
      */
111
-    protected function generateFromClause($vocabs=null) {
111
+    protected function generateFromClause($vocabs = null) {
112 112
         $clause = '';
113 113
         if (!$vocabs) {
114 114
             return $this->graph !== '?graph' && $this->graph !== NULL ? "FROM <$this->graph>" : '';
@@ -249,7 +249,7 @@  discard block
 block discarded – undo
249 249
 
250 250
 	$quote_string = function($val) { return "'$val'"; };
251 251
 	$quoted_values = array_map($quote_string, $langs);
252
-	$langFilter = "FILTER(?lang IN (" . implode(',', $quoted_values) . "))";
252
+	$langFilter = "FILTER(?lang IN (".implode(',', $quoted_values)."))";
253 253
 
254 254
         $values = $this->formatValues('?type', $classes, 'uri');
255 255
         $valuesProp = $this->formatValues('?prop', $props, null);
@@ -693,9 +693,9 @@  discard block
 block discarded – undo
693 693
                 $conceptscheme['title'] = $row->title->getValue();
694 694
             }
695 695
             // add dct:subject and their labels in the result
696
-            if(isset($row->domain) && isset($row->domainLabel)){
697
-                $conceptscheme['subject']['uri']=$row->domain->getURI();
698
-                $conceptscheme['subject']['prefLabel']=$row->domainLabel->getValue();
696
+            if (isset($row->domain) && isset($row->domainLabel)) {
697
+                $conceptscheme['subject']['uri'] = $row->domain->getURI();
698
+                $conceptscheme['subject']['prefLabel'] = $row->domainLabel->getValue();
699 699
             }
700 700
 
701 701
             $ret[$row->cs->getURI()] = $conceptscheme;
@@ -762,7 +762,7 @@  discard block
 block discarded – undo
762 762
           $values[] = "<$graph>";
763 763
         }
764 764
         if (count($values)) {
765
-          return "FILTER (?graph IN (" . implode(',', $values) . "))";
765
+          return "FILTER (?graph IN (".implode(',', $values)."))";
766 766
         }
767 767
     }
768 768
 
@@ -773,16 +773,16 @@  discard block
 block discarded – undo
773 773
      * @return string sparql query clauses
774 774
      */
775 775
     protected function formatLimitAndOffset($limit, $offset) {
776
-        $limit = ($limit) ? 'LIMIT ' . $limit : '';
777
-        $offset = ($offset) ? 'OFFSET ' . $offset : '';
776
+        $limit = ($limit) ? 'LIMIT '.$limit : '';
777
+        $offset = ($offset) ? 'OFFSET '.$offset : '';
778 778
         // eliminating whitespace and line changes when the conditions aren't needed.
779 779
         $limitandoffset = '';
780 780
         if ($limit && $offset) {
781
-            $limitandoffset = "\n" . $limit . "\n" . $offset;
781
+            $limitandoffset = "\n".$limit."\n".$offset;
782 782
         } elseif ($limit) {
783
-            $limitandoffset = "\n" . $limit;
783
+            $limitandoffset = "\n".$limit;
784 784
         } elseif ($offset) {
785
-            $limitandoffset = "\n" . $offset;
785
+            $limitandoffset = "\n".$offset;
786 786
         }
787 787
 
788 788
         return $limitandoffset;
@@ -934,14 +934,14 @@  discard block
 block discarded – undo
934 934
         // if search language and UI/display language differ, must also consider case where there is no prefLabel in
935 935
         // the display language; in that case, should use the label with the same language as the matched label
936 936
         $labelcondFallback = ($searchLang != $lang) ?
937
-          "OPTIONAL { # in case previous OPTIONAL block gives no labels\n" .
937
+          "OPTIONAL { # in case previous OPTIONAL block gives no labels\n".
938 938
           "?s skos:prefLabel ?label . FILTER (LANGMATCHES(LANG(?label), LANG(?match))) }" : "";
939 939
 
940 940
         //  Including the labels if there is no query term given.
941 941
         if ($rawterm === '') {
942 942
           $labelClause = "?s skos:prefLabel ?label .";
943
-          $labelClause = ($lang) ? $labelClause . " FILTER (LANGMATCHES(LANG(?label), '$lang'))" : $labelClause . "";
944
-          return $labelClause . " BIND(?label AS ?match)";
943
+          $labelClause = ($lang) ? $labelClause." FILTER (LANGMATCHES(LANG(?label), '$lang'))" : $labelClause."";
944
+          return $labelClause." BIND(?label AS ?match)";
945 945
         }
946 946
 
947 947
         /*
@@ -1013,20 +1013,20 @@  discard block
 block discarded – undo
1013 1013
         $schemecond = '';
1014 1014
         if (!empty($schemes)) {
1015 1015
             $conditions = array();
1016
-            foreach($schemes as $scheme) {
1016
+            foreach ($schemes as $scheme) {
1017 1017
                 $conditions[] = "{?s skos:inScheme <$scheme>}";
1018 1018
             }
1019
-            $schemecond = '{'.implode(" UNION ",$conditions).'}';
1019
+            $schemecond = '{'.implode(" UNION ", $conditions).'}';
1020 1020
         }
1021
-        $filterDeprecated="";
1021
+        $filterDeprecated = "";
1022 1022
         //show or hide deprecated concepts
1023
-        if(!$showDeprecated){
1024
-            $filterDeprecated="FILTER NOT EXISTS { ?s owl:deprecated true }";
1023
+        if (!$showDeprecated) {
1024
+            $filterDeprecated = "FILTER NOT EXISTS { ?s owl:deprecated true }";
1025 1025
         }
1026 1026
         // extra conditions for parent and group, if specified
1027
-        $parentcond = ($params->getParentLimit()) ? "?s skos:broader+ <" . $params->getParentLimit() . "> ." : "";
1028
-        $groupcond = ($params->getGroupLimit()) ? "<" . $params->getGroupLimit() . "> skos:member ?s ." : "";
1029
-        $pgcond = $parentcond . $groupcond;
1027
+        $parentcond = ($params->getParentLimit()) ? "?s skos:broader+ <".$params->getParentLimit()."> ." : "";
1028
+        $groupcond = ($params->getGroupLimit()) ? "<".$params->getGroupLimit()."> skos:member ?s ." : "";
1029
+        $pgcond = $parentcond.$groupcond;
1030 1030
 
1031 1031
         $orderextra = $this->isDefaultEndpoint() ? $this->graph : '';
1032 1032
 
@@ -1112,9 +1112,9 @@  discard block
 block discarded – undo
1112 1112
             $hit['type'][] = $this->shortenUri($typeuri);
1113 1113
         }
1114 1114
 
1115
-        if(!empty($fields)) {
1115
+        if (!empty($fields)) {
1116 1116
             foreach ($fields as $prop) {
1117
-                $propname = $prop . 's';
1117
+                $propname = $prop.'s';
1118 1118
                 if (isset($row->$propname)) {
1119 1119
                     foreach (explode("\n", $row->$propname->getValue()) as $line) {
1120 1120
                         $rdata = str_getcsv($line, ',', '"', '"');
@@ -1129,7 +1129,7 @@  discard block
 block discarded – undo
1129 1129
                             $propvals = $rdata[2];
1130 1130
                         }
1131 1131
 
1132
-                        $hit['skos:' . $prop][] = $propvals;
1132
+                        $hit['skos:'.$prop][] = $propvals;
1133 1133
                     }
1134 1134
                 }
1135 1135
             }
@@ -1205,7 +1205,7 @@  discard block
 block discarded – undo
1205 1205
      * @return array query result object
1206 1206
      */
1207 1207
     public function queryConcepts($vocabs, $fields, $unique, $params, $showDeprecated = false) {
1208
-        $query = $this->generateConceptSearchQuery($fields, $unique, $params,$showDeprecated);
1208
+        $query = $this->generateConceptSearchQuery($fields, $unique, $params, $showDeprecated);
1209 1209
         $results = $this->query($query);
1210 1210
         return $this->transformConceptSearchResults($results, $vocabs, $fields);
1211 1211
     }
@@ -1260,10 +1260,10 @@  discard block
 block discarded – undo
1260 1260
         $conditions = $this->formatFilterConditions($letter, $lang);
1261 1261
         $filtercondLabel = $conditions['filterpref'];
1262 1262
         $filtercondALabel = $conditions['filteralt'];
1263
-        $qualifierClause = $qualifier ? "OPTIONAL { ?s <" . $qualifier->getURI() . "> ?qualifier }" : "";
1264
-        $filterDeprecated="";
1265
-        if(!$showDeprecated){
1266
-            $filterDeprecated="FILTER NOT EXISTS { ?s owl:deprecated true }";
1263
+        $qualifierClause = $qualifier ? "OPTIONAL { ?s <".$qualifier->getURI()."> ?qualifier }" : "";
1264
+        $filterDeprecated = "";
1265
+        if (!$showDeprecated) {
1266
+            $filterDeprecated = "FILTER NOT EXISTS { ?s owl:deprecated true }";
1267 1267
         }
1268 1268
         $query = <<<EOQ
1269 1269
 SELECT DISTINCT ?s ?label ?alabel ?qualifier
@@ -1740,7 +1740,7 @@  discard block
 block discarded – undo
1740 1740
                 if (!isset($row->label) || $row->label->getLang() === $lang) {
1741 1741
                     $ret[$row->object->getUri()] = $val;
1742 1742
                 } elseif ($row->label->getLang() === $fallbacklang) {
1743
-                    $val['label'] .= ' (' . $row->label->getLang() . ')';
1743
+                    $val['label'] .= ' ('.$row->label->getLang().')';
1744 1744
                     $ret[$row->object->getUri()] = $val;
1745 1745
                 }
1746 1746
             }
@@ -1836,10 +1836,10 @@  discard block
 block discarded – undo
1836 1836
 
1837 1837
             $label = null;
1838 1838
             if (isset($row->label)) {
1839
-                if ($row->label->getLang() == $lang || strpos($row->label->getLang(), $lang . "-") == 0) {
1839
+                if ($row->label->getLang() == $lang || strpos($row->label->getLang(), $lang."-") == 0) {
1840 1840
                     $label = $row->label->getValue();
1841 1841
                 } else {
1842
-                    $label = $row->label->getValue() . " (" . $row->label->getLang() . ")";
1842
+                    $label = $row->label->getValue()." (".$row->label->getLang().")";
1843 1843
                 }
1844 1844
 
1845 1845
             }
@@ -1915,8 +1915,8 @@  discard block
 block discarded – undo
1915 1915
         foreach ($result as $row) {
1916 1916
             if (isset($row->top) && isset($row->label)) {
1917 1917
                 $label = $row->label->getValue();
1918
-                if ($row->label->getLang() && $row->label->getLang() !== $lang && strpos($row->label->getLang(), $lang . "-") !== 0) {
1919
-                    $label .= ' (' . $row->label->getLang() . ')';
1918
+                if ($row->label->getLang() && $row->label->getLang() !== $lang && strpos($row->label->getLang(), $lang."-") !== 0) {
1919
+                    $label .= ' ('.$row->label->getLang().')';
1920 1920
                 }
1921 1921
                 $top = array('uri' => $row->top->getUri(), 'topConceptOf' => $row->topuri->getUri(), 'label' => $label, 'hasChildren' => filter_var($row->children->getValue(), FILTER_VALIDATE_BOOLEAN));
1922 1922
                 if (isset($row->notation)) {
@@ -2009,7 +2009,7 @@  discard block
 block discarded – undo
2009 2009
                 $ret[$uri]['exact'] = $row->exact->getUri();
2010 2010
             }
2011 2011
             if (isset($row->tops)) {
2012
-               $topConceptsList=explode(" ", $row->tops->getValue());
2012
+               $topConceptsList = explode(" ", $row->tops->getValue());
2013 2013
                // sort to guarantee an alphabetical ordering of the URI
2014 2014
                sort($topConceptsList);
2015 2015
                $ret[$uri]['tops'] = $topConceptsList;
@@ -2022,8 +2022,8 @@  discard block
 block discarded – undo
2022 2022
                 $label = null;
2023 2023
                 if (isset($row->childlabel)) {
2024 2024
                     $label = $row->childlabel->getValue();
2025
-                    if ($row->childlabel->getLang() !== $lang && strpos($row->childlabel->getLang(), $lang . "-") !== 0) {
2026
-                        $label .= " (" . $row->childlabel->getLang() . ")";
2025
+                    if ($row->childlabel->getLang() !== $lang && strpos($row->childlabel->getLang(), $lang."-") !== 0) {
2026
+                        $label .= " (".$row->childlabel->getLang().")";
2027 2027
                     }
2028 2028
 
2029 2029
                 }
@@ -2044,8 +2044,8 @@  discard block
 block discarded – undo
2044 2044
             }
2045 2045
             if (isset($row->label)) {
2046 2046
                 $preflabel = $row->label->getValue();
2047
-                if ($row->label->getLang() && $row->label->getLang() !== $lang && strpos($row->label->getLang(), $lang . "-") !== 0) {
2048
-                    $preflabel .= ' (' . $row->label->getLang() . ')';
2047
+                if ($row->label->getLang() && $row->label->getLang() !== $lang && strpos($row->label->getLang(), $lang."-") !== 0) {
2048
+                    $preflabel .= ' ('.$row->label->getLang().')';
2049 2049
                 }
2050 2050
 
2051 2051
                 $ret[$uri]['prefLabel'] = $preflabel;
@@ -2166,9 +2166,9 @@  discard block
 block discarded – undo
2166 2166
      */
2167 2167
     private function generateConceptGroupContentsQuery($groupClass, $group, $lang, $showDeprecated = false) {
2168 2168
         $fcl = $this->generateFromClause();
2169
-        $filterDeprecated="";
2170
-        if(!$showDeprecated){
2171
-            $filterDeprecated="  FILTER NOT EXISTS { ?conc owl:deprecated true }";
2169
+        $filterDeprecated = "";
2170
+        if (!$showDeprecated) {
2171
+            $filterDeprecated = "  FILTER NOT EXISTS { ?conc owl:deprecated true }";
2172 2172
         }
2173 2173
         $query = <<<EOQ
2174 2174
 SELECT ?conc ?super ?label ?members ?type ?notation $fcl
@@ -2207,10 +2207,10 @@  discard block
 block discarded – undo
2207 2207
                     'type' => array($row->type->shorten()),
2208 2208
                 );
2209 2209
                 if (isset($row->label)) {
2210
-                    if ($row->label->getLang() == $lang || strpos($row->label->getLang(), $lang . "-") == 0) {
2210
+                    if ($row->label->getLang() == $lang || strpos($row->label->getLang(), $lang."-") == 0) {
2211 2211
                         $values[$row->conc->getURI()]['prefLabel'] = $row->label->getValue();
2212 2212
                     } else {
2213
-                        $values[$row->conc->getURI()]['prefLabel'] = $row->label->getValue() . " (" . $row->label->getLang() . ")";
2213
+                        $values[$row->conc->getURI()]['prefLabel'] = $row->label->getValue()." (".$row->label->getLang().")";
2214 2214
                     }
2215 2215
 
2216 2216
                 }
@@ -2238,8 +2238,8 @@  discard block
 block discarded – undo
2238 2238
      * @param boolean $showDeprecated whether to include deprecated concepts in search results
2239 2239
      * @return array Result array with concept URI as key and concept label as value
2240 2240
      */
2241
-    public function listConceptGroupContents($groupClass, $group, $lang,$showDeprecated = false) {
2242
-        $query = $this->generateConceptGroupContentsQuery($groupClass, $group, $lang,$showDeprecated);
2241
+    public function listConceptGroupContents($groupClass, $group, $lang, $showDeprecated = false) {
2242
+        $query = $this->generateConceptGroupContentsQuery($groupClass, $group, $lang, $showDeprecated);
2243 2243
         $result = $this->query($query);
2244 2244
         return $this->transformConceptGroupContentsResults($result, $lang);
2245 2245
     }
@@ -2253,9 +2253,9 @@  discard block
 block discarded – undo
2253 2253
      * @param boolean $showDeprecated whether to include deprecated concepts in the change list
2254 2254
      * @return string sparql query
2255 2255
      */
2256
-    private function generateChangeListQuery($prop, $lang, $offset, $limit=200, $showDeprecated=false) {
2256
+    private function generateChangeListQuery($prop, $lang, $offset, $limit = 200, $showDeprecated = false) {
2257 2257
         $fcl = $this->generateFromClause();
2258
-        $offset = ($offset) ? 'OFFSET ' . $offset : '';
2258
+        $offset = ($offset) ? 'OFFSET '.$offset : '';
2259 2259
 
2260 2260
         //Additional clauses when deprecated concepts need to be included in the results
2261 2261
         $deprecatedOptions = '';
@@ -2333,7 +2333,7 @@  discard block
 block discarded – undo
2333 2333
      * @param boolean $showDeprecated whether to include deprecated concepts in the change list
2334 2334
      * @return array Result array
2335 2335
      */
2336
-    public function queryChangeList($prop, $lang, $offset, $limit, $showDeprecated=false) {
2336
+    public function queryChangeList($prop, $lang, $offset, $limit, $showDeprecated = false) {
2337 2337
         $query = $this->generateChangeListQuery($prop, $lang, $offset, $limit, $showDeprecated);
2338 2338
 
2339 2339
         $result = $this->query($query);
Please login to merge, or discard this patch.