Passed
Pull Request — master (#1327)
by
unknown
03:11
created
model/sparql/GenericSparql.php 1 patch
Spacing   +52 added lines, -52 removed lines patch added patch discarded remove patch
@@ -88,11 +88,11 @@  discard block
 block discarded – undo
88 88
     protected function query($query) {
89 89
         $queryId = sprintf("%05d", rand(0, 99999));
90 90
         $logger = $this->model->getLogger();
91
-        $logger->info("[qid $queryId] SPARQL query:\n" . $this->generateQueryPrefixes($query) . "\n$query\n");
91
+        $logger->info("[qid $queryId] SPARQL query:\n".$this->generateQueryPrefixes($query)."\n$query\n");
92 92
         $starttime = microtime(true);
93 93
         $result = $this->client->query($query);
94 94
         $elapsed = intval(round((microtime(true) - $starttime) * 1000));
95
-        if(method_exists($result, 'numRows')) {
95
+        if (method_exists($result, 'numRows')) {
96 96
             $numRows = $result->numRows();
97 97
             $logger->info("[qid $queryId] result: $numRows rows returned in $elapsed ms");
98 98
         } else { // graph result
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
108 108
      * @param Vocabulary[]|null $vocabs
109 109
      * @return string
110 110
      */
111
-    protected function generateFromClause($vocabs=null) {
111
+    protected function generateFromClause($vocabs = null) {
112 112
         if (!$vocabs) {
113 113
             return $this->graph !== '?graph' && $this->graph !== NULL ? "FROM <$this->graph>" : '';
114 114
         }
@@ -250,7 +250,7 @@  discard block
 block discarded – undo
250 250
 
251 251
 	$quote_string = function($val) { return "'$val'"; };
252 252
 	$quoted_values = array_map($quote_string, $langs);
253
-	$langFilter = "FILTER(?lang IN (" . implode(',', $quoted_values) . "))";
253
+	$langFilter = "FILTER(?lang IN (".implode(',', $quoted_values)."))";
254 254
 
255 255
         $values = $this->formatValues('?type', $classes, 'uri');
256 256
         $valuesProp = $this->formatValues('?prop', $props, null);
@@ -697,9 +697,9 @@  discard block
 block discarded – undo
697 697
                 $conceptscheme['title'] = $row->title->getValue();
698 698
             }
699 699
             // add dct:subject and their labels in the result
700
-            if(isset($row->domain) && isset($row->domainLabel)){
701
-                $conceptscheme['subject']['uri']=$row->domain->getURI();
702
-                $conceptscheme['subject']['prefLabel']=$row->domainLabel->getValue();
700
+            if (isset($row->domain) && isset($row->domainLabel)) {
701
+                $conceptscheme['subject']['uri'] = $row->domain->getURI();
702
+                $conceptscheme['subject']['prefLabel'] = $row->domainLabel->getValue();
703 703
             }
704 704
 
705 705
             $ret[$row->cs->getURI()] = $conceptscheme;
@@ -766,7 +766,7 @@  discard block
 block discarded – undo
766 766
           $values[] = "<$graph>";
767 767
         }
768 768
         if (count($values)) {
769
-          return "FILTER (?graph IN (" . implode(',', $values) . "))";
769
+          return "FILTER (?graph IN (".implode(',', $values)."))";
770 770
         }
771 771
     }
772 772
 
@@ -777,16 +777,16 @@  discard block
 block discarded – undo
777 777
      * @return string sparql query clauses
778 778
      */
779 779
     protected function formatLimitAndOffset($limit, $offset) {
780
-        $limit = ($limit) ? 'LIMIT ' . $limit : '';
781
-        $offset = ($offset) ? 'OFFSET ' . $offset : '';
780
+        $limit = ($limit) ? 'LIMIT '.$limit : '';
781
+        $offset = ($offset) ? 'OFFSET '.$offset : '';
782 782
         // eliminating whitespace and line changes when the conditions aren't needed.
783 783
         $limitandoffset = '';
784 784
         if ($limit && $offset) {
785
-            $limitandoffset = "\n" . $limit . "\n" . $offset;
785
+            $limitandoffset = "\n".$limit."\n".$offset;
786 786
         } elseif ($limit) {
787
-            $limitandoffset = "\n" . $limit;
787
+            $limitandoffset = "\n".$limit;
788 788
         } elseif ($offset) {
789
-            $limitandoffset = "\n" . $offset;
789
+            $limitandoffset = "\n".$offset;
790 790
         }
791 791
 
792 792
         return $limitandoffset;
@@ -938,14 +938,14 @@  discard block
 block discarded – undo
938 938
         // if search language and UI/display language differ, must also consider case where there is no prefLabel in
939 939
         // the display language; in that case, should use the label with the same language as the matched label
940 940
         $labelcondFallback = ($searchLang != $lang) ?
941
-          "OPTIONAL { # in case previous OPTIONAL block gives no labels\n" .
941
+          "OPTIONAL { # in case previous OPTIONAL block gives no labels\n".
942 942
           "?s skos:prefLabel ?label . FILTER (LANGMATCHES(LANG(?label), LANG(?match))) }" : "";
943 943
 
944 944
         //  Including the labels if there is no query term given.
945 945
         if ($rawterm === '') {
946 946
           $labelClause = "?s skos:prefLabel ?label .";
947
-          $labelClause = ($lang) ? $labelClause . " FILTER (LANGMATCHES(LANG(?label), '$lang'))" : $labelClause . "";
948
-          return $labelClause . " BIND(?label AS ?match)";
947
+          $labelClause = ($lang) ? $labelClause." FILTER (LANGMATCHES(LANG(?label), '$lang'))" : $labelClause."";
948
+          return $labelClause." BIND(?label AS ?match)";
949 949
         }
950 950
 
951 951
         /*
@@ -1016,20 +1016,20 @@  discard block
 block discarded – undo
1016 1016
         $schemecond = '';
1017 1017
         if (!empty($schemes)) {
1018 1018
             $conditions = array();
1019
-            foreach($schemes as $scheme) {
1019
+            foreach ($schemes as $scheme) {
1020 1020
                 $conditions[] = "{?s skos:inScheme <$scheme>}";
1021 1021
             }
1022
-            $schemecond = '{'.implode(" UNION ",$conditions).'}';
1022
+            $schemecond = '{'.implode(" UNION ", $conditions).'}';
1023 1023
         }
1024
-        $filterDeprecated="";
1024
+        $filterDeprecated = "";
1025 1025
         //show or hide deprecated concepts
1026
-        if(!$showDeprecated){
1027
-            $filterDeprecated="FILTER NOT EXISTS { ?s owl:deprecated true }";
1026
+        if (!$showDeprecated) {
1027
+            $filterDeprecated = "FILTER NOT EXISTS { ?s owl:deprecated true }";
1028 1028
         }
1029 1029
         // extra conditions for parent and group, if specified
1030
-        $parentcond = ($params->getParentLimit()) ? "?s skos:broader+ <" . $params->getParentLimit() . "> ." : "";
1031
-        $groupcond = ($params->getGroupLimit()) ? "<" . $params->getGroupLimit() . "> skos:member ?s ." : "";
1032
-        $pgcond = $parentcond . $groupcond;
1030
+        $parentcond = ($params->getParentLimit()) ? "?s skos:broader+ <".$params->getParentLimit()."> ." : "";
1031
+        $groupcond = ($params->getGroupLimit()) ? "<".$params->getGroupLimit()."> skos:member ?s ." : "";
1032
+        $pgcond = $parentcond.$groupcond;
1033 1033
 
1034 1034
         $orderextra = $this->isDefaultEndpoint() ? $this->graph : '';
1035 1035
 
@@ -1115,9 +1115,9 @@  discard block
 block discarded – undo
1115 1115
             $hit['type'][] = $this->shortenUri($typeuri);
1116 1116
         }
1117 1117
 
1118
-        if(!empty($fields)) {
1118
+        if (!empty($fields)) {
1119 1119
             foreach ($fields as $prop) {
1120
-                $propname = $prop . 's';
1120
+                $propname = $prop.'s';
1121 1121
                 if (isset($row->$propname)) {
1122 1122
                     foreach (explode("\n", $row->$propname->getValue()) as $line) {
1123 1123
                         $rdata = str_getcsv($line, ',', '"', '"');
@@ -1132,7 +1132,7 @@  discard block
 block discarded – undo
1132 1132
                             $propvals = $rdata[2];
1133 1133
                         }
1134 1134
 
1135
-                        $hit['skos:' . $prop][] = $propvals;
1135
+                        $hit['skos:'.$prop][] = $propvals;
1136 1136
                     }
1137 1137
                 }
1138 1138
             }
@@ -1208,7 +1208,7 @@  discard block
 block discarded – undo
1208 1208
      * @return array query result object
1209 1209
      */
1210 1210
     public function queryConcepts($vocabs, $fields, $unique, $params, $showDeprecated = false) {
1211
-        $query = $this->generateConceptSearchQuery($fields, $unique, $params,$showDeprecated);
1211
+        $query = $this->generateConceptSearchQuery($fields, $unique, $params, $showDeprecated);
1212 1212
         $results = $this->query($query);
1213 1213
         return $this->transformConceptSearchResults($results, $vocabs, $fields);
1214 1214
     }
@@ -1263,10 +1263,10 @@  discard block
 block discarded – undo
1263 1263
         $conditions = $this->formatFilterConditions($letter, $lang);
1264 1264
         $filtercondLabel = $conditions['filterpref'];
1265 1265
         $filtercondALabel = $conditions['filteralt'];
1266
-        $qualifierClause = $qualifier ? "OPTIONAL { ?s <" . $qualifier->getURI() . "> ?qualifier }" : "";
1267
-        $filterDeprecated="";
1268
-        if(!$showDeprecated){
1269
-            $filterDeprecated="FILTER NOT EXISTS { ?s owl:deprecated true }";
1266
+        $qualifierClause = $qualifier ? "OPTIONAL { ?s <".$qualifier->getURI()."> ?qualifier }" : "";
1267
+        $filterDeprecated = "";
1268
+        if (!$showDeprecated) {
1269
+            $filterDeprecated = "FILTER NOT EXISTS { ?s owl:deprecated true }";
1270 1270
         }
1271 1271
         $query = <<<EOQ
1272 1272
 SELECT DISTINCT ?s ?label ?alabel ?qualifier
@@ -1743,7 +1743,7 @@  discard block
 block discarded – undo
1743 1743
                 if (!isset($row->label) || $row->label->getLang() === $lang) {
1744 1744
                     $ret[$row->object->getUri()] = $val;
1745 1745
                 } elseif ($row->label->getLang() === $fallbacklang) {
1746
-                    $val['label'] .= ' (' . $row->label->getLang() . ')';
1746
+                    $val['label'] .= ' ('.$row->label->getLang().')';
1747 1747
                     $ret[$row->object->getUri()] = $val;
1748 1748
                 }
1749 1749
             }
@@ -1839,10 +1839,10 @@  discard block
 block discarded – undo
1839 1839
 
1840 1840
             $label = null;
1841 1841
             if (isset($row->label)) {
1842
-                if ($row->label->getLang() == $lang || strpos($row->label->getLang(), $lang . "-") == 0) {
1842
+                if ($row->label->getLang() == $lang || strpos($row->label->getLang(), $lang."-") == 0) {
1843 1843
                     $label = $row->label->getValue();
1844 1844
                 } else {
1845
-                    $label = $row->label->getValue() . " (" . $row->label->getLang() . ")";
1845
+                    $label = $row->label->getValue()." (".$row->label->getLang().")";
1846 1846
                 }
1847 1847
 
1848 1848
             }
@@ -1918,8 +1918,8 @@  discard block
 block discarded – undo
1918 1918
         foreach ($result as $row) {
1919 1919
             if (isset($row->top) && isset($row->label)) {
1920 1920
                 $label = $row->label->getValue();
1921
-                if ($row->label->getLang() && $row->label->getLang() !== $lang && strpos($row->label->getLang(), $lang . "-") !== 0) {
1922
-                    $label .= ' (' . $row->label->getLang() . ')';
1921
+                if ($row->label->getLang() && $row->label->getLang() !== $lang && strpos($row->label->getLang(), $lang."-") !== 0) {
1922
+                    $label .= ' ('.$row->label->getLang().')';
1923 1923
                 }
1924 1924
                 $top = array('uri' => $row->top->getUri(), 'topConceptOf' => $row->topuri->getUri(), 'label' => $label, 'hasChildren' => filter_var($row->children->getValue(), FILTER_VALIDATE_BOOLEAN));
1925 1925
                 if (isset($row->notation)) {
@@ -2012,7 +2012,7 @@  discard block
 block discarded – undo
2012 2012
                 $ret[$uri]['exact'] = $row->exact->getUri();
2013 2013
             }
2014 2014
             if (isset($row->tops)) {
2015
-               $topConceptsList=explode(" ", $row->tops->getValue());
2015
+               $topConceptsList = explode(" ", $row->tops->getValue());
2016 2016
                // sort to guarantee an alphabetical ordering of the URI
2017 2017
                sort($topConceptsList);
2018 2018
                $ret[$uri]['tops'] = $topConceptsList;
@@ -2025,8 +2025,8 @@  discard block
 block discarded – undo
2025 2025
                 $label = null;
2026 2026
                 if (isset($row->childlabel)) {
2027 2027
                     $label = $row->childlabel->getValue();
2028
-                    if ($row->childlabel->getLang() !== $lang && strpos($row->childlabel->getLang(), $lang . "-") !== 0) {
2029
-                        $label .= " (" . $row->childlabel->getLang() . ")";
2028
+                    if ($row->childlabel->getLang() !== $lang && strpos($row->childlabel->getLang(), $lang."-") !== 0) {
2029
+                        $label .= " (".$row->childlabel->getLang().")";
2030 2030
                     }
2031 2031
 
2032 2032
                 }
@@ -2047,8 +2047,8 @@  discard block
 block discarded – undo
2047 2047
             }
2048 2048
             if (isset($row->label)) {
2049 2049
                 $preflabel = $row->label->getValue();
2050
-                if ($row->label->getLang() && $row->label->getLang() !== $lang && strpos($row->label->getLang(), $lang . "-") !== 0) {
2051
-                    $preflabel .= ' (' . $row->label->getLang() . ')';
2050
+                if ($row->label->getLang() && $row->label->getLang() !== $lang && strpos($row->label->getLang(), $lang."-") !== 0) {
2051
+                    $preflabel .= ' ('.$row->label->getLang().')';
2052 2052
                 }
2053 2053
 
2054 2054
                 $ret[$uri]['prefLabel'] = $preflabel;
@@ -2169,9 +2169,9 @@  discard block
 block discarded – undo
2169 2169
      */
2170 2170
     private function generateConceptGroupContentsQuery($groupClass, $group, $lang, $showDeprecated = false) {
2171 2171
         $fcl = $this->generateFromClause();
2172
-        $filterDeprecated="";
2173
-        if(!$showDeprecated){
2174
-            $filterDeprecated="  FILTER NOT EXISTS { ?conc owl:deprecated true }";
2172
+        $filterDeprecated = "";
2173
+        if (!$showDeprecated) {
2174
+            $filterDeprecated = "  FILTER NOT EXISTS { ?conc owl:deprecated true }";
2175 2175
         }
2176 2176
         $query = <<<EOQ
2177 2177
 SELECT ?conc ?super ?label ?members ?type ?notation $fcl
@@ -2210,10 +2210,10 @@  discard block
 block discarded – undo
2210 2210
                     'type' => array($row->type->shorten()),
2211 2211
                 );
2212 2212
                 if (isset($row->label)) {
2213
-                    if ($row->label->getLang() == $lang || strpos($row->label->getLang(), $lang . "-") == 0) {
2213
+                    if ($row->label->getLang() == $lang || strpos($row->label->getLang(), $lang."-") == 0) {
2214 2214
                         $values[$row->conc->getURI()]['prefLabel'] = $row->label->getValue();
2215 2215
                     } else {
2216
-                        $values[$row->conc->getURI()]['prefLabel'] = $row->label->getValue() . " (" . $row->label->getLang() . ")";
2216
+                        $values[$row->conc->getURI()]['prefLabel'] = $row->label->getValue()." (".$row->label->getLang().")";
2217 2217
                     }
2218 2218
 
2219 2219
                 }
@@ -2241,8 +2241,8 @@  discard block
 block discarded – undo
2241 2241
      * @param boolean $showDeprecated whether to include deprecated concepts in search results
2242 2242
      * @return array Result array with concept URI as key and concept label as value
2243 2243
      */
2244
-    public function listConceptGroupContents($groupClass, $group, $lang,$showDeprecated = false) {
2245
-        $query = $this->generateConceptGroupContentsQuery($groupClass, $group, $lang,$showDeprecated);
2244
+    public function listConceptGroupContents($groupClass, $group, $lang, $showDeprecated = false) {
2245
+        $query = $this->generateConceptGroupContentsQuery($groupClass, $group, $lang, $showDeprecated);
2246 2246
         $result = $this->query($query);
2247 2247
         return $this->transformConceptGroupContentsResults($result, $lang);
2248 2248
     }
@@ -2256,9 +2256,9 @@  discard block
 block discarded – undo
2256 2256
      * @param boolean $showDeprecated whether to include deprecated concepts in the change list
2257 2257
      * @return string sparql query
2258 2258
      */
2259
-    private function generateChangeListQuery($prop, $lang, $offset, $limit=200, $showDeprecated=false) {
2259
+    private function generateChangeListQuery($prop, $lang, $offset, $limit = 200, $showDeprecated = false) {
2260 2260
         $fcl = $this->generateFromClause();
2261
-        $offset = ($offset) ? 'OFFSET ' . $offset : '';
2261
+        $offset = ($offset) ? 'OFFSET '.$offset : '';
2262 2262
 
2263 2263
         //Additional clauses when deprecated concepts need to be included in the results
2264 2264
         $deprecatedOptions = '';
@@ -2336,7 +2336,7 @@  discard block
 block discarded – undo
2336 2336
      * @param boolean $showDeprecated whether to include deprecated concepts in the change list
2337 2337
      * @return array Result array
2338 2338
      */
2339
-    public function queryChangeList($prop, $lang, $offset, $limit, $showDeprecated=false) {
2339
+    public function queryChangeList($prop, $lang, $offset, $limit, $showDeprecated = false) {
2340 2340
         $query = $this->generateChangeListQuery($prop, $lang, $offset, $limit, $showDeprecated);
2341 2341
 
2342 2342
         $result = $this->query($query);
Please login to merge, or discard this patch.