Passed
Push — master ( ebde86...9a6d80 )
by Darko
09:46 queued 03:59
created
Blacklight/Binaries.php 1 patch
Spacing   +25 added lines, -25 removed lines patch added patch discarded remove patch
@@ -378,7 +378,7 @@  discard block
 block discarded – undo
378 378
 
379 379
             $done = false;
380 380
             // Get all the parts (in portions of $this->messageBuffer to not use too much memory).
381
-            while (! $done) {
381
+            while (!$done) {
382 382
                 // Increment last until we reach $groupLast (group newest article).
383 383
                 if ($total > $this->messageBuffer) {
384 384
                     if ((string) ($first + $this->messageBuffer) > $groupLast) {
@@ -402,7 +402,7 @@  discard block
 block discarded – undo
402 402
                 $scanSummary = $this->scan($groupMySQL, $first, $last);
403 403
 
404 404
                 // Check if we fetched headers.
405
-                if (! empty($scanSummary)) {
405
+                if (!empty($scanSummary)) {
406 406
                     // If new group, update first record & postdate
407 407
                     if ($groupMySQL['first_record_postdate'] === null && (int) $groupMySQL['first_record'] === 0) {
408 408
                         $groupMySQL['first_record'] = $scanSummary['firstArticleNumber'];
@@ -426,7 +426,7 @@  discard block
 block discarded – undo
426 426
                     }
427 427
 
428 428
                     $scanSummary['lastArticleDate'] = (isset($scanSummary['lastArticleDate']) ? strtotime($scanSummary['lastArticleDate']) : false);
429
-                    if (! is_numeric($scanSummary['lastArticleDate'])) {
429
+                    if (!is_numeric($scanSummary['lastArticleDate'])) {
430 430
                         $scanSummary['lastArticleDate'] = $this->postdate($scanSummary['lastArticleNumber'], $groupNNTP);
431 431
                     }
432 432
 
@@ -575,7 +575,7 @@  discard block
 block discarded – undo
575 575
 
576 576
             // If set we are running in partRepair mode.
577 577
             if ($partRepair && $missingParts !== null) {
578
-                if (! \in_array($header['Number'], $missingParts, false)) {
578
+                if (!\in_array($header['Number'], $missingParts, false)) {
579 579
                     // If article isn't one that is missing skip it.
580 580
                     continue;
581 581
                 }
@@ -620,15 +620,15 @@  discard block
 block discarded – undo
620 620
 
621 621
         unset($headers); // Reclaim memory now that headers are split.
622 622
 
623
-        if (! empty($this->_binaryBlacklistIdsToUpdate)) {
623
+        if (!empty($this->_binaryBlacklistIdsToUpdate)) {
624 624
             $this->updateBlacklistUsage();
625 625
         }
626 626
 
627
-        if ($this->_echoCLI && ! $partRepair) {
627
+        if ($this->_echoCLI && !$partRepair) {
628 628
             $this->outputHeaderInitial();
629 629
         }
630 630
 
631
-        if (! empty($stdHeaders)) {
631
+        if (!empty($stdHeaders)) {
632 632
             $this->storeHeaders($stdHeaders);
633 633
         }
634 634
         unset($stdHeaders);
@@ -703,9 +703,9 @@  discard block
 block discarded – undo
703 703
         // Loop articles, figure out files/parts.
704 704
         foreach ($headers as $this->header) {
705 705
             // Set up the info for inserting into parts/binaries/collections tables.
706
-            if (! isset($articles[$this->header['matches'][1]])) {
706
+            if (!isset($articles[$this->header['matches'][1]])) {
707 707
                 // Attempt to find the file count. If it is not found, set it to 0.
708
-                if (! preg_match('/[[(\s](\d{1,5})(\/|[\s_]of[\s_]|-)(\d{1,5})[])\s$:]/i', $this->header['matches'][1], $fileCount)) {
708
+                if (!preg_match('/[[(\s](\d{1,5})(\/|[\s_]of[\s_]|-)(\d{1,5})[])\s$:]/i', $this->header['matches'][1], $fileCount)) {
709 709
                     $fileCount[1] = $fileCount[3] = 0;
710 710
                 }
711 711
 
@@ -717,7 +717,7 @@  discard block
 block discarded – undo
717 717
                 $this->header['CollectionKey'] = $collMatch['name'].$fileCount[3];
718 718
 
719 719
                 // If this header's collection key isn't in memory, attempt to insert the collection
720
-                if (! isset($collectionIDs[$this->header['CollectionKey']])) {
720
+                if (!isset($collectionIDs[$this->header['CollectionKey']])) {
721 721
                     /* Date from header should be a string this format:
722 722
                      * 31 Mar 2014 15:36:04 GMT or 6 Oct 1998 04:38:40 -0500
723 723
                      * Still make sure it's not unix time, convert it to unix time if it is.
@@ -748,7 +748,7 @@  discard block
 block discarded – undo
748 748
 
749 749
                     $finalXrefArray = [];
750 750
                     foreach ($tempHeaderXrefs as $tempHeaderXref) {
751
-                        if (! in_array($tempHeaderXref, $tempXrefsData, false)) {
751
+                        if (!in_array($tempHeaderXref, $tempXrefsData, false)) {
752 752
                             $finalXrefArray[] = $tempHeaderXref;
753 753
                         }
754 754
                     }
@@ -885,12 +885,12 @@  discard block
 block discarded – undo
885 885
         $iterator1 = 0;
886 886
         $iterator2 = $msgCount - 1;
887 887
         while (true) {
888
-            if (! isset($returnArray['firstArticleNumber']) && isset($headers[$iterator1]['Number'])) {
888
+            if (!isset($returnArray['firstArticleNumber']) && isset($headers[$iterator1]['Number'])) {
889 889
                 $returnArray['firstArticleNumber'] = $headers[$iterator1]['Number'];
890 890
                 $returnArray['firstArticleDate'] = $headers[$iterator1]['Date'];
891 891
             }
892 892
 
893
-            if (! isset($returnArray['lastArticleNumber']) && isset($headers[$iterator2]['Number'])) {
893
+            if (!isset($returnArray['lastArticleNumber']) && isset($headers[$iterator2]['Number'])) {
894 894
                 $returnArray['lastArticleNumber'] = $headers[$iterator2]['Number'];
895 895
                 $returnArray['lastArticleDate'] = $headers[$iterator2]['Date'];
896 896
             }
@@ -1064,7 +1064,7 @@  discard block
 block discarded – undo
1064 1064
         }
1065 1065
 
1066 1066
         // Remove articles that we cant fetch after x attempts.
1067
-        DB::transaction(function () use ($groupArr) {
1067
+        DB::transaction(function() use ($groupArr) {
1068 1068
             DB::delete(
1069 1069
                 sprintf(
1070 1070
                     'DELETE FROM missed_parts WHERE attempts >= %d AND groups_id = %d',
@@ -1103,14 +1103,14 @@  discard block
 block discarded – undo
1103 1103
                     $currentPost
1104 1104
                 )
1105 1105
             );
1106
-            if (! empty($local) && \count($local) > 0) {
1106
+            if (!empty($local) && \count($local) > 0) {
1107 1107
                 $date = $local[0]->date;
1108 1108
                 break;
1109 1109
             }
1110 1110
 
1111 1111
             // If we could not find it locally, try usenet.
1112 1112
             $header = $this->_nntp->getXOVER($currentPost);
1113
-            if (! $this->_nntp::isError($header) && isset($header[0]['Date']) && $header[0]['Date'] !== '') {
1113
+            if (!$this->_nntp::isError($header) && isset($header[0]['Date']) && $header[0]['Date'] !== '') {
1114 1114
                 $date = $header[0]['Date'];
1115 1115
                 break;
1116 1116
             }
@@ -1135,7 +1135,7 @@  discard block
 block discarded – undo
1135 1135
         } while ($attempts++ <= 20);
1136 1136
 
1137 1137
         // If we didn't get a date, set it to now.
1138
-        if (! $date) {
1138
+        if (!$date) {
1139 1139
             $date = time();
1140 1140
         } else {
1141 1141
             $date = strtotime($date);
@@ -1198,7 +1198,7 @@  discard block
 block discarded – undo
1198 1198
             $articleTime = $this->postdate($wantedArticle, $data);
1199 1199
 
1200 1200
             // Article doesn't exist, start again with something random
1201
-            if (! $articleTime) {
1201
+            if (!$articleTime) {
1202 1202
                 $wantedArticle = random_int($aMin, $aMax);
1203 1203
                 $articleTime = $this->postdate($wantedArticle, $data);
1204 1204
             }
@@ -1270,7 +1270,7 @@  discard block
 block discarded – undo
1270 1270
         foreach ($numbers as $number) {
1271 1271
             $sql .= $number.',';
1272 1272
         }
1273
-        DB::transaction(static function () use ($groupID, $sql) {
1273
+        DB::transaction(static function() use ($groupID, $sql) {
1274 1274
             DB::delete(rtrim($sql, ',').') AND groups_id = '.$groupID);
1275 1275
         }, 10);
1276 1276
     }
@@ -1285,10 +1285,10 @@  discard block
 block discarded – undo
1285 1285
      */
1286 1286
     protected function _retrieveBlackList(string $groupName): void
1287 1287
     {
1288
-        if (! isset($this->blackList[$groupName])) {
1288
+        if (!isset($this->blackList[$groupName])) {
1289 1289
             $this->blackList[$groupName] = $this->getBlacklist(true, self::OPTYPE_BLACKLIST, $groupName, true);
1290 1290
         }
1291
-        if (! isset($this->whiteList[$groupName])) {
1291
+        if (!isset($this->whiteList[$groupName])) {
1292 1292
             $this->whiteList[$groupName] = $this->getBlacklist(true, self::OPTYPE_WHITELIST, $groupName, true);
1293 1293
         }
1294 1294
         $this->_listsFound[$groupName] = ($this->blackList[$groupName] || $this->whiteList[$groupName]);
@@ -1302,10 +1302,10 @@  discard block
 block discarded – undo
1302 1302
      */
1303 1303
     public function isBlackListed(array $msg, string $groupName): bool
1304 1304
     {
1305
-        if (! isset($this->_listsFound[$groupName])) {
1305
+        if (!isset($this->_listsFound[$groupName])) {
1306 1306
             $this->_retrieveBlackList($groupName);
1307 1307
         }
1308
-        if (! $this->_listsFound[$groupName]) {
1308
+        if (!$this->_listsFound[$groupName]) {
1309 1309
             return false;
1310 1310
         }
1311 1311
 
@@ -1333,7 +1333,7 @@  discard block
 block discarded – undo
1333 1333
 
1334 1334
         // Check if the field is blacklisted.
1335 1335
 
1336
-        if (! $blackListed && $this->blackList[$groupName]) {
1336
+        if (!$blackListed && $this->blackList[$groupName]) {
1337 1337
             foreach ($this->blackList[$groupName] as $blackList) {
1338 1338
                 if (preg_match('/'.$blackList->regex.'/i', $field[$blackList->msgcol])) {
1339 1339
                     $blackListed = true;
@@ -1443,7 +1443,7 @@  discard block
 block discarded – undo
1443 1443
      */
1444 1444
     public function delete(int $collectionID): void
1445 1445
     {
1446
-        DB::transaction(static function () use ($collectionID) {
1446
+        DB::transaction(static function() use ($collectionID) {
1447 1447
             DB::delete(sprintf('DELETE FROM collections WHERE id = %d', $collectionID));
1448 1448
         }, 10);
1449 1449
 
Please login to merge, or discard this patch.
Blacklight/NZBExport.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -49,19 +49,19 @@  discard block
 block discarded – undo
49 49
         $path = $params[0];
50 50
 
51 51
         // Check if the path ends with dir separator.
52
-        if (! Str::endsWith($path, '/')) {
52
+        if (!Str::endsWith($path, '/')) {
53 53
             $path .= '/';
54 54
         }
55 55
 
56 56
         // Check if it's a directory.
57
-        if (! File::isDirectory($path)) {
57
+        if (!File::isDirectory($path)) {
58 58
             $this->echoOut('Folder does not exist: '.$path);
59 59
 
60 60
             return $this->returnValue();
61 61
         }
62 62
 
63 63
         // Check if we can write to it.
64
-        if (! is_writable($path)) {
64
+        if (!is_writable($path)) {
65 65
             $this->echoOut('Folder is not writable: '.$path);
66 66
 
67 67
             return $this->returnValue();
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
 
70 70
         // Check if the from date is the proper format.
71 71
         if (isset($params[1]) && $params[1] !== '') {
72
-            if (! $this->checkDate($params[1])) {
72
+            if (!$this->checkDate($params[1])) {
73 73
                 return $this->returnValue();
74 74
             }
75 75
             $fromDate = $params[1];
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
77 77
 
78 78
         // Check if the to date is the proper format.
79 79
         if (isset($params[2]) && $params[2] !== '') {
80
-            if (! $this->checkDate($params[2])) {
80
+            if (!$this->checkDate($params[2])) {
81 81
                 return $this->returnValue();
82 82
             }
83 83
             $toDate = $params[2];
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
 
86 86
         // Check if the group_id exists.
87 87
         if (isset($params[3]) && $params[3] !== 0) {
88
-            if (! is_numeric($params[3])) {
88
+            if (!is_numeric($params[3])) {
89 89
                 $this->echoOut('The group ID is not a number: '.$params[3]);
90 90
 
91 91
                 return $this->returnValue();
@@ -120,7 +120,7 @@  discard block
 block discarded – undo
120 120
 
121 121
             // Create a path to store the new NZB files.
122 122
             $currentPath = $path.$this->safeFilename($group['name']).'/';
123
-            if (! File::isDirectory($currentPath) && ! File::makeDirectory($currentPath) && ! File::isDirectory($currentPath)) {
123
+            if (!File::isDirectory($currentPath) && !File::makeDirectory($currentPath) && !File::isDirectory($currentPath)) {
124 124
                 throw new \RuntimeException(sprintf('Directory "%s" was not created', $currentPath));
125 125
             }
126 126
             foreach ($releases as $release) {
@@ -140,7 +140,7 @@  discard block
 block discarded – undo
140 140
 
141 141
                 // Check if the user wants them in gzip, copy it if so.
142 142
                 if ($gzip) {
143
-                    if (! copy($nzbFile, $currentFile.'.nzb.gz')) {
143
+                    if (!copy($nzbFile, $currentFile.'.nzb.gz')) {
144 144
                         if ($this->echoCLI) {
145 145
                             echo 'Unable to export NZB with GUID: '.$release['guid'];
146 146
                         }
@@ -150,7 +150,7 @@  discard block
 block discarded – undo
150 150
                 // If not, decompress it and create a file to store it in.
151 151
                 } else {
152 152
                     $nzbContents = Utility::unzipGzipFile($nzbFile);
153
-                    if (! $nzbContents) {
153
+                    if (!$nzbContents) {
154 154
                         if ($this->echoCLI) {
155 155
                             echo 'Unable to export NZB with GUID: '.$release['guid'];
156 156
                         }
@@ -190,7 +190,7 @@  discard block
 block discarded – undo
190 190
 
191 191
     protected function checkDate($date): bool
192 192
     {
193
-        if (! preg_match('/^(\d{2}\/){2}\d{4}$/', $date)) {
193
+        if (!preg_match('/^(\d{2}\/){2}\d{4}$/', $date)) {
194 194
             $this->echoOut('Wrong date format: '.$date);
195 195
 
196 196
             return false;
Please login to merge, or discard this patch.