| Conditions | 26 | 
| Paths | 288 | 
| Total Lines | 133 | 
| Code Lines | 99 | 
| Lines | 0 | 
| Ratio | 0 % | 
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php | ||
| 98 | public function edit(Request $request) | ||
| 99 |     { | ||
| 100 | $this->setAdminPrefs(); | ||
| 101 | |||
| 102 | $user = [ | ||
| 103 | 'id' => '', | ||
| 104 | 'username' => '', | ||
| 105 | 'email' => '', | ||
| 106 | 'password' => '', | ||
| 107 | 'role' => User::ROLE_USER, | ||
| 108 | 'notes' => '', | ||
| 109 | 'rate_limit' => 60, | ||
| 110 | ]; | ||
| 111 | |||
| 112 | $meta_title = $title = 'View User'; | ||
| 113 | |||
| 114 | // set the current action | ||
| 115 |         $action = $request->input('action') ?? 'view'; | ||
| 116 | |||
| 117 | // get the user roles | ||
| 118 | $userRoles = Role::cursor()->remember(); | ||
| 119 | $roles = []; | ||
| 120 | $defaultRole = 'User'; | ||
| 121 | $defaultInvites = Invitation::DEFAULT_INVITES; | ||
| 122 |         foreach ($userRoles as $r) { | ||
| 123 | $roles[$r->id] = $r->name; | ||
| 124 |             if ($r->isdefault === 1) { | ||
| 125 | $defaultRole = $r->id; | ||
| 126 | $defaultInvites = $r->defaultinvites; | ||
| 127 | } | ||
| 128 | } | ||
| 129 | |||
| 130 | $error = null; | ||
| 131 | |||
| 132 |         switch ($action) { | ||
| 133 | case 'add': | ||
| 134 | $user += [ | ||
| 135 | 'role' => $defaultRole, | ||
| 136 | 'notes' => '', | ||
| 137 | 'invites' => $defaultInvites, | ||
| 138 | 'movieview' => 0, | ||
| 139 | 'xxxview' => 0, | ||
| 140 | 'musicview' => 0, | ||
| 141 | 'consoleview' => 0, | ||
| 142 | 'gameview' => 0, | ||
| 143 | 'bookview' => 0, | ||
| 144 | ]; | ||
| 145 | break; | ||
| 146 | case 'submit': | ||
| 147 |                 if (empty($request->input('id'))) { | ||
| 148 | $invites = $defaultInvites; | ||
| 149 |                     foreach ($userRoles as $role) { | ||
| 150 |                         if ($role['id'] === $request->input('role')) { | ||
| 151 | $invites = $role['defaultinvites']; | ||
| 152 | } | ||
| 153 | } | ||
| 154 |                     $ret = User::signUp($request->input('username'), $request->input('password'), $request->input('email'), '', $request->input('notes'), $invites, '', true, $request->input('role'), false); | ||
| 155 |                 } else { | ||
| 156 |                     $editedUser = User::find($request->input('id')); | ||
| 157 |                     $ret = User::updateUser($editedUser->id, $request->input('username'), $request->input('email'), $request->input('grabs'), $request->input('role'), $request->input('notes'), $request->input('invites'), ($request->has('movieview') ? 1 : 0), ($request->has('musicview') ? 1 : 0), ($request->has('gameview') ? 1 : 0), ($request->has('xxxview') ? 1 : 0), ($request->has('consoleview') ? 1 : 0), ($request->has('bookview') ? 1 : 0)); | ||
| 158 |                     if ($request->input('password') !== null) { | ||
| 159 |                         User::updatePassword($editedUser->id, $request->input('password')); | ||
| 160 | } | ||
| 161 | // Handle rolechangedate - update if has value, clear if empty | ||
| 162 |                     if ($request->has('rolechangedate')) { | ||
| 163 |                         $roleChangeDate = $request->input('rolechangedate'); | ||
| 164 |                         if (! empty($roleChangeDate)) { | ||
| 165 | User::updateUserRoleChangeDate($editedUser->id, $roleChangeDate); | ||
| 166 |                         } else { | ||
| 167 | // Clear the rolechangedate if empty string is provided | ||
| 168 | $editedUser->update(['rolechangedate' => null]); | ||
| 169 | } | ||
| 170 | } | ||
| 171 |                     if ($request->input('role') !== null) { | ||
| 172 | $editedUser->refresh(); | ||
| 173 | } | ||
| 174 | } | ||
| 175 | |||
| 176 |                 if ($ret >= 0) { | ||
| 177 |                     return redirect()->to('admin/user-list'); | ||
| 178 | } | ||
| 179 | |||
| 180 |                 switch ($ret) { | ||
| 181 | case User::ERR_SIGNUP_BADUNAME: | ||
| 182 | $error = 'Bad username. Try a better one.'; | ||
| 183 | break; | ||
| 184 | case User::ERR_SIGNUP_BADPASS: | ||
| 185 | $error = 'Bad password. Try a longer one.'; | ||
| 186 | break; | ||
| 187 | case User::ERR_SIGNUP_BADEMAIL: | ||
| 188 | $error = 'Bad email.'; | ||
| 189 | break; | ||
| 190 | case User::ERR_SIGNUP_UNAMEINUSE: | ||
| 191 | $error = 'Username in use.'; | ||
| 192 | break; | ||
| 193 | case User::ERR_SIGNUP_EMAILINUSE: | ||
| 194 | $error = 'Email in use.'; | ||
| 195 | break; | ||
| 196 | default: | ||
| 197 | $error = 'Unknown save error.'; | ||
| 198 | break; | ||
| 199 | } | ||
| 200 | $user += [ | ||
| 201 |                     'id' => $request->input('id'), | ||
| 202 |                     'username' => $request->input('username'), | ||
| 203 |                     'email' => $request->input('email'), | ||
| 204 |                     'role' => $request->input('role'), | ||
| 205 |                     'notes' => $request->input('notes'), | ||
| 206 | ]; | ||
| 207 | break; | ||
| 208 | case 'view': | ||
| 209 | default: | ||
| 210 |                 if ($request->has('id')) { | ||
| 211 | $title = 'User Edit'; | ||
| 212 |                     $id = $request->input('id'); | ||
| 213 | $user = User::find($id); | ||
| 214 | } | ||
| 215 | |||
| 216 | break; | ||
| 217 | } | ||
| 218 | |||
| 219 | $this->viewData = array_merge($this->viewData, [ | ||
| 220 | 'yesno_ids' => [1, 0], | ||
| 221 | 'yesno_names' => ['Yes', 'No'], | ||
| 222 | 'role_ids' => array_keys($roles), | ||
| 223 | 'role_names' => $roles, | ||
| 224 | 'user' => $user, | ||
| 225 | 'error' => $error, | ||
| 226 | 'title' => $title, | ||
| 227 | 'meta_title' => $meta_title, | ||
| 228 | ]); | ||
| 229 | |||
| 230 |         return view('admin.users.edit', $this->viewData); | ||
| 231 | } | ||
| 278 |