| Total Complexity | 51 |
| Total Lines | 262 |
| Duplicated Lines | 0 % |
| Changes | 0 | ||
Complex classes like AdminUserController often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use AdminUserController, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 14 | class AdminUserController extends BasePageController |
||
| 15 | { |
||
| 16 | /** |
||
| 17 | * @throws \Throwable |
||
| 18 | */ |
||
| 19 | public function index(Request $request) |
||
| 20 | { |
||
| 21 | $this->setAdminPrefs(); |
||
| 22 | |||
| 23 | $meta_title = $title = 'User List'; |
||
| 24 | |||
| 25 | $roles = []; |
||
| 26 | $userRoles = Role::cursor()->remember(); |
||
| 27 | foreach ($userRoles as $userRole) { |
||
| 28 | $roles[$userRole->id] = $userRole->name; |
||
| 29 | } |
||
| 30 | |||
| 31 | $ordering = getUserBrowseOrdering(); |
||
| 32 | $orderBy = $request->has('ob') && \in_array($request->input('ob'), $ordering, false) ? $request->input('ob') : ''; |
||
| 33 | $page = $request->has('page') && is_numeric($request->input('page')) ? $request->input('page') : 1; |
||
| 34 | $offset = ($page - 1) * config('nntmux.items_per_page'); |
||
| 35 | |||
| 36 | $variables = [ |
||
| 37 | 'username' => $request->has('username') ? $request->input('username') : '', |
||
| 38 | 'email' => $request->has('email') ? $request->input('email') : '', |
||
| 39 | 'host' => $request->has('host') ? $request->input('host') : '', |
||
| 40 | 'role' => $request->has('role') ? $request->input('role') : '', |
||
| 41 | 'created_from' => $request->has('created_from') ? $request->input('created_from') : '', |
||
| 42 | 'created_to' => $request->has('created_to') ? $request->input('created_to') : '', |
||
| 43 | ]; |
||
| 44 | |||
| 45 | $result = User::getRange( |
||
| 46 | $offset, |
||
| 47 | config('nntmux.items_per_page'), |
||
| 48 | $orderBy, |
||
| 49 | $variables['username'], |
||
| 50 | $variables['email'], |
||
| 51 | $variables['host'], |
||
| 52 | $variables['role'], |
||
| 53 | true, |
||
| 54 | $variables['created_from'], |
||
| 55 | $variables['created_to'] |
||
| 56 | ); |
||
| 57 | |||
| 58 | $results = $this->paginate($result ?? [], User::getCount($variables['role'], $variables['username'], $variables['host'], $variables['email'], $variables['created_from'], $variables['created_to']) ?? 0, config('nntmux.items_per_page'), $page, $request->url(), $request->query()); |
||
| 59 | |||
| 60 | // Add country data to each user based on their host IP |
||
| 61 | foreach ($results as $user) { |
||
| 62 | $position = null; |
||
| 63 | if (! empty($user->host) && filter_var($user->host, FILTER_VALIDATE_IP)) { |
||
| 64 | $position = Location::get($user->host); |
||
| 65 | } |
||
| 66 | $user->country_name = $position ? $position->countryName : null; |
||
| 67 | $user->country_code = $position ? $position->countryCode : null; |
||
| 68 | } |
||
| 69 | |||
| 70 | // Build order by URLs |
||
| 71 | $orderByUrls = []; |
||
| 72 | foreach ($ordering as $orderType) { |
||
| 73 | $orderByUrls['orderby'.$orderType] = url('admin/user-list?ob='.$orderType); |
||
| 74 | } |
||
| 75 | |||
| 76 | $this->viewData = array_merge($this->viewData, [ |
||
| 77 | 'username' => $variables['username'], |
||
| 78 | 'email' => $variables['email'], |
||
| 79 | 'host' => $variables['host'], |
||
| 80 | 'role' => $variables['role'], |
||
| 81 | 'created_from' => $variables['created_from'], |
||
| 82 | 'created_to' => $variables['created_to'], |
||
| 83 | 'role_ids' => array_keys($roles), |
||
| 84 | 'role_names' => $roles, |
||
| 85 | 'userlist' => $results, |
||
| 86 | 'title' => $title, |
||
| 87 | 'meta_title' => $meta_title, |
||
| 88 | ], $orderByUrls); |
||
| 89 | |||
| 90 | return view('admin.users.index', $this->viewData); |
||
| 91 | } |
||
| 92 | |||
| 93 | /** |
||
| 94 | * @return RedirectResponse|\Illuminate\View\View |
||
| 95 | * |
||
| 96 | * @throws \Exception |
||
| 97 | */ |
||
| 98 | public function edit(Request $request) |
||
| 99 | { |
||
| 100 | $this->setAdminPrefs(); |
||
| 101 | |||
| 102 | $user = [ |
||
| 103 | 'id' => '', |
||
| 104 | 'username' => '', |
||
| 105 | 'email' => '', |
||
| 106 | 'password' => '', |
||
| 107 | 'role' => User::ROLE_USER, |
||
| 108 | 'notes' => '', |
||
| 109 | 'rate_limit' => 60, |
||
| 110 | ]; |
||
| 111 | |||
| 112 | $meta_title = $title = 'View User'; |
||
| 113 | |||
| 114 | // set the current action |
||
| 115 | $action = $request->input('action') ?? 'view'; |
||
| 116 | |||
| 117 | // get the user roles |
||
| 118 | $userRoles = Role::cursor()->remember(); |
||
| 119 | $roles = []; |
||
| 120 | $defaultRole = 'User'; |
||
| 121 | $defaultInvites = Invitation::DEFAULT_INVITES; |
||
| 122 | foreach ($userRoles as $r) { |
||
| 123 | $roles[$r->id] = $r->name; |
||
| 124 | if ($r->isdefault === 1) { |
||
| 125 | $defaultRole = $r->id; |
||
| 126 | $defaultInvites = $r->defaultinvites; |
||
| 127 | } |
||
| 128 | } |
||
| 129 | |||
| 130 | $error = null; |
||
| 131 | |||
| 132 | switch ($action) { |
||
| 133 | case 'add': |
||
| 134 | $user += [ |
||
| 135 | 'role' => $defaultRole, |
||
| 136 | 'notes' => '', |
||
| 137 | 'invites' => $defaultInvites, |
||
| 138 | 'movieview' => 0, |
||
| 139 | 'xxxview' => 0, |
||
| 140 | 'musicview' => 0, |
||
| 141 | 'consoleview' => 0, |
||
| 142 | 'gameview' => 0, |
||
| 143 | 'bookview' => 0, |
||
| 144 | ]; |
||
| 145 | break; |
||
| 146 | case 'submit': |
||
| 147 | if (empty($request->input('id'))) { |
||
| 148 | $invites = $defaultInvites; |
||
| 149 | foreach ($userRoles as $role) { |
||
| 150 | if ($role['id'] === $request->input('role')) { |
||
| 151 | $invites = $role['defaultinvites']; |
||
| 152 | } |
||
| 153 | } |
||
| 154 | $ret = User::signUp($request->input('username'), $request->input('password'), $request->input('email'), '', $request->input('notes'), $invites, '', true, $request->input('role'), false); |
||
| 155 | } else { |
||
| 156 | $editedUser = User::find($request->input('id')); |
||
| 157 | $ret = User::updateUser($editedUser->id, $request->input('username'), $request->input('email'), $request->input('grabs'), $request->input('role'), $request->input('notes'), $request->input('invites'), ($request->has('movieview') ? 1 : 0), ($request->has('musicview') ? 1 : 0), ($request->has('gameview') ? 1 : 0), ($request->has('xxxview') ? 1 : 0), ($request->has('consoleview') ? 1 : 0), ($request->has('bookview') ? 1 : 0)); |
||
| 158 | if ($request->input('password') !== null) { |
||
| 159 | User::updatePassword($editedUser->id, $request->input('password')); |
||
| 160 | } |
||
| 161 | // Handle rolechangedate - update if has value, clear if empty |
||
| 162 | if ($request->has('rolechangedate')) { |
||
| 163 | $roleChangeDate = $request->input('rolechangedate'); |
||
| 164 | if (! empty($roleChangeDate)) { |
||
| 165 | User::updateUserRoleChangeDate($editedUser->id, $roleChangeDate); |
||
| 166 | } else { |
||
| 167 | // Clear the rolechangedate if empty string is provided |
||
| 168 | $editedUser->update(['rolechangedate' => null]); |
||
| 169 | } |
||
| 170 | } |
||
| 171 | if ($request->input('role') !== null) { |
||
| 172 | $editedUser->refresh(); |
||
| 173 | } |
||
| 174 | } |
||
| 175 | |||
| 176 | if ($ret >= 0) { |
||
| 177 | return redirect()->to('admin/user-list'); |
||
| 178 | } |
||
| 179 | |||
| 180 | switch ($ret) { |
||
| 181 | case User::ERR_SIGNUP_BADUNAME: |
||
| 182 | $error = 'Bad username. Try a better one.'; |
||
| 183 | break; |
||
| 184 | case User::ERR_SIGNUP_BADPASS: |
||
| 185 | $error = 'Bad password. Try a longer one.'; |
||
| 186 | break; |
||
| 187 | case User::ERR_SIGNUP_BADEMAIL: |
||
| 188 | $error = 'Bad email.'; |
||
| 189 | break; |
||
| 190 | case User::ERR_SIGNUP_UNAMEINUSE: |
||
| 191 | $error = 'Username in use.'; |
||
| 192 | break; |
||
| 193 | case User::ERR_SIGNUP_EMAILINUSE: |
||
| 194 | $error = 'Email in use.'; |
||
| 195 | break; |
||
| 196 | default: |
||
| 197 | $error = 'Unknown save error.'; |
||
| 198 | break; |
||
| 199 | } |
||
| 200 | $user += [ |
||
| 201 | 'id' => $request->input('id'), |
||
| 202 | 'username' => $request->input('username'), |
||
| 203 | 'email' => $request->input('email'), |
||
| 204 | 'role' => $request->input('role'), |
||
| 205 | 'notes' => $request->input('notes'), |
||
| 206 | ]; |
||
| 207 | break; |
||
| 208 | case 'view': |
||
| 209 | default: |
||
| 210 | if ($request->has('id')) { |
||
| 211 | $title = 'User Edit'; |
||
| 212 | $id = $request->input('id'); |
||
| 213 | $user = User::find($id); |
||
| 214 | } |
||
| 215 | |||
| 216 | break; |
||
| 217 | } |
||
| 218 | |||
| 219 | $this->viewData = array_merge($this->viewData, [ |
||
| 220 | 'yesno_ids' => [1, 0], |
||
| 221 | 'yesno_names' => ['Yes', 'No'], |
||
| 222 | 'role_ids' => array_keys($roles), |
||
| 223 | 'role_names' => $roles, |
||
| 224 | 'user' => $user, |
||
| 225 | 'error' => $error, |
||
| 226 | 'title' => $title, |
||
| 227 | 'meta_title' => $meta_title, |
||
| 228 | ]); |
||
| 229 | |||
| 230 | return view('admin.users.edit', $this->viewData); |
||
| 231 | } |
||
| 232 | |||
| 233 | public function destroy(Request $request): RedirectResponse |
||
| 234 | { |
||
| 235 | if ($request->has('id')) { |
||
| 236 | $user = User::find($request->input('id')); |
||
| 237 | $username = $user->username; // Store username before deletion |
||
| 238 | |||
| 239 | $user->delete(); |
||
| 240 | |||
| 241 | // Redirect with username to display in notification |
||
| 242 | return redirect()->to('admin/user-list?deleted=1&username='.urlencode($username)); |
||
| 243 | } |
||
| 244 | |||
| 245 | if ($request->has('redir')) { |
||
| 246 | return redirect()->to($request->input('redir')); |
||
| 247 | } |
||
| 248 | |||
| 249 | return redirect()->to($request->server('HTTP_REFERER')); |
||
|
|
|||
| 250 | } |
||
| 251 | |||
| 252 | public function resendVerification(Request $request): RedirectResponse |
||
| 253 | { |
||
| 254 | if ($request->has('id')) { |
||
| 255 | $user = User::find($request->input('id')); |
||
| 256 | UserVerification::generate($user); |
||
| 257 | |||
| 258 | UserVerification::send($user, 'User email verification required'); |
||
| 259 | |||
| 260 | return redirect()->back()->with('success', 'Email verification for '.$user->username.' sent'); |
||
| 261 | } |
||
| 262 | |||
| 263 | return redirect()->back()->with('error', 'User is invalid'); |
||
| 264 | } |
||
| 265 | |||
| 266 | public function verify(Request $request): RedirectResponse |
||
| 276 | } |
||
| 277 | } |
||
| 278 |