View GitHub Repository SymfonyStarter

Schedule Inspection
Subscribe
Completed
Branch — master (d30f73)
by Loïc
02:42
created
Category
Toggle Patches
web/config.php 2 patches
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -22,14 +22,14 @@
 
 block discarded – undo
22 22 
     exit('This script is only accessible from localhost.');
23 23 
 }
24 24
25 
-require_once dirname(__FILE__).'/../var/SymfonyRequirements.php';
25 
+require_once dirname(__FILE__) . '/../var/SymfonyRequirements.php';
26 26
27 27 
 $symfonyRequirements = new SymfonyRequirements();
28 28
29 29 
 $majorProblems = $symfonyRequirements->getFailedRequirements();
30 30 
 $minorProblems = $symfonyRequirements->getFailedRecommendations();
31 
-$hasMajorProblems = (bool) count($majorProblems);
32 
-$hasMinorProblems = (bool) count($minorProblems);
31 
+$hasMajorProblems = (bool)count($majorProblems);
32 
+$hasMinorProblems = (bool)count($minorProblems);
33 33
34 34 
 ?>
35 35 
 <!DOCTYPE html>
Please login to merge, or discard this patch.
Braces   +9 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -382,7 +382,10 @@  discard block
 
 block discarded – undo
382 382 
                         <?php if ($hasMinorProblems): ?>
383 383 
                             <h2>Recommendations</h2>
384 384 
                             <p>
385 
-                                <?php if ($hasMajorProblems): ?>Additionally, to<?php else: ?>To<?php endif; ?> enhance your Symfony experience,
385 
+                                <?php if ($hasMajorProblems): ?>Additionally, to<?php else {
386 
+    : ?>To<?php endif;
387 
+}
388 
+?> enhance your Symfony experience,
386 389 
                                 it’s recommended that you fix the following:
387 390 
                             </p>
388 391 
                             <ol>
 
@@ -398,9 +401,12 @@  discard block
 
 block discarded – undo
398 401 
                             <p id="phpini">*
399 402 
                                 <?php if ($symfonyRequirements->getPhpIniConfigPath()): ?>
400 403 
                                     Changes to the <strong>php.ini</strong> file must be done in "<strong><?php echo $symfonyRequirements->getPhpIniConfigPath() ?></strong>".
401 
-                                <?php else: ?>
404 
+                                <?php else {
405 
+    : ?>
402 406 
                                     To change settings, create a "<strong>php.ini</strong>".
403 
-                                <?php endif; ?>
407 
+                                <?php endif;
408 
+}
409 
+?>
404 410 
                             </p>
405 411 
                         <?php endif; ?>
406 412
Please login to merge, or discard this patch.
web/app.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -3,8 +3,8 @@
 
 block discarded – undo
3 3 
 use Symfony\Component\HttpFoundation\Request;
4 4
5 5 
 /** @var \Composer\Autoload\ClassLoader $loader */
6 
-$loader = require __DIR__.'/../app/autoload.php';
7 
-include_once __DIR__.'/../var/bootstrap.php.cache';
6 
+$loader = require __DIR__ . '/../app/autoload.php';
7 
+include_once __DIR__ . '/../var/bootstrap.php.cache';
8 8
9 9 
 $kernel = new AppKernel('prod', false);
10 10 
 $kernel->loadClassCache();
Please login to merge, or discard this patch.
web/app_test.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -18,11 +18,11 @@
 
 block discarded – undo
18 18 
     || !(in_array(@$_SERVER['REMOTE_ADDR'], ['10.0.0.1', '127.0.0.1', '::1']) || php_sapi_name() === 'cli-server')
19 19 
 ) {
20 20 
     header('HTTP/1.0 403 Forbidden');
21 
-    exit('You are not allowed to access this file. Check '.basename(__FILE__).' for more information.');
21 
+    exit('You are not allowed to access this file. Check ' . basename(__FILE__) . ' for more information.');
22 22 
 }
23 23
24 24 
 /** @var \Composer\Autoload\ClassLoader $loader */
25 
-$loader = require __DIR__.'/../app/autoload.php';
25 
+$loader = require __DIR__ . '/../app/autoload.php';
26 26 
 Debug::enable();
27 27
28 28 
 $kernel = new AppKernel('test', false);
Please login to merge, or discard this patch.
web/app_dev.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -15,11 +15,11 @@
 
 block discarded – undo
15 15 
     || !(in_array(@$_SERVER['REMOTE_ADDR'], ['10.0.0.1', '127.0.0.1', '::1']) || php_sapi_name() === 'cli-server')
16 16 
 ) {
17 17 
     header('HTTP/1.0 403 Forbidden');
18 
-    exit('You are not allowed to access this file. Check '.basename(__FILE__).' for more information.');
18 
+    exit('You are not allowed to access this file. Check ' . basename(__FILE__) . ' for more information.');
19 19 
 }
20 20
21 21 
 /** @var \Composer\Autoload\ClassLoader $loader */
22 
-$loader = require __DIR__.'/../app/autoload.php';
22 
+$loader = require __DIR__ . '/../app/autoload.php';
23 23 
 Debug::enable();
24 24
25 25 
 $kernel = new AppKernel('dev', true);
Please login to merge, or discard this patch.
src/AppBundle/Fixture/OptionsResolver/LazyOption.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch 
@@ -43,7 +43,7 @@  discard block
 
 block discarded – undo
43 43 
      */
44 44 
     public static function randomOne(RepositoryInterface $repository)
45 45 
     {
46 
-        return function (Options $options) use ($repository) {
46 
+        return function(Options $options) use ($repository) {
47 47 
             $objects = $repository->findAll();
48 48
49 49 
             if ($objects instanceof Collection) {
 
@@ -64,7 +64,7 @@  discard block
 
 block discarded – undo
64 64 
      */
65 65 
     public static function randomOneOrNull(RepositoryInterface $repository, $chanceOfRandomOne)
66 66 
     {
67 
-        return function (Options $options) use ($repository, $chanceOfRandomOne) {
67 
+        return function(Options $options) use ($repository, $chanceOfRandomOne) {
68 68 
             if (mt_rand(1, 100) > $chanceOfRandomOne) {
69 69 
                 return null;
70 70 
             }
 
@@ -87,7 +87,7 @@  discard block
 
 block discarded – undo
87 87 
      */
88 88 
     public static function randomOnes(RepositoryInterface $repository, $amount)
89 89 
     {
90 
-        return function (Options $options) use ($repository, $amount) {
90 
+        return function(Options $options) use ($repository, $amount) {
91 91 
             $objects = $repository->findAll();
92 92
93 93 
             if ($objects instanceof Collection) {
 
@@ -114,7 +114,7 @@  discard block
 
 block discarded – undo
114 114 
      */
115 115 
     public static function all(RepositoryInterface $repository)
116 116 
     {
117 
-        return function (Options $options) use ($repository) {
117 
+        return function(Options $options) use ($repository) {
118 118 
             return $repository->findAll();
119 119 
         };
120 120 
     }
 
@@ -127,7 +127,7 @@  discard block
 
 block discarded – undo
127 127 
      */
128 128 
     public static function findBy(RepositoryInterface $repository, $field)
129 129 
     {
130 
-        return function (Options $options, $previousValues) use ($repository, $field) {
130 
+        return function(Options $options, $previousValues) use ($repository, $field) {
131 131 
             if (null === $previousValues || [] === $previousValues) {
132 132 
                 return $previousValues;
133 133 
             }
 
@@ -155,7 +155,7 @@  discard block
 
 block discarded – undo
155 155 
      */
156 156 
     public static function findOneBy(RepositoryInterface $repository, $field)
157 157 
     {
158 
-        return function (Options $options, $previousValue) use ($repository, $field) {
158 
+        return function(Options $options, $previousValue) use ($repository, $field) {
159 159 
             if (null === $previousValue || [] === $previousValue) {
160 160 
                 return $previousValue;
161 161 
             }
Please login to merge, or discard this patch.
src/AppBundle/Fixture/Factory/OAuthClientExampleFactory.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -56,10 +56,10 @@  discard block
 
 block discarded – undo
56 56 
     protected function configureOptions(OptionsResolver $resolver)
57 57 
     {
58 58 
         $resolver
59 
-            ->setDefault('random_id', function (Options $options) {
59 
+            ->setDefault('random_id', function(Options $options) {
60 60 
                 return $this->faker->sha1;
61 61 
             })
62 
-            ->setDefault('secret', function (Options $options) {
62 
+            ->setDefault('secret', function(Options $options) {
63 63 
                 return $this->faker->sha1;
64 64 
             });
65 65 
     }
 
@@ -75,7 +75,7 @@  discard block
 
 block discarded – undo
75 75 
         $client = $this->oauthClientFactory->createNew();
76 76 
         $client->setRandomId($options['random_id']);
77 77 
         $client->setSecret($options['secret']);
78 
-        $client->setAllowedGrantTypes(['password','refresh_token','token']);
78 
+        $client->setAllowedGrantTypes(['password', 'refresh_token', 'token']);
79 79
80 80 
         return $client;
81 81 
     }
Please login to merge, or discard this patch.
src/AppBundle/Fixture/Factory/AdminUserExampleFactory.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -81,7 +81,7 @@
 
 block discarded – undo
81 81 
     protected function configureOptions(OptionsResolver $resolver)
82 82 
     {
83 83 
         $resolver
84 
-            ->setDefault('email', function (Options $options) {
84 
+            ->setDefault('email', function(Options $options) {
85 85 
                 return $this->faker->email;
86 86 
             })
87 87 
             ->setDefault('enabled', true)
Please login to merge, or discard this patch.
src/AppBundle/Fixture/Factory/AddressExampleFactory.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -55,13 +55,13 @@
 
 block discarded – undo
55 55 
     protected function configureOptions(OptionsResolver $resolver)
56 56 
     {
57 57 
         $resolver
58 
-            ->setDefault('street', function (Options $options) {
58 
+            ->setDefault('street', function(Options $options) {
59 59 
                 return $this->faker->streetAddress;
60 60 
             })
61 
-            ->setDefault('city', function (Options $options) {
61 
+            ->setDefault('city', function(Options $options) {
62 62 
                 return $this->faker->city;
63 63 
             })
64 
-            ->setDefault('postcode', function (Options $options) {
64 
+            ->setDefault('postcode', function(Options $options) {
65 65 
                 return $this->faker->postcode;
66 66 
             });
67 67 
     }
Please login to merge, or discard this patch.
src/AppBundle/Fixture/Factory/AppUserExampleFactory.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -86,7 +86,7 @@
 
 block discarded – undo
86 86 
     protected function configureOptions(OptionsResolver $resolver)
87 87 
     {
88 88 
         $resolver
89 
-            ->setDefault('email', function (Options $options) {
89 
+            ->setDefault('email', function(Options $options) {
90 90 
                 return $this->faker->email;
91 91 
             })
92 92 
             ->setDefault('enabled', true)
Please login to merge, or discard this patch.