Passed
Push — master ( 9c5f94...c5c65d )
by Sebastian
03:20
created
src/Mailcode/Translator/Syntax/ApacheVelocity/Base/AbstractIf.php 2 patches
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -33,11 +33,11 @@  discard block
 block discarded – undo
33 33
         
34 34
         $keywords = $command->getLogicKeywords()->getKeywords();
35 35
         
36
-        foreach($keywords as $keyword)
36
+        foreach ($keywords as $keyword)
37 37
         {
38 38
             $keyCommand = $keyword->getCommand();
39 39
             
40
-            if($keyCommand instanceof Mailcode_Commands_IfBase)
40
+            if ($keyCommand instanceof Mailcode_Commands_IfBase)
41 41
             {
42 42
                 $body .= ' '.$this->getSign($keyword).' '.$this->translateBody($keyCommand);
43 43
             }
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
60 60
     
61 61
     protected function getSign(Mailcode_Commands_LogicKeywords_Keyword $keyword) : string
62 62
     {
63
-        switch($keyword->getName())
63
+        switch ($keyword->getName())
64 64
         {
65 65
             case 'and':
66 66
                 return '&&';
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
     {
84 84
         $sign = '';
85 85
         
86
-        if($notEmpty)
86
+        if ($notEmpty)
87 87
         {
88 88
             $sign = '!';
89 89
         }
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
99 99
     {
100 100
         $params = $command->getParams();
101 101
         
102
-        if(!$params)
102
+        if (!$params)
103 103
         {
104 104
             return '';
105 105
         }
@@ -120,7 +120,7 @@  discard block
 block discarded – undo
120 120
     protected function _translateContains(Mailcode_Variables_Variable $variable, bool $caseSensitive, string $searchTerm) : string
121 121
     {
122 122
         $opts = 's';
123
-        if($caseSensitive)
123
+        if ($caseSensitive)
124 124
         {
125 125
             $opts = 'is';
126 126
         }
Please login to merge, or discard this patch.
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -40,8 +40,7 @@
 block discarded – undo
40 40
             if($keyCommand instanceof Mailcode_Commands_IfBase)
41 41
             {
42 42
                 $body .= ' '.$this->getSign($keyword).' '.$this->translateBody($keyCommand);
43
-            }
44
-            else
43
+            } else
45 44
             {
46 45
                 throw new Mailcode_Exception(
47 46
                     'Keyword command type does not match expected base class.',
Please login to merge, or discard this patch.
src/Mailcode/Commands/LogicKeywords.php 2 patches
Indentation   +45 added lines, -45 removed lines patch added patch discarded remove patch
@@ -31,27 +31,27 @@  discard block
 block discarded – undo
31 31
     const VALIDATION_CANNOT_MIX_LOGIC_KEYWORDS = 60701;
32 32
     const VALIDATION_INVALID_SUB_COMMAND = 60702;
33 33
     
34
-   /**
35
-    * @var string
36
-    */
34
+    /**
35
+     * @var string
36
+     */
37 37
     private $paramsString;
38 38
     
39
-   /**
40
-    * @var string[]
41
-    */
39
+    /**
40
+     * @var string[]
41
+     */
42 42
     private $names = array(
43 43
         'and', 
44 44
         'or'
45 45
     );
46 46
     
47
-   /**
48
-    * @var Mailcode_Commands_LogicKeywords_Keyword[]
49
-    */
47
+    /**
48
+     * @var Mailcode_Commands_LogicKeywords_Keyword[]
49
+     */
50 50
     private $keywords = array();
51 51
     
52
-   /**
53
-    * @var string
54
-    */
52
+    /**
53
+     * @var string
54
+     */
55 55
     private $mainParams = '';
56 56
     
57 57
     public function __construct(Mailcode_Commands_Command $command, string $paramsString)
@@ -136,9 +136,9 @@  discard block
 block discarded – undo
136 136
         }
137 137
     }
138 138
     
139
-   /**
140
-    * @return string[]
141
-    */
139
+    /**
140
+     * @return string[]
141
+     */
142 142
     private function detectParameters() : array
143 143
     {
144 144
         $params = $this->paramsString;
@@ -156,13 +156,13 @@  discard block
 block discarded – undo
156 156
         return $stack;
157 157
     }
158 158
 
159
-   /**
160
-    * @param string $params
161
-    * @param Mailcode_Commands_LogicKeywords_Keyword $keyword
162
-    * @param string[] $stack
163
-    * @throws Mailcode_Exception
164
-    * @return string
165
-    */
159
+    /**
160
+     * @param string $params
161
+     * @param Mailcode_Commands_LogicKeywords_Keyword $keyword
162
+     * @param string[] $stack
163
+     * @throws Mailcode_Exception
164
+     * @return string
165
+     */
166 166
     private function detectParamsKeyword(string $params, Mailcode_Commands_LogicKeywords_Keyword $keyword, array &$stack) : string
167 167
     {
168 168
         $search = $keyword->getMatchedString();
@@ -187,22 +187,22 @@  discard block
 block discarded – undo
187 187
         return $params;
188 188
     }
189 189
     
190
-   /**
191
-    * Extracts the parameters string to use for the 
192
-    * original command itself, omitting all the logic
193
-    * keywords for the sub-commands.
194
-    * 
195
-    * @return string
196
-    */
190
+    /**
191
+     * Extracts the parameters string to use for the 
192
+     * original command itself, omitting all the logic
193
+     * keywords for the sub-commands.
194
+     * 
195
+     * @return string
196
+     */
197 197
     public function getMainParamsString() : string
198 198
     {
199 199
         return $this->mainParams;
200 200
     }
201 201
     
202
-   /**
203
-    * Retrieves the detected keyword names.
204
-    * @return string[]
205
-    */
202
+    /**
203
+     * Retrieves the detected keyword names.
204
+     * @return string[]
205
+     */
206 206
     public function getDetectedNames() : array
207 207
     {
208 208
         $names = array();
@@ -220,23 +220,23 @@  discard block
 block discarded – undo
220 220
         return $names;
221 221
     }
222 222
     
223
-   /**
224
-    * Retrieves all keywords that were detected in the
225
-    * command's parameters string, if any.
226
-    * 
227
-    * @return Mailcode_Commands_LogicKeywords_Keyword[]
228
-    */
223
+    /**
224
+     * Retrieves all keywords that were detected in the
225
+     * command's parameters string, if any.
226
+     * 
227
+     * @return Mailcode_Commands_LogicKeywords_Keyword[]
228
+     */
229 229
     public function getKeywords() : array
230 230
     {
231 231
         return $this->keywords;
232 232
     }
233 233
     
234
-   /**
235
-    * Detects any keyword statements in the parameters by keyword name.
236
-    * 
237
-    * @param string $name
238
-    * @return Mailcode_Commands_LogicKeywords_Keyword[]
239
-    */
234
+    /**
235
+     * Detects any keyword statements in the parameters by keyword name.
236
+     * 
237
+     * @param string $name
238
+     * @return Mailcode_Commands_LogicKeywords_Keyword[]
239
+     */
240 240
     private function detectKeywords(string $name) : array
241 241
     {
242 242
         $regex = sprintf('/%1$s\s+([a-z\-0-9]+):|%1$s:/x', $name);
Please login to merge, or discard this patch.
Spacing   +20 added lines, -20 removed lines patch added patch discarded remove patch
@@ -71,9 +71,9 @@  discard block
 block discarded – undo
71 71
     
72 72
     private function parse() : void
73 73
     {
74
-        foreach($this->names as $name)
74
+        foreach ($this->names as $name)
75 75
         {
76
-            if(!stristr($this->paramsString, $name))
76
+            if (!stristr($this->paramsString, $name))
77 77
             {
78 78
                 continue;
79 79
             }
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
         $names = $this->getDetectedNames();
91 91
         $amount = count($names);
92 92
         
93
-        if($amount > 1)
93
+        if ($amount > 1)
94 94
         {
95 95
             $this->makeError(
96 96
                 t(
@@ -109,7 +109,7 @@  discard block
 block discarded – undo
109 109
     
110 110
     private function splitParams() : void
111 111
     {
112
-        if(empty($this->keywords))
112
+        if (empty($this->keywords))
113 113
         {
114 114
             $this->mainParams = $this->paramsString;
115 115
             
@@ -118,13 +118,13 @@  discard block
 block discarded – undo
118 118
         
119 119
         $params = $this->detectParameters();
120 120
         
121
-        foreach($this->keywords as $keyword)
121
+        foreach ($this->keywords as $keyword)
122 122
         {
123 123
             $kParams = array_shift($params);
124 124
             
125 125
             $keyword->setParamsString($kParams);
126 126
             
127
-            if(!$keyword->isValid())
127
+            if (!$keyword->isValid())
128 128
             {
129 129
                 $this->makeError(
130 130
                     t('Error #%1$s:', $keyword->getCode()).' '.$keyword->getErrorMessage(),
@@ -144,7 +144,7 @@  discard block
 block discarded – undo
144 144
         $params = $this->paramsString;
145 145
         $stack = array();
146 146
         
147
-        foreach($this->keywords as $keyword)
147
+        foreach ($this->keywords as $keyword)
148 148
         {
149 149
             $params = $this->detectParamsKeyword($params, $keyword, $stack);
150 150
         }
@@ -168,7 +168,7 @@  discard block
 block discarded – undo
168 168
         $search = $keyword->getMatchedString();
169 169
         $pos = strpos($params, $search, 0);
170 170
         
171
-        if($pos === false)
171
+        if ($pos === false)
172 172
         {
173 173
             throw new Mailcode_Exception(
174 174
                 'Keyword matched string not found',
@@ -180,7 +180,7 @@  discard block
 block discarded – undo
180 180
         $length = strlen($search);
181 181
         
182 182
         $store = substr($params, 0, $pos);
183
-        $params = trim(substr($params, $pos+$length));
183
+        $params = trim(substr($params, $pos + $length));
184 184
         
185 185
         $stack[] = $store;
186 186
         
@@ -207,11 +207,11 @@  discard block
 block discarded – undo
207 207
     {
208 208
         $names = array();
209 209
         
210
-        foreach($this->keywords as $keyword)
210
+        foreach ($this->keywords as $keyword)
211 211
         {
212 212
             $name = $keyword->getName();
213 213
             
214
-            if(!in_array($name, $names))
214
+            if (!in_array($name, $names))
215 215
             {
216 216
                 $names[] = $name;
217 217
             }
@@ -244,7 +244,7 @@  discard block
 block discarded – undo
244 244
         $matches = array();
245 245
         preg_match_all($regex, $this->paramsString, $matches, PREG_PATTERN_ORDER);
246 246
         
247
-        if(!isset($matches[0][0]) || empty($matches[0][0]))
247
+        if (!isset($matches[0][0]) || empty($matches[0][0]))
248 248
         {
249 249
             return array();
250 250
         }
@@ -252,7 +252,7 @@  discard block
 block discarded – undo
252 252
         $amount = count($matches[0]);
253 253
         $result = array();
254 254
         
255
-        for($i=0; $i < $amount; $i++)
255
+        for ($i = 0; $i < $amount; $i++)
256 256
         {
257 257
             $result[] = $this->createKeyword(
258 258
                 $name, 
@@ -269,22 +269,22 @@  discard block
 block discarded – undo
269 269
         return !empty($this->keywords);
270 270
     }
271 271
     
272
-    public function appendAND(string $paramsString, string $type='') : Mailcode_Commands_LogicKeywords_Keyword
272
+    public function appendAND(string $paramsString, string $type = '') : Mailcode_Commands_LogicKeywords_Keyword
273 273
     {
274 274
         return $this->appendKeyword('and', $paramsString, $type);
275 275
     }
276 276
     
277
-    public function appendOR(string $paramsString, string $type='') : Mailcode_Commands_LogicKeywords_Keyword
277
+    public function appendOR(string $paramsString, string $type = '') : Mailcode_Commands_LogicKeywords_Keyword
278 278
     {
279 279
         return $this->appendKeyword('or', $paramsString, $type);
280 280
     }
281 281
     
282
-    public function appendKeyword(string $name, string $paramsString, string $type='') : Mailcode_Commands_LogicKeywords_Keyword
282
+    public function appendKeyword(string $name, string $paramsString, string $type = '') : Mailcode_Commands_LogicKeywords_Keyword
283 283
     {
284 284
         $keyword = $this->createKeyword($name, $type);
285 285
         $keyword->setParamsString($paramsString);
286 286
         
287
-        if(!$keyword->isValid())
287
+        if (!$keyword->isValid())
288 288
         {
289 289
             throw new Mailcode_Exception(
290 290
                 'Cannot append invalid logic keyword',
@@ -305,13 +305,13 @@  discard block
 block discarded – undo
305 305
         return $keyword;
306 306
     }
307 307
     
308
-    private function createKeyword(string $name, string $type='', string $matchedString='') : Mailcode_Commands_LogicKeywords_Keyword
308
+    private function createKeyword(string $name, string $type = '', string $matchedString = '') : Mailcode_Commands_LogicKeywords_Keyword
309 309
     {
310
-        if(empty($matchedString))
310
+        if (empty($matchedString))
311 311
         {
312 312
             $matchedString = $name;
313 313
             
314
-            if(!empty($type))
314
+            if (!empty($type))
315 315
             {
316 316
                 $matchedString .= ' '.$type;
317 317
             }
Please login to merge, or discard this patch.
src/Mailcode/Commands/LogicKeywords/Keyword.php 2 patches
Indentation   +51 added lines, -51 removed lines patch added patch discarded remove patch
@@ -26,39 +26,39 @@  discard block
 block discarded – undo
26 26
     const ERROR_CANNOT_GET_INVALID_COMMAND = 60601;
27 27
     const ERROR_CANNOT_OVERWRITE_PARAMETERS = 60602;
28 28
     
29
-   /**
30
-    * @var Mailcode_Commands_LogicKeywords
31
-    */
29
+    /**
30
+     * @var Mailcode_Commands_LogicKeywords
31
+     */
32 32
     private $keywords;
33 33
     
34
-   /**
35
-    * @var string
36
-    */
34
+    /**
35
+     * @var string
36
+     */
37 37
     private $name;
38 38
     
39
-   /**
40
-    * @var string
41
-    */
39
+    /**
40
+     * @var string
41
+     */
42 42
     private $keywordType;
43 43
     
44
-   /**
45
-    * @var string
46
-    */
44
+    /**
45
+     * @var string
46
+     */
47 47
     private $matchedString;
48 48
     
49
-   /**
50
-    * @var string
51
-    */
49
+    /**
50
+     * @var string
51
+     */
52 52
     private $params = '';
53 53
     
54
-   /**
55
-    * @var boolean
56
-    */
54
+    /**
55
+     * @var boolean
56
+     */
57 57
     private $paramsSet = false;
58 58
     
59
-   /**
60
-    * @var Mailcode_Collection
61
-    */
59
+    /**
60
+     * @var Mailcode_Collection
61
+     */
62 62
     private $collection;
63 63
     
64 64
     public function __construct(Mailcode_Commands_LogicKeywords $keywords, string $name, string $matchedString, string $type)
@@ -69,10 +69,10 @@  discard block
 block discarded – undo
69 69
         $this->matchedString = $matchedString;
70 70
     }
71 71
     
72
-   /**
73
-    * The keyword name, e.g. "and". Always lowercase.
74
-    * @return string
75
-    */
72
+    /**
73
+     * The keyword name, e.g. "and". Always lowercase.
74
+     * @return string
75
+     */
76 76
     public function getName() : string
77 77
     {
78 78
         return $this->name;
@@ -95,24 +95,24 @@  discard block
 block discarded – undo
95 95
         return $string;
96 96
     }
97 97
     
98
-   /**
99
-    * The full string that was matched in the command's parameters
100
-    * string. Examples: "and:", "and variable:"...
101
-    * 
102
-    * @return string
103
-    */
98
+    /**
99
+     * The full string that was matched in the command's parameters
100
+     * string. Examples: "and:", "and variable:"...
101
+     * 
102
+     * @return string
103
+     */
104 104
     public function getMatchedString() : string
105 105
     {
106 106
         return $this->matchedString;
107 107
     }
108 108
     
109
-   /**
110
-    * Sets the parameters string matching this logic keyword,
111
-    * which is used to build the actual sub-command. Set by
112
-    * the LogicKeywords class instance.
113
-    * 
114
-    * @param string $params
115
-    */
109
+    /**
110
+     * Sets the parameters string matching this logic keyword,
111
+     * which is used to build the actual sub-command. Set by
112
+     * the LogicKeywords class instance.
113
+     * 
114
+     * @param string $params
115
+     */
116 116
     public function setParamsString(string $params) : void
117 117
     {
118 118
         if($this->paramsSet)
@@ -130,13 +130,13 @@  discard block
 block discarded – undo
130 130
         $this->createCommand();
131 131
     }
132 132
     
133
-   /**
134
-    * Retrieves the full command string used to create 
135
-    * the actual command. For opening commands like IF,
136
-    * this includes the closing {end} command.
137
-    * 
138
-    * @return string
139
-    */
133
+    /**
134
+     * Retrieves the full command string used to create 
135
+     * the actual command. For opening commands like IF,
136
+     * this includes the closing {end} command.
137
+     * 
138
+     * @return string
139
+     */
140 140
     public function getCommandString() : string
141 141
     {
142 142
         $command = $this->keywords->getCommand();
@@ -169,12 +169,12 @@  discard block
 block discarded – undo
169 169
         }
170 170
     }
171 171
     
172
-   /**
173
-    * Retrieves the command for the keyword.
174
-    * 
175
-    * @throws Mailcode_Exception
176
-    * @return Mailcode_Commands_Command
177
-    */
172
+    /**
173
+     * Retrieves the command for the keyword.
174
+     * 
175
+     * @throws Mailcode_Exception
176
+     * @return Mailcode_Commands_Command
177
+     */
178 178
     public function getCommand() : Mailcode_Commands_Command
179 179
     {
180 180
         $command = $this->collection->getFirstCommand();
Please login to merge, or discard this patch.
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
87 87
     {
88 88
         $string = $this->name;
89 89
         
90
-        if(!empty($this->keywordType))
90
+        if (!empty($this->keywordType))
91 91
         {
92 92
             $string .= ' '.$this->keywordType;
93 93
         }
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
     */
116 116
     public function setParamsString(string $params) : void
117 117
     {
118
-        if($this->paramsSet)
118
+        if ($this->paramsSet)
119 119
         {
120 120
             throw new Mailcode_Exception(
121 121
                 'Cannot set parameters twice',
@@ -149,7 +149,7 @@  discard block
 block discarded – undo
149 149
         );
150 150
         
151 151
         // automatically close opening commands to be able to parse valid strings.
152
-        if($command instanceof Mailcode_Commands_Command_Type_Opening)
152
+        if ($command instanceof Mailcode_Commands_Command_Type_Opening)
153 153
         {
154 154
             $string .= '{end}';
155 155
         }
@@ -161,7 +161,7 @@  discard block
 block discarded – undo
161 161
     {
162 162
         $this->collection = Mailcode::create()->parseString($this->getCommandString());
163 163
         
164
-        if(!$this->collection->isValid())
164
+        if (!$this->collection->isValid())
165 165
         {
166 166
             $error = $this->collection->getFirstError();
167 167
             
@@ -179,7 +179,7 @@  discard block
 block discarded – undo
179 179
     {
180 180
         $command = $this->collection->getFirstCommand();
181 181
         
182
-        if($this->collection->isValid() && $command !== null)
182
+        if ($this->collection->isValid() && $command !== null)
183 183
         {
184 184
             return $command;
185 185
         }
Please login to merge, or discard this patch.