Passed
Push — master ( c991d8...c23f05 )
by Sebastian
09:48
created
src/OperationResult.php 2 patches
Indentation   +73 added lines, -73 removed lines patch added patch discarded remove patch
@@ -32,46 +32,46 @@  discard block
 block discarded – undo
32 32
     const TYPE_ERROR = 'error';
33 33
     const TYPE_SUCCESS = 'success';
34 34
     
35
-   /**
36
-    * @var string
37
-    */
35
+    /**
36
+     * @var string
37
+     */
38 38
     protected $message = '';
39 39
     
40
-   /**
41
-    * @var bool
42
-    */
40
+    /**
41
+     * @var bool
42
+     */
43 43
     protected $valid = true;
44 44
   
45
-   /**
46
-    * @var object
47
-    */
45
+    /**
46
+     * @var object
47
+     */
48 48
     protected $subject;
49 49
     
50
-   /**
51
-    * @var integer
52
-    */
50
+    /**
51
+     * @var integer
52
+     */
53 53
     protected $code = 0;
54 54
     
55
-   /**
56
-    * @var string
57
-    */
55
+    /**
56
+     * @var string
57
+     */
58 58
     protected $type = '';
59 59
     
60
-   /**
61
-    * @var integer
62
-    */
60
+    /**
61
+     * @var integer
62
+     */
63 63
     private static $counter = 0;
64 64
     
65
-   /**
66
-    * @var int
67
-    */
65
+    /**
66
+     * @var int
67
+     */
68 68
     private $id;
69 69
     
70
-   /**
71
-    * The subject being validated.
72
-    * 
73
-    * @param object $subject
74
-    */
70
+    /**
71
+     * The subject being validated.
72
+     * 
73
+     * @param object $subject
74
+     */
75 75
     public function __construct(object $subject)
76 76
     {
77 77
         $this->subject = $subject;
@@ -81,21 +81,21 @@  discard block
 block discarded – undo
81 81
         $this->id = self::$counter;
82 82
     }
83 83
     
84
-   /**
85
-    * Retrieves the ID of the result, which is unique within a request.
86
-    * 
87
-    * @return int
88
-    */
84
+    /**
85
+     * Retrieves the ID of the result, which is unique within a request.
86
+     * 
87
+     * @return int
88
+     */
89 89
     public function getID() : int
90 90
     {
91 91
         return $this->id;
92 92
     }
93 93
     
94
-   /**
95
-    * Whether the validation was successful.
96
-    * 
97
-    * @return bool
98
-    */
94
+    /**
95
+     * Whether the validation was successful.
96
+     * 
97
+     * @return bool
98
+     */
99 99
     public function isValid() : bool
100 100
     {
101 101
         return $this->valid;
@@ -126,33 +126,33 @@  discard block
 block discarded – undo
126 126
         return $this->type === $type;
127 127
     }
128 128
     
129
-   /**
130
-    * Retrieves the subject that was validated.
131
-    * 
132
-    * @return object
133
-    */
129
+    /**
130
+     * Retrieves the subject that was validated.
131
+     * 
132
+     * @return object
133
+     */
134 134
     public function getSubject() : object
135 135
     {
136 136
         return $this->subject;
137 137
     }
138 138
     
139
-   /**
140
-    * Makes the result a succes, with the specified message.
141
-    * 
142
-    * @param string $message Should not contain a date, just the system specific info.
143
-    * @return OperationResult
144
-    */
139
+    /**
140
+     * Makes the result a succes, with the specified message.
141
+     * 
142
+     * @param string $message Should not contain a date, just the system specific info.
143
+     * @return OperationResult
144
+     */
145 145
     public function makeSuccess(string $message, int $code=0) : OperationResult
146 146
     {
147 147
         return $this->setMessage(self::TYPE_SUCCESS, $message, $code, true);
148 148
     }
149 149
     
150
-   /**
151
-    * Sets the result as an error.
152
-    * 
153
-    * @param string $message Should be as detailed as possible.
154
-    * @return OperationResult
155
-    */
150
+    /**
151
+     * Sets the result as an error.
152
+     * 
153
+     * @param string $message Should be as detailed as possible.
154
+     * @return OperationResult
155
+     */
156 156
     public function makeError(string $message, int $code=0) : OperationResult
157 157
     {
158 158
         return $this->setMessage(self::TYPE_ERROR, $message, $code, false);
@@ -183,21 +183,21 @@  discard block
 block discarded – undo
183 183
         return $this->type;
184 184
     }
185 185
     
186
-   /**
187
-    * Retrieves the error message, if an error occurred.
188
-    * 
189
-    * @return string The error message, or an empty string if no error occurred.
190
-    */
186
+    /**
187
+     * Retrieves the error message, if an error occurred.
188
+     * 
189
+     * @return string The error message, or an empty string if no error occurred.
190
+     */
191 191
     public function getErrorMessage() : string
192 192
     {
193 193
         return $this->getMessage(self::TYPE_ERROR);
194 194
     }
195 195
     
196
-   /**
197
-    * Retrieves the success message, if one has been provided.
198
-    * 
199
-    * @return string
200
-    */
196
+    /**
197
+     * Retrieves the success message, if one has been provided.
198
+     * 
199
+     * @return string
200
+     */
201 201
     public function getSuccessMessage() : string
202 202
     {
203 203
         return $this->getMessage(self::TYPE_SUCCESS);
@@ -213,21 +213,21 @@  discard block
 block discarded – undo
213 213
         return $this->getMessage(self::TYPE_WARNING);
214 214
     }
215 215
     
216
-   /**
217
-    * Whether a specific error/success code has been specified.
218
-    * 
219
-    * @return bool
220
-    */
216
+    /**
217
+     * Whether a specific error/success code has been specified.
218
+     * 
219
+     * @return bool
220
+     */
221 221
     public function hasCode() : bool
222 222
     {
223 223
         return $this->code > 0;
224 224
     }
225 225
     
226
-   /**
227
-    * Retrieves the error/success code, if any. 
228
-    * 
229
-    * @return int The error code, or 0 if none.
230
-    */
226
+    /**
227
+     * Retrieves the error/success code, if any. 
228
+     * 
229
+     * @return int The error code, or 0 if none.
230
+     */
231 231
     public function getCode() : int
232 232
     {
233 233
         return $this->code;
Please login to merge, or discard this patch.
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -142,7 +142,7 @@  discard block
 block discarded – undo
142 142
     * @param string $message Should not contain a date, just the system specific info.
143 143
     * @return OperationResult
144 144
     */
145
-    public function makeSuccess(string $message, int $code=0) : OperationResult
145
+    public function makeSuccess(string $message, int $code = 0) : OperationResult
146 146
     {
147 147
         return $this->setMessage(self::TYPE_SUCCESS, $message, $code, true);
148 148
     }
@@ -153,7 +153,7 @@  discard block
 block discarded – undo
153 153
     * @param string $message Should be as detailed as possible.
154 154
     * @return OperationResult
155 155
     */
156
-    public function makeError(string $message, int $code=0) : OperationResult
156
+    public function makeError(string $message, int $code = 0) : OperationResult
157 157
     {
158 158
         return $this->setMessage(self::TYPE_ERROR, $message, $code, false);
159 159
     }
@@ -233,11 +233,11 @@  discard block
 block discarded – undo
233 233
         return $this->code;
234 234
     }
235 235
     
236
-    public function getMessage(string $type='') : string
236
+    public function getMessage(string $type = '') : string
237 237
     {
238
-        if(!empty($type))
238
+        if (!empty($type))
239 239
         {
240
-            if($this->type === $type)
240
+            if ($this->type === $type)
241 241
             {
242 242
                 return $this->message;
243 243
             }
Please login to merge, or discard this patch.
src/OperationResult/Collection.php 3 patches
Indentation   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -26,9 +26,9 @@  discard block
 block discarded – undo
26 26
  */
27 27
 class OperationResult_Collection extends OperationResult
28 28
 {
29
-   /**
30
-    * @var OperationResult[]
31
-    */
29
+    /**
30
+     * @var OperationResult[]
31
+     */
32 32
     protected $results = array();
33 33
     
34 34
     public function makeError(string $message, int $code=0) : OperationResult
@@ -106,9 +106,9 @@  discard block
 block discarded – undo
106 106
         return $this;
107 107
     }
108 108
     
109
-   /**
110
-    * @return OperationResult[]
111
-    */
109
+    /**
110
+     * @return OperationResult[]
111
+     */
112 112
     public function getResults() : array
113 113
     {
114 114
         return $this->results;
Please login to merge, or discard this patch.
Spacing   +26 added lines, -26 removed lines patch added patch discarded remove patch
@@ -31,27 +31,27 @@  discard block
 block discarded – undo
31 31
     */
32 32
     protected $results = array();
33 33
     
34
-    public function makeError(string $message, int $code=0) : OperationResult
34
+    public function makeError(string $message, int $code = 0) : OperationResult
35 35
     {
36 36
         return $this->add('makeError', $message, $code);
37 37
     }
38 38
     
39
-    public function makeSuccess(string $message, int $code=0) : OperationResult
39
+    public function makeSuccess(string $message, int $code = 0) : OperationResult
40 40
     {
41 41
         return $this->add('makeSuccess', $message, $code);
42 42
     }
43 43
 
44
-    public function makeWarning(string $message, int $code=0) : OperationResult
44
+    public function makeWarning(string $message, int $code = 0) : OperationResult
45 45
     {
46 46
         return $this->add('makeWarning', $message, $code);
47 47
     }
48 48
     
49
-    public function makeNotice(string $message, int $code=0) : OperationResult
49
+    public function makeNotice(string $message, int $code = 0) : OperationResult
50 50
     {
51 51
         return $this->add('makeNotice', $message, $code);
52 52
     }
53 53
     
54
-    protected function add(string $method, string $message, int $code=0) : OperationResult
54
+    protected function add(string $method, string $message, int $code = 0) : OperationResult
55 55
     {
56 56
         $result = new OperationResult($this->subject);
57 57
         $result->$method($message, $code);
@@ -63,7 +63,7 @@  discard block
 block discarded – undo
63 63
     
64 64
     public function addResult(OperationResult $result) : OperationResult_Collection
65 65
     {
66
-        if($result instanceof OperationResult_Collection)
66
+        if ($result instanceof OperationResult_Collection)
67 67
         {
68 68
             return $this->importCollection($result);
69 69
         }
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
     {
76 76
         $results = $collection->getResults();
77 77
         
78
-        foreach($results as $result)
78
+        foreach ($results as $result)
79 79
         {
80 80
             $this->addResult($result);
81 81
         }
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
92 92
         // the subjects are the same, this is actually the better way.
93 93
         $new = new OperationResult($this->subject);
94 94
         
95
-        if($result->isValid())
95
+        if ($result->isValid())
96 96
         {
97 97
             $new->makeSuccess($result->getSuccessMessage(), $result->getCode());
98 98
         }
@@ -116,9 +116,9 @@  discard block
 block discarded – undo
116 116
     
117 117
     public function isValid() : bool
118 118
     {
119
-        foreach($this->results as $result)
119
+        foreach ($this->results as $result)
120 120
         {
121
-            if(!$result->isValid())
121
+            if (!$result->isValid())
122 122
             {
123 123
                 return false;
124 124
             }
@@ -129,9 +129,9 @@  discard block
 block discarded – undo
129 129
     
130 130
     public function hasCode() : bool
131 131
     {
132
-        foreach($this->results as $result)
132
+        foreach ($this->results as $result)
133 133
         {
134
-            if($result->hasCode())
134
+            if ($result->hasCode())
135 135
             {
136 136
                 return true;
137 137
             }
@@ -142,9 +142,9 @@  discard block
 block discarded – undo
142 142
     
143 143
     public function getCode() : int
144 144
     {
145
-        foreach($this->results as $result)
145
+        foreach ($this->results as $result)
146 146
         {
147
-            if($result->hasCode())
147
+            if ($result->hasCode())
148 148
             {
149 149
                 return $result->getCode();
150 150
             }
@@ -153,13 +153,13 @@  discard block
 block discarded – undo
153 153
         return 0;
154 154
     }
155 155
     
156
-    public function getMessage(string $type='') : string
156
+    public function getMessage(string $type = '') : string
157 157
     {
158
-        foreach($this->results as $result)
158
+        foreach ($this->results as $result)
159 159
         {
160 160
             $msg = $result->getMessage($type);
161 161
             
162
-            if(!empty($msg))
162
+            if (!empty($msg))
163 163
             {
164 164
                 return $msg;
165 165
             }
@@ -170,9 +170,9 @@  discard block
 block discarded – undo
170 170
     
171 171
     public function containsCode(int $code) : bool
172 172
     {
173
-        foreach($this->results as $result)
173
+        foreach ($this->results as $result)
174 174
         {
175
-            if($result->getCode() === $code)
175
+            if ($result->getCode() === $code)
176 176
             {
177 177
                 return true;
178 178
             }
@@ -205,9 +205,9 @@  discard block
 block discarded – undo
205 205
     {
206 206
         $amount = 0;
207 207
         
208
-        foreach($this->results as $result)
208
+        foreach ($this->results as $result)
209 209
         {
210
-            if($result->isType($type))
210
+            if ($result->isType($type))
211 211
             {
212 212
                 $amount++;
213 213
             }
@@ -245,9 +245,9 @@  discard block
 block discarded – undo
245 245
     {
246 246
         $results = array();
247 247
         
248
-        foreach($this->results as $result)
248
+        foreach ($this->results as $result)
249 249
         {
250
-            if($result->isType($type))
250
+            if ($result->isType($type))
251 251
             {
252 252
                 $results[] = $result;
253 253
             }
@@ -258,9 +258,9 @@  discard block
 block discarded – undo
258 258
     
259 259
     public function isType(string $type) : bool
260 260
     {
261
-        foreach($this->results as $result)
261
+        foreach ($this->results as $result)
262 262
         {
263
-            if($result->isType($type))
263
+            if ($result->isType($type))
264 264
             {
265 265
                 return true;
266 266
             }
@@ -276,7 +276,7 @@  discard block
 block discarded – undo
276 276
         $lines[] = 'Collection #'.$this->getID();
277 277
         $lines[] = 'Subject: '.get_class($this->subject);
278 278
         
279
-        foreach($this->results as $result)
279
+        foreach ($this->results as $result)
280 280
         {
281 281
             $lines[] = ' - '.$result->getType().' #'.$result->getCode().' "'.$result->getMessage($result->getType()).'"';
282 282
         }
Please login to merge, or discard this patch.
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -95,8 +95,7 @@
 block discarded – undo
95 95
         if($result->isValid())
96 96
         {
97 97
             $new->makeSuccess($result->getSuccessMessage(), $result->getCode());
98
-        }
99
-        else
98
+        } else
100 99
         {
101 100
             $new->makeError($result->getErrorMessage(), $result->getCode());
102 101
         }
Please login to merge, or discard this patch.