Inspection of "v1.6.2 [improvement] XML reader refactoring. Imple..." - Micro-PHP/dto - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Retried Inspection

Pull Request — master (#12)

by Stanislau

created 2023-02-17 20:36 UTC

Status

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -41,7 +41,7 @@  discard block
 block discarded – undo
 
         $this->createPath($path);
 
-        file_put_contents($path.\DIRECTORY_SEPARATOR.$file, $renderedClassData);
+        file_put_contents($path . \DIRECTORY_SEPARATOR . $file, $renderedClassData);
     }
 
     /**
@@ -59,11 +59,11 @@  discard block
 block discarded – undo
         $path = rtrim($this->classFilePath, '\\');
         if (1 !== \count($classExploded)) {
             $file = array_pop($explodedFile);
-            $path = $path.'\\'.implode(\DIRECTORY_SEPARATOR, $explodedFile);
+            $path = $path . '\\' . implode(\DIRECTORY_SEPARATOR, $explodedFile);
         }
 
         return [
-            'file' => $file.'.php',
+            'file' => $file . '.php',
             'path' => str_replace('\\', '/', $path),
         ];
     }

Please login to merge, or discard this patch.

src/Preparation/Processor/Property/Assert/UuidStrategy.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -27,7 +27,7 @@
 block discarded – undo
             'V1_MAC', 'V2_DCE', 'V3_MD5', 'V4_RANDOM', 'V5_SHA1', 'V6_SORTABLE', 'V7_MONOTONIC',
         ];
 
-        return array_filter(array_map(function (string $constName) {
+        return array_filter(array_map(function(string $constName) {
             $cName = sprintf('%s::%s', Uuid::class, $constName);
 
             return \defined($cName) ? \constant($cName) : null;

Please login to merge, or discard this patch.

example/example.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -79,8 +79,8 @@  discard block
 block discarded – undo
 $deserialized = $classSerializerFacade->fromJsonTransfer($jsonDto);
 
 $className = get_class($user);
-$okNo = get_class($deserialized) === $className ?'true' : 'false';
-print_r( "Deserialize $className: $okNo \r\n");
+$okNo = get_class($deserialized) === $className ? 'true' : 'false';
+print_r("Deserialize $className: $okNo \r\n");
 
 /**
  * Validate DTO example
@@ -117,7 +117,7 @@  discard block
 block discarded – undo
 $validator = new ValidatorFacadeDefault();
 $constraints = $validator->validate($simpleUser);
 
-$validationStatus = !count($constraints) ? 'Validated': 'Validation error';
+$validationStatus = !count($constraints) ? 'Validated' : 'Validation error';
 
 print_r("Validation status: $validationStatus\r\n");
 

Please login to merge, or discard this patch.

src/Preparation/Processor/Property/Assert/ChoiceStrategy.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -48,7 +48,7 @@
 block discarded – undo
 
         $values = $this->explodeString($choices);
 
-        return array_map(function (mixed $value) {
+        return array_map(function(mixed $value) {
             return $this->sanitize($value);
         }, $values);
     }

Please login to merge, or discard this patch.

example/out/Simple/SimpleUserTransfer.php 1 patch

Spacing +45 added lines, -45 removed lines patch added patch discarded remove patch

@@ -358,11 +358,11 @@  discard block
 block discarded – undo
 
     protected static function attributesMetadata(): array
     {
-        return array (
+        return array(
           'parent' =>
-          array (
+          array(
             'type' =>
-            array (
+            array(
               0 => 'Transfer\\Simple\\SimpleObjectTransfer',
               1 => 'null',
             ),
@@ -370,9 +370,9 @@  discard block
 block discarded – undo
             'actionName' => 'parent',
           ),
           'username' =>
-          array (
+          array(
             'type' =>
-            array (
+            array(
               0 => 'string',
               1 => 'null',
             ),
@@ -380,9 +380,9 @@  discard block
 block discarded – undo
             'actionName' => 'username',
           ),
           'age' =>
-          array (
+          array(
             'type' =>
-            array (
+            array(
               0 => 'int',
               1 => 'null',
             ),
@@ -390,9 +390,9 @@  discard block
 block discarded – undo
             'actionName' => 'age',
           ),
           'email' =>
-          array (
+          array(
             'type' =>
-            array (
+            array(
               0 => 'string',
               1 => 'null',
             ),
@@ -400,9 +400,9 @@  discard block
 block discarded – undo
             'actionName' => 'email',
           ),
           'ip' =>
-          array (
+          array(
             'type' =>
-            array (
+            array(
               0 => 'string',
               1 => 'null',
             ),
@@ -410,9 +410,9 @@  discard block
 block discarded – undo
             'actionName' => 'ip',
           ),
           'hostname' =>
-          array (
+          array(
             'type' =>
-            array (
+            array(
               0 => 'string',
               1 => 'null',
             ),
@@ -420,9 +420,9 @@  discard block
 block discarded – undo
             'actionName' => 'hostname',
           ),
           'sometext' =>
-          array (
+          array(
             'type' =>
-            array (
+            array(
               0 => 'string',
               1 => 'null',
             ),
@@ -430,9 +430,9 @@  discard block
 block discarded – undo
             'actionName' => 'sometext',
           ),
           'url' =>
-          array (
+          array(
             'type' =>
-            array (
+            array(
               0 => 'string',
               1 => 'null',
             ),
@@ -440,9 +440,9 @@  discard block
 block discarded – undo
             'actionName' => 'url',
           ),
           'json' =>
-          array (
+          array(
             'type' =>
-            array (
+            array(
               0 => 'string',
               1 => 'null',
             ),
@@ -450,9 +450,9 @@  discard block
 block discarded – undo
             'actionName' => 'json',
           ),
           'uuid' =>
-          array (
+          array(
             'type' =>
-            array (
+            array(
               0 => 'string',
               1 => 'null',
             ),
@@ -460,9 +460,9 @@  discard block
 block discarded – undo
             'actionName' => 'uuid',
           ),
           'created_at' =>
-          array (
+          array(
             'type' =>
-            array (
+            array(
               0 => 'string',
               1 => 'null',
             ),
@@ -470,9 +470,9 @@  discard block
 block discarded – undo
             'actionName' => 'createdAt',
           ),
           'updated_at' =>
-          array (
+          array(
             'type' =>
-            array (
+            array(
               0 => 'string',
               1 => 'null',
             ),
@@ -480,9 +480,9 @@  discard block
 block discarded – undo
             'actionName' => 'updatedAt',
           ),
           'timezone' =>
-          array (
+          array(
             'type' =>
-            array (
+            array(
               0 => 'string',
               1 => 'null',
             ),
@@ -490,9 +490,9 @@  discard block
 block discarded – undo
             'actionName' => 'timezone',
           ),
           'card_scheme' =>
-          array (
+          array(
             'type' =>
-            array (
+            array(
               0 => 'string',
               1 => 'null',
             ),
@@ -500,9 +500,9 @@  discard block
 block discarded – undo
             'actionName' => 'cardScheme',
           ),
           'bic' =>
-          array (
+          array(
             'type' =>
-            array (
+            array(
               0 => 'string',
               1 => 'null',
             ),
@@ -510,9 +510,9 @@  discard block
 block discarded – undo
             'actionName' => 'bic',
           ),
           'currency' =>
-          array (
+          array(
             'type' =>
-            array (
+            array(
               0 => 'string',
               1 => 'null',
             ),
@@ -520,9 +520,9 @@  discard block
 block discarded – undo
             'actionName' => 'currency',
           ),
           'iban' =>
-          array (
+          array(
             'type' =>
-            array (
+            array(
               0 => 'string',
               1 => 'null',
             ),
@@ -530,9 +530,9 @@  discard block
 block discarded – undo
             'actionName' => 'iban',
           ),
           'isbn' =>
-          array (
+          array(
             'type' =>
-            array (
+            array(
               0 => 'string',
               1 => 'null',
             ),
@@ -540,9 +540,9 @@  discard block
 block discarded – undo
             'actionName' => 'isbn',
           ),
           'issn' =>
-          array (
+          array(
             'type' =>
-            array (
+            array(
               0 => 'string',
               1 => 'null',
             ),
@@ -550,9 +550,9 @@  discard block
 block discarded – undo
             'actionName' => 'issn',
           ),
           'isin' =>
-          array (
+          array(
             'type' =>
-            array (
+            array(
               0 => 'string',
               1 => 'null',
             ),
@@ -560,9 +560,9 @@  discard block
 block discarded – undo
             'actionName' => 'isin',
           ),
           'choice' =>
-          array (
+          array(
             'type' =>
-            array (
+            array(
               0 => 'string',
               1 => 'int',
               2 => 'float',
@@ -573,9 +573,9 @@  discard block
 block discarded – undo
             'actionName' => 'choice',
           ),
           'expression' =>
-          array (
+          array(
             'type' =>
-            array (
+            array(
               0 => 'string',
               1 => 'int',
               2 => 'null',

Please login to merge, or discard this patch.

		@@ -79,8 +79,8 @@ discard block
		block discarded – undo
79	79	$deserialized = $classSerializerFacade->fromJsonTransfer($jsonDto);
80	80
81	81	$className = get_class($user);
82		-$okNo = get_class($deserialized) === $className ?'true' : 'false';
83		-print_r( "Deserialize $className: $okNo \r\n");
	82	+$okNo = get_class($deserialized) === $className ? 'true' : 'false';
	83	+print_r("Deserialize $className: $okNo \r\n");
84	84
85	85	/**
86	86	* Validate DTO example
		@@ -117,7 +117,7 @@ discard block
		block discarded – undo
117	117	$validator = new ValidatorFacadeDefault();
118	118	$constraints = $validator->validate($simpleUser);
119	119
120		-$validationStatus = !count($constraints) ? 'Validated': 'Validation error';
	120	+$validationStatus = !count($constraints) ? 'Validated' : 'Validation error';
121	121
122	122	print_r("Validation status: $validationStatus\r\n");
123	123

		@@ -41,7 +41,7 @@ discard block
		block discarded – undo
41	41
42	42	$this->createPath($path);
43	43
44		- file_put_contents($path.\DIRECTORY_SEPARATOR.$file, $renderedClassData);
	44	+ file_put_contents($path . \DIRECTORY_SEPARATOR . $file, $renderedClassData);
45	45	}
46	46
47	47	/**
		@@ -59,11 +59,11 @@ discard block
		block discarded – undo
59	59	$path = rtrim($this->classFilePath, '\\');
60	60	if (1 !== \count($classExploded)) {
61	61	$file = array_pop($explodedFile);
62		- $path = $path.'\\'.implode(\DIRECTORY_SEPARATOR, $explodedFile);
	62	+ $path = $path . '\\' . implode(\DIRECTORY_SEPARATOR, $explodedFile);
63	63	}
64	64
65	65	return [
66		- 'file' => $file.'.php',
	66	+ 'file' => $file . '.php',
67	67	'path' => str_replace('\\', '/', $path),
68	68	];
69	69	}

		@@ -27,7 +27,7 @@
		block discarded – undo
27	27	'V1_MAC', 'V2_DCE', 'V3_MD5', 'V4_RANDOM', 'V5_SHA1', 'V6_SORTABLE', 'V7_MONOTONIC',
28	28	];
29	29
30		- return array_filter(array_map(function (string $constName) {
	30	+ return array_filter(array_map(function(string $constName) {
31	31	$cName = sprintf('%s::%s', Uuid::class, $constName);
32	32
33	33	return \defined($cName) ? \constant($cName) : null;

		@@ -48,7 +48,7 @@
		block discarded – undo
48	48
49	49	$values = $this->explodeString($choices);
50	50
51		- return array_map(function (mixed $value) {
	51	+ return array_map(function(mixed $value) {
52	52	return $this->sanitize($value);
53	53	}, $values);
54	54	}

		@@ -358,11 +358,11 @@ discard block
		block discarded – undo
358	358
359	359	protected static function attributesMetadata(): array
360	360	{
361		- return array (
	361	+ return array(
362	362	'parent' =>
363		- array (
	363	+ array(
364	364	'type' =>
365		- array (
	365	+ array(
366	366	0 => 'Transfer\\Simple\\SimpleObjectTransfer',
367	367	1 => 'null',
368	368	),
		@@ -370,9 +370,9 @@ discard block
		block discarded – undo
370	370	'actionName' => 'parent',
371	371	),
372	372	'username' =>
373		- array (
	373	+ array(
374	374	'type' =>
375		- array (
	375	+ array(
376	376	0 => 'string',
377	377	1 => 'null',
378	378	),
		@@ -380,9 +380,9 @@ discard block
		block discarded – undo
380	380	'actionName' => 'username',
381	381	),
382	382	'age' =>
383		- array (
	383	+ array(
384	384	'type' =>
385		- array (
	385	+ array(
386	386	0 => 'int',
387	387	1 => 'null',
388	388	),
		@@ -390,9 +390,9 @@ discard block
		block discarded – undo
390	390	'actionName' => 'age',
391	391	),
392	392	'email' =>
393		- array (
	393	+ array(
394	394	'type' =>
395		- array (
	395	+ array(
396	396	0 => 'string',
397	397	1 => 'null',
398	398	),
		@@ -400,9 +400,9 @@ discard block
		block discarded – undo
400	400	'actionName' => 'email',
401	401	),
402	402	'ip' =>
403		- array (
	403	+ array(
404	404	'type' =>
405		- array (
	405	+ array(
406	406	0 => 'string',
407	407	1 => 'null',
408	408	),
		@@ -410,9 +410,9 @@ discard block
		block discarded – undo
410	410	'actionName' => 'ip',
411	411	),
412	412	'hostname' =>
413		- array (
	413	+ array(
414	414	'type' =>
415		- array (
	415	+ array(
416	416	0 => 'string',
417	417	1 => 'null',
418	418	),
		@@ -420,9 +420,9 @@ discard block
		block discarded – undo
420	420	'actionName' => 'hostname',
421	421	),
422	422	'sometext' =>
423		- array (
	423	+ array(
424	424	'type' =>
425		- array (
	425	+ array(
426	426	0 => 'string',
427	427	1 => 'null',
428	428	),
		@@ -430,9 +430,9 @@ discard block
		block discarded – undo
430	430	'actionName' => 'sometext',
431	431	),
432	432	'url' =>
433		- array (
	433	+ array(
434	434	'type' =>
435		- array (
	435	+ array(
436	436	0 => 'string',
437	437	1 => 'null',
438	438	),
		@@ -440,9 +440,9 @@ discard block
		block discarded – undo
440	440	'actionName' => 'url',
441	441	),
442	442	'json' =>
443		- array (
	443	+ array(
444	444	'type' =>
445		- array (
	445	+ array(
446	446	0 => 'string',
447	447	1 => 'null',
448	448	),
		@@ -450,9 +450,9 @@ discard block
		block discarded – undo
450	450	'actionName' => 'json',
451	451	),
452	452	'uuid' =>
453		- array (
	453	+ array(
454	454	'type' =>
455		- array (
	455	+ array(
456	456	0 => 'string',
457	457	1 => 'null',
458	458	),
		@@ -460,9 +460,9 @@ discard block
		block discarded – undo
460	460	'actionName' => 'uuid',
461	461	),
462	462	'created_at' =>
463		- array (
	463	+ array(
464	464	'type' =>
465		- array (
	465	+ array(
466	466	0 => 'string',
467	467	1 => 'null',
468	468	),
		@@ -470,9 +470,9 @@ discard block
		block discarded – undo
470	470	'actionName' => 'createdAt',
471	471	),
472	472	'updated_at' =>
473		- array (
	473	+ array(
474	474	'type' =>
475		- array (
	475	+ array(
476	476	0 => 'string',
477	477	1 => 'null',
478	478	),
		@@ -480,9 +480,9 @@ discard block
		block discarded – undo
480	480	'actionName' => 'updatedAt',
481	481	),
482	482	'timezone' =>
483		- array (
	483	+ array(
484	484	'type' =>
485		- array (
	485	+ array(
486	486	0 => 'string',
487	487	1 => 'null',
488	488	),
		@@ -490,9 +490,9 @@ discard block
		block discarded – undo
490	490	'actionName' => 'timezone',
491	491	),
492	492	'card_scheme' =>
493		- array (
	493	+ array(
494	494	'type' =>
495		- array (
	495	+ array(
496	496	0 => 'string',
497	497	1 => 'null',
498	498	),
		@@ -500,9 +500,9 @@ discard block
		block discarded – undo
500	500	'actionName' => 'cardScheme',
501	501	),
502	502	'bic' =>
503		- array (
	503	+ array(
504	504	'type' =>
505		- array (
	505	+ array(
506	506	0 => 'string',
507	507	1 => 'null',
508	508	),
		@@ -510,9 +510,9 @@ discard block
		block discarded – undo
510	510	'actionName' => 'bic',
511	511	),
512	512	'currency' =>
513		- array (
	513	+ array(
514	514	'type' =>
515		- array (
	515	+ array(
516	516	0 => 'string',
517	517	1 => 'null',
518	518	),
		@@ -520,9 +520,9 @@ discard block
		block discarded – undo
520	520	'actionName' => 'currency',
521	521	),
522	522	'iban' =>
523		- array (
	523	+ array(
524	524	'type' =>
525		- array (
	525	+ array(
526	526	0 => 'string',
527	527	1 => 'null',
528	528	),
		@@ -530,9 +530,9 @@ discard block
		block discarded – undo
530	530	'actionName' => 'iban',
531	531	),
532	532	'isbn' =>
533		- array (
	533	+ array(
534	534	'type' =>
535		- array (
	535	+ array(
536	536	0 => 'string',
537	537	1 => 'null',
538	538	),
		@@ -540,9 +540,9 @@ discard block
		block discarded – undo
540	540	'actionName' => 'isbn',
541	541	),
542	542	'issn' =>
543		- array (
	543	+ array(
544	544	'type' =>
545		- array (
	545	+ array(
546	546	0 => 'string',
547	547	1 => 'null',
548	548	),
		@@ -550,9 +550,9 @@ discard block
		block discarded – undo
550	550	'actionName' => 'issn',
551	551	),
552	552	'isin' =>
553		- array (
	553	+ array(
554	554	'type' =>
555		- array (
	555	+ array(
556	556	0 => 'string',
557	557	1 => 'null',
558	558	),
		@@ -560,9 +560,9 @@ discard block
		block discarded – undo
560	560	'actionName' => 'isin',
561	561	),
562	562	'choice' =>
563		- array (
	563	+ array(
564	564	'type' =>
565		- array (
	565	+ array(
566	566	0 => 'string',
567	567	1 => 'int',
568	568	2 => 'float',
		@@ -573,9 +573,9 @@ discard block
		block discarded – undo
573	573	'actionName' => 'choice',
574	574	),
575	575	'expression' =>
576		- array (
	576	+ array(
577	577	'type' =>
578		- array (
	578	+ array(
579	579	0 => 'string',
580	580	1 => 'int',
581	581	2 => 'null',

Micro-PHP / dto

Pull Request — master (#12)

Status

Category

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +45 added lines, -45 removed lines patch added patch discarded remove patch