Inspection of "v1.6.2 [improvement] XML reader refactoring. Imple..." - Micro-PHP/dto - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Retried Inspection

Pull Request — master (#12)

by Stanislau

created 2023-02-17 20:36 UTC

Status

Indentation +30 added lines, -30 removed lines patch added patch discarded remove patch

@@ -116,66 +116,66 @@
 block discarded – undo
     protected static function attributesMetadata(): array
     {
         return array (
-          'username' =>
-          array (
+            'username' =>
+            array (
             'type' =>
             array (
-              0 => 'string',
-              1 => 'int',
-              2 => 'null',
+                0 => 'string',
+                1 => 'int',
+                2 => 'null',
             ),
             'required' => false,
             'actionName' => 'username',
-          ),
-          'books' =>
-          array (
+            ),
+            'books' =>
+            array (
             'type' =>
             array (
-              0 => 'iterable',
-              1 => 'null',
+                0 => 'iterable',
+                1 => 'null',
             ),
             'required' => false,
             'actionName' => 'books',
-          ),
-          'first_name' =>
-          array (
+            ),
+            'first_name' =>
+            array (
             'type' =>
             array (
-              0 => 'string',
-              1 => 'int',
+                0 => 'string',
+                1 => 'int',
             ),
             'required' => true,
             'actionName' => 'firstName',
-          ),
-          'updatedAt' =>
-          array (
+            ),
+            'updatedAt' =>
+            array (
             'type' =>
             array (
-              0 => 'DateTimeInterface',
-              1 => 'null',
+                0 => 'DateTimeInterface',
+                1 => 'null',
             ),
             'required' => false,
             'actionName' => 'updatedAt',
-          ),
-          'someclass' =>
-          array (
+            ),
+            'someclass' =>
+            array (
             'type' =>
             array (
-              0 => 'Micro\\Library\\DTO\\Object\\AbstractDto',
-              1 => 'null',
+                0 => 'Micro\\Library\\DTO\\Object\\AbstractDto',
+                1 => 'null',
             ),
             'required' => false,
             'actionName' => 'someclass',
-          ),
-          'testMixed' =>
-          array (
+            ),
+            'testMixed' =>
+            array (
             'type' =>
             array (
-              0 => 'mixed',
+                0 => 'mixed',
             ),
             'required' => false,
             'actionName' => 'testMixed',
-          ),
+            ),
         );
     }
 }

Please login to merge, or discard this patch.

Spacing +16 added lines, -16 removed lines patch added patch discarded remove patch

@@ -68,17 +68,17 @@  discard block
 block discarded – undo
 
     public function setBooks(iterable|null $books): self
     {
-        if(!$books) {
+        if (!$books) {
                         $this->books = null;
 
                         return $this;
                     }
 
-                    if(!$this->books) {
+                    if (!$this->books) {
                         $this->books = new Collection();
                     }
 
-                    foreach($books as $item) {
+                    foreach ($books as $item) {
                         $this->books->add($item);
                     }
 
@@ -115,11 +115,11 @@  discard block
 block discarded – undo
 
     protected static function attributesMetadata(): array
     {
-        return array (
+        return array(
           'username' =>
-          array (
+          array(
             'type' =>
-            array (
+            array(
               0 => 'string',
               1 => 'int',
               2 => 'null',
@@ -128,9 +128,9 @@  discard block
 block discarded – undo
             'actionName' => 'username',
           ),
           'books' =>
-          array (
+          array(
             'type' =>
-            array (
+            array(
               0 => 'iterable',
               1 => 'null',
             ),
@@ -138,9 +138,9 @@  discard block
 block discarded – undo
             'actionName' => 'books',
           ),
           'first_name' =>
-          array (
+          array(
             'type' =>
-            array (
+            array(
               0 => 'string',
               1 => 'int',
             ),
@@ -148,9 +148,9 @@  discard block
 block discarded – undo
             'actionName' => 'firstName',
           ),
           'updatedAt' =>
-          array (
+          array(
             'type' =>
-            array (
+            array(
               0 => 'DateTimeInterface',
               1 => 'null',
             ),
@@ -158,9 +158,9 @@  discard block
 block discarded – undo
             'actionName' => 'updatedAt',
           ),
           'someclass' =>
-          array (
+          array(
             'type' =>
-            array (
+            array(
               0 => 'Micro\\Library\\DTO\\Object\\AbstractDto',
               1 => 'null',
             ),
@@ -168,9 +168,9 @@  discard block
 block discarded – undo
             'actionName' => 'someclass',
           ),
           'testMixed' =>
-          array (
+          array(
             'type' =>
-            array (
+            array(
               0 => 'mixed',
             ),
             'required' => false,

Please login to merge, or discard this patch.

example/out/Simple/SimpleObjectTransfer.php 2 patches

Indentation +15 added lines, -15 removed lines patch added patch discarded remove patch

@@ -59,36 +59,36 @@
 block discarded – undo
     protected static function attributesMetadata(): array
     {
         return array (
-          'weight' =>
-          array (
+            'weight' =>
+            array (
             'type' =>
             array (
-              0 => 'int',
-              1 => 'null',
+                0 => 'int',
+                1 => 'null',
             ),
             'required' => false,
             'actionName' => 'weight',
-          ),
-          'height' =>
-          array (
+            ),
+            'height' =>
+            array (
             'type' =>
             array (
-              0 => 'int',
-              1 => 'null',
+                0 => 'int',
+                1 => 'null',
             ),
             'required' => false,
             'actionName' => 'height',
-          ),
-          'parent' =>
-          array (
+            ),
+            'parent' =>
+            array (
             'type' =>
             array (
-              0 => 'Transfer\\Simple\\SimpleObjectTransfer',
-              1 => 'null',
+                0 => 'Transfer\\Simple\\SimpleObjectTransfer',
+                1 => 'null',
             ),
             'required' => false,
             'actionName' => 'parent',
-          ),
+            ),
         );
     }
 }

Please login to merge, or discard this patch.

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -58,11 +58,11 @@  discard block
 block discarded – undo
 
     protected static function attributesMetadata(): array
     {
-        return array (
+        return array(
           'weight' =>
-          array (
+          array(
             'type' =>
-            array (
+            array(
               0 => 'int',
               1 => 'null',
             ),
@@ -70,9 +70,9 @@  discard block
 block discarded – undo
             'actionName' => 'weight',
           ),
           'height' =>
-          array (
+          array(
             'type' =>
-            array (
+            array(
               0 => 'int',
               1 => 'null',
             ),
@@ -80,9 +80,9 @@  discard block
 block discarded – undo
             'actionName' => 'height',
           ),
           'parent' =>
-          array (
+          array(
             'type' =>
-            array (
+            array(
               0 => 'Transfer\\Simple\\SimpleObjectTransfer',
               1 => 'null',
             ),

Please login to merge, or discard this patch.

src/Preparation/Processor/Property/Assert/ChoiceStrategy.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -48,7 +48,7 @@
 block discarded – undo
 
         $values = $this->explodeString($choices);
 
-        return array_map(function (mixed $value) {
+        return array_map(function(mixed $value) {
             return $this->sanitize($value);
         }, $values);
     }

Please login to merge, or discard this patch.

		@@ -116,66 +116,66 @@
		block discarded – undo
116	116	protected static function attributesMetadata(): array
117	117	{
118	118	return array (
119		- 'username' =>
120		- array (
	119	+ 'username' =>
	120	+ array (
121	121	'type' =>
122	122	array (
123		- 0 => 'string',
124		- 1 => 'int',
125		- 2 => 'null',
	123	+ 0 => 'string',
	124	+ 1 => 'int',
	125	+ 2 => 'null',
126	126	),
127	127	'required' => false,
128	128	'actionName' => 'username',
129		- ),
130		- 'books' =>
131		- array (
	129	+ ),
	130	+ 'books' =>
	131	+ array (
132	132	'type' =>
133	133	array (
134		- 0 => 'iterable',
135		- 1 => 'null',
	134	+ 0 => 'iterable',
	135	+ 1 => 'null',
136	136	),
137	137	'required' => false,
138	138	'actionName' => 'books',
139		- ),
140		- 'first_name' =>
141		- array (
	139	+ ),
	140	+ 'first_name' =>
	141	+ array (
142	142	'type' =>
143	143	array (
144		- 0 => 'string',
145		- 1 => 'int',
	144	+ 0 => 'string',
	145	+ 1 => 'int',
146	146	),
147	147	'required' => true,
148	148	'actionName' => 'firstName',
149		- ),
150		- 'updatedAt' =>
151		- array (
	149	+ ),
	150	+ 'updatedAt' =>
	151	+ array (
152	152	'type' =>
153	153	array (
154		- 0 => 'DateTimeInterface',
155		- 1 => 'null',
	154	+ 0 => 'DateTimeInterface',
	155	+ 1 => 'null',
156	156	),
157	157	'required' => false,
158	158	'actionName' => 'updatedAt',
159		- ),
160		- 'someclass' =>
161		- array (
	159	+ ),
	160	+ 'someclass' =>
	161	+ array (
162	162	'type' =>
163	163	array (
164		- 0 => 'Micro\\Library\\DTO\\Object\\AbstractDto',
165		- 1 => 'null',
	164	+ 0 => 'Micro\\Library\\DTO\\Object\\AbstractDto',
	165	+ 1 => 'null',
166	166	),
167	167	'required' => false,
168	168	'actionName' => 'someclass',
169		- ),
170		- 'testMixed' =>
171		- array (
	169	+ ),
	170	+ 'testMixed' =>
	171	+ array (
172	172	'type' =>
173	173	array (
174		- 0 => 'mixed',
	174	+ 0 => 'mixed',
175	175	),
176	176	'required' => false,
177	177	'actionName' => 'testMixed',
178		- ),
	178	+ ),
179	179	);
180	180	}
181	181	}

		@@ -68,17 +68,17 @@ discard block
		block discarded – undo
68	68
69	69	public function setBooks(iterable\|null $books): self
70	70	{
71		- if(!$books) {
	71	+ if (!$books) {
72	72	$this->books = null;
73	73
74	74	return $this;
75	75	}
76	76
77		- if(!$this->books) {
	77	+ if (!$this->books) {
78	78	$this->books = new Collection();
79	79	}
80	80
81		- foreach($books as $item) {
	81	+ foreach ($books as $item) {
82	82	$this->books->add($item);
83	83	}
84	84
		@@ -115,11 +115,11 @@ discard block
		block discarded – undo
115	115
116	116	protected static function attributesMetadata(): array
117	117	{
118		- return array (
	118	+ return array(
119	119	'username' =>
120		- array (
	120	+ array(
121	121	'type' =>
122		- array (
	122	+ array(
123	123	0 => 'string',
124	124	1 => 'int',
125	125	2 => 'null',
		@@ -128,9 +128,9 @@ discard block
		block discarded – undo
128	128	'actionName' => 'username',
129	129	),
130	130	'books' =>
131		- array (
	131	+ array(
132	132	'type' =>
133		- array (
	133	+ array(
134	134	0 => 'iterable',
135	135	1 => 'null',
136	136	),
		@@ -138,9 +138,9 @@ discard block
		block discarded – undo
138	138	'actionName' => 'books',
139	139	),
140	140	'first_name' =>
141		- array (
	141	+ array(
142	142	'type' =>
143		- array (
	143	+ array(
144	144	0 => 'string',
145	145	1 => 'int',
146	146	),
		@@ -148,9 +148,9 @@ discard block
		block discarded – undo
148	148	'actionName' => 'firstName',
149	149	),
150	150	'updatedAt' =>
151		- array (
	151	+ array(
152	152	'type' =>
153		- array (
	153	+ array(
154	154	0 => 'DateTimeInterface',
155	155	1 => 'null',
156	156	),
		@@ -158,9 +158,9 @@ discard block
		block discarded – undo
158	158	'actionName' => 'updatedAt',
159	159	),
160	160	'someclass' =>
161		- array (
	161	+ array(
162	162	'type' =>
163		- array (
	163	+ array(
164	164	0 => 'Micro\\Library\\DTO\\Object\\AbstractDto',
165	165	1 => 'null',
166	166	),
		@@ -168,9 +168,9 @@ discard block
		block discarded – undo
168	168	'actionName' => 'someclass',
169	169	),
170	170	'testMixed' =>
171		- array (
	171	+ array(
172	172	'type' =>
173		- array (
	173	+ array(
174	174	0 => 'mixed',
175	175	),
176	176	'required' => false,

		@@ -59,36 +59,36 @@
		block discarded – undo
59	59	protected static function attributesMetadata(): array
60	60	{
61	61	return array (
62		- 'weight' =>
63		- array (
	62	+ 'weight' =>
	63	+ array (
64	64	'type' =>
65	65	array (
66		- 0 => 'int',
67		- 1 => 'null',
	66	+ 0 => 'int',
	67	+ 1 => 'null',
68	68	),
69	69	'required' => false,
70	70	'actionName' => 'weight',
71		- ),
72		- 'height' =>
73		- array (
	71	+ ),
	72	+ 'height' =>
	73	+ array (
74	74	'type' =>
75	75	array (
76		- 0 => 'int',
77		- 1 => 'null',
	76	+ 0 => 'int',
	77	+ 1 => 'null',
78	78	),
79	79	'required' => false,
80	80	'actionName' => 'height',
81		- ),
82		- 'parent' =>
83		- array (
	81	+ ),
	82	+ 'parent' =>
	83	+ array (
84	84	'type' =>
85	85	array (
86		- 0 => 'Transfer\\Simple\\SimpleObjectTransfer',
87		- 1 => 'null',
	86	+ 0 => 'Transfer\\Simple\\SimpleObjectTransfer',
	87	+ 1 => 'null',
88	88	),
89	89	'required' => false,
90	90	'actionName' => 'parent',
91		- ),
	91	+ ),
92	92	);
93	93	}
94	94	}

		@@ -48,7 +48,7 @@
		block discarded – undo
48	48
49	49	$values = $this->explodeString($choices);
50	50
51		- return array_map(function (mixed $value) {
	51	+ return array_map(function(mixed $value) {
52	52	return $this->sanitize($value);
53	53	}, $values);
54	54	}

		@@ -58,11 +58,11 @@ discard block
		block discarded – undo
58	58
59	59	protected static function attributesMetadata(): array
60	60	{
61		- return array (
	61	+ return array(
62	62	'weight' =>
63		- array (
	63	+ array(
64	64	'type' =>
65		- array (
	65	+ array(
66	66	0 => 'int',
67	67	1 => 'null',
68	68	),
		@@ -70,9 +70,9 @@ discard block
		block discarded – undo
70	70	'actionName' => 'weight',
71	71	),
72	72	'height' =>
73		- array (
	73	+ array(
74	74	'type' =>
75		- array (
	75	+ array(
76	76	0 => 'int',
77	77	1 => 'null',
78	78	),
		@@ -80,9 +80,9 @@ discard block
		block discarded – undo
80	80	'actionName' => 'height',
81	81	),
82	82	'parent' =>
83		- array (
	83	+ array(
84	84	'type' =>
85		- array (
	85	+ array(
86	86	0 => 'Transfer\\Simple\\SimpleObjectTransfer',
87	87	1 => 'null',
88	88	),

Micro-PHP / dto

Pull Request — master (#12)

Status

Category

Indentation +30 added lines, -30 removed lines patch added patch discarded remove patch

Spacing +16 added lines, -16 removed lines patch added patch discarded remove patch

Indentation +15 added lines, -15 removed lines patch added patch discarded remove patch

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch