MichaelJ2324 / sugarcrm-restv10-sdk

src/Request/Abstracts/AbstractRequest.php

Doc Comments +1 added lines

@@ -133,6 +133,7 @@
 
     /**
      * @inheritdoc
+     * @param string $body
      */
     public function setBody($body) {
         $this->body = $body;

Spacing +1 added lines, -1 removed lines

@@ -90,7 +90,7 @@
     /**
      * Always make sure to destroy Curl Resource
      */
-    public function __destruct() {
+    public function __destruct(){
         if ($this->status!==self::STATUS_CLOSED){
             curl_close($this->CurlRequest);
         }

Braces +1 added lines, -1 removed lines

@@ -90,7 +90,7 @@
     /**
      * Always make sure to destroy Curl Resource
      */
-    public function __destruct() {
+    public function __destruct(){
         if ($this->status!==self::STATUS_CLOSED){
             curl_close($this->CurlRequest);
         }

src/Exception/SDKException.php

Spacing +1 added lines, -1 removed lines

@@ -4,7 +4,7 @@
 
 class EntryPointException extends SDKException {
 
-    public function __construct($message) {
+    public function __construct($message){
         parent::__construct($message);
     }
 

Braces +1 added lines, -1 removed lines

@@ -4,7 +4,7 @@
 
 class EntryPointException extends SDKException {
 
-    public function __construct($message) {
+    public function __construct($message){
         parent::__construct($message);
     }
 

src/EntryPoint/POST/ModuleRecordFileField.php

Spacing +1 added lines, -1 removed lines

@@ -47,7 +47,7 @@
                 $data[$fileField] = $this->setFileFieldValue($data[$fileField]);
             }else{
                 foreach ($this->Data as $key => $value){
-                    if (!array_key_exists($key,$this->_REQUIRED_DATA)){
+                    if (!array_key_exists($key, $this->_REQUIRED_DATA)){
                         $data[$key] = $this->setFileFieldValue($value);
                     }
                 }

Braces +2 added lines, -2 removed lines

@@ -34,7 +34,7 @@ 
     protected function configureData($data){
         if (!empty($this->Options)){
             $fileField = end($this->Options);
-        }else{
+        } else{
             throw new RequiredOptionsException(get_called_class());
         }
         if (is_string($data) && isset($fileField)){
@@ -45,7 +45,7 @@ 
         if (is_array($data)){
             if (isset($fileField)){
                 $data[$fileField] = $this->setFileFieldValue($data[$fileField]);
-            }else{
+            } else{
                 foreach ($this->Data as $key => $value){
                     if (!array_key_exists($key,$this->_REQUIRED_DATA)){
                         $data[$key] = $this->setFileFieldValue($value);

src/EntryPoint/POST/Bulk.php

Spacing +6 added lines, -6 removed lines

@@ -30,22 +30,22 @@
         'method' => ''
     );
 
-    protected function configureData($data) {
+    protected function configureData($data){
         $requestData = array(
             'requests' => array()
         );
         $counter = 0;
-        foreach($data as $key => $EntryPoint){
-            if (is_object($EntryPoint)) {
+        foreach ($data as $key => $EntryPoint){
+            if (is_object($EntryPoint)){
                 $requestData['requests'][$counter] = $this->bulkRequest;
                 $requestData['requests'][$counter]['method'] = $EntryPoint->getRequest()->getType();
-                if ($requestData['requests'][$counter]['method'] == "POST" || $requestData['requests'][$counter]['method'] == "PUT") {
+                if ($requestData['requests'][$counter]['method']=="POST" || $requestData['requests'][$counter]['method']=="PUT"){
                     $requestData['requests'][$counter]['data'] = $EntryPoint->getRequest()->getBody();
-                } else {
+                }else{
                     unset($requestData['requests'][$counter]['data']);
                 }
                 $requestData['requests'][$counter]['headers'] = $EntryPoint->getRequest()->getHeaders();
-                $requestData['requests'][$counter]['url'] = "v10/" . str_replace($this->baseUrl, "", $EntryPoint->getUrl());
+                $requestData['requests'][$counter]['url'] = "v10/".str_replace($this->baseUrl, "", $EntryPoint->getUrl());
 
                 $counter++;
             }

Braces +4 added lines, -4 removed lines

@@ -30,18 +30,18 @@
         'method' => ''
     );
 
-    protected function configureData($data) {
+    protected function configureData($data){
         $requestData = array(
             'requests' => array()
         );
         $counter = 0;
         foreach($data as $key => $EntryPoint){
-            if (is_object($EntryPoint)) {
+            if (is_object($EntryPoint)){
                 $requestData['requests'][$counter] = $this->bulkRequest;
                 $requestData['requests'][$counter]['method'] = $EntryPoint->getRequest()->getType();
-                if ($requestData['requests'][$counter]['method'] == "POST" || $requestData['requests'][$counter]['method'] == "PUT") {
+                if ($requestData['requests'][$counter]['method'] == "POST" || $requestData['requests'][$counter]['method'] == "PUT"){
                     $requestData['requests'][$counter]['data'] = $EntryPoint->getRequest()->getBody();
-                } else {
+                } else{
                     unset($requestData['requests'][$counter]['data']);
                 }
                 $requestData['requests'][$counter]['headers'] = $EntryPoint->getRequest()->getHeaders();

src/Client/Interfaces/ClientInterface.php

Spacing +2 added lines, -2 removed lines

@@ -31,7 +31,7 @@ 
      * @param $EntryPoint - EPInterface Class Name
      * @return $this
      */
-    public function registerEntryPoint($function,$EntryPoint);
+    public function registerEntryPoint($function, $EntryPoint);
 
     /**
      * Login to the configured SugarCRM server
@@ -57,7 +57,7 @@ 
      * @param $client_id
      * @return boolean
      */
-    public static function storeToken($token,$client_id);
+    public static function storeToken($token, $client_id);
 
     /**
      * Get an SDK Clients authentication Token from Storage

src/Client/Abstracts/AbstractClient.php

Spacing +17 added lines, -17 removed lines

@@ -60,8 +60,8 @@ 
      */
     protected $entryPoints = array();
 
-    public function __construct($server = '',array $credentials = array()){
-        if (!empty($server)) {
+    public function __construct($server = '', array $credentials = array()){
+        if (!empty($server)){
             $this->setServer($server);
         }
         if (!empty($credentials)){
@@ -73,7 +73,7 @@ 
     /**
      * @inheritdoc
      */
-    public function setServer($server) {
+    public function setServer($server){
         $this->server = $server;
         $this->apiURL = Helpers::configureAPIURL($this->server);
         return $this;
@@ -82,7 +82,7 @@ 
     /**
      * @inheritdoc
      */
-    public function getAPIUrl() {
+    public function getAPIUrl(){
         return $this->apiURL;
     }
 
@@ -125,7 +125,7 @@ 
     /**
      * @inheritdoc
      */
-    public function getServer() {
+    public function getServer(){
         return $this->server;
     }
 
@@ -133,7 +133,7 @@ 
      * @inheritdoc
      */
     public function authenticated(){
-        return time() < $this->expiration;
+        return time()<$this->expiration;
     }
 
     /**
@@ -155,10 +155,10 @@ 
      */
     public function registerEntryPoint($funcName, $className){
         $implements = class_implements($className);
-        if (is_array($implements) && in_array('SugarAPI\SDK\EntryPoint\Interfaces\EPInterface',$implements)){
+        if (is_array($implements) && in_array('SugarAPI\SDK\EntryPoint\Interfaces\EPInterface', $implements)){
             $this->entryPoints[$funcName] = $className;
         }else{
-            throw new EntryPointException($className,'Class must extend SugarAPI\SDK\EntryPoint\Interfaces\EPInterface');
+            throw new EntryPointException($className, 'Class must extend SugarAPI\SDK\EntryPoint\Interfaces\EPInterface');
         }
         return $this;
     }
@@ -176,13 +176,13 @@ 
             $EntryPoint = new $Class($this->apiURL, $params);
 
             if ($EntryPoint->authRequired()){
-                if (isset($this->token) && $this->authenticated()) {
+                if (isset($this->token) && $this->authenticated()){
                     $EntryPoint->setAuth($this->getToken()->access_token);
                 }
             }
             return $EntryPoint;
         }else{
-            throw new EntryPointException($name,'Unregistered EntryPoint');
+            throw new EntryPointException($name, 'Unregistered EntryPoint');
         }
     }
 
@@ -190,13 +190,13 @@ 
      * @inheritdoc
      * @throws AuthenticationException - When Login request fails
      */
-    public function login() {
+    public function login(){
         $EP = new OAuth2Token($this->apiURL);
         $response = $EP->execute($this->credentials)->getResponse();
         if ($response->getStatus()=='200'){
             $this->setToken($response->getBody(false));
-            static::storeToken($this->token,$this->credentials['client_id']);
-        } else {
+            static::storeToken($this->token, $this->credentials['client_id']);
+        }else{
             $error = $response->getBody();
             throw new AuthenticationException("Login Response [".$error['error']."] ".$error['error_message']);
         }
@@ -217,7 +217,7 @@ 
         $response = $EP->execute($refreshOptions)->getResponse();
         if ($response->getStatus()=='200'){
             $this->setToken($response->getBody(false));
-            static::storeToken($this->token,$this->credentials['client_id']);
+            static::storeToken($this->token, $this->credentials['client_id']);
         }else{
             $error = $response->getBody();
             throw new AuthenticationException("Refresh Response [".$error['error']."] ".$error['error_message']);
@@ -247,7 +247,7 @@ 
     /**
      * @inheritdoc
      */
-    public static function storeToken($token, $client_id) {
+    public static function storeToken($token, $client_id){
         static::$_STORED_TOKENS[$client_id] = $token;
         return true;
     }
@@ -255,14 +255,14 @@ 
     /**
      * @inheritdoc
      */
-    public static function getStoredToken($client_id) {
+    public static function getStoredToken($client_id){
         return static::$_STORED_TOKENS[$client_id];
     }
 
     /**
      * @inheritdoc
      */
-    public static function removeStoredToken($client_id) {
+    public static function removeStoredToken($client_id){
         unset(static::$_STORED_TOKENS[$client_id]);
         return true;
     }

Braces +14 added lines, -14 removed lines

@@ -61,7 +61,7 @@ 
     protected $entryPoints = array();
 
     public function __construct($server = '',array $credentials = array()){
-        if (!empty($server)) {
+        if (!empty($server)){
             $this->setServer($server);
         }
         if (!empty($credentials)){
@@ -73,7 +73,7 @@ 
     /**
      * @inheritdoc
      */
-    public function setServer($server) {
+    public function setServer($server){
         $this->server = $server;
         $this->apiURL = Helpers::configureAPIURL($this->server);
         return $this;
@@ -82,7 +82,7 @@ 
     /**
      * @inheritdoc
      */
-    public function getAPIUrl() {
+    public function getAPIUrl(){
         return $this->apiURL;
     }
 
@@ -125,7 +125,7 @@ 
     /**
      * @inheritdoc
      */
-    public function getServer() {
+    public function getServer(){
         return $this->server;
     }
 
@@ -157,7 +157,7 @@ 
         $implements = class_implements($className);
         if (is_array($implements) && in_array('SugarAPI\SDK\EntryPoint\Interfaces\EPInterface',$implements)){
             $this->entryPoints[$funcName] = $className;
-        }else{
+        } else{
             throw new EntryPointException($className,'Class must extend SugarAPI\SDK\EntryPoint\Interfaces\EPInterface');
         }
         return $this;
@@ -176,12 +176,12 @@ 
             $EntryPoint = new $Class($this->apiURL, $params);
 
             if ($EntryPoint->authRequired()){
-                if (isset($this->token) && $this->authenticated()) {
+                if (isset($this->token) && $this->authenticated()){
                     $EntryPoint->setAuth($this->getToken()->access_token);
                 }
             }
             return $EntryPoint;
-        }else{
+        } else{
             throw new EntryPointException($name,'Unregistered EntryPoint');
         }
     }
@@ -190,13 +190,13 @@ 
      * @inheritdoc
      * @throws AuthenticationException - When Login request fails
      */
-    public function login() {
+    public function login(){
         $EP = new OAuth2Token($this->apiURL);
         $response = $EP->execute($this->credentials)->getResponse();
         if ($response->getStatus()=='200'){
             $this->setToken($response->getBody(false));
             static::storeToken($this->token,$this->credentials['client_id']);
-        } else {
+        } else{
             $error = $response->getBody();
             throw new AuthenticationException("Login Response [".$error['error']."] ".$error['error_message']);
         }
@@ -218,7 +218,7 @@ 
         if ($response->getStatus()=='200'){
             $this->setToken($response->getBody(false));
             static::storeToken($this->token,$this->credentials['client_id']);
-        }else{
+        } else{
             $error = $response->getBody();
             throw new AuthenticationException("Refresh Response [".$error['error']."] ".$error['error_message']);
         }
@@ -236,7 +236,7 @@ 
             if ($response->getStatus()=='200'){
                 unset($this->token);
                 static::removeStoredToken($this->credentials['client_id']);
-            }else{
+            } else{
                 $error = $response->getBody();
                 throw new AuthenticationException("Logout Response [".$error['error']."] ".$error['message']);
             }
@@ -247,7 +247,7 @@ 
     /**
      * @inheritdoc
      */
-    public static function storeToken($token, $client_id) {
+    public static function storeToken($token, $client_id){
         static::$_STORED_TOKENS[$client_id] = $token;
         return true;
     }
@@ -255,14 +255,14 @@ 
     /**
      * @inheritdoc
      */
-    public static function getStoredToken($client_id) {
+    public static function getStoredToken($client_id){
         return static::$_STORED_TOKENS[$client_id];
     }
 
     /**
      * @inheritdoc
      */
-    public static function removeStoredToken($client_id) {
+    public static function removeStoredToken($client_id){
         unset(static::$_STORED_TOKENS[$client_id]);
         return true;
     }

Doc Comments +1 added lines, -1 removed lines

@@ -151,7 +151,7 @@
     /**
      * @param $funcName
      * @param $className
-     * @return bool
+     * @return AbstractClient
      * @throws EntryPointException
      */
     public function registerEntryPoint($funcName, $className){

src/Helpers/Helpers.php

Braces +1 added lines, -1 removed lines

@@ -39,7 +39,7 @@
     public static function getSDKEntryPointRegistry(){
         $entryPoints = array();
         require __DIR__.DIRECTORY_SEPARATOR.'registry.php';
-        foreach ($entryPoints as $funcName => $className) {
+        foreach ($entryPoints as $funcName => $className){
             $className = "SugarAPI\\SDK\\EntryPoint\\" . $className;
             $entryPoints[$funcName] = $className;
         }

Spacing +4 added lines, -4 removed lines

@@ -15,10 +15,10 @@ 
      * @return string
      */
     public static function configureAPIURL($instance){
-        if (strpos($instance,"http")===FALSE){
+        if (strpos($instance, "http")===FALSE){
             $instance = "http://".$instance;
         }
-        if (strpos($instance,"rest/v10")!==FALSE){
+        if (strpos($instance, "rest/v10")!==FALSE){
             $instance = str_replace("rest/v10", "", $instance);
         }
         return rtrim($instance, "/").self::API_URL;
@@ -39,8 +39,8 @@ 
     public static function getSDKEntryPointRegistry(){
         $entryPoints = array();
         require __DIR__.DIRECTORY_SEPARATOR.'registry.php';
-        foreach ($entryPoints as $funcName => $className) {
-            $className = "SugarAPI\\SDK\\EntryPoint\\" . $className;
+        foreach ($entryPoints as $funcName => $className){
+            $className = "SugarAPI\\SDK\\EntryPoint\\".$className;
             $entryPoints[$funcName] = $className;
         }
         return $entryPoints;

src/EntryPoint/Abstracts/PUT/AbstractPutEntryPoint.php

Spacing +3 added lines, -3 removed lines

@@ -8,14 +8,14 @@
 
 abstract class AbstractPostFileEntryPoint extends AbstractEntryPoint {
 
-    public function __construct($url, array $options = array()) {
+    public function __construct($url, array $options = array()){
         $this->setRequest(new POSTFile());
         parent::__construct($url, $options);
     }
 
-    public function execute($data = null) {
+    public function execute($data = null){
         parent::execute($data);
-        $this->setResponse(new JSON($this->Request->getResponse(),$this->Request->getCurlObject()));
+        $this->setResponse(new JSON($this->Request->getResponse(), $this->Request->getCurlObject()));
         return $this;
     }
 

Braces +2 added lines, -2 removed lines

@@ -8,12 +8,12 @@
 
 abstract class AbstractPostFileEntryPoint extends AbstractEntryPoint {
 
-    public function __construct($url, array $options = array()) {
+    public function __construct($url, array $options = array()){
         $this->setRequest(new POSTFile());
         parent::__construct($url, $options);
     }
 
-    public function execute($data = null) {
+    public function execute($data = null){
         parent::execute($data);
         $this->setResponse(new JSON($this->Request->getResponse(),$this->Request->getCurlObject()));
         return $this;

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -13,7 +13,7 @@
         parent::__construct($url, $options);
     }
 
-    public function execute($data = null) {
+    public function execute($data = NULL) {
         parent::execute($data);
         $this->setResponse(new JSON($this->Request->getResponse(),$this->Request->getCurlObject()));
         return $this;

src/EntryPoint/Abstracts/GET/AbstractGetEntryPoint.php

Spacing +3 added lines, -3 removed lines

@@ -8,14 +8,14 @@
 
 abstract class AbstractPostFileEntryPoint extends AbstractEntryPoint {
 
-    public function __construct($url, array $options = array()) {
+    public function __construct($url, array $options = array()){
         $this->setRequest(new POSTFile());
         parent::__construct($url, $options);
     }
 
-    public function execute($data = null) {
+    public function execute($data = null){
         parent::execute($data);
-        $this->setResponse(new JSON($this->Request->getResponse(),$this->Request->getCurlObject()));
+        $this->setResponse(new JSON($this->Request->getResponse(), $this->Request->getCurlObject()));
         return $this;
     }
 

Braces +2 added lines, -2 removed lines

@@ -8,12 +8,12 @@
 
 abstract class AbstractPostFileEntryPoint extends AbstractEntryPoint {
 
-    public function __construct($url, array $options = array()) {
+    public function __construct($url, array $options = array()){
         $this->setRequest(new POSTFile());
         parent::__construct($url, $options);
     }
 
-    public function execute($data = null) {
+    public function execute($data = null){
         parent::execute($data);
         $this->setResponse(new JSON($this->Request->getResponse(),$this->Request->getCurlObject()));
         return $this;

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -13,7 +13,7 @@
         parent::__construct($url, $options);
     }
 
-    public function execute($data = null) {
+    public function execute($data = NULL) {
         parent::execute($data);
         $this->setResponse(new JSON($this->Request->getResponse(),$this->Request->getCurlObject()));
         return $this;