Completed
Push — master ( 12a138...9e6620 )
by Bart
02:30
created
Security/ShibbolethAuthenticationListenerFactory.php 1 patch
Doc Comments   +11 added lines patch added patch discarded remove patch
@@ -31,6 +31,10 @@  discard block
 block discarded – undo
31 31
             ->end();
32 32
     }
33 33
 
34
+    /**
35
+     * @param string $id
36
+     * @param string $userProvider
37
+     */
34 38
     protected function createAuthenticationProvider(ContainerBuilder $container, $id, $userProvider)
35 39
     {
36 40
         $providerId = 'security.authentication.provider.' . $this->key . '.' . $id;
@@ -41,6 +45,10 @@  discard block
 block discarded – undo
41 45
         return $providerId;
42 46
     }
43 47
 
48
+    /**
49
+     * @param string $id
50
+     * @param string $defaultEntryPoint
51
+     */
44 52
     protected function createEntryPoint(ContainerBuilder $container, $id, $defaultEntryPoint)
45 53
     {
46 54
         if (null !== $defaultEntryPoint) {
@@ -51,6 +59,9 @@  discard block
 block discarded – undo
51 59
         return $entryPointId;
52 60
     }
53 61
 
62
+    /**
63
+     * @param string $id
64
+     */
54 65
     protected function createListener(ContainerBuilder $container, $id, $defaultRoles)
55 66
     {
56 67
         $listenerId = 'security.authentication.listener.' . $this->key . '.' . $id;
Please login to merge, or discard this patch.
Service/PersonDataService.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@
 block discarded – undo
34 34
             throw new \Exception('Could not get person data for ' . $uid . ': ' . json_encode($decodedOutput));
35 35
         }
36 36
         $user = $decodedOutput->d;
37
-        $mainWorkAddresses = array_filter($user->WorkAddresses->results, function (\stdClass $value) {
37
+        $mainWorkAddresses = array_filter($user->WorkAddresses->results, function(\stdClass $value) {
38 38
             return $value->isMainWorkAddress;
39 39
         });
40 40
         $mainWorkAddress = reset($mainWorkAddresses);
Please login to merge, or discard this patch.
Service/LdapAttributesProvider.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -83,7 +83,7 @@
 block discarded – undo
83 83
             $ldapSingleResult = $ldapResults->toArray()['0'];
84 84
             // Extract attributes as strings
85 85
             $attributes = $ldapSingleResult->getAttributes();
86
-            array_walk($attributes, function (&$value) {
86
+            array_walk($attributes, function(&$value) {
87 87
                 $value = (is_array($value) ? implode(';', $value) : $value);
88 88
             });
89 89
             // Save to the session (cache)
Please login to merge, or discard this patch.
Service/ShibbolethAttributesInjectionProviderManager.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -55,7 +55,7 @@
 block discarded – undo
55 55
             }
56 56
             $server = $event->getRequest()->server;
57 57
             $providerPropertiesCollectionIterator = $this->providerPropertiesCollection->getIterator();
58
-            $providerPropertiesCollectionIterator->uasort(function ($first, $second) {
58
+            $providerPropertiesCollectionIterator->uasort(function($first, $second) {
59 59
                 // Place highest priority first
60 60
                 if ($first['priority'] === $second['priority']) {
61 61
                     return 0;
Please login to merge, or discard this patch.
Traits/ShibbolethAttributesResolverTrait.php 1 patch
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -104,7 +104,9 @@
 block discarded – undo
104 104
      */
105 105
     public function hasAttributeValue($name, $value = null)
106 106
     {
107
-        if (!$this->hasAttribute($name)) return false;
107
+        if (!$this->hasAttribute($name)) {
108
+            return false;
109
+        }
108 110
         return (empty($value) ? true : (array_search($value, $this->getArrayAttribute($name)) !== false));
109 111
     }
110 112
 
Please login to merge, or discard this patch.
Service/ShibbolethServiceProvider.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -205,7 +205,7 @@
 block discarded – undo
205 205
 
206 206
     /**
207 207
      * @param string $name
208
-     * @param null   $fallback
208
+     * @param null|double   $fallback
209 209
      * @return null|string
210 210
      */
211 211
     public function getAttribute($name, $fallback = null)
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -232,7 +232,7 @@
 block discarded – undo
232 232
     {
233 233
         $result = true;
234 234
         $empty = microtime(true);
235
-        set_error_handler(function ($errno, $errstr) {
235
+        set_error_handler(function($errno, $errstr) {
236 236
             throw new \Exception($errstr, $errno);
237 237
         });
238 238
         foreach ($keyValues as $checkName => $checkValue) {
Please login to merge, or discard this patch.
Compiler/KuleuvenShibbolethAttributeDefinitionsXmlParserPass.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -114,7 +114,7 @@
 block discarded – undo
114 114
                 }
115 115
             }
116 116
             foreach ($aliases as $alias) {
117
-                $attributeDefinitions[$alias] =& $attributeDefinitions[$id];
117
+                $attributeDefinitions[$alias] = & $attributeDefinitions[$id];
118 118
             }
119 119
         }
120 120
 
Please login to merge, or discard this patch.
Service/HeaderAttributesProvider.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@
 block discarded – undo
40 40
     public function getAttributes()
41 41
     {
42 42
         $attributes = $this->requestStack->getCurrentRequest()->headers->all();
43
-        array_walk($attributes, function (&$value) {
43
+        array_walk($attributes, function(&$value) {
44 44
             $value = (is_array($value) ? implode(';', $value) : $value);
45 45
         });
46 46
         return $attributes;
Please login to merge, or discard this patch.
Service/AttributeDefinitionsProvider.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@
 block discarded – undo
48 48
                 }
49 49
                 $attributeDefinitions[$id] = $attributeDefinition;
50 50
                 foreach ($aliases as $alias) {
51
-                    $attributeDefinitions[$alias] =& $attributeDefinitions[$id];
51
+                    $attributeDefinitions[$alias] = & $attributeDefinitions[$id];
52 52
                 }
53 53
             }
54 54
 
Please login to merge, or discard this patch.