Radchasay\Comment\HTMLForm\CreatePostForm

Complexity

Total Complexity

10

Size/Duplication

Total Lines	136
Duplicated Lines	22.79 %

Coupling/Cohesion

Components	1
Dependencies	6

Test Coverage

Coverage

23.38%

Importance

Changes	2
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
B	__construct()	31	31	1
B	callbackSubmit()	0	39	2
C	createCategory()	0	48	7

<?php

namespace Radchasay\Comment\HTMLForm;

use \Anax\HTMLForm\FormModel;
use \Anax\DI\DIInterface;
use \Radchasay\Comment\Post;
use \Radchasay\User\User;
use \Radchasay\Comment\PostCategory;
use \Radchasay\Comment\Post2Cat;

/**
 * Example of FormModel implementation.
 */
class CreatePostForm extends FormModel
{
    /**
     * Constructor injects with DI container.
     *
     * @param Anax\DI\DIInterface $di a service container
     */
    public function __construct(DIInterface $di)

This method seems to be duplicated in your project.

    {
        parent::__construct($di);

        $this->form->create(
            [
                "id"     => __CLASS__,
                "legend" => "Create Post",
                "class" => "createNewPostForm"
            ],
            [
                "title" => [
                    "type" => "text",
                ],

                "text" => [
                    "type" => "textarea",
                ],

                "tags" => [
                    "type"        => "text",
                ],

                "submit" => [
                    "type"     => "submit",
                    "value"    => "Create Post",
                    "callback" => [$this, "callbackSubmit"],
                ],
            ]
        );
    }


    /**
     * Callback for submit-button which should return true if it could
     * carry out its work and false if something failed.
     *
     * @return boolean true if okey, false if something went wrong.
     */
    public function callbackSubmit()
    {
        // Get values from the submitted form
        //
        $post = new Post();
        $post->setDB($this->di->get("db"));
        $title = htmlentities($this->form->value("title"));
        $data = $this->form->value("text");
        $text = $this->di->get("textfilter")->doFilter($data, ["shortcode", "markdown", "clickable", "bbcode"]);

        var_dump(strlen($title));

var_dump(strlen($title)); looks like debug code. Are you sure you do not want to remove it? This might expose sensitive data.

        if (strlen($title) > 50 ) {
            //$this->form->remeberValues();

75% of this comment could be valid code. Did you maybe forget this after debugging?

            $this->form->addOutput("Title is too long. Please fix!");
            return false;
        } else {
            $post->posttitle = $title;
        }

        $post->posttext = $text;
        $post->postname = htmlentities($this->di->get("session")->get("email"));

        $tags = htmlspecialchars($this->form->value("tags"));

        $user = new User();
        $user->setDb($this->di->get("db"));
        $user->getInformation($post->postname);
        $user->points += 2;

The property points does not seem to exist in Radchasay\User\User.

        $user->save();
        $post->save();


        $this->createCategory($tags, $post->id);

        $url = $this->di->get("url")->create("comment/viewAllPosts");
        $this->di->get("response")->redirect($url);
        return true;
    }


    public function createCategory($tags, $postId)
    {
        $postcat = new PostCategory();
        $postcat->setDb($this->di->get("db"));
        $allCats = $postcat->findall();

        $existingCats = [];

        foreach ($allCats as $ac) {
            array_push($existingCats, $ac->category);
        }

        $tags = array_map('trim', explode(',', $tags));

        $tags = array_map("strtoupper", $tags);

        $uniqueTags = [];

        foreach ($tags as $t) {
            if (!in_array($t, $existingCats)) {
                if (!in_array($t, $uniqueTags)) {
                    array_push($uniqueTags, $t);
                }
            }
        }

        foreach ($uniqueTags as $ut) {
            $pc = new PostCategory();
            $pc->setDb($this->di->get("db"));
            $pc->category = $ut;

            $pc->save();
        }
        //
        foreach ($tags as $t) {
            $pc = new PostCategory();
            $pc->setDb($this->di->get("db"));

            $id = $pc->getId($t);

            $p2c = new Post2Cat();
            $p2c->setDb($this->di->get("db"));
            $p2c->catid = $id;
            $p2c->postid = $postId;

            $p2c->save();
        }
    }
}