CommentController::newComment() - Code Metrics - Inspection of "Show all users of the site" - MagnusGreiff/Comment - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 2da97c...99f011 )

by Magnus

created 2017-10-16 12:54 UTC

CommentController::newComment() A

↳ Parent: CommentController

Complexity

Conditions	2
Paths	2

Size

Total Lines	23
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	12
CRAP Score	2.032

Importance

Changes

Metric	Value
dl	0
loc	23
ccs	12
cts	15
cp	0.8
rs	9.0856
c	0
b	0
f	0
cc	2
eloc	15
nc	2
nop	1
crap	2.032

<?php

namespace Radchasay\Comment;

use \Anax\DI\InjectionAwareInterface;
use \Anax\DI\InjectionAwareTrait;
use \Radchasay\Comment\Post;
use \Radchasay\Comment\Comment;
use \Radchasay\User\User;
use \Radchasay\Comment\HTMLForm\CreatePostForm;
use \Radchasay\Comment\HTMLForm\CreateCommentForm;
use \Radchasay\Comment\HTMLForm\UpdateCommentForm;

/**
 * CommentModel
 */
class CommentController implements InjectionAwareInterface
{
    use InjectionAwareTrait;

    public function deleteComment($commentId)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $comment = new Comment();
        $comment->setDb($this->di->get("db"));
        $comment->delete("idcomment", $commentId);
        $createUrl = $this->di->get("url")->create("comment/viewAllPosts");
        $url = isset($_SERVER["HTTP_REFERER"]) ? $_SERVER["HTTP_REFERER"] : $createUrl;
        $this->di->get("response")->redirect($url);
    }

    public function editComment($commentid)

    {
        $title = "Update comment";
        $view = $this->di->get("view");
        $pageRender = $this->di->get("pageRender");
        $form = new UpdateCommentForm($this->di, $commentid);

        $form->check();

        $data = [
            "form" => $form->getHTML(),
        ];

        $view->add("comment/editComment", $data);

        return $pageRender->renderPage(["title" => $title]);
    }

    public function viewAllPosts()

    {
        $title = "Retrieve all posts";
        $view = $this->di->get("view");
        $pageRender = $this->di->get("pageRender");
        $post = new Post();
        $post->setDb($this->di->get("db"));

        $data = [
            "items" => $post->findAll(),
        ];

        $view->add("comment/viewAllPosts", $data);

        return $pageRender->renderPage(["title" => $title]);
    }

    public function newPost()

    {
        $title = "Create new post";
        $view = $this->di->get("view");
        $pageRender = $this->di->get("pageRender");
        $form = new CreatePostForm($this->di);

        $form->check();

        $data = [
            "form" => $form->getHTML(),
        ];

        $view->add("comment/addNewPost", $data);

        return $pageRender->renderPage(["title" => $title]);
    }

    public function newComment($id)
    {
        if ($this->di->get("session")->has("email")) {
            $title = "Create new comment";
            $view = $this->di->get("view");
            $pageRender = $this->di->get("pageRender");
            $form = new CreateCommentForm($this->di, $id);

            $form->check();

            $data = [
                "form" => $form->getHTML(),
            ];

            $view->add("comment/addNewComment", $data);

            return $pageRender->renderPage(["title" => $title]);
        } else {
            $login = $this->di->get("url")->create("user/login");
            $this->di->get("response")->redirect($login);
            return false;
        }
    }

    public function postAndComments($id)
    {
        $title = "Retrieve one post with comments";
        $view = $this->di->get("view");
        $pageRender = $this->di->get("pageRender");
        $post = new Post();
        $post->setDb($this->di->get("db"));
        if ($this->di->get("session")->has("email")) {
            $user = new User();
            $user->setDb($this->di->get("db"));
            $email = $this->di->get("session")->get("email");
            $userInfo = $user->find("email", $email);
            $permissions = $userInfo->permissions;
        } else {
            $permissions = "user";
        }

        $comment = new Comment();
        $comment->setDb($this->di->get("db"));
        $sql = "Call CheckComment(?)";


        $data = [
            "post" => $post->find("id", $id),
            "comments" => $comment->getAllCommentsFromSpecificPost($sql, [$id]),
            "permissions" => $permissions
        ];

        $view->add("comment/onePostWithComment", $data);

        return $pageRender->renderPage(["title" => $title]);
    }
}


1			<?php
2
3			namespace Radchasay\Comment;
4
5			use \Anax\DI\InjectionAwareInterface;
6			use \Anax\DI\InjectionAwareTrait;
7			use \Radchasay\Comment\Post;
8			use \Radchasay\Comment\Comment;
9			use \Radchasay\User\User;
10			use \Radchasay\Comment\HTMLForm\CreatePostForm;
11			use \Radchasay\Comment\HTMLForm\CreateCommentForm;
12			use \Radchasay\Comment\HTMLForm\UpdateCommentForm;
13
14			/**
15			* CommentModel
16			*/
17			class CommentController implements InjectionAwareInterface
18			{
19			use InjectionAwareTrait;
20
21			public function deleteComment($commentId)
			0 ignored issues – show Coding Style introduced 2017-10-12 11:54 UTC by Report Bug Copy Issue Report `deleteComment` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
22			{
23			$comment = new Comment();
24			$comment->setDb($this->di->get("db"));
25			$comment->delete("idcomment", $commentId);
26			$createUrl = $this->di->get("url")->create("comment/viewAllPosts");
27			$url = isset($_SERVER["HTTP_REFERER"]) ? $_SERVER["HTTP_REFERER"] : $createUrl;
28			$this->di->get("response")->redirect($url);
29			}
30
31		View Code Duplication	public function editComment($commentid)
			0 ignored issues – show Duplication introduced 2017-10-16 12:56 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
32			{
33			$title = "Update comment";
34			$view = $this->di->get("view");
35			$pageRender = $this->di->get("pageRender");
36			$form = new UpdateCommentForm($this->di, $commentid);
37
38			$form->check();
39
40			$data = [
41			"form" => $form->getHTML(),
42			];
43
44			$view->add("comment/editComment", $data);
45
46			return $pageRender->renderPage(["title" => $title]);
47			}
48
49	1	View Code Duplication	public function viewAllPosts()
			0 ignored issues – show Duplication introduced 2017-10-12 16:18 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
50			{
51	1		$title = "Retrieve all posts";
52	1		$view = $this->di->get("view");
53	1		$pageRender = $this->di->get("pageRender");
54	1		$post = new Post();
55	1		$post->setDb($this->di->get("db"));
56
57			$data = [
58	1		"items" => $post->findAll(),
59	1		];
60
61	1		$view->add("comment/viewAllPosts", $data);
62
63	1		return $pageRender->renderPage(["title" => $title]);
64			}
65
66	1	View Code Duplication	public function newPost()
			0 ignored issues – show Duplication introduced 2017-10-12 11:50 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
67			{
68	1		$title = "Create new post";
69	1		$view = $this->di->get("view");
70	1		$pageRender = $this->di->get("pageRender");
71	1		$form = new CreatePostForm($this->di);
72
73	1		$form->check();
74
75			$data = [
76	1		"form" => $form->getHTML(),
77	1		];
78
79	1		$view->add("comment/addNewPost", $data);
80
81	1		return $pageRender->renderPage(["title" => $title]);
82			}
83
84	1		public function newComment($id)
85			{
86	1		if ($this->di->get("session")->has("email")) {
87	1		$title = "Create new comment";
88	1		$view = $this->di->get("view");
89	1		$pageRender = $this->di->get("pageRender");
90	1		$form = new CreateCommentForm($this->di, $id);
91
92	1		$form->check();
93
94			$data = [
95	1		"form" => $form->getHTML(),
96	1		];
97
98	1		$view->add("comment/addNewComment", $data);
99
100	1		return $pageRender->renderPage(["title" => $title]);
101			} else {
102			$login = $this->di->get("url")->create("user/login");
103			$this->di->get("response")->redirect($login);
104			return false;
105			}
106	1		}
107
108			public function postAndComments($id)
109			{
110			$title = "Retrieve one post with comments";
111			$view = $this->di->get("view");
112			$pageRender = $this->di->get("pageRender");
113			$post = new Post();
114			$post->setDb($this->di->get("db"));
115			if ($this->di->get("session")->has("email")) {
116			$user = new User();
117			$user->setDb($this->di->get("db"));
118			$email = $this->di->get("session")->get("email");
119			$userInfo = $user->find("email", $email);
120			$permissions = $userInfo->permissions;
121			} else {
122			$permissions = "user";
123			}
124
125			$comment = new Comment();
126			$comment->setDb($this->di->get("db"));
127			$sql = "Call CheckComment(?)";
128
129
130			$data = [
131			"post" => $post->find("id", $id),
132			"comments" => $comment->getAllCommentsFromSpecificPost($sql, [$id]),
133			"permissions" => $permissions
134			];
135
136			$view->add("comment/onePostWithComment", $data);
137
138			return $pageRender->renderPage(["title" => $title]);
139			}
140			}
141

MagnusGreiff / Comment

Push — master ( 2da97c...99f011 )

CommentController::newComment() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like