Issues in PlayerProfileTransformer.php (master) - Issues in master - Maelstromeous/ps2alerts-api - Measure and Improve Code Quality continuously with Scrutinizer

Issues (194)

Security Analysis no vulnerabilities found

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Transformer/Profiles/PlayerProfileTransformer.php (7 issues)

Labels

Severity

Minor 7

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Ps2alerts\Api\Transformer\Profiles;

use League\Fractal\TransformerAbstract;
use Ps2alerts\Api\Contract\HttpClientAwareInterface;
use Ps2alerts\Api\Contract\HttpClientAwareTrait;
use Ps2alerts\Api\Repository\Metrics\OutfitTotalRepository;
use Ps2alerts\Api\Repository\Metrics\PlayerRepository;
use Ps2alerts\Api\Repository\Metrics\VehicleRepository;
use Ps2alerts\Api\Repository\Metrics\WeaponRepository;
use Ps2alerts\Api\Transformer\Profiles\PlayerCensusTransformer;
use Ps2alerts\Api\Transformer\Profiles\PlayerInvolvementTransformer;
use Ps2alerts\Api\Transformer\Profiles\PlayerMetricsTransformer;
use Ps2alerts\Api\Transformer\Profiles\PlayerOutfitTransformer;

class PlayerProfileTransformer extends TransformerAbstract implements HttpClientAwareInterface
{
    use HttpClientAwareTrait;

    /**
     * List of available includes to this resource
     *
     * @var array
     */
    protected $availableIncludes = [
        'census',
        'involvement',
        'metrics',
        'outfit',
        //'vehicles',
        'weapons'
    ];

    protected $outfitTotalRepo;
    protected $playerRepo;
    protected $vehicleRepo;
    protected $weaponRepo;

    public function __construct(
        OutfitTotalRepository $outfitTotalRepo,
        PlayerRepository      $playerRepo,
        VehicleRepository     $vehicleRepo,
        WeaponRepository      $weaponRepo
    ) {
        $this->outfitTotalRepo = $outfitTotalRepo;
        $this->playerRepo      = $playerRepo;
        $this->vehicleRepo     = $vehicleRepo;
        $this->weaponRepo      = $weaponRepo;
    }

    /**
     * The transform method required by Fractal to parse the data and return proper typing and fields.
     *
     * @param  array $data Data to transform
     *
     * @return array
     */
    public function transform($data)
    {
        return [
            'id'      => (string) $data['playerID'], // Bigint
            'name'    => (string) $data['playerName'],
            'outfit'  => (string) $data['playerOutfit'], // Bigint
            'faction' => (int) $data['playerFaction'],
            'server'  => (int) $data['playerServer']
        ];
    }

    /**
     * Grab Census only info
     *
     * @param  array $data
     *
     * @return \League\Fractal\Resource\Collection
     */
    public function includeCensus($data)
    {
        $client = $this->getHttpClientDriver();

        $namespace = 'ps2:v2';

        if ($data['playerServer'] >= 2000) {
            $namespace = 'ps2ps4eu';
        } elseif ($data['playerServer'] >= 1000) {
            $namespace = 'ps2ps4us';
        }

        $response = $client->get(
            "https://census.daybreakgames.com/s:planetside2alertstats/get/{$namespace}/character/{$data['playerID']}?c:resolve=stat,stat_by_faction"
        );

        $json = json_decode($response->getBody()->getContents(), true);

        $character = $json['character_list'][0];

        $statCount = count($character['stats']['stat']);
        $statFactionCount = count($character['stats']['stat_by_faction']);

        $character['kills']     = 0;
        $character['deaths']    = 0;
        $character['headshots'] = 0;

        for ($i = 0; $i < $statFactionCount; $i++) {
            $row = $character['stats']['stat_by_faction'][$i];

            if ($row['stat_name'] === 'weapon_kills') {
                $character['kills'] = ($row['value_forever_nc'] + $row['value_forever_tr']);
            }

            if ($row['stat_name'] === 'weapon_headshots') {
                $character['headshots'] = ($row['value_forever_nc'] + $row['value_forever_tr']);
            }
        }

        for ($i = 0; $i < $statCount; $i++) {
            $row = $character['stats']['stat'][$i];

            if ($row['stat_name'] === 'weapon_deaths') {
                $character['deaths'] = $row['value_forever'];
            }
        }

        // Removes daft ".0" from the end of the login string...
        $character['times']['last_login_date'] = str_replace('.0', '', $character['times']['last_login_date']);

        return $this->item($character, new PlayerCensusTransformer);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * Get Alert involvement & metrics
     *
     * @param  array $data
     *
     * @return \League\Fractal\Resource\Collection
     */
    public function includeInvolvement($data)
    {
        $data = $this->playerRepo->readAllByIdWithArchive($data['playerID'], 'playerID');

        return $this->collection($data, new PlayerInvolvementTransformer);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * Gets Metrics for a player
     *
     * @param  array $player
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @return array
     */
    public function includeMetrics($data)
    {
        $metrics = [
            'kills'     => 0,
            'deaths'    => 0,
            'teamkills' => 0,
            'suicides'  => 0,
            'headshots' => 0
        ];

        $alerts = $this->playerRepo->readAllByIdWithArchive($data['playerID'], 'playerID');
        $count = count($alerts);
        $metrics['involvement'] = $count;

        // Calculate metrics
        for ($i = 0; $i < $count; $i++) {
            $metrics['kills']     = $metrics['kills'] + $alerts[$i]['playerKills'];
            $metrics['deaths']    = $metrics['deaths'] + $alerts[$i]['playerDeaths'];
            $metrics['teamkills'] = $metrics['teamkills'] + $alerts[$i]['playerTeamKills'];
            $metrics['suicides']  = $metrics['suicides'] + $alerts[$i]['playerSuicides'];
            $metrics['headshots'] = $metrics['headshots'] + $alerts[$i]['headshots'];
        }

        return $this->item($metrics, new PlayerMetricsTransformer);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * Get Outfit info and metrics
     *
     * @param  array $data
     *
     * @return \League\Fractal\Resource\Collection
     */
    public function includeOutfit($data)
    {
        $data = $this->outfitTotalRepo->readSingleById($data['playerOutfit'], 'primary');
        return $this->item($data, new PlayerOutfitTransformer);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * Get Vehicle info and metrics
     *
     * @param  array $data
     *
     * @return \League\Fractal\Resource\Collection
     */
    public function includeVehicles($data)
    {
        $metrics = [];
        $data = $this->vehicleRepo->readAllByIdWithArchive($data['playerID'], 'playerID');
        $count = count($data);

        // Calculate metrics
        for ($i = 0; $i < $count; $i++) {
            $vehicleID = $data[$i]['vehicleID'];
            if (empty($metrics[$vehicleID])) {
                $metrics[$vehicleID] = [
                    'id'        => $vehicleID,
                    'kills'     => 0,
                    'killsInf'  => 0,
                    'killsVeh'  => 0,
                    'deaths'    => 0,
                    'deathsInf' => 0,
                    'deathsVeh' => 0,
                    'bails'     => 0
                ];
            }

            $metrics[$vehicleID]['kills']     = $metrics[$vehicleID]['kills'] + $data[$i]['killCount'];
            $metrics[$vehicleID]['killsInf']  = $metrics[$vehicleID]['killsInf'] + $data[$i]['killICount'];
            $metrics[$vehicleID]['killsVeh']  = $metrics[$vehicleID]['killsVeh'] + $data[$i]['killVCount'];
            $metrics[$vehicleID]['deaths']    = $metrics[$vehicleID]['deaths'] + $data[$i]['deathCount'];
            $metrics[$vehicleID]['deathsInf'] = $metrics[$vehicleID]['deathsInf'] + $data[$i]['deathICount'];
            $metrics[$vehicleID]['deathsVeh'] = $metrics[$vehicleID]['deathsVeh'] + $data[$i]['deathVCount'];
            $metrics[$vehicleID]['bails']     = $metrics[$vehicleID]['bails'] + $data[$i]['bails'];
        }

        return $this->collection($metrics, new PlayerVehicleTransformer);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * Get Weapon info and metrics
     *
     * @param  array $data
     *
     * @return \League\Fractal\Resource\Collection
     */
    public function includeWeapons($data)
    {
        $metrics = [];
        $data = $this->weaponRepo->readAllByIdWithArchive($data['playerID'], 'playerID');
        $count = count($data);

        // Calculate metrics
        for ($i = 0; $i < $count; $i++) {
            $weaponID = $data[$i]['weaponID'];
            if (empty($metrics[$weaponID])) {
                $metrics[$weaponID] = [
                    'id'        => $weaponID,
                    'kills'     => 0,
                    'headshots' => 0,
                    'teamkills' => 0
                ];
            }

            $metrics[$weaponID]['kills']     = $metrics[$weaponID]['kills'] + $data[$i]['killCount'];
            $metrics[$weaponID]['headshots'] = $metrics[$weaponID]['headshots'] + $data[$i]['headshots'];
            $metrics[$weaponID]['teamkills'] = $metrics[$weaponID]['teamkills'] + $data[$i]['teamkills'];
        }

        return $this->collection($metrics, new PlayerWeaponTransformer);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
}


1			<?php
2
3			namespace Ps2alerts\Api\Transformer\Profiles;
4
5			use League\Fractal\TransformerAbstract;
6			use Ps2alerts\Api\Contract\HttpClientAwareInterface;
7			use Ps2alerts\Api\Contract\HttpClientAwareTrait;
8			use Ps2alerts\Api\Repository\Metrics\OutfitTotalRepository;
9			use Ps2alerts\Api\Repository\Metrics\PlayerRepository;
10			use Ps2alerts\Api\Repository\Metrics\VehicleRepository;
11			use Ps2alerts\Api\Repository\Metrics\WeaponRepository;
12			use Ps2alerts\Api\Transformer\Profiles\PlayerCensusTransformer;
13			use Ps2alerts\Api\Transformer\Profiles\PlayerInvolvementTransformer;
14			use Ps2alerts\Api\Transformer\Profiles\PlayerMetricsTransformer;
15			use Ps2alerts\Api\Transformer\Profiles\PlayerOutfitTransformer;
16
17			class PlayerProfileTransformer extends TransformerAbstract implements HttpClientAwareInterface
18			{
19			use HttpClientAwareTrait;
20
21			/**
22			* List of available includes to this resource
23			*
24			* @var array
25			*/
26			protected $availableIncludes = [
27			'census',
28			'involvement',
29			'metrics',
30			'outfit',
31			//'vehicles',
32			'weapons'
33			];
34
35			protected $outfitTotalRepo;
36			protected $playerRepo;
37			protected $vehicleRepo;
38			protected $weaponRepo;
39
40			public function __construct(
41			OutfitTotalRepository $outfitTotalRepo,
42			PlayerRepository $playerRepo,
43			VehicleRepository $vehicleRepo,
44			WeaponRepository $weaponRepo
45			) {
46			$this->outfitTotalRepo = $outfitTotalRepo;
47			$this->playerRepo = $playerRepo;
48			$this->vehicleRepo = $vehicleRepo;
49			$this->weaponRepo = $weaponRepo;
50			}
51
52			/**
53			* The transform method required by Fractal to parse the data and return proper typing and fields.
54			*
55			* @param array $data Data to transform
56			*
57			* @return array
58			*/
59			public function transform($data)
60			{
61			return [
62			'id' => (string) $data['playerID'], // Bigint
63			'name' => (string) $data['playerName'],
64			'outfit' => (string) $data['playerOutfit'], // Bigint
65			'faction' => (int) $data['playerFaction'],
66			'server' => (int) $data['playerServer']
67			];
68			}
69
70			/**
71			* Grab Census only info
72			*
73			* @param array $data
74			*
75			* @return \League\Fractal\Resource\Collection
76			*/
77			public function includeCensus($data)
78			{
79			$client = $this->getHttpClientDriver();
80
81			$namespace = 'ps2:v2';
82
83			if ($data['playerServer'] >= 2000) {
84			$namespace = 'ps2ps4eu';
85			} elseif ($data['playerServer'] >= 1000) {
86			$namespace = 'ps2ps4us';
87			}
88
89			$response = $client->get(
90			"https://census.daybreakgames.com/s:planetside2alertstats/get/{$namespace}/character/{$data['playerID']}?c:resolve=stat,stat_by_faction"
91			);
92
93			$json = json_decode($response->getBody()->getContents(), true);
94
95			$character = $json['character_list'][0];
96
97			$statCount = count($character['stats']['stat']);
98			$statFactionCount = count($character['stats']['stat_by_faction']);
99
100			$character['kills'] = 0;
101			$character['deaths'] = 0;
102			$character['headshots'] = 0;
103
104			for ($i = 0; $i < $statFactionCount; $i++) {
105			$row = $character['stats']['stat_by_faction'][$i];
106
107			if ($row['stat_name'] === 'weapon_kills') {
108			$character['kills'] = ($row['value_forever_nc'] + $row['value_forever_tr']);
109			}
110
111			if ($row['stat_name'] === 'weapon_headshots') {
112			$character['headshots'] = ($row['value_forever_nc'] + $row['value_forever_tr']);
113			}
114			}
115
116			for ($i = 0; $i < $statCount; $i++) {
117			$row = $character['stats']['stat'][$i];
118
119			if ($row['stat_name'] === 'weapon_deaths') {
120			$character['deaths'] = $row['value_forever'];
121			}
122			}
123
124			// Removes daft ".0" from the end of the login string...
125			$character['times']['last_login_date'] = str_replace('.0', '', $character['times']['last_login_date']);
126
127			return $this->item($character, new PlayerCensusTransformer);
			0 ignored issues – show Documentation introduced 2017-07-16 14:16 UTC by Report Bug Copy Issue Report Show Similar Issues like this `new \Ps2alerts\Api\Trans...ayerCensusTransformer()` is of type `object<Ps2alerts\Api\Tra...layerCensusTransformer>`, but the function expects a `callable`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
128			}
129
130			/**
131			* Get Alert involvement & metrics
132			*
133			* @param array $data
134			*
135			* @return \League\Fractal\Resource\Collection
136			*/
137			public function includeInvolvement($data)
138			{
139			$data = $this->playerRepo->readAllByIdWithArchive($data['playerID'], 'playerID');
140
141			return $this->collection($data, new PlayerInvolvementTransformer);
			0 ignored issues – show Documentation introduced 2017-07-16 14:16 UTC by Report Bug Copy Issue Report Show Similar Issues like this `new \Ps2alerts\Api\Trans...nvolvementTransformer()` is of type `object<Ps2alerts\Api\Tra...InvolvementTransformer>`, but the function expects a `callable`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
142			}
143
144			/**
145			* Gets Metrics for a player
146			*
147			* @param array $player
			0 ignored issues – show Bug introduced 2017-07-16 14:16 UTC by Report Bug Copy Issue Report Show Similar Issues like this There is no parameter named `$player`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
148			*
149			* @return array
150			*/
151			public function includeMetrics($data)
152			{
153			$metrics = [
154			'kills' => 0,
155			'deaths' => 0,
156			'teamkills' => 0,
157			'suicides' => 0,
158			'headshots' => 0
159			];
160
161			$alerts = $this->playerRepo->readAllByIdWithArchive($data['playerID'], 'playerID');
162			$count = count($alerts);
163			$metrics['involvement'] = $count;
164
165			// Calculate metrics
166			for ($i = 0; $i < $count; $i++) {
167			$metrics['kills'] = $metrics['kills'] + $alerts[$i]['playerKills'];
168			$metrics['deaths'] = $metrics['deaths'] + $alerts[$i]['playerDeaths'];
169			$metrics['teamkills'] = $metrics['teamkills'] + $alerts[$i]['playerTeamKills'];
170			$metrics['suicides'] = $metrics['suicides'] + $alerts[$i]['playerSuicides'];
171			$metrics['headshots'] = $metrics['headshots'] + $alerts[$i]['headshots'];
172			}
173
174			return $this->item($metrics, new PlayerMetricsTransformer);
			0 ignored issues – show Documentation introduced 2017-07-16 14:16 UTC by Report Bug Copy Issue Report Show Similar Issues like this `new \Ps2alerts\Api\Trans...yerMetricsTransformer()` is of type `object<Ps2alerts\Api\Tra...ayerMetricsTransformer>`, but the function expects a `callable`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
175			}
176
177			/**
178			* Get Outfit info and metrics
179			*
180			* @param array $data
181			*
182			* @return \League\Fractal\Resource\Collection
183			*/
184			public function includeOutfit($data)
185			{
186			$data = $this->outfitTotalRepo->readSingleById($data['playerOutfit'], 'primary');
187			return $this->item($data, new PlayerOutfitTransformer);
			0 ignored issues – show Documentation introduced 2017-07-16 14:16 UTC by Report Bug Copy Issue Report Show Similar Issues like this `new \Ps2alerts\Api\Trans...ayerOutfitTransformer()` is of type `object<Ps2alerts\Api\Tra...layerOutfitTransformer>`, but the function expects a `callable`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
188			}
189
190			/**
191			* Get Vehicle info and metrics
192			*
193			* @param array $data
194			*
195			* @return \League\Fractal\Resource\Collection
196			*/
197			public function includeVehicles($data)
198			{
199			$metrics = [];
200			$data = $this->vehicleRepo->readAllByIdWithArchive($data['playerID'], 'playerID');
201			$count = count($data);
202
203			// Calculate metrics
204			for ($i = 0; $i < $count; $i++) {
205			$vehicleID = $data[$i]['vehicleID'];
206			if (empty($metrics[$vehicleID])) {
207			$metrics[$vehicleID] = [
208			'id' => $vehicleID,
209			'kills' => 0,
210			'killsInf' => 0,
211			'killsVeh' => 0,
212			'deaths' => 0,
213			'deathsInf' => 0,
214			'deathsVeh' => 0,
215			'bails' => 0
216			];
217			}
218
219			$metrics[$vehicleID]['kills'] = $metrics[$vehicleID]['kills'] + $data[$i]['killCount'];
220			$metrics[$vehicleID]['killsInf'] = $metrics[$vehicleID]['killsInf'] + $data[$i]['killICount'];
221			$metrics[$vehicleID]['killsVeh'] = $metrics[$vehicleID]['killsVeh'] + $data[$i]['killVCount'];
222			$metrics[$vehicleID]['deaths'] = $metrics[$vehicleID]['deaths'] + $data[$i]['deathCount'];
223			$metrics[$vehicleID]['deathsInf'] = $metrics[$vehicleID]['deathsInf'] + $data[$i]['deathICount'];
224			$metrics[$vehicleID]['deathsVeh'] = $metrics[$vehicleID]['deathsVeh'] + $data[$i]['deathVCount'];
225			$metrics[$vehicleID]['bails'] = $metrics[$vehicleID]['bails'] + $data[$i]['bails'];
226			}
227
228			return $this->collection($metrics, new PlayerVehicleTransformer);
			0 ignored issues – show Documentation introduced 2017-07-16 14:16 UTC by Report Bug Copy Issue Report Show Similar Issues like this `new \Ps2alerts\Api\Trans...yerVehicleTransformer()` is of type `object<Ps2alerts\Api\Tra...ayerVehicleTransformer>`, but the function expects a `callable`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
229			}
230
231			/**
232			* Get Weapon info and metrics
233			*
234			* @param array $data
235			*
236			* @return \League\Fractal\Resource\Collection
237			*/
238			public function includeWeapons($data)
239			{
240			$metrics = [];
241			$data = $this->weaponRepo->readAllByIdWithArchive($data['playerID'], 'playerID');
242			$count = count($data);
243
244			// Calculate metrics
245			for ($i = 0; $i < $count; $i++) {
246			$weaponID = $data[$i]['weaponID'];
247			if (empty($metrics[$weaponID])) {
248			$metrics[$weaponID] = [
249			'id' => $weaponID,
250			'kills' => 0,
251			'headshots' => 0,
252			'teamkills' => 0
253			];
254			}
255
256			$metrics[$weaponID]['kills'] = $metrics[$weaponID]['kills'] + $data[$i]['killCount'];
257			$metrics[$weaponID]['headshots'] = $metrics[$weaponID]['headshots'] + $data[$i]['headshots'];
258			$metrics[$weaponID]['teamkills'] = $metrics[$weaponID]['teamkills'] + $data[$i]['teamkills'];
259			}
260
261			return $this->collection($metrics, new PlayerWeaponTransformer);
			0 ignored issues – show Documentation introduced 2017-07-16 14:16 UTC by Report Bug Copy Issue Report Show Similar Issues like this `new \Ps2alerts\Api\Trans...ayerWeaponTransformer()` is of type `object<Ps2alerts\Api\Tra...layerWeaponTransformer>`, but the function expects a `callable`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
262			}
263			}
264

Maelstromeous / ps2alerts-api

Issues (194)

Security Analysis no vulnerabilities found

Transformer/Profiles/PlayerProfileTransformer.php (7 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like