Maelstromeous / ps2alerts-api

src/container.php

Spacing +1 added lines, -1 removed lines

@@ -3,7 +3,7 @@
 $container = new League\Container\Container;
 
 // Register the request object singleton to be used later in the request cyncle
-$container->singleton('Symfony\Component\HttpFoundation\Request', function () {
+$container->singleton('Symfony\Component\HttpFoundation\Request', function() {
     return Symfony\Component\HttpFoundation\Request::createFromGlobals();
 });
 

Indentation +8 added lines, -8 removed lines

@@ -18,22 +18,22 @@
 
 // Inflectors
 $container->inflector('Ps2alerts\Api\Contract\ConfigAwareInterface')
-          ->invokeMethod('setConfig', ['config']);
+            ->invokeMethod('setConfig', ['config']);
 $container->inflector('Ps2alerts\Api\Contract\DatabaseAwareInterface')
-          ->invokeMethod('setDatabaseDriver', ['Database'])
-          ->invokeMethod('setDatabaseDataDriver', ['Database\Data']);
+            ->invokeMethod('setDatabaseDriver', ['Database'])
+            ->invokeMethod('setDatabaseDataDriver', ['Database\Data']);
 $container->inflector('Ps2alerts\Api\Contract\LogAwareInterface')
-          ->invokeMethod('setLogDriver', ['Monolog\Logger']);
+            ->invokeMethod('setLogDriver', ['Monolog\Logger']);
 $container->inflector('Ps2alerts\Api\Contract\TemplateAwareInterface')
-          ->invokeMethod('setTemplateDriver', ['Twig_Environment']);
+            ->invokeMethod('setTemplateDriver', ['Twig_Environment']);
 $container->inflector('Ps2alerts\Api\Contract\RedisAwareInterface')
-          ->invokeMethod('setRedisDriver', ['redis']);
+            ->invokeMethod('setRedisDriver', ['redis']);
 $container->inflector('Ps2alerts\Api\Contract\UuidAwareInterface')
-          ->invokeMethod('setUuidDriver', ['Ramsey\Uuid\Uuid']);
+            ->invokeMethod('setUuidDriver', ['Ramsey\Uuid\Uuid']);
 
 
 // Container Inflector
 $container->inflector('League\Container\ContainerAwareInterface')
-          ->invokeMethod('setContainer', [$container]);
+            ->invokeMethod('setContainer', [$container]);
 
 return $container;

src/ServiceProvider/ConfigServiceProvider.php

Spacing +1 added lines, -1 removed lines

@@ -18,7 +18,7 @@
      */
     public function register()
     {
-        $this->getContainer()->singleton('config', function () {
+        $this->getContainer()->singleton('config', function() {
             return include __DIR__ . '/../../config/config.php';
         });
     }

src/ServiceProvider/RedisServiceProvider.php

Spacing +1 added lines, -1 removed lines

@@ -23,7 +23,7 @@
      */
     public function register()
     {
-        $this->getContainer()->singleton('redis', function () {
+        $this->getContainer()->singleton('redis', function() {
             $redisConfig = $this->getContainer()->get('config')['redis'];
 
             $client = new Client([

src/ServiceProvider/LogServiceProvider.php

Spacing +1 added lines, -1 removed lines

@@ -20,7 +20,7 @@
      */
     public function register()
     {
-        $this->getContainer()->singleton('Monolog\Logger', function () {
+        $this->getContainer()->singleton('Monolog\Logger', function() {
             $log = new Logger('app');
             $log->pushHandler(
                 new StreamHandler(__DIR__ . '/../../logs/app.log', Logger::DEBUG)

src/ServiceProvider/UuidServiceProvider.php

Spacing +1 added lines, -1 removed lines

@@ -19,7 +19,7 @@
      */
     public function register()
     {
-        $this->getContainer()->add('Ramsey\Uuid\Uuid', function () {
+        $this->getContainer()->add('Ramsey\Uuid\Uuid', function() {
             $uuid = Uuid::Uuid4();
             return $uuid;
         });

tests/Endpoints/AlertControllerTest.php

Unused Use Statements -2 removed lines

@@ -1,8 +1,6 @@
 <?php
 
 use GuzzleHttp\Client;
-use GuzzleHttp\Psr7\Request;
-use GuzzleHttp\Psr7\Response;
 
 class AlertControllerTest extends \PHPUnit_Framework_TestCase
 {

src/Repository/AbstractEndpointRepository.php

Indentation +2 added lines, -2 removed lines

@@ -89,7 +89,7 @@ 
         $key = $this->returnKeyType($keyType);
 
         $query->cols(['*'])
-              ->where("`{$key}` = '{$id}'");
+                ->where("`{$key}` = '{$id}'");
 
         return $this->fireStatementAndReturn($query, true);
     }
@@ -107,7 +107,7 @@ 
         $key = $this->returnKeyType($keyType);
 
         $query->cols(['*'])
-              ->where("`{$key}` = '{$id}'");
+                ->where("`{$key}` = '{$id}'");
 
         return $this->fireStatementAndReturn($query);
     }

src/Controller/Endpoint/AbstractEndpointController.php

Doc Comments +9 added lines, -9 removed lines

@@ -104,7 +104,7 @@ 
      * @param  \League\Fractal\TransformerAbstract        $callback The Transformer to pass through to Fractal
      * @param  \Symfony\Component\HttpFoundation\Response $response The client's response
      *
-     * @return array
+     * @return Response
      */
     protected function respondWithItem($item, $callback, Response $response)
     {
@@ -121,7 +121,7 @@ 
      * @param  \League\Fractal\TransformerAbstract        $callback   The Transformer to pass through to Fractal
      * @param  \Symfony\Component\HttpFoundation\Response $response   The client's response
      *
-     * @return array
+     * @return Response
      */
     protected function respondWithCollection($collection, $callback, Response $response)
     {
@@ -156,7 +156,7 @@ 
      * @param  string                                     $message   Response message to put in the error
      * @param  int                                        $errorCode Error code to set
      *
-     * @return array
+     * @return Response
      */
     protected function respondWithError(Response $response, $message, $errorCode)
     {
@@ -183,7 +183,7 @@ 
      * @param  \Symfony\Component\HttpFoundation\Response $response
      * @param  string                                     $message
      *
-     * @return void
+     * @return Response
      */
     public function errorEmpty(Response $response, $message = 'No data / Empty')
     {
@@ -197,7 +197,7 @@ 
      * @param  \Symfony\Component\HttpFoundation\Response $response
      * @param  string                                     $message
      *
-     * @return void
+     * @return Response
      */
     public function errorForbidden(Response $response, $message = 'Forbidden')
     {
@@ -211,7 +211,7 @@ 
      * @param  \Symfony\Component\HttpFoundation\Response $response
      * @param  string                                     $message
      *
-     * @return void
+     * @return Response
      */
     public function errorInternalError(Response $response, $message = 'Internal Error')
     {
@@ -225,7 +225,7 @@ 
      * @param  \Symfony\Component\HttpFoundation\Response $response
      * @param  string                                     $message
      *
-     * @return void
+     * @return Response
      */
     public function errorNotFound(Response $response, $message = 'Resource Not Found')
     {
@@ -239,7 +239,7 @@ 
      * @param  \Symfony\Component\HttpFoundation\Response $response
      * @param  string                                     $message
      *
-     * @return void
+     * @return Response
      */
     public function errorUnauthorized(Response $response, $message = 'Unauthorized')
     {
@@ -264,7 +264,7 @@ 
     /**
      * Reads any requested includes and adds them to the item / collection
      *
-     * @param  Symfony\Component\HttpFoundation\Request $request
+     * @param  Request $request
      *
      * @return void
      */

Spacing +4 added lines, -4 removed lines

@@ -303,7 +303,7 @@ 
     {
         $queryString = $request->query->get('embed');
 
-        if (! empty($queryString)) {
+        if (!empty($queryString)) {
             $this->fractal->parseIncludes($request->query->get('embed'));
         }
     }
@@ -324,14 +324,14 @@ 
         $numericals = ['servers', 'zones'];
         $strings = ['factions', 'brackets'];
 
-        if (! empty($queryString)) {
+        if (!empty($queryString)) {
             $check = explode(',', $queryString);
 
             // Run a check on the IDs provided to make sure they're valid and no naughty things are being passed
             foreach ($check as $id) {
                 // If the query string should contain only numbers
                 if (in_array($mode, $numericals)) {
-                    if (! is_numeric($id)) {
+                    if (!is_numeric($id)) {
                         throw new InvalidArgumentException("Non numerical ID detected. Only numerical IDs are accepted with this request.");
                     }
                 }
@@ -341,7 +341,7 @@ 
                     }
                 }
 
-                if (! in_array($id, $filters)) {
+                if (!in_array($id, $filters)) {
                     throw new InvalidArgumentException("Unrecognized {$mode}. Please check the IDs you sent.");
                 }
             }

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -342,7 +342,7 @@
                 }
 
                 if (! in_array($id, $filters)) {
-                    throw new InvalidArgumentException("Unrecognized {$mode}. Please check the IDs you sent.");
+                    throw new InvalidArgumentException("unrecognized {$mode}. Please check the IDs you sent.");
                 }
             }
 

src/Controller/Endpoint/Alerts/AlertCountsEndpointController.php

Doc Comments +7 added lines, -7 removed lines

@@ -20,9 +20,9 @@ 
     /**
      * Construct
      *
-     * @param Ps2alerts\Api\Repository\AlertRepository   $repository
-     * @param Ps2alerts\Api\Transformer\AlertTransformer $transformer
-     * @param League\Fractal\Manager                     $fractal
+     * @param AlertRepository   $repository
+     * @param AlertTransformer $transformer
+     * @param Manager                     $fractal
      */
     public function __construct(
         AlertRepository  $repository,
@@ -37,10 +37,10 @@ 
     /**
      * Returns the victories of each faction and the totals
      *
-     * @param  Symfony\Component\HttpFoundation\Request  $request
-     * @param  Symfony\Component\HttpFoundation\Response $response
+     * @param  Request  $request
+     * @param  Response $response
      *
-     * @return array
+     * @return Response
      */
     public function getVictories(Request $request, Response $response)
     {
@@ -53,7 +53,7 @@ 
      * @param  \Symfony\Component\HttpFoundation\Request  $request
      * @param  \Symfony\Component\HttpFoundation\Response $response
      *
-     * @return array
+     * @return Response
      */
     public function getDominations(Request $request, Response $response)
     {

Spacing +2 added lines, -2 removed lines

@@ -208,11 +208,11 @@
         foreach ($this->getConfigItem('factions') as $faction) {
             $factionAbv = strtoupper($faction);
             $sql .= "SUM(CASE WHEN `ResultWinner`='{$factionAbv}' ";
-            if (! empty($server)) {
+            if (!empty($server)) {
                 $sql .= "AND `ResultServer` IN ({$server}) ";
             }
 
-            if (! empty($zones)) {
+            if (!empty($zones)) {
                 $sql .= "AND `ResultAlertCont` IN ({$zones}) ";
             }