Maelstromeous / ps2alerts-api

src/Controller/Endpoint/Alerts/AlertEndpointController.php

Doc Comments +12 added lines, -12 removed lines

@@ -15,9 +15,9 @@ 
     /**
      * Construct
      *
-     * @param Ps2alerts\Api\Repository\AlertRepository   $repository
-     * @param Ps2alerts\Api\Transformer\AlertTransformer $transformer
-     * @param League\Fractal\Manager                     $fractal
+     * @param AlertRepository   $repository
+     * @param AlertTransformer $transformer
+     * @param Manager                     $fractal
      */
     public function __construct(
         AlertRepository  $repository,
@@ -32,11 +32,11 @@ 
     /**
      * Returns a single alert's information
      *
-     * @param  Symfony\Component\HttpFoundation\Request  $request
-     * @param  Symfony\Component\HttpFoundation\Response $response
+     * @param  Request  $request
+     * @param  Response $response
      * @param  array                                     $args
      *
-     * @return \League\Fractal\TransformerAbstract
+     * @return Response
      */
     public function getSingle(Request $request, Response $response, array $args)
     {
@@ -52,10 +52,10 @@ 
     /**
      * Returns all currently running alerts
      *
-     * @param  Symfony\Component\HttpFoundation\Request  $request
-     * @param  Symfony\Component\HttpFoundation\Response $response
+     * @param  Request  $request
+     * @param  Response $response
      *
-     * @return \League\Fractal\TransformerAbstract
+     * @return Response
      */
     public function getActives(Request $request, Response $response)
     {
@@ -71,10 +71,10 @@ 
     /**
      * Returns all alerts in historial order
      *
-     * @param  Symfony\Component\HttpFoundation\Request  $request
-     * @param  Symfony\Component\HttpFoundation\Response $response
+     * @param  Request  $request
+     * @param  Response $response
      *
-     * @return \League\Fractal\TransformerAbstract
+     * @return Response
      */
     public function getHistoryByDate(Request $request, Response $response)
     {

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 use League\Fractal\Manager;
 use Ps2alerts\Api\Controller\Endpoint\AbstractEndpointController;
 use Ps2alerts\Api\Repository\AlertRepository;
-use Ps2alerts\Api\Transformer\AlertTotalTransformer;
 use Ps2alerts\Api\Transformer\AlertTransformer;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;

Spacing +2 added lines, -2 removed lines

@@ -93,11 +93,11 @@
         $limit    = (int) $request->get('limit');
 
         // Set defaults if not supplied
-        if ($offset === null || ! is_numeric($offset)) {
+        if ($offset === null || !is_numeric($offset)) {
             $offset = 0;
         }
 
-        if ($limit === null || ! is_numeric($limit)) {
+        if ($limit === null || !is_numeric($limit)) {
             $limit = 25;
         }
 

config/config.php

Spacing +4 added lines, -4 removed lines

@@ -24,8 +24,8 @@
         'host'    => $_ENV['REDIS_HOST'],
         'db'      => $_ENV['REDIS_DB']
     ],
-    'servers'  => [1,10,13,17,25,1000,2000],
-    'zones'    => [2,4,6,8],
-    'factions' => ['vs','nc','tr','draw'],
-    'brackets' => ['MOR','AFT','PRI']
+    'servers'  => [1, 10, 13, 17, 25, 1000, 2000],
+    'zones'    => [2, 4, 6, 8],
+    'factions' => ['vs', 'nc', 'tr', 'draw'],
+    'brackets' => ['MOR', 'AFT', 'PRI']
 ];

src/Controller/Endpoint/AbstractEndpointController.php

Spacing +4 added lines, -4 removed lines

@@ -303,7 +303,7 @@ 
     {
         $queryString = $request->query->get('embed');
 
-        if (! empty($queryString)) {
+        if (!empty($queryString)) {
             $this->fractal->parseIncludes($request->query->get('embed'));
         }
     }
@@ -324,14 +324,14 @@ 
         $numericals = ['servers', 'zones'];
         $strings = ['factions', 'brackets'];
 
-        if (! empty($queryString)) {
+        if (!empty($queryString)) {
             $check = explode(',', $queryString);
 
             // Run a check on the IDs provided to make sure they're valid and no naughty things are being passed
             foreach ($check as $id) {
                 // If the query string should contain only numbers
                 if (in_array($mode, $numericals)) {
-                    if (! is_numeric($id)) {
+                    if (!is_numeric($id)) {
                         throw new InvalidArgumentException("Non numerical ID detected. Only numerical IDs are accepted with this request.");
                     }
                 }
@@ -341,7 +341,7 @@ 
                     }
                 }
 
-                if (! in_array($id, $filters)) {
+                if (!in_array($id, $filters)) {
                     throw new InvalidArgumentException("Unrecognized {$mode}. Please check the IDs you sent.");
                 }
             }

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -342,7 +342,7 @@
                 }
 
                 if (! in_array($id, $filters)) {
-                    throw new InvalidArgumentException("Unrecognized {$mode}. Please check the IDs you sent.");
+                    throw new InvalidArgumentException("unrecognized {$mode}. Please check the IDs you sent.");
                 }
             }
 

src/Controller/Endpoint/Alerts/AlertCountsEndpointController.php

Spacing +2 added lines, -2 removed lines

@@ -208,11 +208,11 @@
         foreach ($this->getConfigItem('factions') as $faction) {
             $factionAbv = strtoupper($faction);
             $sql .= "SUM(CASE WHEN `ResultWinner`='{$factionAbv}' ";
-            if (! empty($server)) {
+            if (!empty($server)) {
                 $sql .= "AND `ResultServer` IN ({$server}) ";
             }
 
-            if (! empty($zones)) {
+            if (!empty($zones)) {
                 $sql .= "AND `ResultAlertCont` IN ({$zones}) ";
             }