Ps2alerts\Api\Controller\Endpoint\Alerts\AlertEndpointController

Complexity

Total Complexity

13

Size/Duplication

Total Lines	121
Duplicated Lines	16.53 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes	5
Bugs	1	Features	3

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	9	1
A	getSingle()	10	10	2
A	getActives()	10	10	2
B	getHistoryByDate()	0	54	8

<?php

namespace Ps2alerts\Api\Controller\Endpoint\Alerts;

use League\Fractal\Manager;
use Ps2alerts\Api\Controller\Endpoint\AbstractEndpointController;
use Ps2alerts\Api\Repository\AlertRepository;
use Ps2alerts\Api\Transformer\AlertTotalTransformer;
use Ps2alerts\Api\Transformer\AlertTransformer;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;

class AlertEndpointController extends AbstractEndpointController
{
    /**
     * Construct
     *
     * @param Ps2alerts\Api\Repository\AlertRepository   $repository
     * @param Ps2alerts\Api\Transformer\AlertTransformer $transformer
     * @param League\Fractal\Manager                     $fractal
     */
    public function __construct(
        AlertRepository  $repository,
        AlertTransformer $transformer,
        Manager          $fractal
    ) {
        $this->repository  = $repository;
        $this->transformer = $transformer;
        $this->fractal     = $fractal;
    }

    /**
     * Returns a single alert's information
     *
     * @param  Symfony\Component\HttpFoundation\Request  $request
     * @param  Symfony\Component\HttpFoundation\Response $response
     * @param  array                                     $args
     *
     * @return \League\Fractal\TransformerAbstract
     */
    public function getSingle(Request $request, Response $response, array $args)

This method seems to be duplicated in your project.

    {
        $alert = $this->repository->readSingleById($args['id']);

        if (empty($alert)) {
            return $this->errorEmpty($response);
        }

        return $this->respond('item', $alert, $this->transformer, $request, $response);
    }

    /**
     * Returns all currently running alerts
     *
     * @param  Symfony\Component\HttpFoundation\Request  $request
     * @param  Symfony\Component\HttpFoundation\Response $response
     *
     * @return \League\Fractal\TransformerAbstract
     */
    public function getActives(Request $request, Response $response)

This method seems to be duplicated in your project.

    {
        $actives = $this->repository->readAllByFields(['InProgress' => 1]);

        if (empty($actives)) {
            return $this->errorEmpty($response);
        }

        return $this->respond('collection', $actives, $this->transformer, $request, $response);
    }

    /**
     * Returns all alerts in historial order
     *
     * @param  Symfony\Component\HttpFoundation\Request  $request
     * @param  Symfony\Component\HttpFoundation\Response $response
     *
     * @return \League\Fractal\TransformerAbstract
     */
    public function getHistoryByDate(Request $request, Response $response)
    {
        try {
            $servers  = $this->getFiltersFromQueryString($request->get('servers'), 'servers', $response);
            $zones    = $this->getFiltersFromQueryString($request->get('zones'), 'zones', $response);
            $factions = $this->getFiltersFromQueryString($request->get('factions'), 'factions', $response);
            $brackets = $this->getFiltersFromQueryString($request->get('brackets'), 'brackets', $response);
        } catch (InvalidArgumentException $e) {

The class Ps2alerts\Api\Controller\Endpoint\Alerts\InvalidArgumentException does not exist. Did you forget a USE statement, or did you not list all dependencies?

            return $this->errorWrongArgs($response, $e->getMessage());
        }

        $dateFrom = $request->get('dateFrom');
        $dateTo   = $request->get('dateTo');
        $offset   = (int) $request->get('offset');
        $limit    = (int) $request->get('limit');

        // Set defaults if not supplied
        if ($offset === null || ! is_numeric($offset)) {
            $offset = 0;
        }

        if ($limit === null || ! is_numeric($limit)) {
            $limit = 25;
        }

        if ($dateFrom === null) {
            $dateFrom = date('Y-m-d H:i:s', strtotime('-48 hours'));
        }

        if ($dateTo === null) {
            $dateTo = date('Y-m-d H:i:s', strtotime('now'));
        }

        // Format the dates into UNIX timestamp for use with the DB
        $dateFrom = date('Y-m-d H:i:s', strtotime($dateFrom));
        $dateTo   = date('Y-m-d H:i:s', strtotime($dateTo));

        $query = $this->repository->newQuery();

        $query->cols(['*']);
        $query->where("`ResultServer` IN ({$servers})");
        $query->where("`ResultAlertCont` IN ({$zones})");
        $query->where("`ResultDateTime` > '{$dateFrom}'");
        $query->where("`ResultDateTime` < '{$dateTo}'");
        $query->where("`ResultWinner` IN ({$factions})");
        $query->where("`ResultTimeType` IN ({$brackets})");
        $query->orderBy(["`ResultEndTime` DESC"]);

The method orderBy() does not exist on Aura\SqlQuery\AbstractQuery. Did you maybe mean addOrderBy()?

        $query->limit($limit);
        $query->offset($offset);

        $history = $this->repository->readRaw($query->getStatement());

        return $this->respond('collection', $history, $this->transformer, $request, $response);
    }
}