Maelstromeous / ps2alerts-api

tests/Endpoints/AlertControllerTest.php

Unused Use Statements -2 removed lines

@@ -1,8 +1,6 @@
 <?php
 
 use GuzzleHttp\Client;
-use GuzzleHttp\Psr7\Request;
-use GuzzleHttp\Psr7\Response;
 
 class AlertControllerTest extends \PHPUnit_Framework_TestCase
 {

src/Controller/Endpoint/AbstractEndpointController.php

Spacing +1 added lines, -1 removed lines

@@ -272,7 +272,7 @@
     {
         $queryString = $request->query->get('embed');
 
-        if (! empty($queryString)) {
+        if (!empty($queryString)) {
             $this->fractal->parseIncludes($request->query->get('embed'));
         }
     }

Doc Comments +11 added lines, -11 removed lines

@@ -101,10 +101,10 @@ 
      * Builds an item response in Fractal then hands off to the responder
      *
      * @param  array                                      $item     The item to transform
-     * @param  mixed                                      $callback The Transformer to pass through to Fractal
+     * @param  \League\Fractal\TransformerAbstract                                      $callback The Transformer to pass through to Fractal
      * @param  \Symfony\Component\HttpFoundation\Response $response The client's response
      *
-     * @return array
+     * @return Response
      */
     protected function respondWithItem($item, $callback, Response $response)
     {
@@ -118,10 +118,10 @@ 
      * Builds a collection of items from Fractal then hands off to the responder
      *
      * @param  array $collection                          The collection to transform
-     * @param  mixed $callback                            The Transformer to pass through to Fractal
+     * @param  \League\Fractal\TransformerAbstract $callback                            The Transformer to pass through to Fractal
      * @param  \Symfony\Component\HttpFoundation\Response The client's response
      *
-     * @return array
+     * @return Response
      */
     protected function respondWithCollection($collection, $callback, Response $response)
     {
@@ -156,7 +156,7 @@ 
      * @param  string                                     $message   Response message to put in the error
      * @param  int                                        $errorCode Error code to set
      *
-     * @return array
+     * @return Response
      */
     protected function respondWithError(Response $response, $message, $errorCode)
     {
@@ -183,7 +183,7 @@ 
      * @param  \Symfony\Component\HttpFoundation\Response $response
      * @param  string                                     $message
      *
-     * @return void
+     * @return Response
      */
     public function errorEmpty(Response $response, $message = 'No data / Empty')
     {
@@ -197,7 +197,7 @@ 
      * @param  \Symfony\Component\HttpFoundation\Response $response
      * @param  string                                     $message
      *
-     * @return void
+     * @return Response
      */
     public function errorForbidden(Response $response, $message = 'Forbidden')
     {
@@ -211,7 +211,7 @@ 
      * @param  \Symfony\Component\HttpFoundation\Response $response
      * @param  string                                     $message
      *
-     * @return void
+     * @return Response
      */
     public function errorInternalError(Response $response, $message = 'Internal Error')
     {
@@ -225,7 +225,7 @@ 
      * @param  \Symfony\Component\HttpFoundation\Response $response
      * @param  string                                     $message
      *
-     * @return void
+     * @return Response
      */
     public function errorNotFound(Response $response, $message = 'Resource Not Found')
     {
@@ -239,7 +239,7 @@ 
      * @param  \Symfony\Component\HttpFoundation\Response $response
      * @param  string                                     $message
      *
-     * @return void
+     * @return Response
      */
     public function errorUnauthorized(Response $response, $message = 'Unauthorized')
     {
@@ -264,7 +264,7 @@ 
     /**
      * Reads any requested includes and adds them to the item / collection
      *
-     * @param  Symfony\Component\HttpFoundation\Request $request
+     * @param  Request $request
      *
      * @return void
      */

src/container.php

Indentation +7 added lines, -7 removed lines

@@ -17,21 +17,21 @@
 
 // Inflectors
 $container->inflector('Ps2alerts\Api\Contract\ConfigAwareInterface')
-          ->invokeMethod('setConfig', ['config']);
+            ->invokeMethod('setConfig', ['config']);
 $container->inflector('Ps2alerts\Api\Contract\DatabaseAwareInterface')
-          ->invokeMethod('setDatabaseDriver', ['Aura\Sql']);
+            ->invokeMethod('setDatabaseDriver', ['Aura\Sql']);
 $container->inflector('Ps2alerts\Api\Contract\LogAwareInterface')
-          ->invokeMethod('setLogDriver', ['Monolog\Logger']);
+            ->invokeMethod('setLogDriver', ['Monolog\Logger']);
 $container->inflector('Ps2alerts\Api\Contract\TemplateAwareInterface')
-          ->invokeMethod('setTemplateDriver', ['Twig_Environment']);
+            ->invokeMethod('setTemplateDriver', ['Twig_Environment']);
 $container->inflector('Ps2alerts\Api\Contract\RedisAwareInterface')
-          ->invokeMethod('setRedisDriver', ['redis']);
+            ->invokeMethod('setRedisDriver', ['redis']);
 $container->inflector('Ps2alerts\Api\Contract\UuidAwareInterface')
-          ->invokeMethod('setUuidDriver', ['Ramsey\Uuid\Uuid']);
+            ->invokeMethod('setUuidDriver', ['Ramsey\Uuid\Uuid']);
 
 
 // Container Inflector
 $container->inflector('League\Container\ContainerAwareInterface')
-          ->invokeMethod('setContainer', [$container]);
+            ->invokeMethod('setContainer', [$container]);
 
 return $container;

src/Repository/AbstractEndpointRepository.php

Indentation +2 added lines, -2 removed lines

@@ -89,7 +89,7 @@ 
         $key = $this->returnKeyType($keyType);
 
         $query->cols(['*'])
-              ->where("`{$key}` = '{$id}'");
+                ->where("`{$key}` = '{$id}'");
 
         return $this->fireStatementAndReturn($query, true);
     }
@@ -107,7 +107,7 @@ 
         $key = $this->returnKeyType($keyType);
 
         $query->cols(['*'])
-              ->where("`{$key}` = '{$id}'");
+                ->where("`{$key}` = '{$id}'");
 
         return $this->fireStatementAndReturn($query);
     }

src/Controller/Endpoint/AlertEndpointController.php

Doc Comments +12 added lines, -12 removed lines

@@ -15,9 +15,9 @@ 
     /**
      * Construct
      *
-     * @param Ps2alerts\Api\Repository\AlertRepository   $repository
-     * @param Ps2alerts\Api\Transformer\AlertTransformer $transformer
-     * @param League\Fractal\Manager                     $fractal
+     * @param AlertRepository   $repository
+     * @param AlertTransformer $transformer
+     * @param Manager                     $fractal
      */
     public function __construct(
         AlertRepository  $repository,
@@ -34,11 +34,11 @@ 
      *
      * @see AbstractEndpointController::respondWithItem
      *
-     * @param  Symfony\Component\HttpFoundation\Request  $request
-     * @param  Symfony\Component\HttpFoundation\Response $response
+     * @param  Request  $request
+     * @param  Response $response
      * @param  array                                     $args
      *
-     * @return array
+     * @return Response
      */
     public function getSingle(Request $request, Response $response, array $args)
     {
@@ -65,10 +65,10 @@ 
     /**
      * Returns the victories of each faction and the totals
      *
-     * @param  Symfony\Component\HttpFoundation\Request  $request
-     * @param  Symfony\Component\HttpFoundation\Response $response
+     * @param  Request  $request
+     * @param  Response $response
      *
-     * @return array
+     * @return Response
      */
     public function getVictories(Request $request, Response $response)
     {
@@ -90,10 +90,10 @@ 
     /**
      * Returns the dominations of each faction and the totals
      *
-     * @param  Symfony\Component\HttpFoundation\Request  $request
-     * @param  Symfony\Component\HttpFoundation\Response $response
+     * @param  Request  $request
+     * @param  Response $response
      *
-     * @return array
+     * @return Response
      */
     public function getDominations(Request $request, Response $response)
     {

src/Transformer/AlertTransformer.php

Doc Comments +1 added lines, -1 removed lines

@@ -158,7 +158,7 @@
      *
      * @param  array $data
      *
-     * @return \League\Fractal\Resource\Collection
+     * @return \League\Fractal\Resource\Item
      */
     public function includeCombats($data)
     {