Maelstromeous / ps2alerts-api

src/commands.php

Spacing +3 added lines, -3 removed lines

@@ -9,15 +9,15 @@
 use Ps2alerts\Api\Command\TestCommand;
 use Symfony\Component\Console\Application;
 
-require __DIR__ . '/../vendor/autoload.php';
+require __DIR__.'/../vendor/autoload.php';
 
 // ENV loading
 josegonzalez\Dotenv\Loader::load([
-    'filepath' => __DIR__ . '/../.env',
+    'filepath' => __DIR__.'/../.env',
     'toEnv'    => true
 ]);
 
-include __DIR__ . '/Command/CommandsCommon.php';
+include __DIR__.'/Command/CommandsCommon.php';
 
 $application = new Application();
 // List commands here

src/Command/BaseCommand.php

Spacing +1 added lines, -1 removed lines

@@ -11,7 +11,7 @@
 
     protected function configure()
     {
-        $container = include __DIR__ . '/../container.php';
+        $container = include __DIR__.'/../container.php';
 
         $this->container   = $container;
         $this->auraFactory = $container->get('Ps2alerts\Api\Factory\AuraFactory');

src/Command/LeaderboardOutfitsCommand.php

Spacing +1 added lines, -1 removed lines

@@ -77,7 +77,7 @@
                         $query->where('playerServer', $server);
                     }
 
-                    $query->orderBy([$metric . ' DESC']);
+                    $query->orderBy([$metric.' DESC']);
                     $query->limit($limit);
                     $query->offset($count);
 

src/Command/ArchiveCommand.php

Upper-Lower-Casing +3 added lines, -3 removed lines

@@ -73,7 +73,7 @@ 
         $alerts = $this->alertRepo->fireStatementAndReturn($query);
         $count = count($alerts);
 
-        $output->writeln("Detected {$count} alerts to be archived");
+        $output->writeln("detected {$count} alerts to be archived");
 
         if ($count > 0) {
             $tables = [
@@ -115,7 +115,7 @@ 
             ['json' => $payload]
         );
 
-        $output->writeln("Archived {$records} records!");
+        $output->writeln("archived {$records} records!");
     }
 
     /**
@@ -183,7 +183,7 @@ 
             $this->recordsArchived += $stm->rowCount();
             $records += $stm->rowCount();
 
-            $output->writeln("Archived {$stm->rowCount()} from Alert #{$alert['ResultID']} - Table {$table}");
+            $output->writeln("archived {$stm->rowCount()} from Alert #{$alert['ResultID']} - Table {$table}");
         }
 
         $this->db->commit();

src/Command/LeaderboardPlayersCommand.php

Indentation +1 added lines, -1 removed lines

@@ -89,7 +89,7 @@
                     $query->cols(['*']);
                     $query->from('ws_players_total');
                     if ($server != 0) {
-                         $query->where("playerServer = ?", $server);
+                            $query->where("playerServer = ?", $server);
                     }
                     $query->orderBy([$metric.' DESC']);
                     $query->limit($limit);

src/Controller/Endpoint/AbstractEndpointController.php

Doc Comments +1 added lines, -1 removed lines

@@ -127,7 +127,7 @@
     /**
      * Checks formatting of dates input and then adds them to query
      *
-     * @param mixed         $dates
+     * @param string         $dates
      * @param AbstractQuery $query
      * @param boolean       $raw   Determines if query is being used in raw mode
      *

Spacing +3 added lines, -3 removed lines

@@ -99,7 +99,7 @@ 
 
             // Format into strings comma separated for SQL
             if (in_array($type, $strings)) {
-                $queryString = "'" . implode("','", $values) . "'";
+                $queryString = "'".implode("','", $values)."'";
             }
 
             return $queryString;
@@ -118,7 +118,7 @@ 
         $return = implode(',', $filters);
 
         if (in_array($type, $strings)) {
-            $return = "'" . implode("','", $filters) . "'";
+            $return = "'".implode("','", $filters)."'";
         }
 
         return $return;
@@ -135,7 +135,7 @@ 
      */
     public function addDateRangeWhereClause($dates, AbstractQuery $query, $raw = false)
     {
-        if (! is_array($dates)) {
+        if (!is_array($dates)) {
             $dates = str_replace('\'', '', $dates); // Remove escaping quotes
             $dates = explode(',', $dates);
         }

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -75,7 +75,7 @@
                 }
 
                 if ($type !== 'dates' && !in_array($val, $filters)) {
-                    throw new InvalidArgumentException("Unrecognized {$type}. Please check the DATA you sent.");
+                    throw new InvalidArgumentException("unrecognized {$type}. Please check the DATA you sent.");
                 }
 
                 if ($type === 'dates') {

src/Controller/Endpoint/Alerts/AlertCombatEndpointController.php

Doc Comments +6 added lines

@@ -250,6 +250,9 @@ 
         return $this->respondWithData($results);
     }
 
+    /**
+     * @param integer $classID
+     */
     private function findClassGrouping($classID)
     {
         $classGroups = $this->getConfig()['classesGroups'];
@@ -265,6 +268,9 @@ 
         return false;
     }
 
+    /**
+     * @param integer $classID
+     */
     private function findClassFaction($classID)
     {
         $classesFactions = $this->getConfig()['classesFactions'];

Unused Use Statements -2 removed lines

@@ -3,8 +3,6 @@
 namespace Ps2alerts\Api\Controller\Endpoint\Alerts;
 
 use Ps2alerts\Api\Exception\InvalidArgumentException;
-use Ps2alerts\Api\Repository\Metrics\CombatRepository;
-use Ps2alerts\Api\Repository\Metrics\ClassRepository;
 use Psr\Http\Message\ServerRequestInterface;
 use Psr\Http\Message\ResponseInterface;
 

Spacing +13 added lines, -13 removed lines

@@ -49,23 +49,23 @@ 
 
             $mergedArray = [];
 
-            if (! $data || ! $dataArchive) {
+            if (!$data || !$dataArchive) {
                 $sums = [];
                 foreach ($metrics as $metric) {
                     foreach ($factions as $faction) {
-                        $dbMetric = $metric . strtoupper($faction); // e.g. killsVS
-                        $dataMetric = $metric . strtoupper($faction); // e.g. killsVS
+                        $dbMetric = $metric.strtoupper($faction); // e.g. killsVS
+                        $dataMetric = $metric.strtoupper($faction); // e.g. killsVS
 
                         // Handle teamkills inconsistency
                         if ($metric === 'teamkills') {
-                            $dbMetric = 'teamKills' . strtoupper($faction);
+                            $dbMetric = 'teamKills'.strtoupper($faction);
                         }
                         $sums[] = "SUM(factions.{$dbMetric}) AS $dataMetric";
                     }
 
                     // Totals
-                    $dbMetric = 'total' . ucfirst($metric); // e.g. killsVS
-                    $dataMetric = 'total' . ucfirst($metric); // e.g. killsVS
+                    $dbMetric = 'total'.ucfirst($metric); // e.g. killsVS
+                    $dataMetric = 'total'.ucfirst($metric); // e.g. killsVS
 
                     // Handle teamkills inconsistency
                     if ($metric === 'teamkills') {
@@ -100,12 +100,12 @@ 
             // Merge the two arrays together
             foreach ($metrics as $metric) {
                 // Tot up totals
-                $dbMetric = 'total' . ucfirst($metric);
+                $dbMetric = 'total'.ucfirst($metric);
                 $mergedArray['totals'][$metric] = (int) $data[$dbMetric] + (int) $dataArchive[$dbMetric];
                 $results['all']['totals'][$metric] += $mergedArray['totals'][$metric];
 
                 foreach ($factions as $faction) {
-                    $dbMetric = $metric . strtoupper($faction);
+                    $dbMetric = $metric.strtoupper($faction);
                     $mergedArray[$metric][$faction] = (int) $data[$dbMetric] + (int) $dataArchive[$dbMetric];
                     $results['all'][$metric][$faction] += $mergedArray[$metric][$faction];
                 }
@@ -148,7 +148,7 @@ 
             $dataArchive = $this->getRedisUtility()->checkRedis('api', 'classCombat', "{$server}-dataArchive", 'object');
 
             // If data needs a pull
-            if (! $data || ! $dataArchive) {
+            if (!$data || !$dataArchive) {
                 $query = $this->combatRepository->newQuery('single', true);
                 $query->cols([
                         'classID',
@@ -181,8 +181,8 @@ 
             // Typecase into ints and increase totals
             $metrics = ['kills', 'deaths', 'teamkills', 'suicides'];
             foreach ($data as $row) {
-                $row->classID   = (int) $row->classID;
-                $row->server   = (int) $row->server;
+                $row->classID = (int) $row->classID;
+                $row->server = (int) $row->server;
                 $classGroup = $this->findClassGrouping($row->classID);
                 $faction = $this->findClassFaction($row->classID);
 
@@ -201,8 +201,8 @@ 
             }
 
             foreach ($dataArchive as $row) {
-                $row->classID   = (int) $row->classID;
-                $row->server   = (int) $row->server;
+                $row->classID = (int) $row->classID;
+                $row->server = (int) $row->server;
 
                 foreach ($metrics as $metric) {
                     $row->$metric = (int) $row->$metric;

src/Controller/Endpoint/Leaderboards/LeaderboardOutfitEndpointController.php

Doc Comments -1 removed lines

@@ -15,7 +15,6 @@
     /**
      * Construct
      *
-     * @param League\Fractal\Manager $fractal
      */
     public function __construct(
         OutfitTotalRepository  $repository

Spacing +1 added lines, -1 removed lines

@@ -40,7 +40,7 @@
             $field = $this->getField($_GET['field']);
         }
 
-        if (! isset($field)) {
+        if (!isset($field)) {
             return $this->respondWithError('Field wasn\'t provided and is required.', self::CODE_WRONG_ARGS);
         }
 

src/Controller/Endpoint/Leaderboards/LeaderboardPlayerEndpointController.php

Doc Comments +1 added lines, -1 removed lines

@@ -32,7 +32,7 @@
     /**
      * Get Player Leaderboard
      *
-     * @return \League\Fractal\Manager
+     * @return \Psr\Http\Message\ResponseInterface
      */
     public function players()
     {

Spacing +2 added lines, -2 removed lines

@@ -52,7 +52,7 @@ 
             $field = $this->getField($_GET['field']);
         }
 
-        if (! isset($field)) {
+        if (!isset($field)) {
             return $this->respondWithError('Field wasn\'t provided and is required.', self::CODE_WRONG_ARGS);
         }
 
@@ -81,7 +81,7 @@ 
 
         // Gets outfit details
         for ($i = 0; $i < $count; $i++) {
-            if (! empty($players[$i]['playerOutfit'])) {
+            if (!empty($players[$i]['playerOutfit'])) {
                 // Gets outfit details
                 try {
                     $outfit = $this->dataEndpoint->getOutfit($players[$i]['playerOutfit']);