Maelstromeous / ps2alerts-api

src/Command/DeleteMissingAlertsCommand.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use Ps2alerts\Api\Command\BaseCommand;
 use Ps2alerts\Api\Repository\AlertRepository;
-use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
 

src/commands.php

Spacing +3 added lines, -3 removed lines

@@ -9,15 +9,15 @@
 use Ps2alerts\Api\Command\TestCommand;
 use Symfony\Component\Console\Application;
 
-require __DIR__ . '/../vendor/autoload.php';
+require __DIR__.'/../vendor/autoload.php';
 
 // ENV loading
 josegonzalez\Dotenv\Loader::load([
-    'filepath' => __DIR__ . '/../.env',
+    'filepath' => __DIR__.'/../.env',
     'toEnv'    => true
 ]);
 
-include __DIR__ . '/Command/CommandsCommon.php';
+include __DIR__.'/Command/CommandsCommon.php';
 
 $application = new Application();
 // List commands here

src/Command/BaseCommand.php

Spacing +1 added lines, -1 removed lines

@@ -11,7 +11,7 @@
 
     protected function configure()
     {
-        $container = include __DIR__ . '/../container.php';
+        $container = include __DIR__.'/../container.php';
 
         $this->container   = $container;
         $this->auraFactory = $container->get('Ps2alerts\Api\Factory\AuraFactory');

src/Command/ArchiveCommand.php

Doc Comments +2 added lines, -2 removed lines

@@ -122,8 +122,8 @@
      * Execution of routine
      *
      * @param  array                                            $alert
-     * @param  array                                            $tables
-     * @param  Symfony\Component\Console\Output\OutputInterface $output
+     * @param  string[]                                            $tables
+     * @param  OutputInterface $output
      *
      * @return void
      */

Upper-Lower-Casing +3 added lines, -3 removed lines

@@ -73,7 +73,7 @@ 
         $alerts = $this->alertRepo->fireStatementAndReturn($query);
         $count = count($alerts);
 
-        $output->writeln("Detected {$count} alerts to be archived");
+        $output->writeln("detected {$count} alerts to be archived");
 
         if ($count > 0) {
             $tables = [
@@ -115,7 +115,7 @@ 
             ['json' => $payload]
         );
 
-        $output->writeln("Archived {$records} records!");
+        $output->writeln("archived {$records} records!");
     }
 
     /**
@@ -183,7 +183,7 @@ 
             $this->recordsArchived += $stm->rowCount();
             $records += $stm->rowCount();
 
-            $output->writeln("Archived {$stm->rowCount()} from Alert #{$alert['ResultID']} - Table {$table}");
+            $output->writeln("archived {$stm->rowCount()} from Alert #{$alert['ResultID']} - Table {$table}");
         }
 
         $this->db->commit();

src/Command/DeleteAlertCommand.php

Doc Comments +11 added lines, -5 removed lines

@@ -115,7 +115,7 @@ 
     /**
      * Processes players for alert
      * @param  string $id Alert ID
-     * @return void
+     * @return integer
      */
     protected function processPlayers($id)
     {
@@ -149,7 +149,7 @@ 
     /**
      * Processes outfits for alert
      * @param  string $id Alert ID
-     * @return void
+     * @return integer
      */
     protected function processOutfits($id)
     {
@@ -181,7 +181,7 @@ 
     /**
      * Processes XPs for alert
      * @param  string $id Alert ID
-     * @return void
+     * @return integer
      */
     protected function processXP($id)
     {
@@ -208,11 +208,11 @@ 
     /**
      * Executes the process based on inputs
      * @param  string $id          Alert ID
-     * @param  array  $cols        Columns to look for
+     * @param  string[]  $cols        Columns to look for
      * @param  string $table       Table to look for
      * @param  string $totalsTable Table total to update if applicable
      * @param  string $filter      Column to filter on
-     * @param  array  $fields      Fields to summarize
+     * @param  string[]  $fields      Fields to summarize
      * @param  array  $groupBy     Fields to group by
      * @return int
      */
@@ -270,6 +270,9 @@ 
         return $count;
     }
 
+    /**
+     * @param string $id
+     */
     protected function deleteAllFromTables(array $tables, $id, OutputInterface $output)
     {
         foreach ($tables as $table) {
@@ -288,6 +291,9 @@ 
         }
     }
 
+    /**
+     * @param string $id
+     */
     protected function deleteAlert($id)
     {
         $delete = $this->auraFactory->newDelete();

src/Controller/Endpoint/AbstractEndpointController.php

Unused Use Statements -1 removed lines

@@ -13,7 +13,6 @@
 use Ps2alerts\Api\Contract\RedisAwareInterface;
 use Ps2alerts\Api\Contract\RedisAwareTrait;
 use Ps2alerts\Api\Exception\InvalidArgumentException;
-use Psr\Http\Message\ServerRequestInterface;
 use Psr\Http\Message\ResponseInterface;
 
 abstract class AbstractEndpointController implements

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -437,7 +437,7 @@
                 }
 
                 if (!in_array($id, $filters)) {
-                    throw new InvalidArgumentException("Unrecognized {$mode}. Please check the IDs you sent.");
+                    throw new InvalidArgumentException("unrecognized {$mode}. Please check the IDs you sent.");
                 }
             }
 

src/Command/LeaderboardOutfitsCommand.php

Spacing +1 added lines, -1 removed lines

@@ -77,7 +77,7 @@
                         $query->where('playerServer', $server);
                     }
 
-                    $query->orderBy([$metric . ' DESC']);
+                    $query->orderBy([$metric.' DESC']);
                     $query->limit($limit);
                     $query->offset($count);
 

src/Command/LeaderboardPlayersCommand.php

Indentation +1 added lines, -1 removed lines

@@ -89,7 +89,7 @@
                     $query->cols(['*']);
                     $query->from('ws_players_total');
                     if ($server != 0) {
-                         $query->where("playerServer = ?", $server);
+                            $query->where("playerServer = ?", $server);
                     }
                     $query->orderBy([$metric.' DESC']);
                     $query->limit($limit);

src/Controller/Endpoint/Leaderboards/LeaderboardEndpointController.php

Doc Comments +4 added lines, -4 removed lines

@@ -28,7 +28,7 @@ 
     /**
      * Construct
      *
-     * @param League\Fractal\Manager $fractal
+     * @param Manager $fractal
      */
     public function __construct(
         Manager                $fractal,
@@ -48,7 +48,7 @@ 
     /**
      * Get Player Leaderboard
      *
-     * @return \League\Fractal\Manager
+     * @return ResponseInterface
      */
     public function players()
     {
@@ -137,7 +137,7 @@ 
     /**
      * Get Outfit Leaderboard
      *
-     * @return \League\Fractal\Manager
+     * @return ResponseInterface
      */
     public function outfits()
     {
@@ -208,7 +208,7 @@ 
     /**
      * Get Weapon Leaderboard
      *
-     * @return \League\Fractal\Manager
+     * @return ResponseInterface
      */
     public function weapons()
     {

Unused Use Statements -3 removed lines

@@ -11,12 +11,9 @@
 use Ps2alerts\Api\Repository\Metrics\OutfitTotalRepository;
 use Ps2alerts\Api\Repository\Metrics\PlayerTotalRepository;
 use Ps2alerts\Api\Repository\Metrics\WeaponTotalRepository;
-use Ps2alerts\Api\Transformer\Leaderboards\LeaderboardUpdatedTransformer;
 use Ps2alerts\Api\Transformer\Leaderboards\OutfitLeaderboardTransformer;
 use Ps2alerts\Api\Transformer\Leaderboards\PlayerLeaderboardTransformer;
 use Ps2alerts\Api\Transformer\Leaderboards\WeaponLeaderboardTransformer;
-use Psr\Http\Message\ResponseInterface;
-use Psr\Http\Message\ServerRequestInterface;
 
 class LeaderboardEndpointController extends AbstractEndpointController
 {

Spacing +12 added lines, -12 removed lines

@@ -84,7 +84,7 @@ 
             }
         }
 
-        if (! isset($field)) {
+        if (!isset($field)) {
             return $this->errorWrongArgs('Field wasn\'t provided and is required.');
         }
 
@@ -113,7 +113,7 @@ 
 
         // Gets outfit details
         for ($i = 0; $i < $count; $i++) {
-            if (! empty($players[$i]['playerOutfit'])) {
+            if (!empty($players[$i]['playerOutfit'])) {
                 // Gets outfit details
                 try {
                     $outfit = $this->dataEndpoint->getOutfit($players[$i]['playerOutfit']);
@@ -174,7 +174,7 @@ 
             }
         }
 
-        if (! isset($field)) {
+        if (!isset($field)) {
             return $this->errorWrongArgs('Field wasn\'t provided and is required.');
         }
 
@@ -234,7 +234,7 @@ 
             }
         }
 
-        if (! isset($field)) {
+        if (!isset($field)) {
             return $this->errorWrongArgs('Field wasn\'t provided and is required.');
         }
 
@@ -276,19 +276,19 @@ 
     public function validateRequestVars()
     {
         try {
-            if (! empty($_GET['field'])) {
+            if (!empty($_GET['field'])) {
                 $this->parseField($_GET['field']);
             }
 
-            if (! empty($_GET['server'])) {
+            if (!empty($_GET['server'])) {
                 $this->parseServer($_GET['server']);
             }
 
-            if (! empty($_GET['limit'])) {
+            if (!empty($_GET['limit'])) {
                 $this->parseOffset($_GET['limit']);
             }
 
-            if (! empty($_GET['offset'])) {
+            if (!empty($_GET['offset'])) {
                 $this->parseOffset($_GET['offset']);
             }
         } catch (InvalidArgumentException $e) {
@@ -314,7 +314,7 @@ 
             'captures'
         ];
 
-        if (! empty($field) && in_array($field, $validFields)) {
+        if (!empty($field) && in_array($field, $validFields)) {
             return $field;
         }
 
@@ -335,7 +335,7 @@ 
             unset($validServers[$key]);
         }
 
-        if (! empty($server) && in_array($server, $validServers)) {
+        if (!empty($server) && in_array($server, $validServers)) {
             return $server;
         }
 
@@ -349,7 +349,7 @@ 
      */
     public function parseLimit($limit)
     {
-        if (! isset($limit) && ! is_numeric($limit)) {
+        if (!isset($limit) && !is_numeric($limit)) {
             throw new InvalidArgumentException("Limit needs to be in numerical format.");
         }
 
@@ -361,7 +361,7 @@ 
      */
     public function parseOffset($offset)
     {
-        if (! isset($offset) && ! is_numeric($offset)) {
+        if (!isset($offset) && !is_numeric($offset)) {
             throw new InvalidArgumentException("Offset needs to be in numerical format.");
         }