Maelstromeous / ps2alerts-api

src/Command/DeleteMissingAlertsCommand.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use Ps2alerts\Api\Command\BaseCommand;
 use Ps2alerts\Api\Repository\AlertRepository;
-use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
 

src/commands.php

Spacing +3 added lines, -3 removed lines

@@ -9,15 +9,15 @@
 use Ps2alerts\Api\Command\TestCommand;
 use Symfony\Component\Console\Application;
 
-require __DIR__ . '/../vendor/autoload.php';
+require __DIR__.'/../vendor/autoload.php';
 
 // ENV loading
 josegonzalez\Dotenv\Loader::load([
-    'filepath' => __DIR__ . '/../.env',
+    'filepath' => __DIR__.'/../.env',
     'toEnv'    => true
 ]);
 
-include __DIR__ . '/Command/CommandsCommon.php';
+include __DIR__.'/Command/CommandsCommon.php';
 
 $application = new Application();
 // List commands here

src/Command/BaseCommand.php

Spacing +1 added lines, -1 removed lines

@@ -11,7 +11,7 @@
 
     protected function configure()
     {
-        $container = include __DIR__ . '/../container.php';
+        $container = include __DIR__.'/../container.php';
 
         $this->container   = $container;
         $this->auraFactory = $container->get('Ps2alerts\Api\Factory\AuraFactory');

src/Command/DeleteAlertCommand.php

Doc Comments +11 added lines, -5 removed lines

@@ -115,7 +115,7 @@ 
     /**
      * Processes players for alert
      * @param  string $id Alert ID
-     * @return void
+     * @return integer
      */
     protected function processPlayers($id)
     {
@@ -149,7 +149,7 @@ 
     /**
      * Processes outfits for alert
      * @param  string $id Alert ID
-     * @return void
+     * @return integer
      */
     protected function processOutfits($id)
     {
@@ -181,7 +181,7 @@ 
     /**
      * Processes XPs for alert
      * @param  string $id Alert ID
-     * @return void
+     * @return integer
      */
     protected function processXP($id)
     {
@@ -208,11 +208,11 @@ 
     /**
      * Executes the process based on inputs
      * @param  string $id          Alert ID
-     * @param  array  $cols        Columns to look for
+     * @param  string[]  $cols        Columns to look for
      * @param  string $table       Table to look for
      * @param  string $totalsTable Table total to update if applicable
      * @param  string $filter      Column to filter on
-     * @param  array  $fields      Fields to summarize
+     * @param  string[]  $fields      Fields to summarize
      * @param  array  $groupBy     Fields to group by
      * @return int
      */
@@ -270,6 +270,9 @@ 
         return $count;
     }
 
+    /**
+     * @param string $id
+     */
     protected function deleteAllFromTables(array $tables, $id, OutputInterface $output)
     {
         foreach($tables as $table) {
@@ -288,6 +291,9 @@ 
         }
     }
 
+    /**
+     * @param string $id
+     */
     protected function deleteAlert($id)
     {
         $delete = $this->auraFactory->newDelete();

src/Command/LeaderboardPlayersCommand.php

Indentation +1 added lines, -1 removed lines

@@ -89,7 +89,7 @@
                     $query->cols(['*']);
                     $query->from('ws_players_total');
                     if ($server != 0) {
-                         $query->where("playerServer = ?", $server);
+                            $query->where("playerServer = ?", $server);
                     }
                     $query->orderBy([$metric . ' DESC']);
                     $query->limit($limit);

src/Command/LeaderboardOutfitsCommand.php

Spacing +10 added lines, -10 removed lines

@@ -29,7 +29,7 @@ 
         $this->playerLeaderboards($output);
 
         $end = microtime(true);
-        $output->writeln("Processing took " . gmdate("H:i:s", ($end - $start)));
+        $output->writeln("Processing took ".gmdate("H:i:s", ($end - $start)));
     }
 
     public function playerLeaderboards(OutputInterface $output)
@@ -41,16 +41,16 @@ 
             'playerSuicides',
             'headshots'
         ];
-        $servers = [0,1,10,13,17,25,1000,2000];
+        $servers = [0, 1, 10, 13, 17, 25, 1000, 2000];
 
-        foreach($servers as $server) {
-            foreach($metrics as $metric) {
+        foreach ($servers as $server) {
+            foreach ($metrics as $metric) {
                 $this->markAsBeingUpdated($metric, $server);
             }
         }
 
-        foreach($servers as $server) {
-            foreach($metrics as $metric) {
+        foreach ($servers as $server) {
+            foreach ($metrics as $metric) {
                 $count = 0;
                 $limit = 10000;
                 $ladderLimit = 10000;
@@ -78,7 +78,7 @@ 
                         $query->where('playerServer', $server);
                     }
 
-                    $query->orderBy([$metric . ' DESC']);
+                    $query->orderBy([$metric.' DESC']);
                     $query->limit($limit);
                     $query->offset($count);
 
@@ -93,7 +93,7 @@ 
                         $playerPosKey = "ps2alerts:api:leaderboards:players:pos:{$player->playerID}";
 
                         // If player record doesn't exist
-                        if (! $this->redis->exists($playerPosKey)) {
+                        if (!$this->redis->exists($playerPosKey)) {
                             $data = [
                                 'id'      => $player->playerID,
                                 'updated' => date('U', strtotime('now'))
@@ -103,7 +103,7 @@ 
                         }
 
                         // For first time running
-                        if (! empty($data[$server][$metric])) {
+                        if (!empty($data[$server][$metric])) {
                             $data[$server][$metric]['old'] = $data[$server][$metric]['new'];
                         } else {
                             $data[$server][$metric]['old'] = 0;
@@ -129,7 +129,7 @@ 
         $key = "ps2alerts:api:leaderboards:status:{$metric}:{$server}";
 
         // Create the key if it doesn't exist for some reason (1st runs)
-        if (! $this->redis->exists($key)) {
+        if (!$this->redis->exists($key)) {
             $data = [
                 'beingUpdated' => 1,
                 'lastUpdated'  => 'never'