LukeCarrier / moodle-componentmgr

lib/ComponentManager/ComponentSpecification.php

Doc Comments +1 added lines, -1 removed lines

@@ -118,7 +118,7 @@
      *
      * @param string $property
      *
-     * @return mixed
+     * @return string
      *
      * @throws \OutOfBoundsException
      */

Spacing +2 added lines, -2 removed lines

@@ -66,8 +66,8 @@
      * @param string    $packageSource
      * @param \stdClass $extra
      */
-    public function __construct($name, $version, $packageRepository=null,
-                                $packageSource=null, stdClass $extra=null) {
+    public function __construct($name, $version, $packageRepository = null,
+                                $packageSource = null, stdClass $extra = null) {
         $this->name    = $name;
         $this->version = $version;
 

lib/ComponentManager/Project/Project.php

Doc Comments +1 added lines, -1 removed lines

@@ -71,7 +71,7 @@
      * @param \ComponentManager\Project\ProjectLockFile                    $projectLockFile
      * @param \ComponentManager\PackageRepository\PackageRepositoryFactory $packageRepositoryFactory
      * @param \ComponentManager\PackageSource\PackageSourceFactory         $packageSourceFactory
-     * @param \ComponentManager\PackageSource\PackageFormatFactory         $packageFormatFactory
+     * @param PackageFormatFactory         $packageFormatFactory
      */
     public function __construct(ProjectFile $projectFile,
                                 ProjectLockFile $projectLockFile,

lib/ComponentManager/Step/ObtainMoodleSourceStep.php

Doc Comments -2 removed lines

@@ -38,8 +38,6 @@
     /**
      * Initialiser.
      *
-     * @param \ComponentManager\MoodleVersion $version
-     * @param \Psr\Log\LoggerInterface        $logger
      * @param string                          $archive
      * @param string                          $destination
      */

lib/ComponentManager/Component.php

Spacing +2 added lines, -2 removed lines

@@ -63,7 +63,7 @@ 
      * @param \ComponentManager\ComponentVersion[]                  $versions
      * @param \ComponentManager\PackageRepository\PackageRepository $packageRepository
      */
-    public function __construct($name, $versions, $packageRepository=null) {
+    public function __construct($name, $versions, $packageRepository = null) {
         $this->name     = $name;
         $this->versions = $versions;
 
@@ -120,7 +120,7 @@ 
      * @return string
      */
     public function getPluginType() {
-        list($type, ) = $this->getNameParts();
+        list($type,) = $this->getNameParts();
 
         return $type;
     }

lib/ComponentManager/PackageRepository/StashPackageRepository.php

Spacing +2 added lines, -2 removed lines

@@ -322,7 +322,7 @@ 
      *
      * @return mixed The JSON-decoded representation of the response body.
      */
-    protected function get($path, array $queryParams=[]) {
+    protected function get($path, array $queryParams = []) {
         $uri = $this->options->uri . $path;
 
         $client = new Client();
@@ -344,7 +344,7 @@ 
      *
      * @return mixed The value attribute of the JSON-decoded response body.
      */
-    protected function getAllPages($path, array $queryParams=[]) {
+    protected function getAllPages($path, array $queryParams = []) {
         $values = [];
 
         $responseBody = (object) [

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -328,7 +328,7 @@
         $client = new Client();
         $response = $client->get($uri, [
             'headers' => [
-                'Authorization' => "Basic {$this->options->authentication}",
+                'Authorization' => "basic {$this->options->authentication}",
             ],
             'query' => $queryParams,
         ]);

Indentation +4 added lines, -4 removed lines

@@ -271,7 +271,7 @@ 
      */
     protected function getMetadataCacheFilename() {
         $urlHash = parse_url($this->options->uri, PHP_URL_HOST) . '-'
-                 . $this->options->project;
+                    . $this->options->project;
 
         return $this->platform->joinPaths([
             parent::getMetadataCacheDirectory(),
@@ -370,7 +370,7 @@ 
      */
     protected function getProjectRepositoryListUrl() {
         return sprintf(static::PROJECT_REPOSITORY_LIST_PATH,
-                       $this->options->project);
+                        $this->options->project);
     }
 
     /**
@@ -382,7 +382,7 @@ 
      */
     protected function getRepositoryBranchesPath($componentName) {
         return sprintf(static::REPOSITORY_BRANCHES_PATH, $this->options->project,
-                       $componentName);
+                        $componentName);
     }
 
     /**
@@ -394,6 +394,6 @@ 
      */
     protected function getRepositoryTagsPath($componentName) {
         return sprintf(static::REPOSITORY_TAGS_PATH, $this->options->project,
-                       $componentName);
+                        $componentName);
     }
 }

lib/ComponentManager/ComponentVersion.php

Spacing +1 added lines, -1 removed lines

@@ -83,7 +83,7 @@
      * @param integer                                             $maturity
      * @param \ComponentManager\ComponentSource\ComponentSource[] $sources
      */
-    public function __construct($version, $release, $maturity, $sources=null) {
+    public function __construct($version, $release, $maturity, $sources = null) {
         $this->version  = $version;
         $this->release  = $release;
         $this->maturity = $maturity;

lib/ComponentManager/PackageSource/PackageSource.php

Indentation +3 added lines, -3 removed lines

@@ -56,7 +56,7 @@
      * @return string The path to the module's root directory.
      */
     public function obtainPackage($tempDirectory,
-                                  ResolvedComponentVersion $resolvedComponentVersion,
-                                  Filesystem $filesystem,
-                                  LoggerInterface $logger);
+                                    ResolvedComponentVersion $resolvedComponentVersion,
+                                    Filesystem $filesystem,
+                                    LoggerInterface $logger);
 }

lib/ComponentManager/PackageSource/ZipPackageSource.php

Indentation +15 added lines, -15 removed lines

@@ -80,9 +80,9 @@ 
      * @return string
      */
     protected function getArchiveFilename(Component $component,
-                                          ComponentVersion $version) {
+                                            ComponentVersion $version) {
         return sprintf(static::ARCHIVE_FILENAME_FORMAT, $component->getName(),
-                       $version->getVersion());
+                        $version->getVersion());
     }
 
     /**
@@ -94,18 +94,18 @@ 
      * @return string
      */
     protected function getTargetDirectory(Component $component,
-                                          ComponentVersion $version) {
+                                            ComponentVersion $version) {
         return sprintf(static::TARGET_DIRECTORY_FORMAT, $component->getName(),
-                       $version->getVersion());
+                        $version->getVersion());
     }
 
     /**
      * @override \ComponentManager\PackageSource\PackageSource
      */
     public function obtainPackage($tempDirectory,
-                                  ResolvedComponentVersion $resolvedComponentVersion,
-                                  Filesystem $filesystem,
-                                  LoggerInterface $logger) {
+                                    ResolvedComponentVersion $resolvedComponentVersion,
+                                    Filesystem $filesystem,
+                                    LoggerInterface $logger) {
         $component = $resolvedComponentVersion->getComponent();
         $version   = $resolvedComponentVersion->getVersion();
         $sources   = $version->getSources();
@@ -171,14 +171,14 @@ 
      * @throws InstallationFailureException
      */
     protected function trySource($tempDirectory, LoggerInterface $logger,
-                                 Component $component, ComponentVersion $version,
-                                 ZipComponentSource $source) {
+                                    Component $component, ComponentVersion $version,
+                                    ZipComponentSource $source) {
         $archiveFilename = $tempDirectory
-                         . PlatformUtil::directorySeparator()
-                         . $this->getArchiveFilename($component, $version);
+                            . PlatformUtil::directorySeparator()
+                            . $this->getArchiveFilename($component, $version);
         $targetDirectory = $tempDirectory
-                         . PlatformUtil::directorySeparator()
-                         . $this->getTargetDirectory($component, $version);
+                            . PlatformUtil::directorySeparator()
+                            . $this->getTargetDirectory($component, $version);
 
         $logger->debug('Trying zip source', [
             'archiveFilename' => $archiveFilename,
@@ -212,8 +212,8 @@ 
         }
 
         $moduleRootDirectory = $targetDirectory
-                             . PlatformUtil::directorySeparator()
-                             . $component->getPluginName();
+                                . PlatformUtil::directorySeparator()
+                                . $component->getPluginName();
         if (!is_dir($moduleRootDirectory)) {
             throw new InstallationFailureException(
                     "Module directory {$moduleRootDirectory} did not exist",

lib/ComponentManager/PackageSource/DirectoryPackageSource.php

Indentation +3 added lines, -3 removed lines

@@ -39,9 +39,9 @@
      * @override \ComponentManager\PackageSource\PackageSource
      */
     public function obtainPackage($tempDirectory,
-                                  ResolvedComponentVersion $resolvedComponentVersion,
-                                  Filesystem $filesystem,
-                                  LoggerInterface $logger) {
+                                    ResolvedComponentVersion $resolvedComponentVersion,
+                                    Filesystem $filesystem,
+                                    LoggerInterface $logger) {
         $version = $resolvedComponentVersion->getVersion();
         $sources = $version->getSources();