Inspection of "19e1ba14c4d8f008bc7cc987c92ed444d1ab832b" - LivePersonInc/LiveEngageLaravel - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Branch — master (19e1ba)

by Robert

created 2018-06-12 18:34 UTC

Status

Indentation +49 added lines, -49 removed lines patch added patch discarded remove patch

@@ -8,67 +8,67 @@
 block discarded – undo
 
 class EngagementHistory extends Collection
 {
-    private $instance;
+	private $instance;
 
-    public function __construct(array $models = [], LiveEngageLaravel $instance = null)
-    {
-        $this->instance = $instance;
+	public function __construct(array $models = [], LiveEngageLaravel $instance = null)
+	{
+		$this->instance = $instance;
 
-        parent::__construct($models);
-    }
+		parent::__construct($models);
+	}
     
-    public function find($engagementID)
-    {
-	    $result = $this->filter(function ($value, $key) use ($engagementID) {
-		    return $value->info->sessionId == $engagementID;
-	    });
+	public function find($engagementID)
+	{
+		$result = $this->filter(function ($value, $key) use ($engagementID) {
+			return $value->info->sessionId == $engagementID;
+		});
 	    
-	    return $result->first();
-    }
+		return $result->first();
+	}
 
-    public function next()
-    {
-        if (! $this->instance) {
-            return false;
-        }
+	public function next()
+	{
+		if (! $this->instance) {
+			return false;
+		}
 
-        $instance = $this->instance;
+		$instance = $this->instance;
 
-        $next = $instance->retrieveHistory($instance->start, $instance->end, $instance->next);
-        if (property_exists($next->_metadata, 'next')) {
-            $instance->next = $next->_metadata->next->href;
+		$next = $instance->retrieveHistory($instance->start, $instance->end, $instance->next);
+		if (property_exists($next->_metadata, 'next')) {
+			$instance->next = $next->_metadata->next->href;
 
-            $history = [];
-            foreach ($next->interactionHistoryRecords as $item) {
-                $history[] = new Engagement((array) $item);
-            }
+			$history = [];
+			foreach ($next->interactionHistoryRecords as $item) {
+				$history[] = new Engagement((array) $item);
+			}
 
-            return $this->merge(new self($history));
-        } else {
-            return false;
-        }
-    }
+			return $this->merge(new self($history));
+		} else {
+			return false;
+		}
+	}
 
-    public function prev()
-    {
-        if (! $this->instance) {
-            return false;
-        }
+	public function prev()
+	{
+		if (! $this->instance) {
+			return false;
+		}
 
-        $instance = $this->instance;
+		$instance = $this->instance;
 
-        $prev = $instance->retrieveHistory($instance->start, $instance->end, $instance->prev);
-        if (property_exists($prev->_metadata, 'prev')) {
-            $instance->prev = $prev->_metadata->prev->href;
+		$prev = $instance->retrieveHistory($instance->start, $instance->end, $instance->prev);
+		if (property_exists($prev->_metadata, 'prev')) {
+			$instance->prev = $prev->_metadata->prev->href;
 
-            $history = [];
-            foreach ($next->interactionHistoryRecords as $item) {
-                $history[] = new Engagement((array) $item);
-            }
+			$history = [];
+			foreach ($next->interactionHistoryRecords as $item) {
+				$history[] = new Engagement((array) $item);
+			}
 
-            return $this->merge(new self($history));
-        } else {
-            return false;
-        }
-    }
+			return $this->merge(new self($history));
+		} else {
+			return false;
+		}
+	}
 }

Please login to merge, or discard this patch.

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -19,7 +19,7 @@  discard block
 block discarded – undo
     
     public function find($engagementID)
     {
-	    $result = $this->filter(function ($value, $key) use ($engagementID) {
+	    $result = $this->filter(function($value, $key) use ($engagementID) {
 		    return $value->info->sessionId == $engagementID;
 	    });
 	    
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
 
     public function next()
     {
-        if (! $this->instance) {
+        if (!$this->instance) {
             return false;
         }
 
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
 
     public function prev()
     {
-        if (! $this->instance) {
+        if (!$this->instance) {
             return false;
         }
 

Please login to merge, or discard this patch.

src/Collections/ConversationHistory.php 2 patches

Indentation +49 added lines, -49 removed lines patch added patch discarded remove patch

@@ -8,67 +8,67 @@
 block discarded – undo
 
 class ConversationHistory extends Collection
 {
-    private $instance;
+	private $instance;
 
-    public function __construct(array $models = [], LiveEngageLaravel $instance = null)
-    {
-        $this->instance = $instance;
+	public function __construct(array $models = [], LiveEngageLaravel $instance = null)
+	{
+		$this->instance = $instance;
 
-        parent::__construct($models);
-    }
+		parent::__construct($models);
+	}
     
-    public function find($engagementID)
-    {
-	    $result = $this->filter(function ($value, $key) use ($engagementID) {
-		    return $value->info->conversationId == $engagementID;
-	    });
+	public function find($engagementID)
+	{
+		$result = $this->filter(function ($value, $key) use ($engagementID) {
+			return $value->info->conversationId == $engagementID;
+		});
 	    
-	    return $result->first();
-    }
+		return $result->first();
+	}
 
-    public function next()
-    {
-        if (! $this->instance) {
-            return false;
-        }
+	public function next()
+	{
+		if (! $this->instance) {
+			return false;
+		}
 
-        $instance = $this->instance;
+		$instance = $this->instance;
 
-        $next = $instance->retrieveMsgHistory($instance->start, $instance->end, $instance->next);
-        if (property_exists($next->_metadata, 'next')) {
-            $instance->next = $next->_metadata->next->href;
+		$next = $instance->retrieveMsgHistory($instance->start, $instance->end, $instance->next);
+		if (property_exists($next->_metadata, 'next')) {
+			$instance->next = $next->_metadata->next->href;
 
-            $history = [];
-            foreach ($next->conversationHistoryRecords as $item) {
-                $history[] = new Conversation((array) $item);
-            }
+			$history = [];
+			foreach ($next->conversationHistoryRecords as $item) {
+				$history[] = new Conversation((array) $item);
+			}
 
-            return $this->merge(new self($history));
-        } else {
-            return false;
-        }
-    }
+			return $this->merge(new self($history));
+		} else {
+			return false;
+		}
+	}
 
-    public function prev()
-    {
-        if (! $this->instance) {
-            return false;
-        }
+	public function prev()
+	{
+		if (! $this->instance) {
+			return false;
+		}
 
-        $instance = $this->instance;
+		$instance = $this->instance;
 
-        $prev = $instance->retrieveMsgHistory($instance->start, $instance->end, $instance->prev);
-        if (property_exists($prev->_metadata, 'prev')) {
-            $instance->prev = $prev->_metadata->prev->href;
+		$prev = $instance->retrieveMsgHistory($instance->start, $instance->end, $instance->prev);
+		if (property_exists($prev->_metadata, 'prev')) {
+			$instance->prev = $prev->_metadata->prev->href;
 
-            $history = [];
-            foreach ($next->conversationHistoryRecords as $item) {
-                $history[] = new Conversation((array) $item);
-            }
+			$history = [];
+			foreach ($next->conversationHistoryRecords as $item) {
+				$history[] = new Conversation((array) $item);
+			}
 
-            return $this->merge(new self($history));
-        } else {
-            return false;
-        }
-    }
+			return $this->merge(new self($history));
+		} else {
+			return false;
+		}
+	}
 }

Please login to merge, or discard this patch.

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -19,7 +19,7 @@  discard block
 block discarded – undo
     
     public function find($engagementID)
     {
-	    $result = $this->filter(function ($value, $key) use ($engagementID) {
+	    $result = $this->filter(function($value, $key) use ($engagementID) {
 		    return $value->info->conversationId == $engagementID;
 	    });
 	    
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
 
     public function next()
     {
-        if (! $this->instance) {
+        if (!$this->instance) {
             return false;
         }
 
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
 
     public function prev()
     {
-        if (! $this->instance) {
+        if (!$this->instance) {
             return false;
         }
 

Please login to merge, or discard this patch.

		@@ -8,67 +8,67 @@
		block discarded – undo
8	8
9	9	class EngagementHistory extends Collection
10	10	{
11		- private $instance;
	11	+ private $instance;
12	12
13		- public function __construct(array $models = [], LiveEngageLaravel $instance = null)
14		- {
15		- $this->instance = $instance;
	13	+ public function __construct(array $models = [], LiveEngageLaravel $instance = null)
	14	+ {
	15	+ $this->instance = $instance;
16	16
17		- parent::__construct($models);
18		- }
	17	+ parent::__construct($models);
	18	+ }
19	19
20		- public function find($engagementID)
21		- {
22		- $result = $this->filter(function ($value, $key) use ($engagementID) {
23		- return $value->info->sessionId == $engagementID;
24		- });
	20	+ public function find($engagementID)
	21	+ {
	22	+ $result = $this->filter(function ($value, $key) use ($engagementID) {
	23	+ return $value->info->sessionId == $engagementID;
	24	+ });
25	25
26		- return $result->first();
27		- }
	26	+ return $result->first();
	27	+ }
28	28
29		- public function next()
30		- {
31		- if (! $this->instance) {
32		- return false;
33		- }
	29	+ public function next()
	30	+ {
	31	+ if (! $this->instance) {
	32	+ return false;
	33	+ }
34	34
35		- $instance = $this->instance;
	35	+ $instance = $this->instance;
36	36
37		- $next = $instance->retrieveHistory($instance->start, $instance->end, $instance->next);
38		- if (property_exists($next->_metadata, 'next')) {
39		- $instance->next = $next->_metadata->next->href;
	37	+ $next = $instance->retrieveHistory($instance->start, $instance->end, $instance->next);
	38	+ if (property_exists($next->_metadata, 'next')) {
	39	+ $instance->next = $next->_metadata->next->href;
40	40
41		- $history = [];
42		- foreach ($next->interactionHistoryRecords as $item) {
43		- $history[] = new Engagement((array) $item);
44		- }
	41	+ $history = [];
	42	+ foreach ($next->interactionHistoryRecords as $item) {
	43	+ $history[] = new Engagement((array) $item);
	44	+ }
45	45
46		- return $this->merge(new self($history));
47		- } else {
48		- return false;
49		- }
50		- }
	46	+ return $this->merge(new self($history));
	47	+ } else {
	48	+ return false;
	49	+ }
	50	+ }
51	51
52		- public function prev()
53		- {
54		- if (! $this->instance) {
55		- return false;
56		- }
	52	+ public function prev()
	53	+ {
	54	+ if (! $this->instance) {
	55	+ return false;
	56	+ }
57	57
58		- $instance = $this->instance;
	58	+ $instance = $this->instance;
59	59
60		- $prev = $instance->retrieveHistory($instance->start, $instance->end, $instance->prev);
61		- if (property_exists($prev->_metadata, 'prev')) {
62		- $instance->prev = $prev->_metadata->prev->href;
	60	+ $prev = $instance->retrieveHistory($instance->start, $instance->end, $instance->prev);
	61	+ if (property_exists($prev->_metadata, 'prev')) {
	62	+ $instance->prev = $prev->_metadata->prev->href;
63	63
64		- $history = [];
65		- foreach ($next->interactionHistoryRecords as $item) {
66		- $history[] = new Engagement((array) $item);
67		- }
	64	+ $history = [];
	65	+ foreach ($next->interactionHistoryRecords as $item) {
	66	+ $history[] = new Engagement((array) $item);
	67	+ }
68	68
69		- return $this->merge(new self($history));
70		- } else {
71		- return false;
72		- }
73		- }
	69	+ return $this->merge(new self($history));
	70	+ } else {
	71	+ return false;
	72	+ }
	73	+ }
74	74	}

		@@ -19,7 +19,7 @@ discard block
		block discarded – undo
19	19
20	20	public function find($engagementID)
21	21	{
22		- $result = $this->filter(function ($value, $key) use ($engagementID) {
	22	+ $result = $this->filter(function($value, $key) use ($engagementID) {
23	23	return $value->info->sessionId == $engagementID;
24	24	});
25	25
		@@ -28,7 +28,7 @@ discard block
		block discarded – undo
28	28
29	29	public function next()
30	30	{
31		- if (! $this->instance) {
	31	+ if (!$this->instance) {
32	32	return false;
33	33	}
34	34
		@@ -51,7 +51,7 @@ discard block
		block discarded – undo
51	51
52	52	public function prev()
53	53	{
54		- if (! $this->instance) {
	54	+ if (!$this->instance) {
55	55	return false;
56	56	}
57	57

		@@ -8,67 +8,67 @@
		block discarded – undo
8	8
9	9	class ConversationHistory extends Collection
10	10	{
11		- private $instance;
	11	+ private $instance;
12	12
13		- public function __construct(array $models = [], LiveEngageLaravel $instance = null)
14		- {
15		- $this->instance = $instance;
	13	+ public function __construct(array $models = [], LiveEngageLaravel $instance = null)
	14	+ {
	15	+ $this->instance = $instance;
16	16
17		- parent::__construct($models);
18		- }
	17	+ parent::__construct($models);
	18	+ }
19	19
20		- public function find($engagementID)
21		- {
22		- $result = $this->filter(function ($value, $key) use ($engagementID) {
23		- return $value->info->conversationId == $engagementID;
24		- });
	20	+ public function find($engagementID)
	21	+ {
	22	+ $result = $this->filter(function ($value, $key) use ($engagementID) {
	23	+ return $value->info->conversationId == $engagementID;
	24	+ });
25	25
26		- return $result->first();
27		- }
	26	+ return $result->first();
	27	+ }
28	28
29		- public function next()
30		- {
31		- if (! $this->instance) {
32		- return false;
33		- }
	29	+ public function next()
	30	+ {
	31	+ if (! $this->instance) {
	32	+ return false;
	33	+ }
34	34
35		- $instance = $this->instance;
	35	+ $instance = $this->instance;
36	36
37		- $next = $instance->retrieveMsgHistory($instance->start, $instance->end, $instance->next);
38		- if (property_exists($next->_metadata, 'next')) {
39		- $instance->next = $next->_metadata->next->href;
	37	+ $next = $instance->retrieveMsgHistory($instance->start, $instance->end, $instance->next);
	38	+ if (property_exists($next->_metadata, 'next')) {
	39	+ $instance->next = $next->_metadata->next->href;
40	40
41		- $history = [];
42		- foreach ($next->conversationHistoryRecords as $item) {
43		- $history[] = new Conversation((array) $item);
44		- }
	41	+ $history = [];
	42	+ foreach ($next->conversationHistoryRecords as $item) {
	43	+ $history[] = new Conversation((array) $item);
	44	+ }
45	45
46		- return $this->merge(new self($history));
47		- } else {
48		- return false;
49		- }
50		- }
	46	+ return $this->merge(new self($history));
	47	+ } else {
	48	+ return false;
	49	+ }
	50	+ }
51	51
52		- public function prev()
53		- {
54		- if (! $this->instance) {
55		- return false;
56		- }
	52	+ public function prev()
	53	+ {
	54	+ if (! $this->instance) {
	55	+ return false;
	56	+ }
57	57
58		- $instance = $this->instance;
	58	+ $instance = $this->instance;
59	59
60		- $prev = $instance->retrieveMsgHistory($instance->start, $instance->end, $instance->prev);
61		- if (property_exists($prev->_metadata, 'prev')) {
62		- $instance->prev = $prev->_metadata->prev->href;
	60	+ $prev = $instance->retrieveMsgHistory($instance->start, $instance->end, $instance->prev);
	61	+ if (property_exists($prev->_metadata, 'prev')) {
	62	+ $instance->prev = $prev->_metadata->prev->href;
63	63
64		- $history = [];
65		- foreach ($next->conversationHistoryRecords as $item) {
66		- $history[] = new Conversation((array) $item);
67		- }
	64	+ $history = [];
	65	+ foreach ($next->conversationHistoryRecords as $item) {
	66	+ $history[] = new Conversation((array) $item);
	67	+ }
68	68
69		- return $this->merge(new self($history));
70		- } else {
71		- return false;
72		- }
73		- }
	69	+ return $this->merge(new self($history));
	70	+ } else {
	71	+ return false;
	72	+ }
	73	+ }
74	74	}

LivePersonInc / LiveEngageLaravel

Branch — master (19e1ba)

Status

Category

Indentation +49 added lines, -49 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Indentation +49 added lines, -49 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch