for testing and deploying your application
for finding and fixing issues
for empowering human code reviews
<?php
namespace App\Http\Middleware;
use Closure;
use Auth;
use App\Models\Link;
use Illuminate\Http\Request;
class LinkId
{
public function handle($request, Closure $next)
$linkId = $request->route('id');
$user = Auth::user();
$link = Link::find($linkId);
if (!$link) {
return abort(404);
abort(404)
null
This check looks for function or method calls that always return null and whose return value is used.
class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) {
The method getObject() can return nothing but null, so it makes no sense to use the return value.
getObject()
The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes.
}
if ($user->id != $link->user_id) {
id
Illuminate\Contracts\Auth\Authenticatable
instanceof
return abort(403);
abort(403)
return $next($request);
LinkStackOrg /
LinkStack
Julian Prieber
Loading history...
This check looks for function or method calls that always return null and whose return value is used.
The method
getObject()can return nothing but null, so it makes no sense to use the return value.The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes.